Subject: Re: [bug#32727] [PATCH] gnu: Add telegram-purple.

From: [email-masked] (Ludovic Courtès)
Date: Tue, 02 Oct 2018 11:48:51 +0200

Hello!

Tomáš, did you have a chance to look into this?

Thanks,
Ludo’.

Leo Famulari <[email-masked]> skribis:

> On Thu, Sep 13, 2018 at 02:20:56PM +0200, Tomáš Čech wrote:
>> +    (source (origin
>> +              (method git-fetch)
>> +              (uri (git-reference
>> +                    (url "https://github.com/majn/telegram-purple")
>> +                    (commit (string-append "v" version))
>> +                    (recursive? #t)))
>
> This recursive Git clone brings brings two libraries with it, 'tgl' and
> 'tl-parser':
>
> https://github.com/majn/tgl/
> https://github.com/vysheng/tl-parser
>
> Is it possible to include these as their own separate Guix packages?
> Would anything else potentially use them?
>
> In general we try to avoid bundling things, but sometimes the effort is
> not worth it.
>
>> +     `(#:tests? #f
>
> If there are no tests, please add a comment like "No test suite". Or
> else leave a comment explaining why we skip the tests.
>
>> +         (add-after 'unpack 'prepare-commit.h
>> +           (lambda _
>> +             (with-output-to-file "./commit.h"
>> +               (lambda ()
>> +                 (display
>> +                  (string-append "//generated by guix, use version instead of "
>> +                                 "commit\n"
>> +                                 "#ifndef GIT_COMMIT\n"
>> +                                 "#  define GIT_COMMIT \"v"
>> +                                 ,version "\"\n"
>> +                                 "#endif\n"))))))
>
> Can you add a brief comment explaining this?
>
>> +    (description "Telegram protocol support for pidgin.")
>
> To make it a complete sentence, how about ""Telegram-purple is a Libpurple
> protocol plugin that adds support for the Telegram messenger."?