From unknown Fri Aug 15 14:18:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32723 <32723@debbugs.gnu.org> To: bug#32723 <32723@debbugs.gnu.org> Subject: Status: [PATCH] Fix erc-autojoin for same channel names on multiple servers Reply-To: bug#32723 <32723@debbugs.gnu.org> Date: Fri, 15 Aug 2025 21:18:18 +0000 retitle 32723 [PATCH] Fix erc-autojoin for same channel names on multiple s= ervers reassign 32723 emacs submitter 32723 Martin Kletzander severity 32723 normal tag 32723 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 12 11:46:01 2018 Received: (at submit) by debbugs.gnu.org; 12 Sep 2018 15:46:01 +0000 Received: from localhost ([127.0.0.1]:38390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g07L7-0001ct-6X for submit@debbugs.gnu.org; Wed, 12 Sep 2018 11:46:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g07K5-0001Za-5T for submit@debbugs.gnu.org; Wed, 12 Sep 2018 11:44:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g07Jz-0003Qm-8q for submit@debbugs.gnu.org; Wed, 12 Sep 2018 11:44:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g07Jz-0003Qi-5V for submit@debbugs.gnu.org; Wed, 12 Sep 2018 11:44:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g07Jy-0001kd-B5 for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 11:44:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g07Jt-0003Oz-CL for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 11:44:50 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:37388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g07Jt-0003OT-56 for bug-gnu-emacs@gnu.org; Wed, 12 Sep 2018 11:44:45 -0400 Received: by mail-wr1-x432.google.com with SMTP id u12-v6so2564168wrr.4 for ; Wed, 12 Sep 2018 08:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=ZEIVk/XP+EcSWMm9CaDk4WBDBNiDwhCYYmOhzEqsYEU=; b=dUmu8NVC3AKHSaz7XkaOkyL8XnbnlsH9oOYgVLvm1vro2Zhf07hcOfw2x2lP2k+7Lg gPxnYYhNZr41qNGzigPqYMQSQvPAUmTXrKNSr1VO0RN2IbUj0yILeXLhUT3FFbq4I5Og Dc7u/uXUX3bBVqTeH1ArOedQ0vgpSeSvt5fcWRipcTSerGtnKkAIxV8EwJQW50QSmciI lCwMdR0pVhUd7uFZK8IChXm6zKZZoAEcvwBuFNcOsrTp2cQTZ/bbPyNnBHGpf5ozf1gM H7MV8ss6bZ3OrXNsbDFHy1Tm3lfArghXUJkAGNp0n/g8d1BNVjxLadNRA7U7tLiTGAJX s1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=ZEIVk/XP+EcSWMm9CaDk4WBDBNiDwhCYYmOhzEqsYEU=; b=YKFoWAFzM/qQeNivfihY5hDQ3p8yFueRwL990UOSoMtoVO7jm3FbEHA8OhN2bxJvbz ejHGfWZreYQRKaMgt/3fy+FaC1j4xAWNvqmsW+zRQ7Fyo8AeS5yJ2Jn70bFj/4Uyp+s1 RqVr6hFAmP6far24QlofCjWwRoV8MfrZXYXNF5HCRk2pPbeemhpd/hjpgPmy8pEuoUd1 07/TJgGcfSfVMPqbE9kDPa7jzatX0o3EksUcp0dbmJJg+86/vintXhY75h/BSHoqlRPQ Zb6qcg7WQupsYwrOGMRiqi3UuXJybik2tqPkUyv5TSfSFF/AMcXhvscd/6uP+y1raaoZ Zplw== X-Gm-Message-State: APzg51Cmj96T+yIyd3g2dqOFl46Hybe6KQcAWaCdfQjLMydtsHk+PM/A Gjr1jTwzsQmr5o7Vl3FAsB+yVBFq X-Google-Smtp-Source: ANB0VdbDTO3Vofwwra5Htd5f+OIoIkNY9ms6Z6JNpAY9qFdexT5SaRo8AV704z9MgEacwKfvce2e4A== X-Received: by 2002:adf:e648:: with SMTP id b8-v6mr2128831wrn.254.1536767083495; Wed, 12 Sep 2018 08:44:43 -0700 (PDT) Received: from wheatley (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id u7-v6sm1883710wmd.46.2018.09.12.08.44.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Sep 2018 08:44:42 -0700 (PDT) Received: from wheatley.brq.redhat.com (wheatley.usersys.redhat.com [127.0.0.1]) by wheatley (Postfix) with ESMTP id A6EA47E002C for ; Wed, 12 Sep 2018 17:44:41 +0200 (CEST) From: Martin Kletzander To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix erc-autojoin for same channel names on multiple servers Date: Wed, 12 Sep 2018 17:44:29 +0200 Message-Id: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> X-Mailer: git-send-email 2.18.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 12 Sep 2018 11:45:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When auto-joining channel with the same name on multiple channels the auto-join will go over the list of channels and for each one it checks if there is a buffer and alive server process. However it does not check if the server process matches the server being currently processed for auto-joining. This happens since commit "Don't join erc channels doubly" Fix it by checking if the currently processed server matches the erc process name of the already joined channel. * lisp/erc/erc-join.el (erc-autojoin-channels): Join channels with the same name on different servers. Copyright-paperwork-exempt: yes --- lisp/erc/erc-join.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/erc/erc-join.el b/lisp/erc/erc-join.el index a6bf6518ea86..567a4cc27e19 100644 --- a/lisp/erc/erc-join.el +++ b/lisp/erc/erc-join.el @@ -161,6 +161,9 @@ This function is run from `erc-nickserv-identified-hook'." ;; Only auto-join the channels that we aren't already in ;; using a different nick. (when (or (not buffer) + ;; If the same channel is joined on another + ;; server the best-effort is to just join + (not (string-match (car l) (process-name erc-server-process))) (not (with-current-buffer buffer (erc-server-process-alive)))) (erc-server-join-channel server chan)))))))) -- 2.18.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 17:53:29 2019 Received: (at 32723) by debbugs.gnu.org; 23 Jun 2019 21:53:29 +0000 Received: from localhost ([127.0.0.1]:55199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfAQS-0001Rj-SP for submit@debbugs.gnu.org; Sun, 23 Jun 2019 17:53:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfAQR-0001RW-0v for 32723@debbugs.gnu.org; Sun, 23 Jun 2019 17:53:27 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfAQO-0002XK-3e; Sun, 23 Jun 2019 23:53:26 +0200 From: Lars Ingebrigtsen To: Martin Kletzander Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> Date: Sun, 23 Jun 2019 23:53:23 +0200 In-Reply-To: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> (Martin Kletzander's message of "Wed, 12 Sep 2018 17:44:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Martin Kletzander writes: > When auto-joining channel with the same name on > multiple channels the auto-join will go over the > list of channels and for each one it checks if > there is a buffer and alive server process. > Ho [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32723 Cc: 32723@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Martin Kletzander writes: > When auto-joining channel with the same name on > multiple channels the auto-join will go over the > list of channels and for each one it checks if > there is a buffer and alive server process. > However it does not check if the server process > matches the server being currently processed for > auto-joining. > > This happens since commit "Don't join erc channels > doubly" > > Fix it by checking if the currently processed > server matches the erc process name of the already > joined channel. Looks good to me; I've now applied it to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 23 17:53:36 2019 Received: (at control) by debbugs.gnu.org; 23 Jun 2019 21:53:36 +0000 Received: from localhost ([127.0.0.1]:55202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfAQa-0001S6-8n for submit@debbugs.gnu.org; Sun, 23 Jun 2019 17:53:36 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfAQY-0001Ry-UJ for control@debbugs.gnu.org; Sun, 23 Jun 2019 17:53:35 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfAQV-0002XR-IM for control@debbugs.gnu.org; Sun, 23 Jun 2019 23:53:34 +0200 Date: Sun, 23 Jun 2019 23:53:31 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #32723 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 32723 fixed close 32723 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32723 fixed close 32723 27.1 quit From unknown Fri Aug 15 14:18:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 22 Jul 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun May 10 15:45:33 2020 Received: (at control) by debbugs.gnu.org; 10 May 2020 19:45:33 +0000 Received: from localhost ([127.0.0.1]:50471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXrtE-00050n-RZ for submit@debbugs.gnu.org; Sun, 10 May 2020 15:45:32 -0400 Received: from forward1-smtp.messagingengine.com ([66.111.4.223]:51097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXrtC-00050V-Ug for control@debbugs.gnu.org; Sun, 10 May 2020 15:45:31 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id 56F62194152B; Sun, 10 May 2020 15:45:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 10 May 2020 15:45:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=k86j9N3ud+XFKlJAigl5mm59SRsOJEENckX5yDYes tI=; b=Fnq2tdh+pdOUCrvGekOgA2dl/zfZWmPI21ZUsnhKIptTr58pkq25+tW/w WVY4SxNlP5QLn1uXtlZQ4pmvfZvKlobKd1WtGxlwB2kNj3QbKT+RwgRna2nZam7/ 91SDMCNytbirFUU9dhz1oENS93PfgikxiDQSnT0yggo2wShFCapFfFAwklc4dBwY PmMpeApiaYD8cWNwt6M2dGuElHDm9XIQzAere7cfdJ56JpNAHlvZES9H4PKT9bdl fdiAhwFUp0Zec3dTPk5nN0xEorNiiJ9v40XcoU5Wd1FvGNB0fPMAvb7oI9XqkLT6 tdgJCovturTJtqFDqHn+MIPvFADSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkeekgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpefhvfffkfggtgesthdtredttddttdenucfhrhhomhepmfgvvhhinhcuuehruhgs vggtkhcufghnhhgrmhhmvghruceouhhnhhgrmhhmvghrsehfshhfvgdrohhrgheqnecugg ftrfgrthhtvghrnhepteduheejkeekjeefhefhkedtheeuheeuudevkefhledtkefhgfdu ffdvhfejleelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepuhhnhhgrmhhmvghrsehfshhfvgdrohhrgh X-ME-Proxy: From: Kevin Brubeck Unhammer To: control@debbugs.gnu.org Date: Sun, 10 May 2020 21:45:21 +0200 Message-ID: <871rnrh8vi.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 32723 Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.223 listed in list.dnswl.org] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: messagingengine.com] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 32723 Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: messagingengine.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.223 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 TVD_SPACE_RATIO No description available. unarchive 32723 From debbugs-submit-bounces@debbugs.gnu.org Sun May 10 15:46:04 2020 Received: (at 32723) by debbugs.gnu.org; 10 May 2020 19:46:04 +0000 Received: from localhost ([127.0.0.1]:50477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXrtk-00052h-1Z for submit@debbugs.gnu.org; Sun, 10 May 2020 15:46:04 -0400 Received: from forward1-smtp.messagingengine.com ([66.111.4.223]:43927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jXrti-00051V-Cq for 32723@debbugs.gnu.org; Sun, 10 May 2020 15:46:02 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.nyi.internal (Postfix) with ESMTP id 437251941535; Sun, 10 May 2020 15:45:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 10 May 2020 15:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2hbqrp S97bSdPUbqgRjnVcYAA+wtbbJ195Nh/l9R+go=; b=d35+woI1R3qYoj9sMUwsh2 AMK9LaR1+d5/B51EY3xqeZoYaOEf8S1+dvglz7PkhzoiDS7dh2hHALs1wtfkDvom PiKM3iYhIQy41kRBOUEJgtOVuRnm1GYZkc0JEeBe9obAJgilQ9u3mYmyfCt58vO6 WJ+C9SQ/mfvl3HRYBU2h2nnoi6ZOlsguYqYzf+yQNR3wtHuh1M6QE18Lnt0cRenZ siEiXhd0g6UKb9501ITXrOP068RtwBIMuXrd8Os+LRiJwyOy9LB80KxTgdmO0MY4 HsK5/mfbGx7R1A4UhMHWOiN/Conmsrfm4yY8TXUUGYghIJMq9gjJCtVH8CS48pjw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrkeekgddugeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenuchmihhsshhinhhgucfvqfcufhhivghlugculdeftd dmnecujfgurhephffujghffffkgggtsehgtderredttdejnecuhfhrohhmpefmvghvihhn uceurhhusggvtghkucgfnhhhrghmmhgvrhcuoehunhhhrghmmhgvrhesfhhsfhgvrdhorh hgqeenucggtffrrghtthgvrhhnpefgjeeggefhteeujeejfedtffeivdevueetgeejudei heetfeejteeuheethfevteenucffohhmrghinhepvgigrghmphhlvgdrtghomhdpvghrtg dqvgigrghmphhlvgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehunhhhrghmmhgvrhesfhhsfhgvrdhorhhg X-ME-Proxy: From: Kevin Brubeck Unhammer Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers In-Reply-To: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> (Martin Kletzander's message of "Wed, 12 Sep 2018 17:44:29 +0200") References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> Date: Sun, 10 May 2020 21:45:54 +0200 Message-ID: <87zhaffua5.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Martin Kletzander čálii: > When auto-joining channel with the same name on > multiple channels the auto-join will go over the > list of channels and for each one it checks if > there is a buffer and alive server process. > Ho [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: messagingengine.com] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.223 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.2 MISSING_HEADERS Missing To: header X-Debbugs-Envelope-To: 32723 Cc: 32723@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Martin Kletzander =C4=8D=C3=A1lii: > When auto-joining channel with the same name on > multiple channels the auto-join will go over the > list of channels and for each one it checks if > there is a buffer and alive server process. > However it does not check if the server process > matches the server being currently processed for > auto-joining. > > This happens since commit "Don't join erc channels > doubly" > > Fix it by checking if the currently processed > server matches the erc process name of the already > joined channel. That's not always going to match though. The car's of erc-autojoin-channels contain the values of erc-server-announced-name or erc-session-server, not the process-name of erc-server-process. E.g. when I join my weechat relay, erc-session-server is "example.com" and erc-server-announced-name is "weechat.relay.irc" while (process-name erc-server-process) is "erc-example.com-9001<1>". Also, the check is against the current erc-server-process (for the server being joined). Isn't the intention of the patch to check against the candidate buffer's server-process? I would expect something like (when (or (not buffer) ;; If the same channel is joined on another ;; server the best-effort is to just join (not (with-current-buffer buffer (or (string-match-p (car l) erc-session-serv= er) (string-match-p (car l) erc-session-anno= unced-name)))) (not (with-current-buffer buffer (erc-server-process-alive)))) (erc-server-join-channel server chan)) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq9A0PxCu5rIo7lbX/DwefQCTFmcFAl64WfIACgkQ/DwefQCT FmckcA/+NpOiRjvgkmEcUUjtkke/0Tl3siLxjSRrtq8PdfXha95h+82/xpG+S7+D o6AzL13B/AdkEJrTldWSsXExOyQGrmKf0iWkDQtkKjzUXBucbJJAgjidpwmWhdwU EO6aLiHPHqrrUumsEyzF+ui2obpAeOwnciKNOSeGBITni/ldeH5HshKI1NL46hHZ pXU2HRLpv0rxksf38VgM1lqkq4NtgFzN7/x7zmtLjMaN41WtBMc60slZ/QDLsV2O CKCn9WNBBW3HgAawiQFa3S8euroL/NhnWEEwHvP2f04n6s3JJpdQaJbg0uNFhLhB EMWEQFGjjihHmz3agfAvEnlyYr1lqtRmI+56JAVA1UmJZ95RmoI0/AxgVTF9kCDY 8KBE77+NMqljuH9vG8g+KVQPDvFB469b3N+uHkHjPrHuTdLvZ3rKQ2a9B5tjn56N NZZTrlx3vNyB7M8H2QdM7B/cAUBB2TwIFZQ+J7wZ9yo7lY/9eKQDANBpMcMx83y7 v7P7Tgu83/7HKSbHat2NpZmHc3bmJjE0Rj5EqXqjOHUQHJ/E4G/7RUX88iuHEq8t WLVgORazJZqbOPdCp7EZ2aDlzEnLoG5lyyL7v3BT1k0Dpz+GVtwf4ZteN3GT2gf1 jC58yyNaRKvhBCuJyuaMa3PcopJr8qksFPvvPv0tP3pEHEzC7ZU= =supr -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 11 11:07:04 2020 Received: (at 32723) by debbugs.gnu.org; 11 May 2020 15:07:04 +0000 Received: from localhost ([127.0.0.1]:52959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYA1I-00066D-92 for submit@debbugs.gnu.org; Mon, 11 May 2020 11:07:04 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYA1G-00065Z-Ow for 32723@debbugs.gnu.org; Mon, 11 May 2020 11:07:03 -0400 Received: by mail-wm1-f52.google.com with SMTP id g12so19694881wmh.3 for <32723@debbugs.gnu.org>; Mon, 11 May 2020 08:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=m9SCBobVRHfEFaPdfAlEAF+1HVQ5lRi+0IxGPcA0HOQ=; b=mm0RZYsqUnTCb7IV0U9W3XbaOYZBtMAtCNcPC/HDz1DpF7H712oRsK9ll/Fk0fZ4dn kGVDbGNSJd1tyZK/Z1o4e23gFAAL/ekL5k1VIXluGOg0Mh/0wACY83spZ6FZqvwI+2tf cGT0OIlnoRrIzqucg/xs1ej4yvEiCCon/Ll0Ikl3YQm2cDwga0/jxt3K7tUCJdgifGH6 x5BtMB2B9K+hI0Fjo3MsdMuUBF/1Js213HBu+FnA8aXmghH/jnpm/O/4au5Uj3o1/6LS 9A6GvTrDJU6k7nmCzKkv4rkrWJ+lJEj4KO9m0SD+IALl1pWUBZ5DzEgYJnsTSmdqhhUS T7ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=m9SCBobVRHfEFaPdfAlEAF+1HVQ5lRi+0IxGPcA0HOQ=; b=LJmxvFQIiI32L7KpB4C8XD587BdDOj7JHi55YplEzT7LDlp4BuF1rq/S5i8JuGskj2 9JJAPLUYVPq02Vq8G5U9QmbgYkXzj6YgBR4K4Q4e8bABuC6M5LlVb4iseKi1JxlO9sHL m71An3QfViwLEVVObFYRPSA48UYqlIAWiKzDSjMM5eMUNFg5U9OKId9GeBHC10h2TwYq WXWA5t7U/TwMYvTTKvNZmh7z+eacB9RnxaNcWcDmhiC2aBXHKUwJtW2NaLB0zaPLK4Xr ZxRRVKi0/QgepdFGPDG8T8AGrNnK81eH9uWXbFoTOzXA3RQbqOlGKT/TWvCscS7+s9zW uZBw== X-Gm-Message-State: AGi0PuYbXZRQt4lO+ncYG5fDKmrcDQGYGVcFItfxDaaGWifPXoHCQrCf mG9yBbNsH/j2kzdEAFLr9iFvjvKY X-Google-Smtp-Source: APiQypKxSDtbrE+fMdYumRIboCEEIiBwAHqC+YdiLfxl5bwK+fI8yTwgrDL78acjIiJ2sjsA7Js+/w== X-Received: by 2002:a7b:cbc6:: with SMTP id n6mr12757567wmi.34.1589209616530; Mon, 11 May 2020 08:06:56 -0700 (PDT) Received: from carol.localdomain (k8r.cz. [95.82.177.71]) by smtp.gmail.com with ESMTPSA id n9sm5124490wmj.5.2020.05.11.08.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2020 08:06:55 -0700 (PDT) Received: by carol.localdomain (Postfix, from userid 1000) id C7D1CC2002A; Mon, 11 May 2020 17:06:54 +0200 (CEST) Date: Mon, 11 May 2020 17:06:54 +0200 From: Martin Kletzander To: Kevin Brubeck Unhammer Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers Message-ID: <20200511150654.GF30179@wheatley> References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> <87ftc7h9gp.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: <87ftc7h9gp.fsf@fsfe.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32723 Cc: Lars Ingebrigtsen , 32723@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, May 10, 2020 at 09:32:38PM +0200, Kevin Brubeck Unhammer wrote: >Martin Kletzander čálii: > >> When auto-joining channel with the same name on >> multiple channels the auto-join will go over the >> list of channels and for each one it checks if >> there is a buffer and alive server process. >> However it does not check if the server process >> matches the server being currently processed for >> auto-joining. >> >> This happens since commit "Don't join erc channels >> doubly" >> >> Fix it by checking if the currently processed >> server matches the erc process name of the already >> joined channel. > >That's not always going to match though. The car's of >erc-autojoin-channels contain the values of erc-server-announced-name or >erc-session-server, not the process-name of >erc-server-process. E.g. when I join my weechat relay, >erc-session-server is "example.com" and erc-server-announced-name is >"weechat.relay.irc" while (process-name erc-server-process) is >"erc-example.com-9001<1>". > Oh, I completely forgot what I was doing there, I just know that with this patch it is fixed for me, even though it might be dependent on various quirks that just happen on my client (be it joining servers with very different latency, not using autojoin twice or something completely different). >Also, the check is against the current erc-server-process (for the >server being joined). Isn't the intention of the patch to check against >the candidate buffer's server-process? > As I said, I do not remember what exactly was the reason for this particular way of dealing with it. I definitely made some mistakes. >I would expect something like > > (when (or (not buffer) > ;; If the same channel is joined on another > ;; server the best-effort is to just join > (not (with-current-buffer buffer > (or (string-match-p (car l) erc-session-server) > (string-match-p (car l) erc-session-announced-name)))) > (not (with-current-buffer buffer > (erc-server-process-alive)))) > (erc-server-join-channel server chan)) > If that works, then I'm fine with it. I can test it later on and let you know if it works for me. Thanks, Martin From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 14:25:36 2020 Received: (at 32723) by debbugs.gnu.org; 19 May 2020 18:25:36 +0000 Received: from localhost ([127.0.0.1]:50934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb6vo-00025D-IU for submit@debbugs.gnu.org; Tue, 19 May 2020 14:25:36 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb6vk-00024m-Pd for 32723@debbugs.gnu.org; Tue, 19 May 2020 14:25:33 -0400 Received: by mail-wm1-f46.google.com with SMTP id f134so251491wmf.1 for <32723@debbugs.gnu.org>; Tue, 19 May 2020 11:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VwLZJz8izaUQIihhCz85TpqpyGfDSp00l0GMy2TPlow=; b=c5t5C4a8cwju4ONpzQW9j3ghF66dgnSnwDWawoYfpaGQ1lYmWrUNVla0coU5SvcNSN 2mdaT1sxoc4F5dvtPfm2I72THT3BWiM4BNaVDtUjq7cAFmFgcTKwXArFK533lPdQpBWD AolOcwsf/WnlOH7vai39E+OreoKkpnhayB7a6ID21b8EraXT+nThGu1UJcwE2m7W8NHO NA1CfuBkMK4a1Yzro0GY50hAUpxCe/432AccqKCoeor1TKuV8oi06G1AmNSLFGAgdPGy 6/3T5VMduV/gRB1TXM+tNQxo0fLlyhlV/RXAtmoUUDo3VyI0O7X7qRMr07wRpY+6svby 4UPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VwLZJz8izaUQIihhCz85TpqpyGfDSp00l0GMy2TPlow=; b=iZyDRUoN37CZYQ9nDUCMHC29JTPfSoQJc7jjFaTtiGhAvWZRGw1jprt6V7bMdZG0+j 41UAX1wjVdzQuSj2ceI0hjPlrOSNIwpCcT/H4IaeoilQX5aGXvbXR4tFhJrybY0BFDGV S/ApwuUYYqUOTcw5AqYl2dp9fdgCwnl2kuANeM44UE+QnTkR0njNWIUwGmwfiqk4cCfS SADfhUkJ1GperpvNzuxMooMknBzP15W+/PpdlCxjMTJvryvg9V5rzS49btHOoyFY1S97 6me5HtuKFMmBNXicpAdCzgrpV8k0tdur7nqN/jZcxAsQb1YbOrPw9T3UiO+5m1XARsOz ZWNg== X-Gm-Message-State: AOAM531qXfMdRhifKagAn2NFFnVG7lW3KruRKE45Y+1rC2OGBOyRZ5eE +4JiLbW6Q5TBAQVEntlAese2a3SU X-Google-Smtp-Source: ABdhPJwnzVDPYCbrZDnyPDa6EY/GZqWO14Y1ucPWOgFYiZmp6o7moJ/OzYTNJfp2KB0qwiLeOgulaA== X-Received: by 2002:a1c:2d14:: with SMTP id t20mr762483wmt.28.1589912726393; Tue, 19 May 2020 11:25:26 -0700 (PDT) Received: from carol.localdomain (k8r.cz. [95.82.177.71]) by smtp.gmail.com with ESMTPSA id v5sm228102wrr.93.2020.05.19.11.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 11:25:25 -0700 (PDT) Received: by carol.localdomain (Postfix, from userid 1000) id 8285AC20F8A; Tue, 19 May 2020 20:25:24 +0200 (CEST) Date: Tue, 19 May 2020 20:25:24 +0200 From: Martin Kletzander To: Kevin Brubeck Unhammer Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers Message-ID: <20200519182524.GE926@wheatley> References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> <87ftc7h9gp.fsf@fsfe.org> <20200511150654.GF30179@wheatley> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: <20200511150654.GF30179@wheatley> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32723 Cc: Lars Ingebrigtsen , 32723@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, May 11, 2020 at 05:06:54PM +0200, Martin Kletzander wrote: >On Sun, May 10, 2020 at 09:32:38PM +0200, Kevin Brubeck Unhammer wrote: >>Martin Kletzander čálii: >> >>> When auto-joining channel with the same name on >>> multiple channels the auto-join will go over the >>> list of channels and for each one it checks if >>> there is a buffer and alive server process. >>> However it does not check if the server process >>> matches the server being currently processed for >>> auto-joining. >>> >>> This happens since commit "Don't join erc channels >>> doubly" >>> >>> Fix it by checking if the currently processed >>> server matches the erc process name of the already >>> joined channel. >> >>That's not always going to match though. The car's of >>erc-autojoin-channels contain the values of erc-server-announced-name or >>erc-session-server, not the process-name of >>erc-server-process. E.g. when I join my weechat relay, >>erc-session-server is "example.com" and erc-server-announced-name is >>"weechat.relay.irc" while (process-name erc-server-process) is >>"erc-example.com-9001<1>". >> > >Oh, I completely forgot what I was doing there, I just know that with this patch >it is fixed for me, even though it might be dependent on various quirks that >just happen on my client (be it joining servers with very different latency, not >using autojoin twice or something completely different). > >>Also, the check is against the current erc-server-process (for the >>server being joined). Isn't the intention of the patch to check against >>the candidate buffer's server-process? >> So I just tried emacs-27.0.91 and with your approach it does not join any channel on any server. With my patch (which I just learned is in, I found out that it could not be applied locally) it joins all channels, but there is only one of those two that have the same name. However if I try joining the other one manually it joins, but does not create a buffer. It only gets created once someone posts to the channel. I actually started writing that it does not get joined while a message appeared out of nowhere, I thought it was a private query because there was no header, nothing. Only after that I realised it has a name of the channel, but on the second server, so I deleted that part of the e-mail! I think there is something wrong with some other part of erc-join (or erc), so for a while I'm sticking to 26.* with my patch on top of it, but sooner or later I'll have to figure that out (or someone else, maybe). Unfortunately I'm swamped with more important things lately. > >As I said, I do not remember what exactly was the reason for this particular way >of dealing with it. I definitely made some mistakes. > >>I would expect something like >> >> (when (or (not buffer) >> ;; If the same channel is joined on another >> ;; server the best-effort is to just join >> (not (with-current-buffer buffer >> (or (string-match-p (car l) erc-session-server) >> (string-match-p (car l) erc-session-announced-name)))) >> (not (with-current-buffer buffer >> (erc-server-process-alive)))) >> (erc-server-join-channel server chan)) >> > >If that works, then I'm fine with it. I can test it later on and let you know if >it works for me. > >Thanks, >Martin From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 14:40:55 2020 Received: (at 32723) by debbugs.gnu.org; 19 May 2020 18:40:55 +0000 Received: from localhost ([127.0.0.1]:51119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb7Ad-0004iM-AY for submit@debbugs.gnu.org; Tue, 19 May 2020 14:40:55 -0400 Received: from wforward4-smtp.messagingengine.com ([64.147.123.34]:39907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb7Ab-0004i7-01 for 32723@debbugs.gnu.org; Tue, 19 May 2020 14:40:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailforward.west.internal (Postfix) with ESMTP id C8649936; Tue, 19 May 2020 14:40:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 May 2020 14:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xTnqoS XEy49As+7u/dAsjecn8piYqCqYMarSt6C91Yc=; b=RvTrcflIpIy8vonwwFznX5 WVIbN6NxRGKAe9pWc0Tu5+L7XywPmiClhx5/pcThHBtnJz9Isg6dkpFxPGaufVkQ 2RTZF8i6kQQ52XDVDTFFCaRthpxKPJSttfeh4bkmPODnLGzyGAp1V7V+0wI3N23M OsDwdjAXgO602dUzgecMCMzxB4+5YUxuJiJtTRzsE+C9J8rfBcSzYBlh0CHfAmCL Obb6DAqrCxU1VShVpVfYMS5MhjXSIhdLcyb1ylJuhEa1S3yHWm7+rubl1DjWDzVE mCqvzUfjvkYLwrgKc9RF5ZgREY9u/euC2gRWWBQTJxzTuJbVRNi6Rzq5jKceG2UA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtjedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufhffjgfkgggtsehgtderredttdejnecuhfhrohhmpefmvghvihhn uceurhhusggvtghkucgfnhhhrghmmhgvrhcuoehunhhhrghmmhgvrhesfhhsfhgvrdhorh hgqeenucggtffrrghtthgvrhhnpeekvefhkeejtedvkedtgeefleekffevudevveegteef fedtteeuhedvieeffeevvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehunhhhrghmmhgvrhesfhhsfhgvrdhorhhg X-ME-Proxy: From: Kevin Brubeck Unhammer To: Martin Kletzander Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> <87ftc7h9gp.fsf@fsfe.org> <20200511150654.GF30179@wheatley> <20200519182524.GE926@wheatley> Date: Tue, 19 May 2020 20:40:41 +0200 In-Reply-To: <20200519182524.GE926@wheatley> (Martin Kletzander's message of "Tue, 19 May 2020 20:25:24 +0200") Message-ID: <87sgfvydhy.fsf@mm.st> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 32723 Cc: Lars Ingebrigtsen , 32723@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Martin Kletzander =C4=8D=C3=A1lii: > Only after that I realised it has a name > of the channel, but on the second server, so I deleted that part of the e= -mail! > > I think there is something wrong with some other part of erc-join (or erc= ), so > for a while I'm sticking to 26.* I also noticed this with Emacs 27 after writing you. ERC shows things like #emacs@BitlBee (should be @freenode). I haven't been able to find out what causes it (doesn't happen every time I connect to two servers, only when I don't have time to investigate). Will report back if I figure it out. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq9A0PxCu5rIo7lbX/DwefQCTFmcFAl7EKCkACgkQ/DwefQCT FmcRYQ//X8YqfyoG0JQhVTnr38bBj0FtD0FJcvAS/GxmAs3SKyhBnyJRfzo+EANw GvMH7sooNGYyXyhBNmRfxjnOTGVsv1vj3AXJBr8BUFxFX0bG3XbILtzE7DwZn8Pm +tBY0OJJXqtHWLT2ErJXogpH4OwSfJXW+JoRew56wicutts7SysPEfXYu8p5bZRK zHXnAppQfnlNnD/+/xu2G9K0cZYDWvBg6PExTiJ6LnR4SJW5AjtJXmIHLbMX9EMz Brd/cZ9c97dtLLgH/n0PxZ21EHh0VKZBh/4y2hrsntuXtp/AA3hNZuKQBESYIBZi YO3wu7QzvV4AzWYdZic6oQe7BhVVHt9cLeh7glV2oQMJdA7ubDm2LkTY+Atrmp+W wAmiFDtY78p5eibNkbRIvVsu7qLo6mdjg4winPEJe+b/445QMz38rD5wAmnYDaEo BEhEyF9jEbVtma3HE1QXsaW3xx6foZkyHJCFnYeLbssaR+tDVEcKYmJ2WS/b0wpE HzgFxybDdH+ChM3L+xnkuwuQqJzE5WiYOjF9Q275tZaL+3eHKJO2gP4tzBUaLOMG Zykec1N6TVXxrg5NYnQqkRCdvyDoFdhXIkF+nMszHjCTIJMmNE8rPFObFO0PfeNK XR4rT35o4h1NA0MZbg3Qw7FSMupHWUNnAiSKg1ibektMu4mT61g= =NL+O -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 19 16:32:47 2020 Received: (at 32723) by debbugs.gnu.org; 19 May 2020 20:32:47 +0000 Received: from localhost ([127.0.0.1]:51203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb8uk-0007Tc-1h for submit@debbugs.gnu.org; Tue, 19 May 2020 16:32:47 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:41319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb8ui-0007TO-O0 for 32723@debbugs.gnu.org; Tue, 19 May 2020 16:32:37 -0400 Received: by mail-qv1-f42.google.com with SMTP id v15so279873qvr.8 for <32723@debbugs.gnu.org>; Tue, 19 May 2020 13:32:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SFvreER7iQr6plxg2IQnGlq1D8M9EGinfeWYYFxWMmw=; b=pMtLQEahHU1UXxNgu088gIiqPmuBpUjkLsJUJnIGgq5v/xaL0cia9RBeeEr4LuhXxk SqP+EH64OcFOEULYaFuN5Km5U0WZZr5TuXiyQ1W6dvpyOL4YJesAzY6zGSdGzIuF9jLo JMhJV7hi1ilv1fM0LFmF4ZOylaqu4BiqFNFGJChz+Fo7onFxHbs82amJ6Yzx8ZNlyrBG gN44vPAzXTgiXNCJHJ0xFE1EPFNGzZ6uqq0lc95Abg5ex6a938jF7okVXDl37z70o0ZM pQqSGJTBGjvqzQQ87IF94g08CVbcGPTydRLL7j4FvVb21ilB8iAD3iYCDbUM5+vZzCtR nCDA== X-Gm-Message-State: AOAM532FaZhcRalCOc+dM4AGSo7YSxXnLgLc8QNzf+sZl5f1gCimN3kz KEJDhY+rCmNZ4oeOYrGfz0jzfBoFzkV0bwr/7fM= X-Google-Smtp-Source: ABdhPJy4v+aeu0WdstHl8ByzLJjTH6kbcJzmDWVNO7CRJG3C+k+OZI3bF97I3SjMl0f6o4CpeZxonfSGIulT0ZAWLn8= X-Received: by 2002:a0c:eb49:: with SMTP id c9mr1548201qvq.123.1589920350990; Tue, 19 May 2020 13:32:30 -0700 (PDT) MIME-Version: 1.0 References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> <87ftc7h9gp.fsf@fsfe.org> <20200511150654.GF30179@wheatley> <20200519182524.GE926@wheatley> <87sgfvydhy.fsf@mm.st> In-Reply-To: <87sgfvydhy.fsf@mm.st> From: Corwin Brust Date: Tue, 19 May 2020 15:32:19 -0500 Message-ID: Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers To: Kevin Brubeck Unhammer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 32723 Cc: Lars Ingebrigtsen , 32723@debbugs.gnu.org, Martin Kletzander X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) FWIW, and please forgive the top-posted reply: This seems related to this bug I opened fairly recently: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40121#5 I'm not sure but I think this started happening for me after I pulled in a new ERC from master to my ~/site-lisp, which was not too long before I made the switch to Emacs 27 PR 1. (I wanted Amin's patch to make nicks highlight even when followed by a punctuation character.) In any case this behavior has been consistent across all versions of Emacs 27 I've used and started before I'd actually upgraded from Emacs 26.3, if I'm not mistaken. Regards, Corwin On Tue, May 19, 2020 at 1:41 PM Kevin Brubeck Unhammer wrote: > > Martin Kletzander =C4=8D=C3=A1lii: > > > Only after that I realised it has a name > > of the channel, but on the second server, so I deleted that part of the= e-mail! > > > > I think there is something wrong with some other part of erc-join (or e= rc), so > > for a while I'm sticking to 26.* > > I also noticed this with Emacs 27 after writing you. ERC shows things > like #emacs@BitlBee (should be @freenode). I haven't been able to find > out what causes it (doesn't happen every time I connect to two servers, > only when I don't have time to investigate). Will report back if I > figure it out. --=20 Corwin corwin@bru.st From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 10:52:16 2020 Received: (at 32723) by debbugs.gnu.org; 9 Jun 2020 14:52:16 +0000 Received: from localhost ([127.0.0.1]:60574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifbs-0002yJ-4L for submit@debbugs.gnu.org; Tue, 09 Jun 2020 10:52:16 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jifbr-0002y7-5o for 32723@debbugs.gnu.org; Tue, 09 Jun 2020 10:52:15 -0400 Received: by mail-ed1-f65.google.com with SMTP id q13so16622057edi.3 for <32723@debbugs.gnu.org>; Tue, 09 Jun 2020 07:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=sct/do0wz5OD6eWmDiGrh6ka7xcdOArmBfFrNknbhx8=; b=HAJHCe3+ZGNw8lVexa+zlVQotpdreQn8Dc7mRz3GXjxo3bho/E25jqOXx4KYpR3JD9 0QR7c50XVK59op/uRkwTckFfsf+i7vAj5x858SgOQa2vT6rExuGLp3JPO/eaFbifNrAu ZEpdGZO9dHgmcLQ7rLXwKkxdcwBkIb45++2QN3IMEGEFJ5Z0LYbVAT8uXw5b1WdsbVPh 4e4ORCJAtj3zVXEKxNXS1U6GVquX8kdrFaj/4rGyiZgc0b6FoU4uu+GG4MbrBIkoei9I EUWEZJI972v1kNgbsqN3B87VXLVQRXv2NNa3HmoXepBgpRBGXj0zZmzS6eA4rJW7VHhM +VBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=sct/do0wz5OD6eWmDiGrh6ka7xcdOArmBfFrNknbhx8=; b=Ee2VXkCyjQKUqHLU/hJzvls53XzTKKUO4w048D+MJA3K/W78qNg9qtJhj0t/UtGjkJ 5MH4n36LcOi0sWP5t5CU1opPfEJJ7IAsE6MMgzpCEMxBwzfVJgLNL3NPP/t72ceN997d gQ4YA3D2/383r9WKGFM269bucs6CdScjtqGZHW3qWcy2St7waRpqI5glXprihN6Wr6z1 Klv7AwmjBWHOswVkp259+HTjGiFv8I0dt5SKK3zYYUIM+i5MycyObq9jCWhK2KLLhwf0 6Mo2ntXP/3RVbBnRDBpNGeLz9YpIKw6HfDpAFbXOqcLbBtA3t/BHvfJehvJXqsHTbgJS wcVQ== X-Gm-Message-State: AOAM533mOlcTCyGNqaphEBsTBlTjg2NyHBMcbWKVf140wojSfni2Veh3 51cKZ7lzIG/CldjSuQVnCdA= X-Google-Smtp-Source: ABdhPJz4/e0DLxhII3HZoXWHQhxuqjA4psonJeP42lSr//M/ibwxH0+f5yz9SS5Akd9W9LqOWLzFLw== X-Received: by 2002:a05:6402:1812:: with SMTP id g18mr26671784edy.96.1591714329036; Tue, 09 Jun 2020 07:52:09 -0700 (PDT) Received: from carol.localdomain (k8r.cz. [95.82.177.71]) by smtp.gmail.com with ESMTPSA id cn14sm11804187edb.22.2020.06.09.07.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 07:52:07 -0700 (PDT) Received: by carol.localdomain (Postfix, from userid 1000) id 43E3FC20021; Tue, 9 Jun 2020 16:52:07 +0200 (CEST) Date: Tue, 9 Jun 2020 16:52:07 +0200 From: Martin Kletzander To: Corwin Brust Subject: Re: bug#32723: [PATCH] Fix erc-autojoin for same channel names on multiple servers Message-ID: <20200609145207.GA27971@wheatley> References: <1ea700cd1f4f6a80dd1315c8192361bd09d1eadd.1536767069.git.nert.pinx@gmail.com> <87ftc7h9gp.fsf@fsfe.org> <20200511150654.GF30179@wheatley> <20200519182524.GE926@wheatley> <87sgfvydhy.fsf@mm.st> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32723 Cc: Kevin Brubeck Unhammer , 32723@debbugs.gnu.org, Lars Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, May 19, 2020 at 03:32:19PM -0500, Corwin Brust wrote: >FWIW, and please forgive the top-posted reply: > >This seems related to this bug I opened fairly recently: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40121#5 > >I'm not sure but I think this started happening for me after I pulled >in a new ERC from master to my ~/site-lisp, which was not too long >before I made the switch to Emacs 27 PR 1. (I wanted Amin's patch to >make nicks highlight even when followed by a punctuation character.) > >In any case this behavior has been consistent across all versions of >Emacs 27 I've used and started before I'd actually upgraded from Emacs >26.3, if I'm not mistaken. > Sorry for such a late reply, just wanted to share that I experience the same thing as you described in the bug, it happens on 27.0.91, but *not* on 26.3. >Regards, >Corwin > >On Tue, May 19, 2020 at 1:41 PM Kevin Brubeck Unhammer > wrote: >> >> Martin Kletzander čálii: >> >> > Only after that I realised it has a name >> > of the channel, but on the second server, so I deleted that part of the e-mail! >> > >> > I think there is something wrong with some other part of erc-join (or erc), so >> > for a while I'm sticking to 26.* >> >> I also noticed this with Emacs 27 after writing you. ERC shows things >> like #emacs@BitlBee (should be @freenode). I haven't been able to find >> out what causes it (doesn't happen every time I connect to two servers, >> only when I don't have time to investigate). Will report back if I >> figure it out. > > > >-- >Corwin >corwin@bru.st From unknown Fri Aug 15 14:18:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Jul 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator