From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 22:44:31 2018 Received: (at submit) by debbugs.gnu.org; 12 Sep 2018 02:44:31 +0000 Received: from localhost ([127.0.0.1]:37612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzv8n-0000fl-OJ for submit@debbugs.gnu.org; Tue, 11 Sep 2018 22:44:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzv8k-0000fW-Qf for submit@debbugs.gnu.org; Tue, 11 Sep 2018 22:44:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzv8e-0002FK-Dx for submit@debbugs.gnu.org; Tue, 11 Sep 2018 22:44:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59156) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzv8a-0002Dk-QA for submit@debbugs.gnu.org; Tue, 11 Sep 2018 22:44:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzv8X-0001yt-Id for guix-patches@gnu.org; Tue, 11 Sep 2018 22:44:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzv3W-0008K3-Rq for guix-patches@gnu.org; Tue, 11 Sep 2018 22:39:05 -0400 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:24597 helo=smtp.centurylink.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzv3W-0008Hg-4p for guix-patches@gnu.org; Tue, 11 Sep 2018 22:39:02 -0400 DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402; c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1536719939; h=From:Subject:Date:To:MIME-Version; bh=zhmLiEKuRhOSS/zRHhZqqdBlUHk=; b=TZV7BmbxcZMuh+tfOsW4O1qOu92LzXkHfB1AF+xF24AUiFsOLkohXZxkdQ7LI58l ghF3hln/oMm3LHVyZ6wauw3tfic5VsBg9IzsXSYF+ZzW5+Wr8Nx9evOj+eGRAb0R QVi5MvYF5i7QQ5D5VhV+axfNKrh+SoHVUVrWJw+2fsObdGgtbTCcW8Ydc9rwf1hA lCSS7VTowviBUlMWiIUknSAfbKpWPhehOSnBgvBorKEOGUgo8iwr6hbjgjJOTVo6 zqOqwG4yEuzzMq3LGalElirhy1SMSYZp4S54Ub5I68t4pyCxnolQJTZ0ZX+wcjCB 9NLDYtTzQh1dsK9lNAlBKA==; X_CMAE_Category: , , X-CNFS-Analysis: v=2.2 cv=ZfNfDYdA c=1 sm=1 tr=0 a=boACHAFv0BJYV+eIivT6MQ==:117 a=boACHAFv0BJYV+eIivT6MQ==:17 a=KGjhK52YXX0A:10 a=JBFolyDoGHsA:10 a=zSv6zi-ZgakA:10 a=inoG4m36AAAA:8 a=aCpeKuseNI8zNWB0MyYA:9 a=_Qgj-RFg6mImvLaOgLPg:22 X-CM-Score: 0 X-Scanned-by: Cloudmark Authority Engine X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ= Authentication-Results: smtp03.onyx.dfw.sync.lan smtp.user=ericbavier@centurylink.net; auth=pass (LOGIN) Received: from [97.116.168.230] ([97.116.168.230:57498] helo=localhost.localdomain) by smtp.centurylink.net (envelope-from ) (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA (cipher=DHE-RSA-AES128-GCM-SHA256) id 15/B3-20861-34C789B5; Tue, 11 Sep 2018 22:38:59 -0400 From: ericbavier@centurylink.net To: guix-patches@gnu.org Subject: [PATCH] ui: Fix abort on #\nul character in build output. Date: Tue, 11 Sep 2018 21:38:23 -0500 Message-Id: <20180912023823.13240-1-ericbavier@centurylink.net> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) From: Eric Bavier Fixes build of "lz4" package, e.g. * guix/ui.scm (build-output-port)[handle-string]: Check for #\nul before doing any regex matching. --- guix/ui.scm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/guix/ui.scm b/guix/ui.scm index c55ae7e2f..207aba8ad 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -1762,18 +1762,19 @@ phase announcements and replaces any other output with a spinner." RED BLUE RED BLUE RED BLUE)))) (lambda (str) (let ((processed - (any (match-lambda - ((pattern #:transform transform) - (and=> (string-match pattern str) - transform)) - ((pattern . colors) - (and=> (string-match pattern str) - (lambda (m) - (let ((substrings - (map (cut match:substring m <>) - (iota (- (match:count m) 1) 1)))) - (string-join (map proc substrings colors) "")))))) - rules))) + (and (not (string-index str #\nul)) ;(ice-9 regex) cannot handle #\nul + (any (match-lambda + ((pattern #:transform transform) + (and=> (string-match pattern str) + transform)) + ((pattern . colors) + (and=> (string-match pattern str) + (lambda (m) + (let ((substrings + (map (cut match:substring m <>) + (iota (- (match:count m) 1) 1)))) + (string-join (map proc substrings colors) "")))))) + rules)))) (when spun? (display (string #\backspace) port)) (if processed -- 2.18.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 28 17:15:00 2018 Received: (at 32711-done) by debbugs.gnu.org; 28 Sep 2018 21:15:00 +0000 Received: from localhost ([127.0.0.1]:58099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g606G-0006EM-JR for submit@debbugs.gnu.org; Fri, 28 Sep 2018 17:15:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g606E-0006E0-Un for 32711-done@debbugs.gnu.org; Fri, 28 Sep 2018 17:14:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6069-0005TY-B7 for 32711-done@debbugs.gnu.org; Fri, 28 Sep 2018 17:14:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6067-0005RG-KK; Fri, 28 Sep 2018 17:14:51 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48986 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g6067-0007Kx-BD; Fri, 28 Sep 2018 17:14:51 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: ericbavier@centurylink.net Subject: Re: [bug#32711] [PATCH] ui: Fix abort on #\nul character in build output. References: <20180912023823.13240-1-ericbavier@centurylink.net> Date: Fri, 28 Sep 2018 23:14:49 +0200 In-Reply-To: <20180912023823.13240-1-ericbavier@centurylink.net> (ericbavier's message of "Tue, 11 Sep 2018 21:38:23 -0500") Message-ID: <8736tt1fzq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32711-done Cc: 32711-done@debbugs.gnu.org, Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Eric, ericbavier@centurylink.net skribis: > From: Eric Bavier > > Fixes build of "lz4" package, e.g. > > * guix/ui.scm (build-output-port)[handle-string]: Check for #\nul before = doing > any regex matching. This is fixed in the new (guix status) code, commit dc0f74e5fc26977a3ee6c4f2aa74a141f4359982 (see the =E2=80=98color-rules=E2= =80=99 macro.) Thank you, and sorry for not responding earlier! Ludo=E2=80=99. From unknown Fri Aug 15 21:26:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 27 Oct 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator