GNU bug report logs - #32703
echo_man_error

Previous Next

Full log

Message #30 received at 32703 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: 32703 <at> debbugs.gnu.org, P <at> draigBrady.com, szq1064240043 <at> qq.com
Subject: Re: bug#32703: echo_man_error
Date: Mon, 24 Sep 2018 23:47:39 +0200

[Message part 1 (text/plain, inline)]

On 9/24/18 4:48 AM, Pádraig Brady wrote:
> I'll push the attached later.
> Interesting there were no echo tests until now.

Nice work, indeed.

Additionally to Eric's comment, I'd suggest to increase the coverage
for 'echo' to about 100% [1] with the attached patch:

*  src/echo.c (usage): Assert that STATUS is always EXIT_SUCCESS.
* tests/misc/echo.sh: Add further tests for all hex and escape and
escape characters.

You may simply squash it in.

[1] To get coverage statistic, run:
  make coverage -j 4 TESTS=tests/misc/echo.sh SUBDIRS=.
  xdg-open file:doc/coverage/src/echo.c.gcov.frameset.html


Have a nice day,
Berny

[echo-test-coverage.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.