From unknown Fri Jun 20 20:08:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32680 <32680@debbugs.gnu.org> To: bug#32680 <32680@debbugs.gnu.org> Subject: Status: 27.0.50; Improve docstring and customization for 'message-signature' Reply-To: bug#32680 <32680@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:08:26 +0000 retitle 32680 27.0.50; Improve docstring and customization for 'message-sig= nature' reassign 32680 emacs submitter 32680 Philipp Stephani severity 32680 minor tag 32680 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 10 09:16:08 2018 Received: (at submit) by debbugs.gnu.org; 10 Sep 2018 13:16:08 +0000 Received: from localhost ([127.0.0.1]:51881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzM2y-0000XS-3I for submit@debbugs.gnu.org; Mon, 10 Sep 2018 09:16:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzM2w-0000Wy-Dl for submit@debbugs.gnu.org; Mon, 10 Sep 2018 09:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzM2q-0004CJ-1t for submit@debbugs.gnu.org; Mon, 10 Sep 2018 09:16:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49108) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzM2p-0004BB-08 for submit@debbugs.gnu.org; Mon, 10 Sep 2018 09:15:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzM2n-0008Bz-Ox for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2018 09:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzLzk-0000y8-Ul for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2018 09:12:49 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:40790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fzLzk-0000xv-OL for bug-gnu-emacs@gnu.org; Mon, 10 Sep 2018 09:12:48 -0400 Received: by mail-wr1-x42a.google.com with SMTP id n2-v6so21896296wrw.7 for ; Mon, 10 Sep 2018 06:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=bU+jK+v288qROwvKJdDVER2QwxF3Dy03qALgWK+HDsQ=; b=QiEiF3i2kT5y7bR1jKmHZNRSIOcZPl80u7SLP6gp/KLE6w7yU2PXFXm8/cVxUPMbSo Jyk7I+zra73cKMnUG9BqBWag3+Acb9OPmBl8WpgBHvp8u2d4qmRcrZ2DQxycY9JSTxGL 5KcY9GzFJP1Lfmo7RFFkbTpXZt3xO2kxWz0dnmCHjdmcauoWIY2VuqiA4wjGgE0WJ+xQ gnXaDqTGJU3aWHtJTswnDCZoMr23cxsJDyJgSCPs/dS1WccLrHAjCLUe+ZmfyKDyBYw1 Hl6DYkKFvi54g2ZkCbsll+I80PLY5BYDZuSsQca6HnNbef5/5C770QVQ6RPzBCG+Z0pQ KdPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=bU+jK+v288qROwvKJdDVER2QwxF3Dy03qALgWK+HDsQ=; b=jGBurSZELBLyP97hHpqh2z9RXwVMXEMFOcyXeMdAKhFkOGjfCyOr+XAcu8cz6+iNb6 FBPEzYivfS0fL/6JHr87OREmTRFtyy+rLsnxDD9Gbi2I1wqZRhh6rP0WS5vboNhqMvfW GYMMV78WF9rZG7vSZj4VgHRf2FTzwB74YuF9r76SWB0rqJ8leeMj+LhO8B19EC96OrRx F/aKosEqEoM5fZv3yGEKmOC2o/hgH36O/FInu59u7SVqbK/NzcgymGcVb7ish6WnknKW REeeqCTfPxpqjWzT0aQtrmC9LqWx07qb3ydTuSNjD871dNIOI7zrYd9SKKBXCHKQVPpm 1TkQ== X-Gm-Message-State: APzg51B9v8x3bUcEXFbX6GITHDI/cjAahPomA5B+BAC0l7jGQTMj1AOC wiWpKv9Xrpu2pbuXAZu85hQymglI X-Google-Smtp-Source: ANB0VdYcROT+GiV2SKErFymyY1DK/oMqb6it3iPoeLb6TUfs+cY7CZDOKHUdRVpYhZIyQL+7tJs0sA== X-Received: by 2002:a5d:574b:: with SMTP id q11-v6mr15063995wrw.272.1536585166169; Mon, 10 Sep 2018 06:12:46 -0700 (PDT) Received: from a.muc.corp.google.com ([2a00:79e0:15:10:cd99:29f5:6da:65fc]) by smtp.gmail.com with ESMTPSA id 94-v6sm19713501wrc.10.2018.09.10.06.12.45 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Sep 2018 06:12:45 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Improve docstring and customization for 'message-signature' Date: Mon, 10 Sep 2018 15:12:40 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) The manual states If you change =E2=80=98message-signature=E2=80=99 to =E2=80=98nil=E2=80= =99, Emacs will not insert your mail signature automatically. You can insert your mail signature by typing =E2=80=98C-c C-w=E2=80=99 (=E2=80=98message-insert-signature=E2= =80=99) in the mail buffer. Emacs will look for your signature in the signature file. However, the docstring for message-signature doesn't state that nil is a possible value, and the customization choices also don't suggest nil. In GNU Emacs 27.0.50 (build 45, x86_64-pc-linux-gnu, GTK+ Version 3.22.24) of 2018-09-10 built on localhost Repository revision: a65fe6fbf6f05789bb69c50de7b0946adf8773ac Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Debian GNU/Linux buster/sid Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --without-threads --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY GNUTLS FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES JSON GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 95085 7371) (symbols 48 20185 1) (strings 32 28364 1644) (string-bytes 1 762351) (vectors 16 14358) (vector-slots 8 509630 11310) (floats 8 48 69) (intervals 56 223 0) (buffers 992 12)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don=E2=80=99t forward= it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 10 10:25:31 2018 Received: (at 32680) by debbugs.gnu.org; 10 Sep 2018 14:25:31 +0000 Received: from localhost ([127.0.0.1]:52501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzN86-0002NS-SI for submit@debbugs.gnu.org; Mon, 10 Sep 2018 10:25:31 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:41522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzN85-0002NF-Cf for 32680@debbugs.gnu.org; Mon, 10 Sep 2018 10:25:29 -0400 Received: by mail-wr1-f45.google.com with SMTP id z96-v6so22172240wrb.8 for <32680@debbugs.gnu.org>; Mon, 10 Sep 2018 07:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=uvOAZIyFHyGxOxrNfjZrP9Qp3MXx47qP2WeDYmF0o14=; b=N5xtAtqO/wNzKE/+E5b61QNUpmQCsNG1Vv3Kb7ieMax13Os6ZurlRA8eFbx5wDebOj gFrnjfVR7+H/woHn5bTTlyTPmFc/9zM2T0Iz3mFqhGVp3i5GG2mFrBg8at7jqE5gHnVk xB4UNGYLLBRpu5FQWv4WGwo8cfI0DajN4vwD8/+HfjHjjBUOcBZk6Pet6snppB3RvM1T BBtX+XH6bp/wKi+uM2vohs6puzqONWkNlQI2R3ckaZRfoayjf0RiutUzKij9vmBUiZYP /Ms1TU4IzWO2upZHnD6+hCPuyCIjOYq8ONJGmibK9Umf+C83WkyuvkEKCplbfQbKr/Qa L3tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=uvOAZIyFHyGxOxrNfjZrP9Qp3MXx47qP2WeDYmF0o14=; b=fjWxEGIwLYp5lyqZDO3FrlBOaZmzkX8KGW9QuvGIXaYspwHaiXSPZP0+6HSFIqFEcF //ZVd7sEXXJkQT8OuxDAvwDXhXkfRiGssvPKKwU8ycxlhxtU+Eh40dcibFRfnoeTRPkW QuNj+j2US7VsL9FKVvDwKCymkbJ3fnLrwXunkdyA5LHRoQmWJaP5HVGol4qtLPUnUQg9 cw330+3o0889L0GhAuB9yo+ByRix+b+m6nWtwzc1Q9DIB8IIzF5MFkgquK/JkZXfrH6h veXDKZyl2mCb3cRsnAxyB+5knJm8z/ehoC7FzUc4iwXx5olSH2VekgdvOmJv3DHSFDli Ks3g== X-Gm-Message-State: APzg51AA0NNaE+/Ivik9ULI7TAqMeZLIVsnqdIZsqU6rUwTCMJk7gCaI LkoU7N6A/z6jvQt/zwu8YHiPJi33 X-Google-Smtp-Source: ANB0VdYgc6zCykKaNDuDtAFk5GBrDiT1vjSOG/ubK1yWJhP5X4upUdKXQsTXzvQPtNo5NXHd+1Qk7Q== X-Received: by 2002:adf:a936:: with SMTP id u51-v6mr16252125wrc.175.1536589523111; Mon, 10 Sep 2018 07:25:23 -0700 (PDT) Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id b10-v6sm15592020wrr.88.2018.09.10.07.25.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Sep 2018 07:25:22 -0700 (PDT) From: Robert Pluim To: Philipp Stephani Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 10 Sep 2018 16:25:21 +0200 In-Reply-To: (Philipp Stephani's message of "Mon, 10 Sep 2018 15:12:40 +0200") Message-ID: <87wort1lbi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32680 Cc: 32680@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philipp Stephani writes: > The manual states > > If you change =E2=80=98message-signature=E2=80=99 to =E2=80=98nil=E2= =80=99, Emacs will not insert > your mail signature automatically. You can insert your mail signature > by typing =E2=80=98C-c C-w=E2=80=99 (=E2=80=98message-insert-signature=E2= =80=99) in the mail buffer. > Emacs will look for your signature in the signature file. > > However, the docstring for message-signature doesn't state that nil is a > possible value, and the customization choices also don't suggest nil. We could even put this in emacs-26. 2018-09-10 Robert Pluim * lisp/gnus/message.el (message-signature): Allow nil as a customizable value, and describe its effect. (Bug #32680) diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el index 66356b6fda..ec2286b06d 100644 --- i/lisp/gnus/message.el +++ w/lisp/gnus/message.el @@ -1079,12 +1079,15 @@ message-indent-citation-function (defcustom message-signature mail-signature "String to be inserted at the end of the message buffer. If t, the `message-signature-file' file will be inserted instead. +If nil, no signature is inserted. If a function, the result from the function will be used instead. -If a form, the result from the form will be used instead." - :version "23.2" +If a form, the result from the form will be used instead. +See `mail-signature' for the recommended format of a signature." + :version "27.1" :type '(choice string (const :tag "Contents of signature file" t) function - sexp) + sexp + (const :tag "None" nil)) :risky t :link '(custom-manual "(message)Insertion Variables") :group 'message-insertion) From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 10 10:55:31 2018 Received: (at 32680) by debbugs.gnu.org; 10 Sep 2018 14:55:31 +0000 Received: from localhost ([127.0.0.1]:52541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzNb7-00038W-LW for submit@debbugs.gnu.org; Mon, 10 Sep 2018 10:55:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzNb6-00038H-4r for 32680@debbugs.gnu.org; Mon, 10 Sep 2018 10:55:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzNax-0003TH-Jj for 32680@debbugs.gnu.org; Mon, 10 Sep 2018 10:55:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzNax-0003TD-G1; Mon, 10 Sep 2018 10:55:19 -0400 Received: from [176.228.60.248] (port=2735 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fzNax-0006PE-36; Mon, 10 Sep 2018 10:55:19 -0400 Date: Mon, 10 Sep 2018 17:55:27 +0300 Message-Id: <83lg89o10h.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-reply-to: <87wort1lbi.fsf@gmail.com> (message from Robert Pluim on Mon, 10 Sep 2018 16:25:21 +0200) Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: <87wort1lbi.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32680 Cc: 32680@debbugs.gnu.org, p.stephani2@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Robert Pluim > Date: Mon, 10 Sep 2018 16:25:21 +0200 > Cc: 32680@debbugs.gnu.org > > Philipp Stephani writes: > > > The manual states > > > > If you change ‘message-signature’ to ‘nil’, Emacs will not insert > > your mail signature automatically. You can insert your mail signature > > by typing ‘C-c C-w’ (‘message-insert-signature’) in the mail buffer. > > Emacs will look for your signature in the signature file. > > > > However, the docstring for message-signature doesn't state that nil is a > > possible value, and the customization choices also don't suggest nil. > > We could even put this in emacs-26. Fine with me, but if it will go to emacs-26, then the :version tag should say so. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 10 11:52:35 2018 Received: (at 32680) by debbugs.gnu.org; 10 Sep 2018 15:52:35 +0000 Received: from localhost ([127.0.0.1]:35663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzOUM-0000z0-UO for submit@debbugs.gnu.org; Mon, 10 Sep 2018 11:52:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzOUL-0000yk-GQ for 32680@debbugs.gnu.org; Mon, 10 Sep 2018 11:52:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzOUD-0005Qf-6I for 32680@debbugs.gnu.org; Mon, 10 Sep 2018 11:52:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzOU6-0005Om-U5; Mon, 10 Sep 2018 11:52:23 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1fzOU1-0000Ym-8c; Mon, 10 Sep 2018 11:52:15 -0400 From: Glenn Morris To: 32680@debbugs.gnu.org Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: <87wort1lbi.fsf@gmail.com> X-Spook: [Hello to all my friends and fans in domestic X-Ran: )wWA*hS8(E-Xkc\9${n?(_<%ds-Lwgf=UZZjKsFF (Robert Pluim's message of "Mon, 10 Sep 2018 16:25:21 +0200") Message-ID: <4qlg89tknn.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32680 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Robert Pluim wrote: > --- i/lisp/gnus/message.el > +++ w/lisp/gnus/message.el > @@ -1079,12 +1079,15 @@ message-indent-citation-function > (defcustom message-signature mail-signature > "String to be inserted at the end of the message buffer. > If t, the `message-signature-file' file will be inserted instead. > +If nil, no signature is inserted. > If a function, the result from the function will be used instead. > -If a form, the result from the form will be used instead." > - :version "23.2" > +If a form, the result from the form will be used instead. May as well rewrite it all to use the active voice while you are there. > +See `mail-signature' for the recommended format of a signature." > + :version "27.1" It's not new, and the default hasn't changed, so a version bump is not appropriate. It's just a doc fix. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 11 03:28:53 2018 Received: (at 32680) by debbugs.gnu.org; 11 Sep 2018 07:28:53 +0000 Received: from localhost ([127.0.0.1]:36099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzd6S-0004ru-Oz for submit@debbugs.gnu.org; Tue, 11 Sep 2018 03:28:53 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fzd6R-0004ri-05 for 32680@debbugs.gnu.org; Tue, 11 Sep 2018 03:28:51 -0400 Received: by mail-wm0-f65.google.com with SMTP id o18-v6so238776wmc.0 for <32680@debbugs.gnu.org>; Tue, 11 Sep 2018 00:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=20qg2kJfgHL4pv/h8lHwXO0Decn6DjJgM1UZBTw/nno=; b=KSQRP1Ez/XheLwy3NsQYZXEpabg+c0lDhZSyu6nTu/vWfVwu2hizb9ix73+N1exS88 d0UrgnTlQHV19GdKgA2pKNpcU/yPvrZxHlnj5kTDuc+8sfd6BEdQxrnfs3CLfFDOFSMI hUO127lFg6dbCYIUEXO1uqBN4H5KJ2R9RKyEnXubTdTPw5lNBV9RQfOGoXAdARYycotQ Adqe/9pKMzoEzpm4PImYxm4KEj+RA0lHk0rt1WZIFFZNxqYEwHyd+3OgQJnv2Ty2OM6b DgBjt09z0hJL4KMBJF6v58HYqrYY5Bj+y7QwTQ3Ee0R2IIsVYn0hQ48apAF2/Rl6n+5r J1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=20qg2kJfgHL4pv/h8lHwXO0Decn6DjJgM1UZBTw/nno=; b=SlNrLBi9tWyttRr0qIPSRC9xaH5BzH3C1IEsP/2PUoI/vHw7yIx+UnOjyGp36G634S 110aPJvtLgv6ufLgJlMhBl8dbc/9fPpffprud3cGozqbFPZnhKQ8py29vx9a2P30MRIO fOJI0KOqMo1BO/T/b8pT7oLiYwgsuCGOcL6NIdmtTshn8GQzPQPHeCrRWlGoO8DGtUoT yd0au9ECXPth7m8GORCHqjfWhRMgQlBFLYXlW5h4p17Z0zeemMImSdlxshCbfVW/6zUH /+6ymzUpFp8Sjwf6O+rj4ZUImUZwT/zqUIFruakDei8WQuOY1sEUJq6HXi2N2kCk6S/l 58CQ== X-Gm-Message-State: APzg51Ay/VR5NiawDnDeg1xv3iMHtv0tdjNwg3Q5l2XYl4vVq0TVPZTP wzF1VfLHh0UrD4Zhkz2QuQ8= X-Google-Smtp-Source: ANB0VdbVhUd2yLBz2PKOK8c3ZF8R3eHabDHSOqKl7ka61nw3PY8Emc6kmbRBoLSNABZ4JP9X1SdBkw== X-Received: by 2002:a1c:1f50:: with SMTP id f77-v6mr405707wmf.52.1536650924976; Tue, 11 Sep 2018 00:28:44 -0700 (PDT) Received: from rpluim-ubuntu (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id k34-v6sm27317109wre.18.2018.09.11.00.28.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Sep 2018 00:28:44 -0700 (PDT) From: Robert Pluim To: Glenn Morris Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: <87wort1lbi.fsf@gmail.com> <4qlg89tknn.fsf@fencepost.gnu.org> X-Debbugs-No-Ack: yes Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 11 Sep 2018 09:28:43 +0200 In-Reply-To: <4qlg89tknn.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 10 Sep 2018 11:52:12 -0400") Message-ID: <877ejsebmc.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32680 Cc: 32680@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Glenn Morris writes: > Robert Pluim wrote: > >> --- i/lisp/gnus/message.el >> +++ w/lisp/gnus/message.el >> @@ -1079,12 +1079,15 @@ message-indent-citation-function >> (defcustom message-signature mail-signature >> "String to be inserted at the end of the message buffer. >> If t, the `message-signature-file' file will be inserted instead. >> +If nil, no signature is inserted. >> If a function, the result from the function will be used instead. >> -If a form, the result from the form will be used instead." >> - :version "23.2" >> +If a form, the result from the form will be used instead. > > May as well rewrite it all to use the active voice while you are there. > OK. I modified 'mail-signature' as well, it didn=CA=BCt describe the nil value. >> +See `mail-signature' for the recommended format of a signature." >> + :version "27.1" > > It's not new, and the default hasn't changed, so a version bump is not > appropriate. It's just a doc fix. Fixed. 2018-09-10 Robert Pluim * lisp/gnus/message.el (message-signature): Allow nil as a customizable value, and describe its effect. * lisp/mail/sendmail.el (mail-signature): Describe effect of nil value. diff --git i/lisp/gnus/message.el w/lisp/gnus/message.el index 66356b6fda..6ecf804e9e 100644 --- i/lisp/gnus/message.el +++ w/lisp/gnus/message.el @@ -1078,13 +1078,16 @@ message-indent-citation-function =20 (defcustom message-signature mail-signature "String to be inserted at the end of the message buffer. -If t, the `message-signature-file' file will be inserted instead. -If a function, the result from the function will be used instead. -If a form, the result from the form will be used instead." +If nil, no signature is inserted. +If t, the `message-signature-file' file is inserted instead. +If a function, the result from the function is used. +If a form, the result from the form is used. +See `mail-signature' for the recommended format of a signature." :version "23.2" :type '(choice string (const :tag "Contents of signature file" t) function - sexp) + sexp + (const :tag "None" nil)) :risky t :link '(custom-manual "(message)Insertion Variables") :group 'message-insertion) diff --git i/lisp/mail/sendmail.el w/lisp/mail/sendmail.el index 50dd81039e..af5270fbd9 100644 --- i/lisp/mail/sendmail.el +++ w/lisp/mail/sendmail.el @@ -370,6 +370,7 @@ mail-mode-map ;;;###autoload (defcustom mail-signature t "Text inserted at end of mail buffer when a message is initialized. +If nil, no signature is inserted. If t, it means to insert the contents of the file `mail-signature-file'. If a string, that string is inserted. (To make a proper signature, the string should begin with \\n\\n-- \\n, From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 13 11:31:13 2018 Received: (at 32680) by debbugs.gnu.org; 13 Sep 2018 15:31:13 +0000 Received: from localhost ([127.0.0.1]:39400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0TaL-0007iA-A2 for submit@debbugs.gnu.org; Thu, 13 Sep 2018 11:31:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0TaJ-0007cx-UO for 32680@debbugs.gnu.org; Thu, 13 Sep 2018 11:31:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g0TaD-000353-UO for 32680@debbugs.gnu.org; Thu, 13 Sep 2018 11:31:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g0TaD-00034z-Qw; Thu, 13 Sep 2018 11:31:05 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g0TaC-0005IV-Df; Thu, 13 Sep 2018 11:31:04 -0400 From: Glenn Morris To: 32680@debbugs.gnu.org Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: <87wort1lbi.fsf@gmail.com> <4qlg89tknn.fsf@fencepost.gnu.org> <877ejsebmc.fsf@gmail.com> X-Spook: Aladdin csim Gas Mena MS-13 Treasury STARLAN class X-Ran: (p_9h;P'9qR!SJ|sPfB+?="mt0(_0VGBjYM03,^g~zUSj]/pw('lvMf}wVp7[F"`9ci&f` X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 13 Sep 2018 11:31:04 -0400 In-Reply-To: <877ejsebmc.fsf@gmail.com> (Robert Pluim's message of "Tue, 11 Sep 2018 09:28:43 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32680 Cc: Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Robert Pluim wrote: > -If t, the `message-signature-file' file will be inserted instead. > -If a function, the result from the function will be used instead. > -If a form, the result from the form will be used instead." > +If nil, no signature is inserted. > +If t, the `message-signature-file' file is inserted instead. > +If a function, the result from the function is used. > +If a form, the result from the form is used. > +See `mail-signature' for the recommended format of a signature." To me, "active" would be: If nil, don't insert a signature. If t, insert `message-signature-file'. If a function or form, insert its result. From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 16:46:25 2019 Received: (at 32680) by debbugs.gnu.org; 13 May 2019 20:46:26 +0000 Received: from localhost ([127.0.0.1]:46467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHq2-0008E6-Sf for submit@debbugs.gnu.org; Mon, 13 May 2019 16:46:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:45988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHpw-00087g-NB for 32680@debbugs.gnu.org; Mon, 13 May 2019 16:46:17 -0400 Received: from [12.41.144.226] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hQHps-0001VN-HU; Mon, 13 May 2019 22:46:15 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#32680: 27.0.50; Improve docstring and customization for 'message-signature' References: <87wort1lbi.fsf@gmail.com> <4qlg89tknn.fsf@fencepost.gnu.org> <877ejsebmc.fsf@gmail.com> Date: Mon, 13 May 2019 16:46:11 -0400 In-Reply-To: <877ejsebmc.fsf@gmail.com> (Robert Pluim's message of "Tue, 11 Sep 2018 09:28:43 +0200") Message-ID: <87lfzaqe0c.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > 2018-09-10 Robert Pluim > > * lisp/gnus/message.el (message-signature): Allow nil as a > customizable value, and describe its effect. > * lisp/mail/sendmail.el (mail-signature): D [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32680 Cc: 32680@debbugs.gnu.org, Philipp Stephani X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > 2018-09-10 Robert Pluim > > * lisp/gnus/message.el (message-signature): Allow nil as a > customizable value, and describe its effect. > * lisp/mail/sendmail.el (mail-signature): Describe effect of nil value. Thanks; I've now applied this to Emacs 27.1 with Glenn's tweaks to the text. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 16:46:29 2019 Received: (at control) by debbugs.gnu.org; 13 May 2019 20:46:30 +0000 Received: from localhost ([127.0.0.1]:46472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHq9-0008Jy-Fa for submit@debbugs.gnu.org; Mon, 13 May 2019 16:46:29 -0400 Received: from quimby.gnus.org ([80.91.231.51]:46002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQHq4-0008FF-Kk for control@debbugs.gnu.org; Mon, 13 May 2019 16:46:25 -0400 Received: from [12.41.144.226] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hQHq1-0001VV-SD for control@debbugs.gnu.org; Mon, 13 May 2019 22:46:24 +0200 Date: Mon, 13 May 2019 16:46:20 -0400 Message-Id: <87k1euqe03.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #32680 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 32680 fixed close 32680 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32680 fixed close 32680 27.1 quit From unknown Fri Jun 20 20:08:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 11 Jun 2019 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator