GNU bug report logs - #32617
[PATCH] gnu: libjpeg: Update description.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32617 in the body.
You can then email your comments to 32617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: libjpeg: Update description.
Date: Sun, 02 Sep 2018 17:54:58 -0400

[Message part 1 (text/plain, inline)]

Hello,

This should help people like me that failed finding which of our package
provided `jpegtran' :)

Thank you,

Maxim

[0001-gnu-libjpeg-Update-description.patch (text/x-patch, attachment)]

Message #8 received at 32617 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32617 <at> debbugs.gnu.org
Subject: Re: [bug#32617] [PATCH] gnu: libjpeg: Update description.
Date: Tue, 04 Sep 2018 15:09:22 +0200

Hello!

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> This should help people like me that failed finding which of our package
> provided `jpegtran' :)

Heheh.  :-)

>>From 188244b597f7f351cdefe0f50f67b463ceab847f Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Sun, 2 Sep 2018 17:49:51 -0400
> Subject: [PATCH] gnu: libjpeg: Update description.
>
> * gnu/packages/image.scm (libjpeg): Add the list of the programs it provides.

[...]

> +@item cjpeg
> +@item djpeg
> +@item jpegtran
> +@item rdjpgcom
> +@item wrjpgcom

Nitpicking: maybe write:

  @item @command{cjpeg};
  …
  @item @command{wrjpgcom}.

Otherwise LGTM!

Ludo’.

Message #11 received at 32617 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32617 <at> debbugs.gnu.org
Subject: Re: [bug#32617] [PATCH] gnu: libjpeg: Update description.
Date: Tue, 04 Sep 2018 20:54:23 -0400

Hi Ludovic!

ludo <at> gnu.org (Ludovic Courtès) writes:

[...]

>> +@item cjpeg
>> +@item djpeg
>> +@item jpegtran
>> +@item rdjpgcom
>> +@item wrjpgcom
>
> Nitpicking: maybe write:
>
>   @item @command{cjpeg};
>   …
>   @item @command{wrjpgcom}.

I tried this originally, but our linter gently reminded me this was not
supported by our texinfo parser ;).

Thanks for reviewing!

Maxim

Message #14 received at 32617 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32617 <at> debbugs.gnu.org
Subject: Re: [bug#32617] [PATCH] gnu: libjpeg: Update description.
Date: Wed, 05 Sep 2018 12:23:23 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
> [...]
>
>>> +@item cjpeg
>>> +@item djpeg
>>> +@item jpegtran
>>> +@item rdjpgcom
>>> +@item wrjpgcom
>>
>> Nitpicking: maybe write:
>>
>>   @item @command{cjpeg};
>>   …
>>   @item @command{wrjpgcom}.
>
> I tried this originally, but our linter gently reminded me this was not
> supported by our texinfo parser ;).

Oh, I had not noticed that.

Thanks!

Ludo’.

Message #19 received at 32617-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 32617-done <at> debbugs.gnu.org
Subject: Re: [bug#32617] [PATCH] gnu: libjpeg: Update description.
Date: Sat, 15 Sep 2018 10:50:42 +0800

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hello,
>
> This should help people like me that failed finding which of our package
> provided `jpegtran' :)
>

Pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.