GNU bug report logs - #32613
[PATCH] gnu: Add emacs-picpocket.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32613: closed ([PATCH] gnu: Add emacs-picpocket.)
Date: Tue, 04 Sep 2018 13:40:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 04 Sep 2018 15:39:23 +0200
with message-id <874lf5bcvo.fsf <at> gnu.org>
and subject line Re: [bug#32613] [PATCH] gnu: Add emacs-picpocket.
has caused the debbugs.gnu.org bug report #32613,
regarding [PATCH] gnu: Add emacs-picpocket.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32613: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32613
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: alexvong1995 <at> gmail.com
Subject: [PATCH] gnu: Add emacs-picpocket.
Date: Mon, 03 Sep 2018 02:34:49 +0800

[Message part 3 (text/plain, inline)]

Hello guix,

This patch adds picpocket, which is an emacs package for displaying
pictures. It supports full-screen and rotation, which is better than the
vanilla image-mode.

[0001-gnu-Add-emacs-picpocket.patch (text/x-diff, inline)]

From c126ff68c5f881d506226e2a260b96fa6d4635ea Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Mon, 3 Sep 2018 02:25:31 +0800
Subject: [PATCH] gnu: Add emacs-picpocket.

* gnu/packages/emacs.scm (emacs-picpocket): New public variable.
---
 gnu/packages/emacs.scm | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 08554280c..a3c695975 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -15,7 +15,7 @@
 ;;; Copyright © 2016, 2017 Nils Gillmann <ng0 <at> n0.is>
 ;;; Copyright © 2016 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2016, 2017, 2018 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
-;;; Copyright © 2016, 2017 Alex Vong <alexvong1995 <at> gmail.com>
+;;; Copyright © 2016, 2017, 2018 Alex Vong <alexvong1995 <at> gmail.com>
 ;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2017 Christopher Baines <mail <at> cbaines.net>
 ;;; Copyright © 2017, 2018 Mathieu Othacehe <m.othacehe <at> gmail.com>
@@ -11314,6 +11314,44 @@ e.g. the package dependencies it requires.  See function
 file.")
       (license license:gpl3+))))
 
+(define-public emacs-picpocket
+  (let ((version "20180610.1059") ; taken from melpa
+        (commit "ce4b6ed088384f2414af82e8e4eae5b92c2874bf"))
+    (package
+      (name "emacs-picpocket")
+      (version version)
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/johanclaesson/picpocket")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "15vpbcv83mc4j1pvrk7xic0klh2bl9gzg2xxs7c2lmnix52hy8mv"))))
+      (build-system emacs-build-system)
+      (arguments ; needed for running tests
+       `(#:tests? #t
+         #:emacs ,emacs
+         #:test-command '("emacs" "--batch"
+                          "-l" "picpocket-test.el"
+                          "-f" "ert-run-tests-batch-and-exit")))
+      (home-page "https://github.com/johanclaesson/picpocket")
+      (synopsis "Image viewer for Emacs")
+      (description
+       "Picpocket is an image viewer which requires GNU Emacs 24.4+
+compiled with ImageMagick.  It have commands for:
+
+@itemize
+@item File operations on the picture files (delete, move, copy, hardlink).
+@item Scale and rotate the picture.
+@item Associate pictures with tags which are saved to disk.
+@item Filter pictures according to tags.
+@item Customizing keystrokes for quick tagging and file operations.
+@item Undo and browse history of undoable commands.
+@end itemize")
+      (license license:gpl3+))))
+
 (define-public emacs-wgrep-helm
   ;; `emacs-wgrep-helm' was mistakenly added.
   (deprecated-package "emacs-wgrep-helm" emacs-wgrep))
-- 
2.18.0

[Message part 5 (text/plain, inline)]

Cheers,
Alex

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 32613-done <at> debbugs.gnu.org
Subject: Re: [bug#32613] [PATCH] gnu: Add emacs-picpocket.
Date: Tue, 04 Sep 2018 15:39:23 +0200

[Message part 8 (text/plain, inline)]

Hi Alex,

Alex Vong <alexvong1995 <at> gmail.com> skribis:

> From c126ff68c5f881d506226e2a260b96fa6d4635ea Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995 <at> gmail.com>
> Date: Mon, 3 Sep 2018 02:25:31 +0800
> Subject: [PATCH] gnu: Add emacs-picpocket.
>
> * gnu/packages/emacs.scm (emacs-picpocket): New public variable.

Applied with the minor changes below.

Thanks,
Ludo’.

[Message part 9 (text/x-patch, inline)]

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2bacd560f..957b72f4e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -11340,8 +11340,7 @@ file.")
       (home-page "https://github.com/johanclaesson/picpocket")
       (synopsis "Image viewer for Emacs")
       (description
-       "Picpocket is an image viewer which requires GNU Emacs 24.4+
-compiled with ImageMagick.  It have commands for:
+       "Picpocket is an image viewer for GNU Emacs.  It has commands for:
 
 @itemize
 @item File operations on the picture files (delete, move, copy, hardlink).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.