GNU bug report logs - #32587
[PATCH] gnu: Add r-pore.

Previous Next

Full log

Message #8 received at 32587 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: <MadalinIonel.Patrascu <at> mdc-berlin.de>
Cc: 32587 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add r-pore.
Date: Mon, 3 Sep 2018 17:22:29 +0200

Hi,

thanks for the patch!

> +
> +(define-public r-pore
> +  (package
> +    (name "r-pore")
> +    (version "0.24")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://sourceforge.net/projects/rpore/files/"version"/poRe_"version".tar.gz"))

Please use mirror://sourceforge/ here.

> +       (sha256
> +        (base32 "0pih9nljbv8g4x8rkk29i7aqq681b782r5s5ynp4nw9yzqnmmksv"))))
> +    (properties `((upstream-name . "poRe")))
> +    (build-system r-build-system)
> +    (native-inputs
> +     `(("r-rhdf5" ,r-rhdf5)
> +       ("r-shiny" ,r-shiny)
> +       ("r-svdialogs" ,r-svdialogs)
> +       ("r-data-table" ,r-data-table)
> +       ("r-bit64" ,r-bit64)))

Are you sure these should be native-inputs?  They probably should be
propagated inputs, because they should be installed together with the
“r-pore” package.

Please also sort these inputs alphabetically.

> +    (home-page "https://sourceforge.net/projects/rpore/files/")

Please use “https://sourceforge.net/projects/rpore”.

> +    (synopsis "This R package enable visualisation of nanopore sequencing data")

Please use “Visualize Nanopore sequencing data”.

> +    (description
> +     "The Oxford Nanopore MinION is a revolutionary sequencer with a unique model of data
> +delivery, requiring novel tools for the novice user.  This package enables
> +organisation and visualisation of MinION data.")

Please try to avoid marketing terms such as “revolutionary”, “unique”,
“novel” etc.  Could you try to come up with a description that better
describes the features of the poRe package?

Here’s a draft:

  This package provides graphical user interfaces to organize and
  visualize Nanopore sequencing data.

> +    (license license:gpl3)))

I don’t think this is correct.  The DESCRIPTION file says “BSD”, but
fails to state the variant.  I have opened an issue about this here:

    https://github.com/mw55309/poRe_docs/issues/10

Could you please send an updated patch?

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.