GNU bug report logs - #32584
[PATCH] gnu: Add yad.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32584 in the body.
You can then email your comments to 32584 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pimi <madalinionel.patrascu <at> mdc-berlin.de>
To: <guix-patches <at> gnu.org>
Cc: pimi <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] gnu: Add yad.
Date: Thu, 30 Aug 2018 11:51:52 +0200

gnu/packages/gtk.scm (yad): New variable.
---
 gnu/packages/gtk.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 8b11e3fb1..9b20f4f96 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018 Alex Vong <alexvong1995 <at> gmail.com>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2018 Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1651,3 +1652,44 @@ Parcellite and adds bugfixes and features.")
 it does not deal with windowing system surfaces, drawing, scene graphs, or
 input.")
     (license license:expat)))
+
+(define-public yad
+  (package
+    (name "yad")
+    (version "0.40.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/v1cont/"name"/archive/v"version".tar.gz"))
+       (sha256
+        (base32 "1fs892d0xq2x43blqfxrlif22n1mnpbbw6lj8mfvm9j637m8hfm6"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags
+       '("--with-gtk=gtk3"
+         "--enable-html"
+         "--enable-gio"
+         "--enable-spell"
+         "--enable-icon-browser")
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'bootstrap
+           (lambda _
+             (invoke "autoreconf" "-vif")
+             (invoke "intltoolize" "--force" "--automake")
+             #t)))))
+    (inputs
+     `(("gtk+" ,gtk+)))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://sourceforge.net/projects/yad-dialog/")
+    (synopsis "Standard dialog boxes for Windows, MacOS and Linux")
+    (description
+     "This program allows you to display GTK+ dialog boxes from command line or shell
+scripts.  More example of @code{yad} usage can be consulted at
+@url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.  The @code{yad}
+depends on GTK+ only.")
+    (license license:gpl3)))
-- 
2.17.1

Message #8 received at 32584 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: pimi <madalinionel.patrasc <at> mdc-berlin.de>
Cc: 32584 <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add yad.
Date: Mon, 3 Sep 2018 17:57:45 +0200

Hi,

thanks for the patch!

> gnu/packages/gtk.scm (yad): New variable.
[…]
> +(define-public yad
> +  (package
> +    (name "yad")
> +    (version "0.40.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> "https://github.com/v1cont/"name"/archive/v"version".tar.gz"))

Please don’t use automatically generated tarballs, because they can
change over time.  Github generates these tarballs on demand and caches
them for a long time, but they are not guaranteed to be permanent.
A regenerated tarball would have a different hash.

Please use git-fetch instead.

> +    (synopsis "Standard dialog boxes for Windows, MacOS and Linux")

Please use “GTK+ dialog boxes for shell scripts”.

> +    (description
> +     "This program allows you to display GTK+ dialog boxes from command line or shell
> +scripts.  More example of @code{yad} usage can be consulted at
> +@url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.  The @code{yad}
> +depends on GTK+ only.")

I think we can drop the last sentence.  How about this:

   This program allows you to display GTK+ dialog boxes from the command
   line or shell scripts.  Example of how to use @code{yad} usage can be
   found at @url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.

> +    (license license:gpl3)))

The source files say that it’s gpl3+.  Here’s an excerpt from the header
of yad/src/color.c:

 * YAD is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.

Could you please send an updated patch?

--
Ricardo

Message #11 received at 32584 <at> debbugs.gnu.org (full text, mbox):

From: pimi <madalinionel.patrascu <at> mdc-berlin.de>
To: <32584 <at> debbugs.gnu.org>
Cc: pimi <madalinionel.patrascu <at> mdc-berlin.de>
Subject: [PATCH] gnu: Add yad.
Date: Wed, 5 Sep 2018 12:42:37 +0200

gnu/packages/gtk.scm (yad): New variable
---
 gnu/packages/gtk.scm | 45 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 6c43a3ab5..f89474fe9 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1665,3 +1665,48 @@ Parcellite and adds bugfixes and features.")
 it does not deal with windowing system surfaces, drawing, scene graphs, or
 input.")
     (license license:expat)))
+
+(define-public yad
+  (let ((commit "8957347fc6376bc4ec992adef078a7b53399850e")
+        (revision "1"))
+    (package
+      (name "yad")
+      (version (git-version "0.40.3" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/v1cont/yad.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "04vqm6khqsaar25qa8xaixp6i1jp7v33b32f6i425kfdi6wfr2yb"))))
+      (build-system gnu-build-system)
+      (arguments
+       `(#:configure-flags
+         '("--with-gtk=gtk3"
+           "--enable-html"
+           "--enable-gio"
+           "--enable-spell"
+           "--enable-icon-browser")
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'bootstrap
+             (lambda _
+               (invoke "autoreconf" "-vif")
+               (invoke "intltoolize" "--force" "--automake")
+               #t)))))
+      (inputs
+       `(("gtk+" ,gtk+)))
+      (native-inputs
+       `(("autoconf" ,autoconf)
+         ("automake" ,automake)
+         ("intltool" ,intltool)
+         ("pkg-config" ,pkg-config)))
+      (home-page "https://sourceforge.net/projects/yad-dialog/")
+      (synopsis "GTK+ dialog boxes for shell scripts")
+      (description
+       "This program allows you to display GTK+ dialog boxes from command line or
+shell scripts.  Example of how to use @code{yad} can be consulted at
+@url{https://sourceforge.net/p/yad-dialog/wiki/browse_pages/}.")
+      (license license:gpl3+))))
-- 
2.17.1

Message #14 received at 32584 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: <32584 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: Add yad.
Date: Wed, 5 Sep 2018 14:08:57 +0200

Hi pimi,

thanks for the update.

In this case you can avoid having to record the git commit that
corresponds to version 0.40.3 because that commit is tagged.  You can
remove the “let”, keep “version” at “0.40.3”, and use “(commit version)”
instead of “(commit commit)”.

This would make the package description a little less confusing to read.

Does that make sense?

--
Ricardo

Message #19 received at 32584-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: MadalinIonel.Patrascu <at> mdc-berlin.de
Cc: 32584-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add yad.
Date: Mon, 10 Sep 2018 14:47:51 +0200

I made the suggested changes myself and pushed it to the “master” branch
with commit 57d70dbab.

Thanks!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.