GNU bug report logs - #32564
27.0.50; cedet/ede/pconf.el

Previous Next

Full log

Message #10 received at 32564 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Pierre Lorenzon <devel <at> pollock-nageoire.net>
Cc: 32564 <at> debbugs.gnu.org, cedet-devel <at> lists.sourceforge.net
Subject: Re: bug#32564: 27.0.50; cedet/ede/pconf.el
Date: Fri, 31 Aug 2018 22:16:30 -0400

Pierre Lorenzon <devel <at> pollock-nageoire.net> writes:

> Bug in pconf.el has not been fixed yet. Here is a diff
> indicating what has to be done. I have to do it each time I
> upgrade my git copy of emacs otherwise C-c . C in ede mode
> crashes.

> @@ -135,7 +135,7 @@
>  	  (with-current-buffer "*compilation*"
>  	    (goto-char (point-max))
>  
> -	    (when (not (string= mode-line-process ":exit [0]"))
> +	    (when (not (string= (car mode-line-process) ":exit [0]"))
>  	      (error "Configure failed!"))
>  
>  	    ;; The Makefile is now recreated by configure?
>
> Diff finished.  Wed Aug 29 05:09:19 2018
>
>
>>>>  -- End Diff 
>
>
> The problem is that this code do not take care of the fact that
> type of variable `mode-line-process' has been changed from
> string to list.

Wouldn't it be better to, e.g., add a function to
compilation-finish-functions so that pconf would stop depending on the
exact modeline format used by compile.el?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.