From unknown Thu Sep 11 01:08:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32549 <32549@debbugs.gnu.org> To: bug#32549 <32549@debbugs.gnu.org> Subject: Status: Allow passing custom options to vc-git-grep Reply-To: bug#32549 <32549@debbugs.gnu.org> Date: Thu, 11 Sep 2025 08:08:53 +0000 retitle 32549 Allow passing custom options to vc-git-grep reassign 32549 emacs submitter 32549 Federico Tedin severity 32549 wishlist tag 32549 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 19:03:39 2018 Received: (at submit) by debbugs.gnu.org; 27 Aug 2018 23:03:39 +0000 Received: from localhost ([127.0.0.1]:34566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuQXq-0005Vm-PT for submit@debbugs.gnu.org; Mon, 27 Aug 2018 19:03:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuQXn-0005VV-5D for submit@debbugs.gnu.org; Mon, 27 Aug 2018 19:03:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuQXh-000142-5A for submit@debbugs.gnu.org; Mon, 27 Aug 2018 19:03:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54824) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fuQXg-00013s-Uh for submit@debbugs.gnu.org; Mon, 27 Aug 2018 19:03:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fuQXg-0004pT-7b for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 19:03:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuQXe-0000zr-5C for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 19:03:27 -0400 Received: from mail-it0-x231.google.com ([2607:f8b0:4001:c0b::231]:37288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fuQXd-0000yU-Vu for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2018 19:03:26 -0400 Received: by mail-it0-x231.google.com with SMTP id h20-v6so858523itf.2 for ; Mon, 27 Aug 2018 16:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=06LRoe9soL1SszbRxgxuJoaD52vZW1PkhZt3OJDJAxk=; b=TRYQIPWVheBeVnbVE36Kla8U879EmPI/RoJIVuaqs+P9ETGuQyuhMdAV5XdRpb9vz+ 51iIDXSN/3tHqvh7DCLLLc766VUNDOzw8khX/KaRKltuMaZRsvYrNewt5z/UaAz3Yu1k ZFKCIdR+6Hj+fd+qZwcIzofPRzBwaz/zv6qpkf3cm87IZUq6kbq3jzRElvpC8jK1qvDm qgM63YvJInkKn9aEBO+mGJKJDf6gC8NOQ/wxWe59a/9cfATpO1IEp8sHHVl7p1vX4FIw A/c8rUprIqjrgj4nh6hALzP49P8tKKlcUCipUyG0gywnoAud8ZHgqD95mLMQejVCpmdI RRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=06LRoe9soL1SszbRxgxuJoaD52vZW1PkhZt3OJDJAxk=; b=Tsh0t/4xTVFv1OvNJE1VYq+75Co2lfzU6fCaQwMB3JxeF+5gz7ExPVJ0q+Df8gntH7 C0+/wc6qtpTUKklymCEJu/yZ2cPnGYfxMEN8Vuxqp9hPAF6ebAvozlNYeIHj4WDgW5l8 17yLjOMjzZGMytQzGNLLDR7yYd8KRaWtA4u7arDzYg9YxfDXjTNueCv7e5KLNaeMvzAN 2XqUNHaoPYg+nS7zp0yJa0DfxxecY7OOs+gBegVPta5USJLo2WljRgYgFNc+DVdO6w84 by2FCHOebHJbL+DM4h26R9i6ERrigdojz7uQkSGWFxGHlAUdXfXS1wVtIeumVTIJn8CF M8+A== X-Gm-Message-State: APzg51BfZhd92xKLK/CDzyXR/CKGQ/q5FWICF6H66H+bUYdrV7yl1WVF 5jnV0FSqwn5xjk8Wx9eLDr2z9iQSpri8cjqY2M3Tfg== X-Google-Smtp-Source: ANB0VdYvZvnRLojcW9hg2ThaHENyAYOQVeLHUjMYLSqUYUYAM28wxw2jWuXEJsJ4JqMHq3yntMpfn/NnDEFDaXAdlFQ= X-Received: by 2002:a24:bc84:: with SMTP id n126-v6mr8135185ite.152.1535411004463; Mon, 27 Aug 2018 16:03:24 -0700 (PDT) MIME-Version: 1.0 From: Federico Tedin Date: Mon, 27 Aug 2018 20:03:13 -0300 Message-ID: Subject: Allow passing custom options to vc-git-grep To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When using vc-git-grep, it is not possible to pass custom options to the git grep command. It would be good to have a customizable template variable for vc-git-grep (like grep-command or grep-find-command) to allow for more customization. I am willing to implement this feature assuming there's no other possible workaround. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 19:21:02 2018 Received: (at 32549) by debbugs.gnu.org; 27 Aug 2018 23:21:02 +0000 Received: from localhost ([127.0.0.1]:34581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuQof-0005wT-Ml for submit@debbugs.gnu.org; Mon, 27 Aug 2018 19:21:02 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:54489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuQoe-0005w3-1k for 32549@debbugs.gnu.org; Mon, 27 Aug 2018 19:21:00 -0400 Received: by mail-it0-f41.google.com with SMTP id f14-v6so26087ita.4 for <32549@debbugs.gnu.org>; Mon, 27 Aug 2018 16:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=3hakedS6MiGcCvTFhxZZ00ChrTXBwZOW1nUBpPPhArA=; b=r+4kvuXyx4uSdPJMmy9N2ojL5ZWTJV6JNnmn25Yzpw/wRbXOv0VYCvErzvCqHpshoT YHoGTgAJ02yq+Lz7EABRGFelQpd/l8fF39LRLhDftvMIca6gCJnTRP19JXslg6oEBeRd y5T70YKVYPKJSthxE0EDbnnxZ0D9sreV2K+pSICh92mZ3RIq8uKGoDAF/KnZBdpJ+zFT Gb72l/NUKRiIZa4ykjE1gnGMMWf1v5kL74c02ITj/MBbxMlt1ic/u7jNCjYn71BaAi/1 rq9588Rv5trYxtTitIvYse4ARlxVgEYPyGP0AmK6FIe64Kp1HCVmGqSuICA+8fZyoAT/ DZCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=3hakedS6MiGcCvTFhxZZ00ChrTXBwZOW1nUBpPPhArA=; b=q+gM04fidAKVnUuyWM7v+6hIDZEW1lcfj4fdphBi+Kp/mU3AT7Yn+Rn3O5tsTGLDxh AtaHzSreOL0VgmI0GnNe3GuuqH3DcYPKMyX2DiLunHFStwcjPJuDRYq4zhGY6RQ+yO6l yf9l2M3+XYBnKIthvbIOpmxlD96TtUYiowT0rvjZjwMxmtpJ4VcSV3URlS3Vt4hasYmV ym+w/5Szp5iWBk65QqlHwWICRIieDCcYuzfJONeIcHlpJ+lOrQpT8NsgfeOUcDHIeZoq RYNqM9yp83keWXNvqQ4JPSsILNSDvkdhXEycZ0t/ok2k4rHWYxlHxeoNnOxIQPGGycFB 08BA== X-Gm-Message-State: APzg51DXh6XQf9gk/Qmmew9YKaOJpBvWuYRfyeWwrjiM/+tG4QStiq6R yQ7XpPA7wxwzfDobPIHrXSwLRhqG X-Google-Smtp-Source: ANB0Vdat+J8E82T/RXf54roXHFQ1uF0Tbr23fg7yAPuTdYBjnImvbq2XlaXwqynJWQCZ1frD6klqwA== X-Received: by 2002:a24:bc84:: with SMTP id n126-v6mr8175628ite.152.1535412054262; Mon, 27 Aug 2018 16:20:54 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id j10-v6sm256258itj.15.2018.08.27.16.20.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 16:20:53 -0700 (PDT) From: Noam Postavsky To: Federico Tedin Subject: Re: bug#32549: Allow passing custom options to vc-git-grep References: Date: Mon, 27 Aug 2018 19:20:50 -0400 In-Reply-To: (Federico Tedin's message of "Mon, 27 Aug 2018 20:03:13 -0300") Message-ID: <875zzvv1kd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Federico Tedin writes: > When using vc-git-grep, it is not possible to pass custom options to > the git grep command. It would be good to have a customizable template > variable for vc-git-grep (like grep-command or grep-find-command) to > allow for more customization. I am willing to implement this feature > assuming there's no other possible workaround. Does C-u help? From the docstring: With C-u prefix, you can edit the constructed shell command line before it is executed. With two C-u prefixes, directly edit and run =E2=80=98grep-command=E2= =80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 22:55:55 2018 Received: (at 32549) by debbugs.gnu.org; 28 Aug 2018 02:55:55 +0000 Received: from localhost ([127.0.0.1]:34669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuUAd-0006j3-AA for submit@debbugs.gnu.org; Mon, 27 Aug 2018 22:55:55 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:52130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuUAb-0006ip-N8 for 32549@debbugs.gnu.org; Mon, 27 Aug 2018 22:55:54 -0400 Received: by mail-it0-f67.google.com with SMTP id e14-v6so580283itf.1 for <32549@debbugs.gnu.org>; Mon, 27 Aug 2018 19:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=Qzg196pclBCZjtUFuR/fs86Rzuu2ln6xbbcVVSzkvxI=; b=AJTS1fsEcPcaM0QNhGUOoM4GqLCzrwRPuCzVtpDlRTdOtnBwIBdaLkS+looe8GKAqC /l0jHf1w7LLV5TOuft/YlO3zMvX8JGIG44j+ZFnY3cECoZp1LuQbXYb4Bc/UqJ+T86pJ W1XyOk4EJ5yXXY+6lItabeC6WYp8bGM6I2PWaWDZjauz6o7XwdZYQM17rg0L1VgiNAPU wdCTaRgAdOZXZWYF7nmxaP1kB7P2dfmPxGgwjfnbrQso1KMbFg2bnB9hG7BpVTbyOPhO 0zn6G3NcdyrhswWklFC9pm8pnxk8p4MN2z9lFgM6VLzdAlBXZ2n7Gz73NLclJbKA7rFM sO7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=Qzg196pclBCZjtUFuR/fs86Rzuu2ln6xbbcVVSzkvxI=; b=CCxyEjIBLPdyczVT9sOT9pSMhPLW+oAB7Kdi/s+9V4tbYaXbN71/tRqAVWUikMUyLx ea3LEowzg9w+acj3jwaBOwni1YQhbNJi3U7r5CcOPTVoZc2F9kQgKaIKr/FoH/zI7KIb 6sLHIOwS6/FViXXLFS0FYSz6QVPw5gDWULxppaTBIUtrUm3Yw3qTXKy60V0/KbqPLZ4D VFDdbQjUb/BlZcS3cJ5a89UBDIIY+V9FgmtI4z1Z93hR3EJAulwJDCadrpdEVAVJ06Ud 56hyEdn/lgG5Oq8Htl0Is+WuNTnwsCCCHjms3O6MStr5vBg3GBTJE0B7uI9irEqsP09P gZeQ== X-Gm-Message-State: APzg51B7fv14iHlprzAGkmLyoOmAOdY1ROe6rnX+FLMVuVpfcYfu2D4O Oomld5bOb0kXL1j+a/5FcwoQBOTrK9AgLdyig32gfRE6 X-Google-Smtp-Source: ANB0Vdau+zysOyY8C1AvexKtPNDRlYeL5GoQZYsMP4lFnJKR2kPKMbxIBQeZ9xh7IGdizSQWrlQ8HHaBbMOLC3H5baI= X-Received: by 2002:a24:1d52:: with SMTP id 79-v6mr5299955itj.142.1535424947913; Mon, 27 Aug 2018 19:55:47 -0700 (PDT) MIME-Version: 1.0 References: <875zzvv1kd.fsf@gmail.com> In-Reply-To: <875zzvv1kd.fsf@gmail.com> From: Federico Tedin Date: Mon, 27 Aug 2018 23:55:36 -0300 Message-ID: Subject: Re: bug#32549: Allow passing custom options to vc-git-grep To: 32549@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32549 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Does C-u help? From the docstring: > > With C-u prefix, you can edit the constructed shell command line > before it is executed. > With two C-u prefixes, directly edit and run =E2=80=98grep-command=E2= =80=99. You're right! With C-u, I am eventually prompted for the full git-grep arguments, This is useful when manually invoking the command, but now I'm wondering how I would set my custom arguments when the vc-git-grep function is called from another function. For example, the projectile package defines projectile-grep, which eventually calls rgrep or vc-git-grep [1] (depending on the user's choice). [1] https://github.com/bbatsov/projectile/blob/master/projectile.el#L2757 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 27 23:52:50 2018 Received: (at 32549) by debbugs.gnu.org; 28 Aug 2018 03:52:50 +0000 Received: from localhost ([127.0.0.1]:34681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuV3i-0008Fa-07 for submit@debbugs.gnu.org; Mon, 27 Aug 2018 23:52:50 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:46518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuV3g-0008FM-9s for 32549@debbugs.gnu.org; Mon, 27 Aug 2018 23:52:48 -0400 Received: by mail-io0-f174.google.com with SMTP id y12-v6so152552ioj.13 for <32549@debbugs.gnu.org>; Mon, 27 Aug 2018 20:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PipYHpoVhyUw26CP33vsiihzU4wxWjFo/oZnyB7uNJw=; b=Mzz48CvKwoBFgIcm9AravjWEKnfx0AelUb43NXXw27p5hyc+8CUSQC90omjMMdq/Am Se+7aep8e+d4ebTNpb0pYOErfHx1+BQJNdAXD+1Xr1Ujhqg4KHRq5DjXz2B9kEhUzZRg XOyzWgcz5GATACzQxooXEvs1//Dvzq7KiLI/gpSP+tQRggeMS9JbnYvRD99TdTiqnbO2 ha+6jF+U2JX3+SzPDYl9R8kCEU7wpZodkivupft0yKL8LhI8tPG7mxwSgDz3QFNmY0wF dsT7FFIuqd4srZj7S7sD/STN18yU+45Ag+9ECjDjktKGnVriEDYx5rmny+/lR9Tm1j/K sJuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PipYHpoVhyUw26CP33vsiihzU4wxWjFo/oZnyB7uNJw=; b=e4pLje5pdBeprO25Bb+Gk3kEPiHsyVj9M51g/mHvziZHTwCwP2Zz7+w2b09tmI/Fol l2eHNp1qKunzsAIjpylhBY1vQUQvp9I3t+XKJ6gMttZuit3fNnlQK9YJHy8BJifl0IJP VZ8L6mtwA2wfYHmGe+4J3B4H6AgemaFDHYGRqBJbQQOMukwkVJV67r5l6rLgsA8NEC+A 9PykqyCGJx9msAfqJsgvF87y4Ij4m5V6KdarAZRHr5N7KnD+h8WYqRH1xzgy2dbtbd6U Q3ajwuTeTDWyp3dlfmzrmkV6StxBsWoYitRsnbZFmirx3b2f2Aj/E2EuPernNt/uHS0N OeSw== X-Gm-Message-State: APzg51DXUWXHdiQ8wljtMqB8QCizqfde0oIOep9JNnjg/J/+rPw1pVDu zmq2mjUKeFqhoRmrnImrK3QNDGiH X-Google-Smtp-Source: ANB0VdZUp10Nbx410WOHnVzueHAw9iJKvlO8V+IXmysBwie8yolDflsu3DxGFNGOoTdDKCa+ZFpjng== X-Received: by 2002:a6b:de0c:: with SMTP id v12-v6mr13007113iog.121.1535428362676; Mon, 27 Aug 2018 20:52:42 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m7-v6sm77563itb.39.2018.08.27.20.52.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Aug 2018 20:52:41 -0700 (PDT) From: Noam Postavsky To: Federico Tedin Subject: Re: bug#32549: Allow passing custom options to vc-git-grep References: <875zzvv1kd.fsf@gmail.com> Date: Mon, 27 Aug 2018 23:52:41 -0400 In-Reply-To: (Federico Tedin's message of "Mon, 27 Aug 2018 23:55:36 -0300") Message-ID: <87r2ijtaeu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Federico Tedin writes: > I'm wondering how I would set my custom arguments when the vc-git-grep > function is called from another function. For example, the projectile > package defines projectile-grep, which eventually calls rgrep or > vc-git-grep [1] (depending on the user's choice). It looks like you'd have to do (let ((current-prefix-arg '(4))) (vc-git-grep ...)) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 19:01:53 2018 Received: (at 32549) by debbugs.gnu.org; 28 Aug 2018 23:01:54 +0000 Received: from localhost ([127.0.0.1]:36172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fumzh-0000FQ-FR for submit@debbugs.gnu.org; Tue, 28 Aug 2018 19:01:53 -0400 Received: from mail-it0-f45.google.com ([209.85.214.45]:53024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fumzf-0000BE-Es for 32549@debbugs.gnu.org; Tue, 28 Aug 2018 19:01:51 -0400 Received: by mail-it0-f45.google.com with SMTP id h3-v6so5073962ita.2 for <32549@debbugs.gnu.org>; Tue, 28 Aug 2018 16:01:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pgM6IDSM9RMwmGTcYXXHMuNMWk4hboTB5rt4pCD8i9E=; b=LKb+Tc+FWEj0L8MY1ykqYs+49FHpepNwwGmyLoMM0aisOc+DSMNuP3eLIuaihdHGLz aCorjtmS96OJCF8MHz8BDZrg56MU8uenWTIEN2gA//QdUx09QGVJuRXUzH4WH5yyqTEb 52Iv3k+qKeS3jqXSnpxRwCbU1CmPvP26HrquO+g9LtPC8JQ1wPuwLJUZL+wNSzDEPa82 c3MDteJvQBFi1k2Sa8alDn9/3jQGOQ7uHkrANRNtkwtp/OOuNPzkIJHWDd0ADBMaP4Sz Zxb2s0sceQnNlxZnaoLzYtVXDk56lj4Lg76jRRl4kLUTtQHt/OJp41J8VdGryrTf5Skp Icfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pgM6IDSM9RMwmGTcYXXHMuNMWk4hboTB5rt4pCD8i9E=; b=OcX3fQYNevFb1rtxS+VRRyZuB1e6HgCzSwK9gaC1xWQMAzt1OJUHAQTpUpcFzIc/o8 onXkG159yRhJvAi9otwcOCLG89Ur3peQajPzADRb8zGDJEw+PT3b09b//Qj73YNvIFBf uRMMqc6P8MxBr392sWaxZBne03MjpDptlMXT4Wbf3BR2n0kc85guriYpHRRJ/HgsRK4O iDvVNydmxsOrjFdR93aBIbtzeJtIB7d/VF1fm4l0ztgAN6ehZiu+ZxzBNP2+m99172HW LQZKQCAgHKKqxA4miBmkD1v7AiHuTor9oDkmCWH36nlV+qLgaWdslLWsOL1U9RdLKMko wEVA== X-Gm-Message-State: APzg51Ck+WEM7m6ipQ1ayymdzFJMXeRouRkTfbON/D1m5ldaqx+L9Liw 7l51m1sXeUHm29IURyHBIaGrIfYdHV9P7qVM4nQ= X-Google-Smtp-Source: ANB0VdZVs2S0QldWJ1boSt4ebDkr5F93i0w5JOsX+eEIo75SFmCvqwcj2p8CjsB6BmUmjQxx6JIB6aM7nV7LNNNcM28= X-Received: by 2002:a02:59cc:: with SMTP id v73-v6mr3405980jad.5.1535497305910; Tue, 28 Aug 2018 16:01:45 -0700 (PDT) MIME-Version: 1.0 References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> In-Reply-To: <87r2ijtaeu.fsf@gmail.com> From: Federico Tedin Date: Tue, 28 Aug 2018 20:01:33 -0300 Message-ID: Subject: Re: bug#32549: Allow passing custom options to vc-git-grep To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > I'm wondering how I would set my custom arguments when the vc-git-grep > > function is called from another function. For example, the projectile > > package defines projectile-grep, which eventually calls rgrep or > > vc-git-grep [1] (depending on the user's choice). > > It looks like you'd have to do > > (let ((current-prefix-arg '(4))) > (vc-git-grep ...)) I've set the prefix argument using the current-prefix-arg variable as you mentioned: (let ((current-prefix-arg '(4))) (vc-git-grep "something" "*.el" ".")) And then I also tried: (let ((current-prefix-arg '(4))) (projectile-grep)) In both cases, I am prompted for the full git-grep command (and nothing else). Is there any way to set a default set of arguments in order to avoid typing them when invoking the function? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 19:15:06 2018 Received: (at 32549) by debbugs.gnu.org; 28 Aug 2018 23:15:06 +0000 Received: from localhost ([127.0.0.1]:36186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1funCT-0001Hm-Mg for submit@debbugs.gnu.org; Tue, 28 Aug 2018 19:15:05 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1funCR-0001DM-QQ for 32549@debbugs.gnu.org; Tue, 28 Aug 2018 19:15:04 -0400 Received: by mail-it0-f44.google.com with SMTP id p129-v6so4778889ite.3 for <32549@debbugs.gnu.org>; Tue, 28 Aug 2018 16:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pGNR2M44CfAKUPiEo9W4W9Eol39g39UQHy3zrVm/g2E=; b=Pqu9e3VZhRgw2T+Hbn93G5jZaksxrWqCC+37RERrw8gtjEft7J5rJ6AyeysRYNuGaC yfWeok5WxyYjc9dY3ND0ntMsWCEUxL+IIPkzmBymVBPW11BCgSFWg6EdAARsauGCbN/o YTMP+xXa5HCINYLCshLdmEiPqyaf5yNqm02fm0DGv30PA3WpNLJ0iXMMAD3gjIchON0B y1/YMXxq4f/Ue8h2lI2V6FoEpEM45HDKeUwcSMw/C8MnLs/HDTmeo0mLc3rw0bC3hVML ynkfkFweoaWK4Xt+F9g+st+Ho6IaNApPdY3OE7OqX00119YTyRhpJK5fxco791VhVKFw EohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pGNR2M44CfAKUPiEo9W4W9Eol39g39UQHy3zrVm/g2E=; b=jQTbNLAOIeGp6BAugrzpEd3J9XAMkZa2fs7qXDwBdF7FzwoFIXhmTwNaTI7ECanXXI /mayMNYjTeIPmbSHV1f8nwTBpnqHZiynDn1RY3Km3GKSGNDBjWOhJK9C58PqiE0nrOTK OVlSqsU3PgFm0CYZMf1bYRtwY5dr+lI6KR0srDc8uoorX9uyQPRZAMcgHfatXY5r77QS bMUH7tgtDG7PMIZ6s4ekgEXJ7H0lvjRWUIJxkLSp0L65LhlXmok0PYMiEbGYd04/XTMj ZHwow6089dPK97IIvcPKokEHq1qZtMsjgLdSaiwqORKgHAg+RQyqomr7en70Mq+IEa6l NfRA== X-Gm-Message-State: APzg51B9/7/sb+xw0+famultUQJxU/5BDa6aF0nGeMhV/NYQb4wdf1WQ xXaMfWS4HjfVoxUYuWh1UJUP86Jx X-Google-Smtp-Source: ANB0VdYB6/SNQ/SEuisWG3brFL4NzPUhtQGp1JFqaeeczK0hOE/mjGKEbXEDe+oLscgVmp4SOJBMTQ== X-Received: by 2002:a02:5fcc:: with SMTP id x73-v6mr3461269jad.96.1535498098174; Tue, 28 Aug 2018 16:14:58 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id e5-v6sm1712863itf.0.2018.08.28.16.14.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Aug 2018 16:14:57 -0700 (PDT) From: Noam Postavsky To: Federico Tedin Subject: Re: bug#32549: Allow passing custom options to vc-git-grep References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> Date: Tue, 28 Aug 2018 19:14:56 -0400 In-Reply-To: (Federico Tedin's message of "Tue, 28 Aug 2018 20:01:33 -0300") Message-ID: <8736uyt767.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Federico Tedin writes: > (let ((current-prefix-arg '(4))) > (vc-git-grep "something" "*.el" ".")) > > And then I also tried: > > (let ((current-prefix-arg '(4))) > (projectile-grep)) > > In both cases, I am prompted for the full git-grep command (and > nothing else). Doesn't projectile-grep prompt you for a regexp? I don't have it installed here, but it looks like you have to pass a non-nil ARG to get prompted for filenames, i.e., (let ((current-prefix-arg '(4))) (projectile-grep nil t)) > Is there any way to set a default set of arguments in order to avoid > typing them when invoking the function? Not sure I follow, when you pass "something" and "*.el" to the function, those get inserted into the default command so you don't have to type them interactively. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 19:31:46 2018 Received: (at 32549) by debbugs.gnu.org; 28 Aug 2018 23:31:46 +0000 Received: from localhost ([127.0.0.1]:36190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1funSa-0003bg-DA for submit@debbugs.gnu.org; Tue, 28 Aug 2018 19:31:44 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:36842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1funSY-0003bT-V3 for 32549@debbugs.gnu.org; Tue, 28 Aug 2018 19:31:43 -0400 Received: by mail-io0-f178.google.com with SMTP id q5-v6so2944521iop.3 for <32549@debbugs.gnu.org>; Tue, 28 Aug 2018 16:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o6IgZjhm34RyB2UdBaONQz6hGTdCCsfxDojlRWs2Ooo=; b=tc0wPxC9x8eD0Onplh+hMtTuk1qhvUlRyyAzHWXufQv/zz3TopFQxHIp9IIoSYUc5k UWBrH6IqprMXDERAvs7JlsbYf3MXVzARaPkjnu4yBLNhWv/MHt6H12uqF+OtvKjrKJQK dF7h37Ds6Xt4r8m6oY6FKZWJTqMqMivpRHpaNSxREywzBGoXJ2I7VSySX0BqwaQzfIul A3JT/03rHGI1aIJ+zdUafiTiUxNWq8mWkFiT0L8KO1NkCIZ6EfPsK7RvuwxBGajNtFoz OtiX5doy6Xx+m5Eqwv8n4iWUQUYc74sF/aiR7gk2AikNVCvcOslVhNRowtWMKJNAbW5Z BOfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o6IgZjhm34RyB2UdBaONQz6hGTdCCsfxDojlRWs2Ooo=; b=AUIjpUmWxY/bYYnB/FdVmaUZQpcvzrbkzsSVTrL6SKdguSkZUgfgkFQj+Vo/jSzl+L 5PZVuv+qHw/C7ara8fz8Zfdoa5PQZT5JIwNEaYanPXsHVmnYqVjTKXicPxSgYp40KEMq ZT/Ba5i6k3gLbPZbpCSrWs32V/gsZK+9mJx9Lp92sgMpies0P8lze6es8SwA/YH4mNqj ZsGQudEliWYQ/fFCt0hqIGCcrqeZyRML0rrh9eu2Y5w1xU0OPCj0bWJh4IHKPYj7ZwYC MF64ngLl4EAr+bOgm6g9gazKrFgRlxPHHTi0sZA+Earxzkr2xkZEXx4rLd+JoJEtevLu sd0A== X-Gm-Message-State: APzg51CjZ6h+732sucw4q0Tx8+7gbeeMLbEhdIMOnkMU5fbSuTex12wd dearmsdsZdZrNQL7wuaIlG8sv6JuXO/TmqFp5Kg= X-Google-Smtp-Source: ANB0VdYcrNhIlqMO2tSPO6sylLfSeTaWSqZ+SQHafqL/wPnTZ3DJND0jRuDqXDVPCfIrhQ6WUnzjBqgBU3VtlVCZEMk= X-Received: by 2002:a6b:b44e:: with SMTP id d75-v6mr3384959iof.63.1535499097490; Tue, 28 Aug 2018 16:31:37 -0700 (PDT) MIME-Version: 1.0 References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> <8736uyt767.fsf@gmail.com> In-Reply-To: <8736uyt767.fsf@gmail.com> From: Federico Tedin Date: Tue, 28 Aug 2018 20:31:25 -0300 Message-ID: Subject: Re: bug#32549: Allow passing custom options to vc-git-grep To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Doesn't projectile-grep prompt you for a regexp? I don't have it > installed here, but it looks like you have to pass a non-nil ARG to get > prompted for filenames, i.e., > > (let ((current-prefix-arg '(4))) > (projectile-grep nil t)) My mistake. Calling projectile-grep with current-prefix-arg '(4) indeed prompts for the git-grep command _and_ a regexp. > > Is there any way to set a default set of arguments in order to avoid > > typing them when invoking the function? > > Not sure I follow, when you pass "something" and "*.el" to the function, > those get inserted into the default command so you don't have to type > them interactively. I am sorry if I wasn't clear enough. What I'm trying to say is, when calling vc-git-grep directly or indirectly with current-prefix-arg '(4), I am always prompted for the full git-grep command. I would like to skip this step completely, and always use a custom set of arguments (like, for example, "-C 3"). Then, I would be prompted for a regexp and (maybe) files, which would be added to this custom git-grep command's arguments (this is how the rgrep command works, I think). From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 20:45:20 2018 Received: (at 32549) by debbugs.gnu.org; 29 Aug 2018 00:45:20 +0000 Received: from localhost ([127.0.0.1]:36213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuobo-0005LA-EJ for submit@debbugs.gnu.org; Tue, 28 Aug 2018 20:45:20 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:52678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuobm-0005Kx-W8 for 32549@debbugs.gnu.org; Tue, 28 Aug 2018 20:45:19 -0400 Received: by mail-it0-f48.google.com with SMTP id h3-v6so5323834ita.2 for <32549@debbugs.gnu.org>; Tue, 28 Aug 2018 17:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=M+vTN2mcNavTNYCYuyWyNVVmSB066RgKoEWXXAvnXVE=; b=lcJriDvJZZHzlz+doOm/qREVRJ7TyQ3/8FDYUmCYfoo0D2DvIc5KZ0LlXrh3SKhu3V 83h3pFojkBNGYhAJsHvMj0erjw+kENGNrLoUOWg9HOJNSTIV5/Ccn2bWJiH3e72aa3dA rftmdGlK9S/29tOxADiP3revsYO/CxMgg6WhmcKptGsnSqQ0WXwd/Hdzsz6R7Qy5Ydx/ mVOGqZUgPcT7APjWxwhyd2rlb8h6O2qFIkqATMT9r6H84/r8z3woVqzOHJWfYzq84wiN HPrHUyt8CL68q+bq1jKqQ8e2cmaMjKZVyr6Zzpj9sYotjjzUz8KdwCEqxO9t6zm0nllw Cfgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=M+vTN2mcNavTNYCYuyWyNVVmSB066RgKoEWXXAvnXVE=; b=Ye2i6gMZHhikS71gD+bwf9jLtAgqdpLmo8NfK6lTOSN2D5WsmJl1GLc20ZQYdPgH+S 3Pzo3wV2yal1P2qzmRvkJjyv552Rk/jqMo4r5IsoZgeK+Tq2cntYppoqTWI/I2U707m9 9iKCgHb5492Dtt7iRCiuo0Q811cAontCYJ5lrw3eAS4OaYGuyrcwsEtlkU/waDb05DG5 K05p5mSIVrXeAZzK/k5GDrd/NJjjpgXsVJs24IoYNdezGRyVosk0ZQ9qVap48VKzs3On fMpRRBzEOkP3aja5Xv3NRQHtSl4SAqpu+H/9MSc+gf6cRNY4yfnkmw+96PswKegxS0WT 5IHQ== X-Gm-Message-State: APzg51DGARENfryPG8c6Wu4ZDjwqDoq/SApc1QpEpUoMwgnTy58id67H hY/uZ84NAcTeTBGgzM4hBsSO/eB6 X-Google-Smtp-Source: ANB0VdbPztlLtxpV/1Au2gbnM5KH/rewMbCTKH1ycXBDgGqUdiPh0csC3FIbNZ5niBdiwXO20A5CSw== X-Received: by 2002:a02:88ad:: with SMTP id n42-v6mr3432036jaj.38.1535503513258; Tue, 28 Aug 2018 17:45:13 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d11-v6sm1071233ioh.22.2018.08.28.17.45.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Aug 2018 17:45:12 -0700 (PDT) From: Noam Postavsky To: Federico Tedin Subject: Re: bug#32549: Allow passing custom options to vc-git-grep References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> <8736uyt767.fsf@gmail.com> Date: Tue, 28 Aug 2018 20:45:10 -0400 In-Reply-To: (Federico Tedin's message of "Tue, 28 Aug 2018 20:31:25 -0300") Message-ID: <87zhx6rofd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Federico Tedin writes: > when calling vc-git-grep directly or indirectly with > current-prefix-arg '(4), I am always prompted for the full git-grep > command. I would like to skip this step completely, > and always use a custom set of arguments (like, for example, "-C 3"). Then, I > would be prompted for a regexp and (maybe) files, which would be added to this > custom git-grep command's arguments (this is how the rgrep command works, I > think). Ah, I see what you mean, vc-git-grep hardcodes the grep-command template, so it doesn't allow for this. Would you like to send a patch? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 28 20:54:32 2018 Received: (at 32549) by debbugs.gnu.org; 29 Aug 2018 00:54:32 +0000 Received: from localhost ([127.0.0.1]:36218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuoki-0005XY-Cc for submit@debbugs.gnu.org; Tue, 28 Aug 2018 20:54:32 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:51217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fuokg-0005XK-5b for 32549@debbugs.gnu.org; Tue, 28 Aug 2018 20:54:30 -0400 Received: by mail-it0-f47.google.com with SMTP id e14-v6so5356676itf.1 for <32549@debbugs.gnu.org>; Tue, 28 Aug 2018 17:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Es92amRFKmw8mUXOUJ9JWesAWZclwAfqyn4BcUpQD3U=; b=snll4WMLUmLT8TY2dnmvuMteTVKjiLRjvraouZbN8PZLA/Eaf3AHClUQWIyAa30699 AgWyJDU2+9n8VCwDHsihW8uOuZ/7iIT1vkuKKv1UuQkN2Eti5K74++5lRn6J+Z0klhV9 D42U3xErPJ/DhLRY1gXDWlbYyWk4+NYOZ+LpG3klHY3c/5ECRKLZmTw0owWR9zlUA+/T NkCH7YV81KgO560s7oAAf3UAXGSHmXd6bRSk8CuuBwB9vgjd4qT/hBtZjjgV6y5jpsxB Ys45tAR/ofrMQEo2IbTZReuK4Oimzjl9o67dEly3h671FT2VLtbW6ufJPN0TAzCJajcI ngIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Es92amRFKmw8mUXOUJ9JWesAWZclwAfqyn4BcUpQD3U=; b=tWhR4G4Z3LuuWAxequGUEUCSggkfbIOViK4z8p1cntxUohvQAJt8VKIpQdqJD3KD2R X3i0uPjEccFdUmYyhD/cFZuYEFZLZkNGRG9DDhGu+0p2FK1wMPho01LuU2ZJcothFFk8 LwEK8sN9o2jI1mw+fpv66W5m7QqEwKUaXUafa9uOBWDphAlC+2LQwYl+Uuc6j4Jza2aO 4s1bHHGX3Y8HSCj7Xeatrw/JhEoWRY24Inu5G//cF2QrRUA9sN0suNWdpP+FiQkyeFkt kuNpuIZSvFTPcmKslmTOcit0HJ0tCEctpS55xIJb++YsZTHHRpJuKi7L9I7ea6rpBzL5 514w== X-Gm-Message-State: APzg51CrMYwo1f5TiAZYgq1cHVljyQvQGCEM92HAVPq3BK2UKutaHUnj To+rifLLxAz677OyUG4oGZZUwBb6zLQgdsFXnEk= X-Google-Smtp-Source: ANB0VdbWJVpHN5vZeO76ug7c/5V6qwavVsZTSMuDRtJ+fLW42pEYYZpfyBt7/JXD6HBpkD+MqezEUjQ0CYNwr0GNu7k= X-Received: by 2002:a24:1d52:: with SMTP id 79-v6mr3428844itj.142.1535504064643; Tue, 28 Aug 2018 17:54:24 -0700 (PDT) MIME-Version: 1.0 References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> <8736uyt767.fsf@gmail.com> <87zhx6rofd.fsf@gmail.com> In-Reply-To: <87zhx6rofd.fsf@gmail.com> From: Federico Tedin Date: Tue, 28 Aug 2018 21:54:12 -0300 Message-ID: Subject: Re: bug#32549: Allow passing custom options to vc-git-grep To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Ah, I see what you mean, vc-git-grep hardcodes the grep-command > template, so it doesn't allow for this. Would you like to send a patch? Sure! I'll start working on it. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 01 17:55:35 2018 Received: (at 32549) by debbugs.gnu.org; 1 Sep 2018 21:55:35 +0000 Received: from localhost ([127.0.0.1]:42172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwDrj-0000k3-Ca for submit@debbugs.gnu.org; Sat, 01 Sep 2018 17:55:35 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:33529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwDrh-0000jq-S2 for 32549@debbugs.gnu.org; Sat, 01 Sep 2018 17:55:34 -0400 Received: by mail-it0-f43.google.com with SMTP id j198-v6so8041197ita.0 for <32549@debbugs.gnu.org>; Sat, 01 Sep 2018 14:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uhh/W1DCxxvkhHpt+5Z+vAtcBPWDap56+1PG34SKS2A=; b=LCjk4WDG77GVUnZkUUkY9Y7rq66KdCJ/PD9yCWZxOG7CLyVhhKoBD+O+l0q44A5vSX CO53kWiEjb1C8nDsy9ygGEaZsLUXqLROuFUXuMlqtjVIXBlIKgDy96bsSPWC++totEeC xZypK7pIfrCeS3Zdqp7NuP9ggZP+tGHAnpu122D4TCWORV5eGx2jwdcsecq0r2544cMn gTTsc/eIQe3x+KJjkGynCrNFukVzMfB9l85IjDj5oWnAc7lCzlRl/t95cBwMahwtZB6c /z32oAExLSh2IRyNYdaia4lxI/p6fzIRJPedZRDufxmSJpaY5XwEExmxvyb9fVnR8YDE bKWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uhh/W1DCxxvkhHpt+5Z+vAtcBPWDap56+1PG34SKS2A=; b=Wmk3mbWCtG8tYdAv8LRxoCMDX1zbdf6LzvOWqRFxjO6fMyabNJov1EP8VrpDoD4p/t 8A0O4lg6JtDPpbiMy5H/HAR++70rriuPJ7aLqa/BBLZtNwTDDnqcZ3P7M6M6xe933wZa t3MVwEiUQzP5khXpCV0guNyLubdqL0vD2nSx6JS4YaMPBr5WsDtteXJnXCWn8/+1gp41 v3zS3WTh48rk5yaG0GzDeraEXAqz6y6tQwrS8R5jbtiYQDXHOzpGsZPfJdyini3LK/3v C7KpIc0stc5aW+NxO3YTudvjCtTXr4vZU3OwP0nVVw5/hxpSEX07ffbBWRJNfLDHkUPG hggg== X-Gm-Message-State: APzg51Cw1kl7svpScdDJHN2e4FE+pLptUatIRvVC3/P+sx3dRwzZs6ge IVB5MSTaVhyT5VJ9wjVDE2Yh8RQ2isLadSa3NK0= X-Google-Smtp-Source: ANB0VdYu6ufpo1ipw/O5Q8ugm7WnjgLnfqlfQStmCXjP7gLud/bzHXBcJS6j48IYIoYMfvrffwzzB78Nd2LxVzaWPaA= X-Received: by 2002:a02:9832:: with SMTP id t47-v6mr16224121jaj.137.1535838928176; Sat, 01 Sep 2018 14:55:28 -0700 (PDT) MIME-Version: 1.0 References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> <8736uyt767.fsf@gmail.com> <87zhx6rofd.fsf@gmail.com> In-Reply-To: From: Federico Tedin Date: Sat, 1 Sep 2018 18:55:15 -0300 Message-ID: Subject: Re: bug#32549: Allow passing custom options to vc-git-grep To: Noam Postavsky Content-Type: multipart/mixed; boundary="000000000000bfd5d20574d65d1d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000bfd5d20574d65d1d Content-Type: text/plain; charset="UTF-8" I'm attaching a patch with the implementation of the new feature (vc-git-grep-template). --000000000000bfd5d20574d65d1d Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Add-variable-vc-git-grep-template.patch" Content-Disposition: attachment; filename="0001-Add-variable-vc-git-grep-template.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jljyt2iq0 RnJvbSA1NTI0M2U2ZTcyNDE0Y2UzNTA1OGJlMmFkNDVhOGNhNjY0M2VkMTRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGZWRlcmljbyBUZWRpbiA8ZmVkZXJpY290ZWRpbkBnbWFpbC5j b20+CkRhdGU6IFNhdCwgMSBTZXAgMjAxOCAxODo0NjoxNiAtMDMwMApTdWJqZWN0OiBbUEFUQ0gg MS8xXSBBZGQgdmFyaWFibGUgdmMtZ2l0LWdyZXAtdGVtcGxhdGUKCiogbGlzcC92Yy92Yy1naXQu ZWwgKHZjLWdpdC1ncmVwLXRlbXBsYXRlKTogTmV3IHZhcmlhYmxlLCBhbGxvd3MKICBjaGFuZ2lu ZyB0aGUgZGVmYXVsdCBhcmd1bWVudHMgcGFzc2VkIHRvIGdpdC1ncmVwIHdoZW4gdXNpbmcKICAn dmMtZ2l0LWdyZXAnLgoqIGV0Yy9ORVdTOiBNZW50aW9uICd2Yy1naXQtZ3JlcC10ZW1wbGF0ZScu ICAoQnVnIzMyNTQ5KQotLS0KIGV0Yy9ORVdTICAgICAgICAgIHwgIDQgKysrKwogbGlzcC92Yy92 Yy1naXQuZWwgfCAxMCArKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4 IDFmZTY2MmZmZmYuLmZhNjAwYzY3YjUgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9O RVdTCkBAIC0yNzcsNiArMjc3LDEwIEBAIHN0aWxsIGJlIHVzZWQgaWYgaXQgZXhpc3RzLikgIFNl dCB0aGUgdmFyaWFibGUgdG8gbmlsIHRvIGdldCB0aGUKIHByZXZpb3VzIGJlaGF2aW9yIG9mIGFs d2F5cyBjcmVhdGluZyBhIGJ1ZmZlciB0aGF0IHZpc2l0cyBhIENoYW5nZUxvZwogZmlsZS4KIAor KioqIE5ldyBjdXN0b21pemFibGUgdmFyaWFibGUgJ3ZjLWdpdC1ncmVwLXRlbXBsYXRlJy4KK1Ro aXMgbmV3IHZhcmlhYmxlIGFsbG93cyBjdXN0b21pemluZyB0aGUgZGVmYXVsdCBhcmd1bWVudHMg cGFzc2VkIHRvCitnaXQtZ3JlcCB3aGVuICd2Yy1naXQtZ3JlcCcgaXMgdXNlZC4KKwogKiogZGlm Zi1tb2RlCiAqKiogSHVua3MgYXJlIG5vdyBhdXRvbWF0aWNhbGx5IHJlZmluZWQgYnkgZGVmYXVs dC4KIFRvIGRpc2FibGUgaXQsIHNldCB0aGUgbmV3IGRlZmN1c3RvbSAnZGlmZi1mb250LWxvY2st cmVmaW5lJyB0byBuaWwuCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWdpdC5lbCBiL2xpc3AvdmMv dmMtZ2l0LmVsCmluZGV4IDk2YzJmMzhhZjQuLjU2N2YwMDEwNGIgMTAwNjQ0Ci0tLSBhL2xpc3Av dmMvdmMtZ2l0LmVsCisrKyBiL2xpc3AvdmMvdmMtZ2l0LmVsCkBAIC0xNzksNiArMTc5LDE0IEBA IHZjLWdpdC1sb2ctb3V0cHV0LWNvZGluZy1zeXN0ZW0KICAgOnR5cGUgJyhjb2Rpbmctc3lzdGVt IDp0YWcgIkNvZGluZyBzeXN0ZW0gdG8gZGVjb2RlIEdpdCBsb2cgb3V0cHV0IikKICAgOnZlcnNp b24gIjI1LjEiKQogCisoZGVmY3VzdG9tIHZjLWdpdC1ncmVwLXRlbXBsYXRlICJnaXQgLS1uby1w YWdlciBncmVwIC1uIC1lIDxSPiAtLSA8Rj4iCisgICJUaGUgZGVmYXVsdCBjb21tYW5kIHRvIHJ1 biBmb3IgXFxbdmMtZ2l0LWdyZXBdLgorVGhlIGZvbGxvd2luZyBwbGFjZSBob2xkZXJzIHNob3Vs ZCBiZSBwcmVzZW50IGluIHRoZSBzdHJpbmc6CisgPEY+IC0gZmlsZSBuYW1lcyBhbmQgd2lsZGNh cmRzIHRvIHNlYXJjaC4KKyA8Uj4gLSB0aGUgcmVndWxhciBleHByZXNzaW9uIHNlYXJjaGVkIGZv ci4iCisgIDp0eXBlICdzdHJpbmcKKyAgOnZlcnNpb24gIjI3LjEiKQorCiA7OyBIaXN0b3J5IG9m IEdpdCBjb21tYW5kcy4KIChkZWZ2YXIgdmMtZ2l0LWhpc3RvcnkgbmlsKQogCkBAIC0xNDQ5LDcg KzE0NTcsNyBAQCB2Yy1naXQtZ3JlcAogCSAgICAgIChzZXRxIGNvbW1hbmQgbmlsKSkKIAkoc2V0 cSBkaXIgKGZpbGUtbmFtZS1hcy1kaXJlY3RvcnkgKGV4cGFuZC1maWxlLW5hbWUgZGlyKSkpCiAJ KHNldHEgY29tbWFuZAotCSAgICAgIChncmVwLWV4cGFuZC10ZW1wbGF0ZSAiZ2l0IC0tbm8tcGFn ZXIgZ3JlcCAtbiAtZSA8Uj4gLS0gPEY+IgorCSAgICAgIChncmVwLWV4cGFuZC10ZW1wbGF0ZSB2 Yy1naXQtZ3JlcC10ZW1wbGF0ZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmVnZXhwIGZpbGVzKSkKIAkod2hlbiBjb21tYW5kCiAJICAoaWYgKGVxdWFsIGN1cnJlbnQtcHJl Zml4LWFyZyAnKDQpKQotLSAKMi4xNy4xCgo= --000000000000bfd5d20574d65d1d-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 04 19:04:00 2018 Received: (at 32549) by debbugs.gnu.org; 4 Sep 2018 23:04:00 +0000 Received: from localhost ([127.0.0.1]:46108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxKMY-0008Sb-1R for submit@debbugs.gnu.org; Tue, 04 Sep 2018 19:03:58 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:34708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxKMQ-0008S8-6v; Tue, 04 Sep 2018 19:03:52 -0400 Received: by mail-io0-f174.google.com with SMTP id c22-v6so4465607iob.1; Tue, 04 Sep 2018 16:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=L+l9gIom3qC2MoTPgAdh6nkO+6JZ8eNp+VFcsUTCL2A=; b=rEAsaGo137Ro+i0fk134SyPSTCfHyRTQF57wc2k+YN3vvf3Ft0Hec4aa5GB9cG+nWE TkofiVLvyIdsF5JFcxeMIiWpsNMrdTCtw5uOSbbZBQZM6U/oY16OiFX6xi/e9zvBQyb8 Toarvfo8ANg6YjjPLVfkbY4BHKNVkBU5g3tY4/qd7amK7jNUhJAlVRgBUMlxvk3AQQY5 mgZoBdxBRWM1i6tBx++lTJvQT5dUtNjiY5DON6ACj+VoOr+nfnYYUqb8I3vFnAe9vY02 bPBzvNk9U5DRmYjbehlmnJG5X7ITQrFnj7qnFecKjfvEaC7bD9hPfZ28zJogIBmxi5lz voNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=L+l9gIom3qC2MoTPgAdh6nkO+6JZ8eNp+VFcsUTCL2A=; b=a1ChdW9PfIdFvYZj1ez1G/N4m6Cl+lBcLXgwSW9KhYli676fPjvq7lmiH7esL/62PR qnnc1I/ou65cyY2onyjqa9qd23vC0T4VncHOd606P7xs9Byb6SG0v8xivAHMvWZ8Lbeo 4YygWjlLRN/FizaMsLRUnLPqc36bm9FzahubZLZwa6GHFJMk+jkHmLkuE6rFniG/3dJi lWxhqq5KZgaZDfKHJK28DQmRGSPL9mXKgSD/yjKTD+MQEL7Rp/9LFJNQysarz095k7LG baDEEGt4J76QM2sCc2wyiHdR6FMB/t6nZpo29nNN/DRgtNBHjJAn2ezZ+C19eZZo9Xva Ebqg== X-Gm-Message-State: APzg51CHlgRHLks/QLyOUl5VlaIDQSlOTHQzL+n2VTuV5YakYek8UE4o Hyba6mPdsXeRwI4u/7NK6wI0F3KD X-Google-Smtp-Source: ANB0VdZg+mCXdfZcHRhSAdDB2fKQ3TfdUar9q8R2DEejgkoXqGtsd+vOMhlgHKhPShMoNVMHDXEq7Q== X-Received: by 2002:a5e:8510:: with SMTP id i16-v6mr23763382ioj.301.1536102224357; Tue, 04 Sep 2018 16:03:44 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m7-v6sm438490itb.39.2018.09.04.16.03.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 04 Sep 2018 16:03:43 -0700 (PDT) From: Noam Postavsky To: Federico Tedin Subject: Re: bug#32549: Allow passing custom options to vc-git-grep References: <875zzvv1kd.fsf@gmail.com> <87r2ijtaeu.fsf@gmail.com> <8736uyt767.fsf@gmail.com> <87zhx6rofd.fsf@gmail.com> Date: Tue, 04 Sep 2018 19:03:42 -0400 In-Reply-To: (Federico Tedin's message of "Sat, 1 Sep 2018 18:55:15 -0300") Message-ID: <87wos0hnld.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32549 Cc: 32549@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32549 fixed close 32549 27.1 quit Federico Tedin writes: > I'm attaching a patch with the implementation of the new feature > (vc-git-grep-template). Thanks, pushed to master. [1: e3661f8c35]: 2018-09-04 18:53:59 -0400 Add variable vc-git-grep-template https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e3661f8c35b3057c58e8c0b474f597697ce413ba From unknown Thu Sep 11 01:08:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 03 Oct 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator