GNU bug report logs - #32543
26.1; list-matching-lines-jump-to-current breaks revert-buffer in occur-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32543: closed (26.1; list-matching-lines-jump-to-current
 breaks revert-buffer in occur-mode)
Date: Tue, 18 Sep 2018 12:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 18 Sep 2018 21:33:47 +0900
with message-id <87fty77zo4.fsf <at> calancha-pc.dy.bbexcite.jp>
and subject line Re: bug#32543: 26.1; list-matching-lines-jump-to-current breaks revert-buffer in occur-mode
has caused the debbugs.gnu.org bug report #32543,
regarding 26.1; list-matching-lines-jump-to-current breaks revert-buffer in occur-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32543: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32543
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrey Kolomoets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; list-matching-lines-jump-to-current breaks revert-buffer in
 occur-mode
Date: Mon, 27 Aug 2018 14:49:41 +0300

0. emacs -Q
1. M-: (setq list-matching-lines-jump-to-current-line t) <RET>
2. M-s o text <RET>
3. C-x o
4. g

(wrong-type-argument number-or-marker-p nil)
  occur-engine("text" (#<buffer *scratch*>) #<buffer *Occur*> 0 t underline shadow match t)
  occur-1("text" nil (#<buffer *scratch*>) "*Occur*")
  apply(occur-1 ("text" nil (#<buffer *scratch*>) "*Occur*"))
  occur-revert-function(t nil)
  revert-buffer(t)
  funcall-interactively(revert-buffer t)
  call-interactively(revert-buffer nil nil)
  command-execute(revert-buffer)

I think it's because occur--orig-line not initialized in occur-revert-function and it fails on

(when (and list-matching-lines-jump-to-current-line
 (null orig-line-shown-p)
 (> curr-line orig-line))


In GNU Emacs 26.1 and still in 27.0.50

[Message part 3 (message/rfc822, inline)]

From: Tino Calancha <tino.calancha <at> gmail.com>
To: 32543-done <at> debbugs.gnu.org
Subject: Re: bug#32543: 26.1;
 list-matching-lines-jump-to-current breaks revert-buffer in occur-mode
Date: Tue, 18 Sep 2018 21:33:47 +0900

Tino Calancha <tino.calancha <at> gmail.com> writes:

> Juri Linkov <juri <at> linkov.net> writes:
>
>>> +    (let* ((region (occur--parse-occur-buffer))
>>> +           (region-start (car region))
>>> +           (region-end (cadr region))
>>> +           (orig-line (caddr region))
>>> +           (buffer (cadddr region))
>>
>> Better to use (nth 1), (nth 2), (nth 3), ...
> Yeah, it reads better.
> Here is the updated patch:
Fixed in master branch as commit 'Fix bug 32543'
(75d9a55fae1c484aa6d213064931bfe3b65cf5dd)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.