GNU bug report logs - #32529
Submitting package for SpaceFM

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32529 in the body.
You can then email your comments to 32529 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ison111 <ison111 <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Submitting package for SpaceFM
Date: Sat, 25 Aug 2018 20:27:58 +0000

[Message part 1 (text/plain, inline)]

Hello,
I would like to submit this package for the SpaceFM file manager.

[Message part 2 (text/html, inline)]

[spacefm.scm (text/x-scheme, attachment)]

Message #8 received at 32529 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ison111 <ison111 <at> protonmail.com>
Cc: 32529 <at> debbugs.gnu.org
Subject: Re: [bug#32529] Submitting package for SpaceFM
Date: Sun, 26 Aug 2018 00:20:27 +0200

Hello Ison111,

Could you please send it as a patch as produced by ‘git format-patch’?
Please see
<https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>,
which also contains other pieces of advice.

At first sight there are a couple of minor issues that ‘guix lint’
should report.  Usually we don’t indent items in the ‘inputs’ list the
way you did, but I’m nitpicking.

Could you send the updated patch?  Let me know if you have troubles with
any of this.

Thanks,
Ludo’.

Message #11 received at 32529 <at> debbugs.gnu.org (full text, mbox):

From: Ison111 <ison111 <at> protonmail.com>
To: "32529 <at> debbugs.gnu.org" <32529 <at> debbugs.gnu.org>
Subject: [PATCH] Submit SpaceFM package
Date: Sun, 26 Aug 2018 08:57:25 +0000

[Message part 1 (text/plain, inline)]

Sorry for the poor formatting, and thanks for the documentation. Please let me know if there are still any issues, or if this package should be added to an existing package file instead of given it's own as I'm not sure what the convention is for that.

[Message part 2 (text/html, inline)]

[0001-Submit-SpaceFM-package.patch (text/x-patch, attachment)]

Message #16 received at 32529-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ison111 <ison111 <at> protonmail.com>
Cc: "32529 <at> debbugs.gnu.org" <32529-done <at> debbugs.gnu.org>
Subject: Re: [bug#32529] [PATCH] Submit SpaceFM package
Date: Tue, 28 Aug 2018 12:37:02 +0200

Hello Ison111,

Ison111 <ison111 <at> protonmail.com> skribis:

> Sorry for the poor formatting, and thanks for the documentation. Please let me know if there are still any issues, or if this package should be added to an existing package file instead of given it's own as I'm not sure what the convention is for that.

I ended up moving it to lxde.scm, next to PCManFM.  I added a copyright
line for you, tweaked the description, and added a commit log that
follows our conventions.  You can see the result here:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d2434b6966b06893a4d2b15d0620b05e921fd182

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.