From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Aug 2018 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32510@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.153503836128564 (code B ref -1); Thu, 23 Aug 2018 15:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Aug 2018 15:32:41 +0000 Received: from localhost ([127.0.0.1]:59012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsrbF-0007Qe-K5 for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsrbD-0007QR-AL for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsrb6-0007jI-Lj for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsrb6-0007j2-FA for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsrb1-0003ps-Rc for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsray-0007eA-No for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:27 -0400 Received: from rmap1.bookmyname.com ([88.191.249.149]:54001 helo=webmail.free.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsray-0007cU-G5 for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:24 -0400 Received: by webmail.free.org (Postfix, from userid 5000) id 10555507A558; Thu, 23 Aug 2018 17:32:22 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Aug 2018 16:32:21 +0100 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org User-Agent: Roundcube Webmail/0.5.3 X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.bookmyname.com X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Package: emacs Version: 26.1 Severity: wishlist Hello, It would be nice if xref-find-definitions returned files in addition to language-specific "definitions". For example: M-. foo-bar.adb RET should open the file foo-bar.adb (wherever it is in the potentially complex directory structure of the project) and leave point at the beginning of the file. This is a feature of find-tag but find-tag is now deprecated in favor of xref-find-definitions; so this feature is missing and xref-find-definitions is not yet a complete replacement for find-tag. Thanks for consideration. -- Ludovic Brenta. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 02:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.15629862406105 (code B ref 32510); Sat, 13 Jul 2019 02:51:02 +0000 Received: (at 32510) by debbugs.gnu.org; 13 Jul 2019 02:50:40 +0000 Received: from localhost ([127.0.0.1]:41130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm87T-0001aP-Ox for submit@debbugs.gnu.org; Fri, 12 Jul 2019 22:50:39 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm87R-0001aH-Ug for 32510@debbugs.gnu.org; Fri, 12 Jul 2019 22:50:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hm87O-0004n7-Qg; Sat, 13 Jul 2019 04:50:37 +0200 From: Lars Ingebrigtsen References: Date: Sat, 13 Jul 2019 04:50:34 +0200 In-Reply-To: (Ludovic Brenta's message of "Thu, 23 Aug 2018 16:32:21 +0100") Message-ID: <87h87qzlz9.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ludovic Brenta writes: > It would be nice if xref-find-definitions returned files in > addition to language-specific "definitions". For example: > > M-. foo-bar.adb RET > > should open the file foo-bar.adb (wherever it is i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Brenta writes: > It would be nice if xref-find-definitions returned files in > addition to language-specific "definitions". For example: > > M-. foo-bar.adb RET > > should open the file foo-bar.adb (wherever it is in the > potentially complex directory structure of the project) and > leave point at the beginning of the file. > > This is a feature of find-tag but find-tag is now deprecated > in favor of xref-find-definitions; so this feature is missing > and xref-find-definitions is not yet a complete replacement for > find-tag. Hm... it seems to me that a command like that seems to belong more in something like project.el than in xref, which has a different scope. So I'm closing this bug report; if somebody else disagrees, please reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 12 22:50:45 2019 Received: (at control) by debbugs.gnu.org; 13 Jul 2019 02:50:45 +0000 Received: from localhost ([127.0.0.1]:41133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm87Z-0001aj-1d for submit@debbugs.gnu.org; Fri, 12 Jul 2019 22:50:45 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm87X-0001ab-Jf for control@debbugs.gnu.org; Fri, 12 Jul 2019 22:50:43 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hm87V-0004nD-2I for control@debbugs.gnu.org; Sat, 13 Jul 2019 04:50:42 +0200 Date: Sat, 13 Jul 2019 04:50:40 +0200 Message-Id: <87ftnazlz3.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #32510 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 32510 wontfix close 32510 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32510 wontfix close 32510 quit From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: acknowledged by developer (control message for bug #32510) Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 19:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix To: 32510@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.15630464769308 (code B ref 32510); Sat, 13 Jul 2019 19:35:02 +0000 Received: (at 32510) by debbugs.gnu.org; 13 Jul 2019 19:34:36 +0000 Received: from localhost ([127.0.0.1]:43402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmNn2-0002Q2-2u for submit@debbugs.gnu.org; Sat, 13 Jul 2019 15:34:36 -0400 Received: from eir.is.scarlet.be ([193.74.71.27]:46099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmNn0-0002Pn-LR; Sat, 13 Jul 2019 15:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scarlet.be; s=scarlet; t=1563046468; bh=kjVpNXG4kLo6zbikyNj9dr04MTtVUYIJCUL4GSnXuyw=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding; b=jYGCFRz9ttA0Hgatfo2CBUh0vxIh3Z8cZB1nRMa28mJjHxz1TVJfKqwhJDemBrsF8 8sM7CljhXN9Tgr7Irym1l3ty7pwxf0JiegkBx/ZUIv/1f6nO8B29d1HbxnxIb2SZ8t D0zIIEqRZ+OZpkcakJTHnLvj/b4ZKQbtzqnVvw7o= Received: from samuel (ip-62-235-96-208.dsl.scarlet.be [62.235.96.208]) by eir.is.scarlet.be (8.15.2/8.14.9) with ESMTPS id x6DJYQQu010352 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Jul 2019 21:34:28 +0200 X-Scarlet: d=1563046468 c=62.235.96.208 From: Ludovic Brenta References: <87ftnazlz3.fsf@mouse.gnus.org> Date: Sat, 13 Jul 2019 21:34:26 +0200 In-Reply-To: (GNU bug Tracking System's message of "Fri, 12 Jul 2019 22:51:02 -0400") Message-ID: <87o91xwwxp.fsf@samuel> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-DCC-scarlet.be-Metrics: eir 20001; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: clamav-milter 0.98.1-exp at eir X-Virus-Status: Clean X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) reopen 32510 thanks Please to not close this bug so summarily. Quoting the doc-string of find-tag: This function is obsolete since 25.1; use =E2=80=98xref-find-definitions=E2=80=99 instead. This bug report states that a useful functionality of find-tag is *not* provided by its official replacement, xref-find-definitions. This is a regression. Just because you think this missing functionality should be provided elsewhere is not a good reason to close this bug without providing any solution. --=20 Ludovic Brenta. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: acknowledged by developer (control message for bug #32510) Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 23:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix To: Ludovic Brenta , 32510@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.15630603657197 (code B ref 32510); Sat, 13 Jul 2019 23:27:02 +0000 Received: (at 32510) by debbugs.gnu.org; 13 Jul 2019 23:26:05 +0000 Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmRP2-0001rv-Qx for submit@debbugs.gnu.org; Sat, 13 Jul 2019 19:26:05 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmRP0-0001rI-2b; Sat, 13 Jul 2019 19:26:03 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6DNPFET017022; Sat, 13 Jul 2019 23:25:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=BwyU0Lv7I80mJA5gRhQK8DMOSjG/CbUcEIJG8ChpjBM=; b=NlO3o5UGA3cYSHuIuxLEIGQu1GVwnggabw0/vle9xSf1mmsu2K6Ysfrbavx5ze9ru6H4 ioHhyy71Fyf9DOW3HlP0QBId/XCMBmS7of67KTklZryR7Z+AJkQUXdQuFSadKVhY1XK/ 70d/u/bzcgFd0Zd7liPg8MTYoTx9ssNL5MlbbbVPHR3MEz3JKVnFnlZzqa90qkXlWkq4 RWHE1O889KyGTPUYEzKKBGeJJ66Of5cuWlSBM9mzQFOqbreuMqf3+w/73B+N922vtYyS GWeuJsE3YBkrcChb/2bIm7cqFilcrYEw4uqJ0IkWnapDiKQroPovsYUnV5g17+TMeaUH MQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2tq7xqhq5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jul 2019 23:25:55 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6DNMUYn077078; Sat, 13 Jul 2019 23:25:55 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2tq6mkrqx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 13 Jul 2019 23:25:55 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6DNPoir007671; Sat, 13 Jul 2019 23:25:54 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 13 Jul 2019 16:25:49 -0700 (PDT) From: Drew Adams References: <87ftnazlz3.fsf@mouse.gnus.org> <87o91xwwxp.fsf@samuel> In-Reply-To: <87o91xwwxp.fsf@samuel> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9317 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907130288 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9317 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907130289 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > reopen 32510 > thanks >=20 > Please [d]o not close this bug so summarily. Quoting the doc-string of > find-tag: >=20 > This function is obsolete since 25.1; > use =E2=80=98xref-find-definitions=E2=80=99 instead. >=20 > This bug report states that a useful functionality of find-tag is *not* > provided by its official replacement, xref-find-definitions. This is a > regression. Just because you think this missing functionality should be > provided elsewhere is not a good reason to close this bug without > providing any solution. +1 And I don't think that `find-tag' should be deprecated (obsolete). Its "replacement" is simply a different command, with some things in common and some things different. Both have their uses; each can be preferred by some users for some things. (I also don't think that the default key binding of `find-tag' should have been hijacked for its "replacement", but that's a different and lesser problem.) From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: acknowledged by developer (control message for bug #32510) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jul 2019 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix To: Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156308170913292 (code B ref 32510); Sun, 14 Jul 2019 05:22:02 +0000 Received: (at 32510) by debbugs.gnu.org; 14 Jul 2019 05:21:49 +0000 Received: from localhost ([127.0.0.1]:43721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmWxI-0003SJ-T0 for submit@debbugs.gnu.org; Sun, 14 Jul 2019 01:21:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hmWxG-0003S7-UV for 32510@debbugs.gnu.org; Sun, 14 Jul 2019 01:21:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hmWxB-0006rA-5c; Sun, 14 Jul 2019 01:21:41 -0400 Received: from [176.228.60.248] (port=4015 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hmWxA-0002aX-Ib; Sun, 14 Jul 2019 01:21:40 -0400 Date: Sun, 14 Jul 2019 08:21:23 +0300 Message-Id: <83k1clyywc.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87o91xwwxp.fsf@samuel> (message from Ludovic Brenta on Sat, 13 Jul 2019 21:34:26 +0200) References: <87ftnazlz3.fsf@mouse.gnus.org> <87o91xwwxp.fsf@samuel> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ludovic Brenta > Date: Sat, 13 Jul 2019 21:34:26 +0200 > > This bug report states that a useful functionality of find-tag is *not* > provided by its official replacement, xref-find-definitions. This is a > regression. Just because you think this missing functionality should be > provided elsewhere is not a good reason to close this bug without > providing any solution. With the patch below, you should be able to have what you want if you add tag-partial-file-name-match-p to the list in etags-xref-find-definitions-tag-order. Please try this patch and see if it works for you. Thanks. diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index 7bf5753..b092c63 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -2070,13 +2070,16 @@ etags--xref-find-definitions (beginning-of-line) (pcase-let* ((tag-info (etags-snarf-tag)) (`(,hint ,line . _) tag-info)) - (unless (eq hint t) ; hint==t if we are in a filename line + (unless (and (eq hint t) ; we are in a filename line + (not (eq order-fun + 'tag-partial-file-name-match-p))) (let* ((file (file-of-tag)) (mark-key (cons file line))) (unless (gethash mark-key marks) (let ((loc (xref-make-etags-location tag-info (expand-file-name file)))) - (push (xref-make hint loc) xrefs) + (push (xref-make (if (eq hint t) pattern hint) loc) + xrefs) (puthash mark-key t marks))))))))))) (nreverse xrefs))) From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: Tags: wontfix -> patch References: In-Reply-To: Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jul 2019 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix To: control@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156319887021469 (code B ref 32510); Mon, 15 Jul 2019 13:55:01 +0000 Received: (at 32510) by debbugs.gnu.org; 15 Jul 2019 13:54:30 +0000 Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn1R0-0005aC-Dr for submit@debbugs.gnu.org; Mon, 15 Jul 2019 09:54:30 -0400 Received: from webmail.bookmyname.com ([88.191.249.153]:60836 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hn1Qx-0005Zz-Uo; Mon, 15 Jul 2019 09:54:29 -0400 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id 42BF8370EC; Mon, 15 Jul 2019 15:54:25 +0200 (CEST) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Mon, 15 Jul 2019 15:54:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Jul 2019 15:54:25 +0200 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32510 -wontfix patch thanks -- Ludovic Brenta. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too References: In-Reply-To: Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch wontfix To: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346162710837 (code B ref 32510); Thu, 18 Jul 2019 14:54:02 +0000 Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 14:53:47 +0000 Received: from localhost ([127.0.0.1]:54479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7n1-0002oh-4A for submit@debbugs.gnu.org; Thu, 18 Jul 2019 10:53:47 -0400 Received: from webmail.bookmyname.com ([88.191.249.153]:15076 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7my-0002oO-RE; Thu, 18 Jul 2019 10:53:45 -0400 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id C7474380B2; Thu, 18 Jul 2019 16:53:42 +0200 (CEST) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Thu, 18 Jul 2019 16:53:42 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 18 Jul 2019 16:53:42 +0200 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32510 - wontfix thanks I can confirm that the patch by Eli Zaretskii works, with a difference compared to find-tag: find-tag opens the first file whose name matches the searched string whereas xref-find-definitions opens a new buffer with all matches, forcing the user to use many keystrokes (or worse: reach for the mouse :)) to choose a match. I suppose this change of behavior is intentional, consistent with all other cross-references, and only affects ergonomy; the patch more importantly restores the functionality that was previously lost. -- Ludovic Brenta. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346300321485 (code B ref 32510); Thu, 18 Jul 2019 15:17:02 +0000 Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 15:16:43 +0000 Received: from localhost ([127.0.0.1]:54531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho89C-0005aS-JL for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:16:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho89A-0005aD-Ft for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 11:16:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ho893-0003Tx-PV; Thu, 18 Jul 2019 11:16:34 -0400 Received: from [176.228.60.248] (port=2493 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ho892-0007Av-H2; Thu, 18 Jul 2019 11:16:33 -0400 Date: Thu, 18 Jul 2019 18:16:23 +0300 Message-Id: <83a7dbweyg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Ludovic Brenta on Thu, 18 Jul 2019 16:53:42 +0200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 18 Jul 2019 16:53:42 +0200 > From: Ludovic Brenta > > I can confirm that the patch by Eli Zaretskii works, with a > difference compared to find-tag: find-tag opens the first > file whose name matches the searched string whereas > xref-find-definitions opens a new buffer with all matches, > forcing the user to use many keystrokes (or worse: reach > for the mouse :)) to choose a match. That's not what happened to me after the patch. For me, M-. just visited the one file whose name I typed. Can you show the exact sequence of commands you typed, preferably using the Emacs sources and corresponding TAGS tables and file names as the basis, so that I could repeat it here? > I suppose this change of behavior is intentional, consistent > with all other cross-references, and only affects ergonomy; > the patch more importantly restores the functionality that > was previously lost. I cannot tell whether it's intentional until I see the behavior you describe. What I can say is that if there's only one match, xref goes there automatically and immediately, but if there are several candidate matches, xref shows them and allows you to select the one(s) you want. The xref behavior is better when the match you want is not one of the first few, because find-tag required you to continuously type "C-u M-." in that case, and moreover do that blindly, since you had no idea how far away is your match. With xref you can select the match you are after without iterating through all the previous ones. However, I would expect the user to type the full file name in this use case, since that's what this feature is about: finding a file given its name. In that case, both commands behave almost identically. Dmitry, any comments on the patch? I admit I didn't study in detail the role of the PATTERN slot of the object generated by the function where I proposed to make the change, so perhaps I'm missing some use case where the patch will not DTRT? Thanks. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Ludovic Brenta Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346530325260 (code B ref 32510); Thu, 18 Jul 2019 15:56:02 +0000 Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 15:55:03 +0000 Received: from localhost ([127.0.0.1]:54560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8kJ-0006ZL-CY for submit@debbugs.gnu.org; Thu, 18 Jul 2019 11:55:03 -0400 Received: from webmail.bookmyname.com ([88.191.249.153]:28786 helo=webmail.free.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8kH-0006Yq-7o for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 11:55:02 -0400 Received: from 153.98.68.208 (unknown [127.0.1.3]) by webmail.free.org (Postfix) with ESMTP id A3C98380F1; Thu, 18 Jul 2019 17:54:59 +0200 (CEST) Received: from [153.98.68.208] by webmail.ludovic-brenta.org with HTTP (HTTP/1.1 POST); Thu, 18 Jul 2019 17:54:59 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Date: Thu, 18 Jul 2019 17:54:59 +0200 From: Ludovic Brenta In-Reply-To: <83a7dbweyg.fsf@gnu.org> References: <83a7dbweyg.fsf@gnu.org> Message-ID: X-Sender: ludovic@ludovic-brenta.org X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.ludovic-brenta.org X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 2019-07-18 17:16, Eli Zaretskii a =C3=A9crit=C2=A0: > [...] if there's only one match, xref goes > there automatically and immediately, but if there are several > candidate matches, xref shows them and allows you to select the one(s) > you want. Yes, this is exactly what happens. We have thousands of source files in our tree and most have names longer than 20 characters. Our normal usage pattern is to use partial matching. Also your patch uses tag-partial-file-name-match-p, not tag-full-file-name-match-p, so it's not surprising that it should do partial matching with possibly more than one match :) With etags we were used to using "C-u M-." a couple times too, or start over with a longer substring of the file name we wanted. I'm not complaining about this new behavior; it will just take a little getting used to. Personally I like the fact that M-g M-n works with the *xref* buffer like it does in a *compilation* buffer. --=20 Ludovic Brenta. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jul 2019 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156346608326998 (code B ref 32510); Thu, 18 Jul 2019 16:09:01 +0000 Received: (at 32510) by debbugs.gnu.org; 18 Jul 2019 16:08:03 +0000 Received: from localhost ([127.0.0.1]:54569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8wt-00071F-4u for submit@debbugs.gnu.org; Thu, 18 Jul 2019 12:08:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ho8wr-00070f-UR for 32510@debbugs.gnu.org; Thu, 18 Jul 2019 12:08:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ho8wm-0001AF-C7; Thu, 18 Jul 2019 12:07:56 -0400 Received: from [176.228.60.248] (port=1638 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ho8wl-0002X6-MK; Thu, 18 Jul 2019 12:07:56 -0400 Date: Thu, 18 Jul 2019 19:07:50 +0300 Message-Id: <8336j3wckp.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Ludovic Brenta on Thu, 18 Jul 2019 17:54:59 +0200) References: <83a7dbweyg.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 18 Jul 2019 17:54:59 +0200 > From: Ludovic Brenta > > Yes, this is exactly what happens. We have thousands of source files > in our tree and most have names longer than 20 characters. Our normal > usage pattern is to use partial matching. Also your patch uses > tag-partial-file-name-match-p, not tag-full-file-name-match-p, so > it's not surprising that it should do partial matching with possibly > more than one match :) > > With etags we were used to using "C-u M-." a couple times too, or > start over with a longer substring of the file name we wanted. > > I'm not complaining about this new behavior; it will just take a > little getting used to. Personally I like the fact that M-g M-n > works with the *xref* buffer like it does in a *compilation* buffer. OK, so I hope Dmitry will approve the change. Thanks. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Jul 2019 22:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ludovic Brenta , Eli Zaretskii Cc: "32510@debbugs.gnu.org" <32510@debbugs.gnu.org> Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.15635750221039 (code B ref 32510); Fri, 19 Jul 2019 22:24:01 +0000 Received: (at 32510) by debbugs.gnu.org; 19 Jul 2019 22:23:42 +0000 Received: from localhost ([127.0.0.1]:56625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hobHy-0000Gg-2n for submit@debbugs.gnu.org; Fri, 19 Jul 2019 18:23:42 -0400 Received: from forward500p.mail.yandex.net ([77.88.28.110]:50027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hobHv-0000GQ-JL for 32510@debbugs.gnu.org; Fri, 19 Jul 2019 18:23:40 -0400 Received: from mxback18g.mail.yandex.net (mxback18g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:318]) by forward500p.mail.yandex.net (Yandex) with ESMTP id 4BF459407EA; Sat, 20 Jul 2019 01:23:33 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback18g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id uFbDRZH4sC-NWRiJMsg; Sat, 20 Jul 2019 01:23:32 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1563575012; bh=peP2Jsyh3r6tgpzEtItTUqOUs97aPU/mn7IObWgpTtc=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=W9ldHZalHdSglueauSYZZ+LTAUlhnRKX7tXZcYYhHjw+Mbp3rVS0R1JRpVgd4M6Q3 taFgxR1c4rD0o5hEnqfpUQqYyiN6UpQZ22YJ5EY3Iv/U3GsZSf3GA/5s2WXhNw2kLT b4EPeTsHquWGct/nnD7jdFHC+8zuf5N6KxvFlUZQ= Authentication-Results: mxback18g.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by myt6-add70abb4f02.qloud-c.yandex.net with HTTP; Sat, 20 Jul 2019 01:23:32 +0300 From: Dmitry Gutov In-Reply-To: <83a7dbweyg.fsf@gnu.org> References: <83a7dbweyg.fsf@gnu.org> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 20 Jul 2019 01:23:32 +0300 Message-Id: <2120281563575012@myt6-add70abb4f02.qloud-c.yandex.net> Content-Transfer-Encoding: base64 Content-Type: text/html; charset=utf-8 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) SGkgRWxpLDxkaXY+PGJyIC8+PC9kaXY+PGRpdj5Tb3JyeSwgSSdtIG9uIGEgdmFjYXRpb24gaW4g dGhlIG5leHQgc2V2ZXJhbCBkYXlzLCBhbmQgYXdheSBmcm9tIG15IGNvbXB1dGVyLCBzbyBJIGNh bid0IHRlc3QgaXQuPC9kaXY+PGRpdj48YnIgLz48L2Rpdj48ZGl2PkJ1dCB0aGUgaWRlYSBiZWhp bmQgdGhlIHBhdGNoIHNlZW1zIHNvdW5kLCBhbmQgaWYgaXQgd29ya3MgZmluZSBmb3IgeW91IChp biBwYXJ0aWN1bGFyLCB3aXRoIHBhcnRpYWwgZmlsZSBuYW1lIGlucHV0cyksIGl0J3MgcHJvYmFi bHkgZ29vZC48L2Rpdj48ZGl2PjxiciAvPjwvZGl2PjE3OjE3LCBKdWx5IDE4LCAyMDE5LCBFbGkg WmFyZXRza2lpICZsdDtlbGl6QGdudS5vcmcmZ3Q7OjxiciAvPjxibG9ja3F1b3RlIGNsYXNzPSJi NGZkNWNmMmVjOTJiYzY4Y2I4OTg3MDBiYjgxMzU1ZndtaS1xdW90ZSI+PGJsb2NrcXVvdGUgY2xh c3M9ImI0ZmQ1Y2YyZWM5MmJjNjhjYjg5ODcwMGJiODEzNTVmd21pLXF1b3RlIj7CoERhdGU6IFRo dSwgMTggSnVsIDIwMTkgMTY6NTM6NDIgKzAyMDA8YnIgLz7CoEZyb206IEx1ZG92aWMgQnJlbnRh ICZsdDs8YSBocmVmPSJtYWlsdG86bHVkb3ZpY0BsdWRvdmljLWJyZW50YS5vcmciPmx1ZG92aWNA bHVkb3ZpYy1icmVudGEub3JnPC9hPiZndDs8YnIgLz48YnIgLz7CoEkgY2FuIGNvbmZpcm0gdGhh dCB0aGUgcGF0Y2ggYnkgRWxpIFphcmV0c2tpaSB3b3Jrcywgd2l0aCBhPGJyIC8+wqBkaWZmZXJl bmNlIGNvbXBhcmVkIHRvIGZpbmQtdGFnOiBmaW5kLXRhZyBvcGVucyB0aGUgZmlyc3Q8YnIgLz7C oGZpbGUgd2hvc2UgbmFtZSBtYXRjaGVzIHRoZSBzZWFyY2hlZCBzdHJpbmcgd2hlcmVhczxiciAv PsKgeHJlZi1maW5kLWRlZmluaXRpb25zIG9wZW5zIGEgbmV3IGJ1ZmZlciB3aXRoIGFsbCBtYXRj aGVzLDxiciAvPsKgZm9yY2luZyB0aGUgdXNlciB0byB1c2UgbWFueSBrZXlzdHJva2VzIChvciB3 b3JzZTogcmVhY2g8YnIgLz7CoGZvciB0aGUgbW91c2UgOikpIHRvIGNob29zZSBhIG1hdGNoLjxi ciAvPjwvYmxvY2txdW90ZT48cD48YnIgLz5UaGF0J3Mgbm90IHdoYXQgaGFwcGVuZWQgdG8gbWUg YWZ0ZXIgdGhlIHBhdGNoLiAgRm9yIG1lLCBNLS4ganVzdDxiciAvPnZpc2l0ZWQgdGhlIG9uZSBm aWxlIHdob3NlIG5hbWUgSSB0eXBlZC48YnIgLz48YnIgLz5DYW4geW91IHNob3cgdGhlIGV4YWN0 IHNlcXVlbmNlIG9mIGNvbW1hbmRzIHlvdSB0eXBlZCwgcHJlZmVyYWJseTxiciAvPnVzaW5nIHRo ZSBFbWFjcyBzb3VyY2VzIGFuZCBjb3JyZXNwb25kaW5nIFRBR1MgdGFibGVzIGFuZCBmaWxlIG5h bWVzPGJyIC8+YXMgdGhlIGJhc2lzLCBzbyB0aGF0IEkgY291bGQgcmVwZWF0IGl0IGhlcmU/PGJy IC8+PGJyIC8+PC9wPjxibG9ja3F1b3RlIGNsYXNzPSJiNGZkNWNmMmVjOTJiYzY4Y2I4OTg3MDBi YjgxMzU1ZndtaS1xdW90ZSI+wqBJIHN1cHBvc2UgdGhpcyBjaGFuZ2Ugb2YgYmVoYXZpb3IgaXMg aW50ZW50aW9uYWwsIGNvbnNpc3RlbnQ8YnIgLz7CoHdpdGggYWxsIG90aGVyIGNyb3NzLXJlZmVy ZW5jZXMsIGFuZCBvbmx5IGFmZmVjdHMgZXJnb25vbXk7PGJyIC8+wqB0aGUgcGF0Y2ggbW9yZSBp bXBvcnRhbnRseSByZXN0b3JlcyB0aGUgZnVuY3Rpb25hbGl0eSB0aGF0PGJyIC8+wqB3YXMgcHJl dmlvdXNseSBsb3N0LjxiciAvPjwvYmxvY2txdW90ZT48cD48YnIgLz5JIGNhbm5vdCB0ZWxsIHdo ZXRoZXIgaXQncyBpbnRlbnRpb25hbCB1bnRpbCBJIHNlZSB0aGUgYmVoYXZpb3IgeW91PGJyIC8+ ZGVzY3JpYmUuICBXaGF0IEkgY2FuIHNheSBpcyB0aGF0IGlmIHRoZXJlJ3Mgb25seSBvbmUgbWF0 Y2gsIHhyZWYgZ29lczxiciAvPnRoZXJlIGF1dG9tYXRpY2FsbHkgYW5kIGltbWVkaWF0ZWx5LCBi dXQgaWYgdGhlcmUgYXJlIHNldmVyYWw8YnIgLz5jYW5kaWRhdGUgbWF0Y2hlcywgeHJlZiBzaG93 cyB0aGVtIGFuZCBhbGxvd3MgeW91IHRvIHNlbGVjdCB0aGUgb25lKHMpPGJyIC8+eW91IHdhbnQu ICBUaGUgeHJlZiBiZWhhdmlvciBpcyBiZXR0ZXIgd2hlbiB0aGUgbWF0Y2ggeW91IHdhbnQgaXMg bm90PGJyIC8+b25lIG9mIHRoZSBmaXJzdCBmZXcsIGJlY2F1c2UgZmluZC10YWcgcmVxdWlyZWQg eW91IHRvIGNvbnRpbnVvdXNseTxiciAvPnR5cGUgIkMtdSBNLS4iIGluIHRoYXQgY2FzZSwgYW5k IG1vcmVvdmVyIGRvIHRoYXQgYmxpbmRseSwgc2luY2UgeW91PGJyIC8+aGFkIG5vIGlkZWEgaG93 IGZhciBhd2F5IGlzIHlvdXIgbWF0Y2guICBXaXRoIHhyZWYgeW91IGNhbiBzZWxlY3QgdGhlPGJy IC8+bWF0Y2ggeW91IGFyZSBhZnRlciB3aXRob3V0IGl0ZXJhdGluZyB0aHJvdWdoIGFsbCB0aGUg cHJldmlvdXMgb25lcy48YnIgLz48YnIgLz5Ib3dldmVyLCBJIHdvdWxkIGV4cGVjdCB0aGUgdXNl ciB0byB0eXBlIHRoZSBmdWxsIGZpbGUgbmFtZSBpbiB0aGlzPGJyIC8+dXNlIGNhc2UsIHNpbmNl IHRoYXQncyB3aGF0IHRoaXMgZmVhdHVyZSBpcyBhYm91dDogZmluZGluZyBhIGZpbGU8YnIgLz5n aXZlbiBpdHMgbmFtZS4gIEluIHRoYXQgY2FzZSwgYm90aCBjb21tYW5kcyBiZWhhdmUgYWxtb3N0 PGJyIC8+aWRlbnRpY2FsbHkuPGJyIC8+PGJyIC8+RG1pdHJ5LCBhbnkgY29tbWVudHMgb24gdGhl IHBhdGNoPyAgSSBhZG1pdCBJIGRpZG4ndCBzdHVkeSBpbiBkZXRhaWw8YnIgLz50aGUgcm9sZSBv ZiB0aGUgUEFUVEVSTiBzbG90IG9mIHRoZSBvYmplY3QgZ2VuZXJhdGVkIGJ5IHRoZSBmdW5jdGlv bjxiciAvPndoZXJlIEkgcHJvcG9zZWQgdG8gbWFrZSB0aGUgY2hhbmdlLCBzbyBwZXJoYXBzIEkn bSBtaXNzaW5nIHNvbWUgdXNlPGJyIC8+Y2FzZSB3aGVyZSB0aGUgcGF0Y2ggd2lsbCBub3QgRFRS VD88YnIgLz48YnIgLz5UaGFua3MuPGJyIC8+PGJyIC8+PGJyIC8+PGJyIC8+PC9wPjwvYmxvY2tx dW90ZT48YnIgLz48YnIgLz4tLSBEbWl0cnkgR3V0b3Y= From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: xref-find-definitions should return file names, too Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jul 2019 07:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: 32510@debbugs.gnu.org, ludovic@ludovic-brenta.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156360707126890 (code B ref 32510); Sat, 20 Jul 2019 07:18:01 +0000 Received: (at 32510) by debbugs.gnu.org; 20 Jul 2019 07:17:51 +0000 Received: from localhost ([127.0.0.1]:56774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hojct-0006ze-D6 for submit@debbugs.gnu.org; Sat, 20 Jul 2019 03:17:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hojcq-0006zQ-2n for 32510@debbugs.gnu.org; Sat, 20 Jul 2019 03:17:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hojck-00035x-8I; Sat, 20 Jul 2019 03:17:42 -0400 Received: from [176.228.60.248] (port=1921 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hojcj-0005yr-8W; Sat, 20 Jul 2019 03:17:41 -0400 Date: Sat, 20 Jul 2019 10:17:38 +0300 Message-Id: <83sgr1tbsd.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <2120281563575012@myt6-add70abb4f02.qloud-c.yandex.net> (message from Dmitry Gutov on Sat, 20 Jul 2019 01:23:32 +0300) References: <83a7dbweyg.fsf@gnu.org> <2120281563575012@myt6-add70abb4f02.qloud-c.yandex.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Cc: "32510@debbugs.gnu.org" <32510@debbugs.gnu.org> > Date: Sat, 20 Jul 2019 01:23:32 +0300 > > Sorry, I'm on a vacation in the next several days, and away from my computer, so I can't test it. > > But the idea behind the patch seems sound, and if it works fine for you (in particular, with partial file name > inputs), it's probably good. Thanks. I prefer to wait for you to review the code when you have time. From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: acknowledged by developer (control message for bug #32510) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 00:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.15644451911928 (code B ref 32510); Tue, 30 Jul 2019 00:07:02 +0000 Received: (at 32510) by debbugs.gnu.org; 30 Jul 2019 00:06:31 +0000 Received: from localhost ([127.0.0.1]:49342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsFew-0000V2-HG for submit@debbugs.gnu.org; Mon, 29 Jul 2019 20:06:30 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:45815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsFeu-0000Uo-5L for 32510@debbugs.gnu.org; Mon, 29 Jul 2019 20:06:28 -0400 Received: by mail-wr1-f42.google.com with SMTP id f9so63685146wre.12 for <32510@debbugs.gnu.org>; Mon, 29 Jul 2019 17:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PC/CJxN0t2ELBqaJkWqtam0wsQG2yLB2HEl5IGDId58=; b=GfdyY+4904U5WqrdgdGjGOuIeI5eWhINWbwbAYgfEXMuF1cJF5Lq8nD7RC3baSaWr2 gdrzW5b0/B4ydlGUt0UmKYA1ADHOl+KwCk80vPuIrpzxCc6MDcbVbEpNOyrWkBbGcE58 +Q6aul9dbGyraOvlK5rlqTblrk6JExTn7GYDmtZeScUIq3NnbFkvTFQqGLeIGIhjU7Rc lXsKWk63YpFZN1nPEq1sPbTj8KIwG/LPUFEK4hHXtRWydaYOAiCn2y7jjdnwb5EtGVl4 ru6A6aF8BodO4xSJkywWIWI9eii4OwDZc+v9rc4gS0LyGpp9ZWwUkaTqdPgqdGnD3g7N tC7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PC/CJxN0t2ELBqaJkWqtam0wsQG2yLB2HEl5IGDId58=; b=W0XoI/5As3rvRIOygF+HabCGIlZqVwXFfV7/SMwokjekzptznvV7BvbgSdk5fw+Tnp zLUoT2wKR/t7rZGBKEOa12FlF3jaWKjx5P2F0B2V+Oop9HMkh8phvDaoxYo9bwOO8oGA vRwiPYIDquZVZp50jMvW2Bd2qR3JqEXVMu0Xdp1ekRmt1tFqoUQfTVc98SfoIBYcXYAh 95DPaVZXg3ehFC13nad8cHxVmn+lmQr940SZ0EKKSI6k/AEPJdtqLEDGMv5M4lFbKW1x ugW9qxngunOYwaz8cEQMQzax18Upyflenw3hSySEvtIfURql1ayCtL+fPzgiypJ/J84J wsgQ== X-Gm-Message-State: APjAAAVO5cPP7fbg2il8NZc4S5EXUXq5lCrG5JcBnKhUQKWIGJujeIuj nuwqhh2oElonyQjP1ObQ8SQYEK5vLMU= X-Google-Smtp-Source: APXvYqy7ZO6IRaVFVUg8fYOujEay+/R+3YK7MXA3Wpi+hi3UyaSgiqf+Ccg03CXHMed+rY3ZMv796g== X-Received: by 2002:adf:e541:: with SMTP id z1mr31970574wrm.48.1564445182133; Mon, 29 Jul 2019 17:06:22 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id v65sm69451178wme.31.2019.07.29.17.06.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jul 2019 17:06:21 -0700 (PDT) References: <87ftnazlz3.fsf@mouse.gnus.org> <87o91xwwxp.fsf@samuel> <83k1clyywc.fsf@gnu.org> From: Dmitry Gutov Message-ID: <77c6d179-4499-4a99-db58-b0c7c2cee2f5@yandex.ru> Date: Tue, 30 Jul 2019 03:06:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <83k1clyywc.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 14.07.2019 8:21, Eli Zaretskii wrote: >> From: Ludovic Brenta >> Date: Sat, 13 Jul 2019 21:34:26 +0200 >> >> This bug report states that a useful functionality of find-tag is *not* >> provided by its official replacement, xref-find-definitions. This is a >> regression. Just because you think this missing functionality should be >> provided elsewhere is not a good reason to close this bug without >> providing any solution. > > With the patch below, you should be able to have what you want if you > add tag-partial-file-name-match-p to the list in Finally got around to reviewing it... > diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el > index 7bf5753..b092c63 100644 > --- a/lisp/progmodes/etags.el > +++ b/lisp/progmodes/etags.el > @@ -2070,13 +2070,16 @@ etags--xref-find-definitions > (beginning-of-line) > (pcase-let* ((tag-info (etags-snarf-tag)) > (`(,hint ,line . _) tag-info)) > - (unless (eq hint t) ; hint==t if we are in a filename line > + (unless (and (eq hint t) ; we are in a filename line > + (not (eq order-fun > + 'tag-partial-file-name-match-p))) First, I was thinking we shouldn't check for the exact order-fun value (because others could be used, too) and replace it with something like (save-excursion (forward-line 0) (forward-char -2) (not (looking-at "\f\n"))) But then, I'm not sure why that check is there in the first place (the order functions make sure not to match the wrong like). Maybe because the code inside couldn't handle hint=t? So if it does now, the (unless ...) conditional can be removed. > (let* ((file (file-of-tag)) > (mark-key (cons file line))) > (unless (gethash mark-key marks) > (let ((loc (xref-make-etags-location > tag-info (expand-file-name file)))) > - (push (xref-make hint loc) xrefs) > + (push (xref-make (if (eq hint t) pattern hint) loc) > + xrefs) I'm not sure using pattern as a hint works well. How about we say something like "(file name match)" instead? Or you could pick a better wording. The full proposed patch is below. I see that it doesn't work exactly perfectly, e.g. moving point within the quotes in #include "composite.h" and pressing M-. brings up three matches (composite.c, composite.h and composite.el), whereas only one of them is correct, but find-tag probably has the same problem anyway. Maybe CC Mode should set up find-tag-default-function to return the full file name when inside #include statements. diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index 7bf575340e..a052ad2ce5 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -2070,14 +2070,15 @@ etags--xref-find-definitions (beginning-of-line) (pcase-let* ((tag-info (etags-snarf-tag)) (`(,hint ,line . _) tag-info)) - (unless (eq hint t) ; hint==t if we are in a filename line - (let* ((file (file-of-tag)) - (mark-key (cons file line))) - (unless (gethash mark-key marks) - (let ((loc (xref-make-etags-location - tag-info (expand-file-name file)))) - (push (xref-make hint loc) xrefs) - (puthash mark-key t marks))))))))))) + (let* ((file (file-of-tag)) + (mark-key (cons file line))) + (unless (gethash mark-key marks) + (let ((loc (xref-make-etags-location + tag-info (expand-file-name file)))) + (push (xref-make (if (eq hint t) "(filename match)" hint) + loc) + xrefs) + (puthash mark-key t marks)))))))))) (nreverse xrefs))) (defclass xref-etags-location (xref-location) From unknown Fri Aug 15 15:33:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32510: acknowledged by developer (control message for bug #32510) Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32510 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Ludovic Brenta Cc: 32510@debbugs.gnu.org Received: via spool by 32510-submit@debbugs.gnu.org id=B32510.156449523926180 (code B ref 32510); Tue, 30 Jul 2019 14:01:02 +0000 Received: (at 32510) by debbugs.gnu.org; 30 Jul 2019 14:00:39 +0000 Received: from localhost ([127.0.0.1]:50957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsSgB-0006oC-1T for submit@debbugs.gnu.org; Tue, 30 Jul 2019 10:00:39 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:38191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsSgA-0006o1-0y for 32510@debbugs.gnu.org; Tue, 30 Jul 2019 10:00:38 -0400 Received: by mail-wr1-f54.google.com with SMTP id g17so65913937wrr.5 for <32510@debbugs.gnu.org>; Tue, 30 Jul 2019 07:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NH9+CVpnDPJ5R2PnC0dPB2M8h+TWcwvRlD7eTWZwz8Y=; b=BbJtssC3Hr1j3m+URiekdW/mcp3yMOd0evcCKoa/Ttq43RbyveJful+pQmMykH09qu qnlH2elyOZQNqOmL6hk9u/zrzjYxgcEwUbXcT75BfAqKYL1EuH2XqaEd8Tkm2nGDOzZU GdAQNGSQIJkn9b5Uo8TfoayG0EbCZ4c9p2zxfJG/OdvyGKjpS5xHM76rb0V6NBDjZEuP SOTcw0Z0tPaNk+oLeqIMlr9nVEYfA26ODAdGTjk2hJXzVzuL/G0Hkq/hyoWoXBirDGQQ 9F7qa85TeQSFKm5GwhiRgOF5EDs1ND3dhVGo/jDWjfb8FXNVsqYpZhTMiUF9hodckJPD cAhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=NH9+CVpnDPJ5R2PnC0dPB2M8h+TWcwvRlD7eTWZwz8Y=; b=gmzOnBNsc7sVF/jdiD56mzXQM+4CJv0HmgXippZhDnCy323oZzrVeegykp5Iyxm76r tEj2wpLmZjhWZCwEtKXjiQOTFhkDp/UMAeVkB30YNRNER/IoHVhu1SK2Ym4ngi4gJvIo +CXkWHDORu3yc+SzzZ98CUnbaHUyTizpbFBmwlqovuD9iEL2RMz9+0Zo5EPmz0ANH5Ux 1ZBhi300ZU/ZEnGM8PbXjDHsHPJQi5LTX9tHvXe1u7wstGFqiL1WZCr7mKV5DW7Q/REx QI4fazt/aervg8NY52NNdgzEZmsDytiR9BBf7nT0A4Cex+QXwg9IRBcWZlCLbiLdCqME iGSA== X-Gm-Message-State: APjAAAVJuTN472rAgkOex5iRf2p3IsVy2QAf99edwiXNnZwD6N24QcJV mSjHg8a0LugNnQ3LWeq2+7hPIlhmcdM= X-Google-Smtp-Source: APXvYqySMC5zzYAjya3h1yiHf8Pzk4vtIpwo+7DLRPRJWA1GsVrTo4sok5s1MZ5CPpd8kThoWkpDXw== X-Received: by 2002:adf:b64e:: with SMTP id i14mr116669781wre.248.1564495231867; Tue, 30 Jul 2019 07:00:31 -0700 (PDT) Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id z25sm67875171wmf.38.2019.07.30.07.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 07:00:29 -0700 (PDT) From: Dmitry Gutov References: <87ftnazlz3.fsf@mouse.gnus.org> <87o91xwwxp.fsf@samuel> <83k1clyywc.fsf@gnu.org> <77c6d179-4499-4a99-db58-b0c7c2cee2f5@yandex.ru> Message-ID: <921a86e3-82a2-d26a-dcb8-dca01a199e02@yandex.ru> Date: Tue, 30 Jul 2019 17:00:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <77c6d179-4499-4a99-db58-b0c7c2cee2f5@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 30.07.2019 3:06, Dmitry Gutov wrote: > The full proposed patch is below. I've pushed that change now to master. Please try it out. From unknown Fri Aug 15 15:33:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic Brenta Subject: bug#32510: closed (Re: bug#32510: acknowledged by developer (control message for bug #32510)) Message-ID: References: <83o916efgb.fsf@gnu.org> X-Gnu-PR-Message: they-closed 32510 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 32510@debbugs.gnu.org Date: Sat, 03 Aug 2019 10:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1564826462-11638-1" This is a multi-part message in MIME format... ------------=_1564826462-11638-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32510: xref-find-definitions should return file names, too which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32510@debbugs.gnu.org. --=20 32510: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32510 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1564826462-11638-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32510-done) by debbugs.gnu.org; 3 Aug 2019 10:00:55 +0000 Received: from localhost ([127.0.0.1]:58297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htqqL-00031G-KJ for submit@debbugs.gnu.org; Sat, 03 Aug 2019 06:00:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htqqJ-000314-3N for 32510-done@debbugs.gnu.org; Sat, 03 Aug 2019 06:00:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htqqD-0005Xy-3Z; Sat, 03 Aug 2019 06:00:45 -0400 Received: from [176.228.60.248] (port=3739 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1htqqC-0004V0-K9; Sat, 03 Aug 2019 06:00:44 -0400 Date: Sat, 03 Aug 2019 13:00:36 +0300 Message-Id: <83o916efgb.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <921a86e3-82a2-d26a-dcb8-dca01a199e02@yandex.ru> (message from Dmitry Gutov on Tue, 30 Jul 2019 17:00:28 +0300) Subject: Re: bug#32510: acknowledged by developer (control message for bug #32510) References: <87ftnazlz3.fsf@mouse.gnus.org> <87o91xwwxp.fsf@samuel> <83k1clyywc.fsf@gnu.org> <77c6d179-4499-4a99-db58-b0c7c2cee2f5@yandex.ru> <921a86e3-82a2-d26a-dcb8-dca01a199e02@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32510-done Cc: 32510-done@debbugs.gnu.org, ludovic@ludovic-brenta.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Dmitry Gutov > Cc: 32510@debbugs.gnu.org > Date: Tue, 30 Jul 2019 17:00:28 +0300 > > On 30.07.2019 3:06, Dmitry Gutov wrote: > > The full proposed patch is below. > > I've pushed that change now to master. Please try it out. Thanks, it LGTM, so I'm closing the bug. ------------=_1564826462-11638-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Aug 2018 15:32:41 +0000 Received: from localhost ([127.0.0.1]:59012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsrbF-0007Qe-K5 for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsrbD-0007QR-AL for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsrb6-0007jI-Lj for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fsrb6-0007j2-FA for submit@debbugs.gnu.org; Thu, 23 Aug 2018 11:32:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsrb1-0003ps-Rc for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsray-0007eA-No for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:27 -0400 Received: from rmap1.bookmyname.com ([88.191.249.149]:54001 helo=webmail.free.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsray-0007cU-G5 for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 11:32:24 -0400 Received: by webmail.free.org (Postfix, from userid 5000) id 10555507A558; Thu, 23 Aug 2018 17:32:22 +0200 (CEST) To: Subject: xref-find-definitions should return file names, too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 23 Aug 2018 16:32:21 +0100 From: Ludovic Brenta Message-ID: X-Sender: ludovic@ludovic-brenta.org User-Agent: Roundcube Webmail/0.5.3 X-Complaints-To: abuse_at_bookmyname.com X-Abuse-Info: Please be sure to forward a copy of ALL headers X-Origin-Web-Site: webmail.bookmyname.com X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Package: emacs Version: 26.1 Severity: wishlist Hello, It would be nice if xref-find-definitions returned files in addition to language-specific "definitions". For example: M-. foo-bar.adb RET should open the file foo-bar.adb (wherever it is in the potentially complex directory structure of the project) and leave point at the beginning of the file. This is a feature of find-tag but find-tag is now deprecated in favor of xref-find-definitions; so this feature is missing and xref-find-definitions is not yet a complete replacement for find-tag. Thanks for consideration. -- Ludovic Brenta. ------------=_1564826462-11638-1--