GNU bug report logs - #32504
[PATCH] syntax-is-{comment|string}-p

Previous Next

Package: emacs;

Reported by: Alex Branham <alex.branham <at> gmail.com>

Date: Wed, 22 Aug 2018 20:20:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #51 received at 32504 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 32504 <at> debbugs.gnu.org
Subject: Re: bug#32504: [PATCH] syntax-is-{comment|string}-p
Date: Mon, 08 Jul 2019 20:05:15 -0400
[Message part 1 (text/plain, inline)]
Alex Branham <alex.branham <at> gmail.com> writes:

> On Thu 30 Aug 2018 at 20:21, Noam Postavsky <npostavs <at> gmail.com> wrote:
>
>>> I'm not a big fan of the docstrings generated by this, is there a way to
>>> change them to be more helpful?
>>
>> Hmm, doesn't look like it.  Well, that's just a convenient way of
>> defining them all quickly for discussion, it wouldn't be that much
>> harder to write out defuns I guess.
>
> Fair enough.

The recent talk about accessors for decoded time reminded me of this.
Here's an initial patch.

[0001-Add-named-accessors-for-syntax-ppss-state-Bug-32504.patch (text/plain, attachment)]
[Message part 3 (text/plain, inline)]
>>> CL-X defaults to point.
>>
>> And, my intention is to operate on the return value of syntax-ppss, not
>> give a point to call it with.
>
> Right, but whenever I want to call on these functions, 90% of the time
> the question I'm trying to answer is "Is point in a comment/string?" And
> the 3rd party ***-is-comment/string-p functions I've looked at usually
> (always?) look at positions.

Well, for me I just want to stop having to look up the docstring of
parse-partial-sexp every damn time I see (nth X PPSS).  But I wouldn't
be against having syntax-is-comment/string-p which take a position as
well.

This bug report was last modified 5 years and 314 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.