GNU bug report logs - #32485
27.0.50; Problem with zerop on 32-bit platforms

Previous Next

Full log

Message #19 received at 32485-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 32485-done <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton <at> gmail.com>
Subject: Re: bug#32485: 27.0.50; Problem with zerop on 32-bit platforms
Date: Tue, 21 Aug 2018 13:54:11 -0700

[Message part 1 (text/plain, inline)]

> vc-hg-state-fast might still need 
> attention.  Currently (zerop (lsh -1 32)) returns nil on all platforms, 
> so it's useless; but that might change

This prompted me to audit the uses of lsh in the Emacs source code. I found and 
fixed a few glitches by installing the attached patch; in particular it fixes 
vg-hg-state-fast by using ash instead, as ash's semantics are clear and not 
subject to change. This patch goes further in this direction by replacing lsh 
with ash when either will do.

As this fixes the remaining problems mentioned in this bug report, I'm boldly 
closing the report.

[0001-Audit-use-of-lsh-and-fix-glitches.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.