GNU bug report logs - #32483
[PATCH] import: stackage: Support recursive importing.

Previous Next

Package: guix-patches;

Reported by: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>

Date: Mon, 20 Aug 2018 15:59:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 32483 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: 32483 <at> debbugs.gnu.org
Subject: Re: [bug#32483] [PATCH] import: stackage: Support recursive importing.
Date: Thu, 23 Aug 2018 17:03:02 +0200

Hello!

Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> skribis:

> * guix/import/hackage.scm (hackage-name->package-name): Export procedure.
> * guix/import/stackage.scm (lts-info-packages-lts-info): Fix match expression.
> (stackage-recursive-import): New procedure.
> (stackage->guix-package): Memoize results.
> * guix/scripts/import/stackage.scm (show-help, %options,
> guix-import-stackage): Support recursive importing.
> * doc/guix.texi (Invoking guix import): Document option.

Could you add a test for recursive imports, similar to what Oleg did in
tests/gem.scm?  Or perhaps that’d be redundant since it does little more
than call ‘recursive-import’ from (guix import utils)?  (And I realize
tests/elpa.scm doesn’t have recursive import tests.)

Anyway, apart from that it LGTM.  Thanks!

Ludo’.
This bug report was last modified 6 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.