GNU bug report logs - #32479
Fix tracking of freed emacs_values with enabled --module-assertions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32479 in the body.
You can then email your comments to 32479 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergey Vinokurov <serg.foo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix tracking of freed emacs_values with enabled --module-assertions
Date: Mon, 20 Aug 2018 09:27:46 +0100

[Message part 1 (text/plain, inline)]

Hi,

I was developing a dynamic module when I noticed that when
'--module-assertions' are enabled I got strange complaints regarding
value to be freed. Namely, Emacs was producing an error message like the
following one:

    Emacs module assertion: Global value was not found in list of 10 globals

I tracked it down to a bug in module_free_global_ref. It's traversal of
the linked list of all allocated global values was flawed and only
considered the head of the list. Please find attached my attempt at
fixing it and a test in Emacs test suite that reproduces the issue.

Regards,
Sergey

[0001-Fix-detection-of-freed-emacs_values.patch (text/x-patch, attachment)]

Message #8 received at 32479 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Sergey Vinokurov <serg.foo <at> gmail.com>
Cc: 32479 <at> debbugs.gnu.org
Subject: Re: bug#32479: Fix tracking of freed emacs_values with enabled
 --module-assertions
Date: Sat, 25 Aug 2018 19:03:02 -0400

tags 32479 fixed
close 32479 26.2
quit

Sergey Vinokurov <serg.foo <at> gmail.com> writes:

> I was developing a dynamic module when I noticed that when
> '--module-assertions' are enabled I got strange complaints regarding
> value to be freed. Namely, Emacs was producing an error message like the
> following one:
>
>     Emacs module assertion: Global value was not found in list of 10 globals
>
> I tracked it down to a bug in module_free_global_ref. It's traversal of
> the linked list of all allocated global values was flawed and only
> considered the head of the list. Please find attached my attempt at
> fixing it and a test in Emacs test suite that reproduces the issue.

Thanks, pushed to emacs-26.

P.S. Don't forget to end sentences with a period in the body of the
commit message.

[1: 54fb383af6]: 2018-08-25 18:57:56 -0400
  Fix detection of freed emacs_values (Bug#32479)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=54fb383af6f6af7b72c28f38b308d9b24d2af4f6

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.