From unknown Tue Sep 09 22:28:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32475: 27.0.50; Multiple log-view-mode buffers Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Aug 2018 21:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32475 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 32475@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153471537215304 (code B ref -1); Sun, 19 Aug 2018 21:50:03 +0000 Received: (at submit) by debbugs.gnu.org; 19 Aug 2018 21:49:32 +0000 Received: from localhost ([127.0.0.1]:54878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZj-0003yi-QU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZh-0003yN-KN for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZb-00027n-SU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZb-00027i-Pk for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frVZb-00023e-20 for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZa-00026k-3x for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from homie-sub3.mail.dreamhost.com ([69.163.253.7]:46242 helo=homiemail-a22.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZZ-00026J-UO for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:22 -0400 Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id DCD7F114066 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) Received: from localhost.linkov.net (m91-129-110-6.cust.tele2.ee [91.129.110.6]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPSA id 41977114065 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) From: Juri Linkov Organization: LINKOV.NET Date: Mon, 20 Aug 2018 00:31:50 +0300 Message-ID: <87pnye9gpt.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=-=-= Content-Type: text/plain To support the ability to create multiple *vc-change-log* buffers with customization like (add-hook 'log-view-mode-hook 'rename-uniquely) vc-log-internal-common needs an improvement to remember and reuse the buffer object, instead of searching the same buffer by name: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-log-internal-common.1.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index b2bedfae93..487594b2d5 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2268,11 +2268,11 @@ vc-log-internal-common setup-buttons-func goto-location-func rev-buff-func) - (let (retval) - (with-current-buffer (get-buffer-create buffer-name) + (let (retval (buffer (get-buffer-create buffer-name))) + (with-current-buffer buffer (set (make-local-variable 'vc-log-view-type) type)) (setq retval (funcall backend-func backend buffer-name type files)) - (with-current-buffer (get-buffer buffer-name) + (with-current-buffer buffer (let ((inhibit-read-only t)) ;; log-view-mode used to be called with inhibit-read-only bound ;; to t, so let's keep doing it, just in case. @@ -2283,7 +2283,7 @@ vc-log-internal-common rev-buff-func))) ;; Display after setting up major-mode, so display-buffer-alist can know ;; the major-mode. - (pop-to-buffer buffer-name) + (pop-to-buffer buffer) (vc-run-delayed (let ((inhibit-read-only t)) (funcall setup-buttons-func backend files retval) --=-=-=-- From unknown Tue Sep 09 22:28:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#32475: closed (Re: bug#32475: 27.0.50; Multiple log-view-mode buffers) Message-ID: References: <87o9dj339f.fsf@mail.linkov.net> <87pnye9gpt.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 32475 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 32475@debbugs.gnu.org Date: Thu, 30 Aug 2018 22:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1535667722-24922-1" This is a multi-part message in MIME format... ------------=_1535667722-24922-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32475: 27.0.50; Multiple log-view-mode buffers which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32475@debbugs.gnu.org. --=20 32475: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32475 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1535667722-24922-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32475-done) by debbugs.gnu.org; 30 Aug 2018 22:21:09 +0000 Received: from localhost ([127.0.0.1]:39554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvVJM-0006Sm-S5 for submit@debbugs.gnu.org; Thu, 30 Aug 2018 18:21:09 -0400 Received: from pop.dreamhost.com ([64.90.62.162]:39460 helo=pdx1-sub0-mail-a11.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fvVJM-0006Sf-9I for 32475-done@debbugs.gnu.org; Thu, 30 Aug 2018 18:21:08 -0400 Received: from pdx1-sub0-mail-a11.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a11.g.dreamhost.com (Postfix) with ESMTP id 710587FEDE for <32475-done@debbugs.gnu.org>; Thu, 30 Aug 2018 15:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Kib0alJATGDC6dvuWDvorD8gLWY=; b= Q5p9D7gS6Vpk6Qbk5/IOvl4pbRkyE47a5THK++7UCnlkFMh8pLi7MIYSBQ0vAIwi jIwt4yCZeyzJjEZJVw/faAZe52dniiRkqshY+yB7/FZpF8i+Sve/MZTir71dOBEN dBaTNCANDjIH1K2RO+RzOKrCeMx6c4nNymuYXRsP89g= Received: from localhost.linkov.net (m91-129-99-146.cust.tele2.ee [91.129.99.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a11.g.dreamhost.com (Postfix) with ESMTPSA id BAC467FF0B for <32475-done@debbugs.gnu.org>; Thu, 30 Aug 2018 15:21:06 -0700 (PDT) From: Juri Linkov To: 32475-done@debbugs.gnu.org Subject: Re: bug#32475: 27.0.50; Multiple log-view-mode buffers Organization: LINKOV.NET References: <87pnye9gpt.fsf@mail.linkov.net> Date: Fri, 31 Aug 2018 01:20:44 +0300 In-Reply-To: <87pnye9gpt.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 20 Aug 2018 00:31:50 +0300") Message-ID: <87o9dj339f.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32475-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > To support the ability to create multiple *vc-change-log* buffers > with customization like > > (add-hook 'log-view-mode-hook 'rename-uniquely) > > vc-log-internal-common needs an improvement to remember and reuse > the buffer object, instead of searching the same buffer by name: Done in 15006cf1dd. ------------=_1535667722-24922-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Aug 2018 21:49:32 +0000 Received: from localhost ([127.0.0.1]:54878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZj-0003yi-QU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVZh-0003yN-KN for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZb-00027n-SU for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZb-00027i-Pk for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frVZb-00023e-20 for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frVZa-00026k-3x for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:23 -0400 Received: from homie-sub3.mail.dreamhost.com ([69.163.253.7]:46242 helo=homiemail-a22.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1frVZZ-00026J-UO for bug-gnu-emacs@gnu.org; Sun, 19 Aug 2018 17:49:22 -0400 Received: from homiemail-a22.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTP id DCD7F114066 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) Received: from localhost.linkov.net (m91-129-110-6.cust.tele2.ee [91.129.110.6]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by homiemail-a22.g.dreamhost.com (Postfix) with ESMTPSA id 41977114065 for ; Sun, 19 Aug 2018 14:49:20 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Multiple log-view-mode buffers Organization: LINKOV.NET Date: Mon, 20 Aug 2018 00:31:50 +0300 Message-ID: <87pnye9gpt.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --=-=-= Content-Type: text/plain To support the ability to create multiple *vc-change-log* buffers with customization like (add-hook 'log-view-mode-hook 'rename-uniquely) vc-log-internal-common needs an improvement to remember and reuse the buffer object, instead of searching the same buffer by name: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-log-internal-common.1.patch diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index b2bedfae93..487594b2d5 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2268,11 +2268,11 @@ vc-log-internal-common setup-buttons-func goto-location-func rev-buff-func) - (let (retval) - (with-current-buffer (get-buffer-create buffer-name) + (let (retval (buffer (get-buffer-create buffer-name))) + (with-current-buffer buffer (set (make-local-variable 'vc-log-view-type) type)) (setq retval (funcall backend-func backend buffer-name type files)) - (with-current-buffer (get-buffer buffer-name) + (with-current-buffer buffer (let ((inhibit-read-only t)) ;; log-view-mode used to be called with inhibit-read-only bound ;; to t, so let's keep doing it, just in case. @@ -2283,7 +2283,7 @@ vc-log-internal-common rev-buff-func))) ;; Display after setting up major-mode, so display-buffer-alist can know ;; the major-mode. - (pop-to-buffer buffer-name) + (pop-to-buffer buffer) (vc-run-delayed (let ((inhibit-read-only t)) (funcall setup-buttons-func backend files retval) --=-=-=-- ------------=_1535667722-24922-1--