GNU bug report logs - #32470
rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 32470 <at> debbugs.gnu.org
Subject: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F
Date: Fri, 14 Sep 2018 08:22:23 -0400

Ivan Shmakov <ivan <at> siamics.net> writes:

> 	I’m somewhat unsure if this change is NEWS-worthy; if so,
> 	I suggest the following entry.

The behaviour of debug tracing functions is somewhat in the gray area
between user visible and internal details, but I'd say there's no need
to update NEWS for this.

> -      (goto-char (point-max))
> -      (insert (concat
> -	       "["
> -	       (format-time-string "%Y-%m-%dT%T ") (process-name process)
> -	       "] "
> -	       text)))))
> +      (let ((old (set-marker (make-marker) (point))))

You could use (point-marker) instead.

> +        (set-marker-insertion-type old t)
> +        (goto-char (point-max))
> +        (let ((inhibit-read-only t))
> +          (terpri (current-buffer) t)

This looks like you're adding an extra newline, or was there a lack of
newlines before?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.