GNU bug report logs - #32470
rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F

Previous Next

Full log

Message #14 received at 32470 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 32470 <at> debbugs.gnu.org
Subject: Re: bug#32470: rcirc-debug: ignore read-only;
 do not move point if mid-buffer; use %F
Date: Tue, 18 Sep 2018 18:46:59 -0400

Ivan Shmakov <ivan <at> siamics.net> writes:

>  >> +          (terpri (current-buffer) t)
>
>  > This looks like you’re adding an extra newline,
>
> 	Only if there’s none already, as the second argument to terpri
> 	is non-nil.  Which can happen, for example, should user edit the
> 	buffer manually (for whatever reason.)

Oh, right.  I don't use terpri so much, so I'd forgotten about that
handy feature.

> 	Please consider the revised patch MIMEd.
>
> 	FTR, a ‘side effect’ of this change is that rcirc-debug no
> 	longer returns the string appended to buffer.  (Instead, it
> 	returns the marker coinciding with point.)  AFAICT, the return
> 	value of this function is never used in the Rcirc code.

I think that's fine, please push to master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.