From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 18 04:57:51 2018 Received: (at submit) by debbugs.gnu.org; 18 Aug 2018 08:57:51 +0000 Received: from localhost ([127.0.0.1]:53925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqx3O-0007U0-Ko for submit@debbugs.gnu.org; Sat, 18 Aug 2018 04:57:51 -0400 Received: from fely.am-1.org ([78.47.74.50]:48632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqx3M-0007Ti-EH for submit@debbugs.gnu.org; Sat, 18 Aug 2018 04:57:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net ; s=a2013295; h=Content-Type:MIME-Version:Message-ID:Date:X-License:To: Subject:From:Sender:Content-Transfer-Encoding:In-Reply-To:References:Reply-To :Cc:Content-ID:Content-Description; bh=+DmfF1WVdBaIT4vkzAel9TZmmAs/jYu7mFFBXpjCyjk=; b=CserASkcwY5RHQ3Cz4imzapb5I W9BkLZ6jAJe6i+yTPWC+gnCw4qaCtTjPdt7dHEW1BOvLF2ONJAqkCeDwPeS6V+/DzOB4YiPTiizYc 8zZ/f/TeP/P0kzZj/WFhUTU6EhTEmmiy4DcFb9ZS/Qqn4mbQjIHdCHFMZpY7m2rXKsoI=; Received: from violet.siamics.net ([2001:470:1f13:1eb::1:1d]) by fely.am-1.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1fqx3K-0007NN-4A for submit@debbugs.gnu.org; Sat, 18 Aug 2018 08:57:46 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.84_2) (envelope-from ) id 1fqx3I-00086a-4Z for submit@debbugs.gnu.org; Sat, 18 Aug 2018 08:57:44 +0000 From: Ivan Shmakov Subject: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F To: submit@debbugs.gnu.org X-License: CC0-1.0 (original contributions only) Date: Sat, 18 Aug 2018 08:57:43 +0000 Message-ID: <87k1ooyrug.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Package: emacs Severity: wishlist Tags: patch I find it quite convenient to be able to make the *rcirc debug* buffer read-only, so that I won=E2=80=99t be able to change it by accident. This of course requires the rcirc-debug function to use inhibit-read-only. Another usability tweak is to restore point after insertion =E2=80=93 unless it was at the end of the (visible portion of the) buffer before. (Hence allowing the buffer to scroll normally after end-of-buffer is used.) Also, while we=E2=80=99re at, %Y-%m-%d can be replaced with the equivalent %F in the format-time-string argument; and concat is useless as =E2=80=98insert=E2=80=99 effectively concatenates its string arguments already. I=E2=80=99m somewhat unsure if this change is NEWS-worthy; if so, I suggest the following entry. ** rcirc +++ *** The 'rcirc-debug-buffer' can now be made read-only; it will be ignored when adding debug text to it. Also, the point will not be moved, unless it's set to the end of the visible portion of the buffer. Please thus consider the patch MIMEd. --=20 FSF associate member #7257 np. Funicul=C3=AC, funicul=C3=A0 =E2=80=94 Luci= ano Pavarotti --=-=-= Content-Type: text/patch Content-Disposition: inline From: Ivan Shmakov Subject: Improve user convenience of the rcirc debug buffer Date: Sat, 18 Aug 2018 08:57:08 +0000 * lisp/net/rcirc.el (rcirc-debug): Ignore rcirc-debug-buffer read-only status. Restore point after insertion unless it was at the end. Replace %Y-%m-%d with the equivalent %F in format-time-string; remove useless concat. (Bug#-XXX-) --- --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -670,16 +670,24 @@ "If non-nil, write information to `rcirc-debug-buffer'.") (defun rcirc-debug (process text) "Add an entry to the debug log including PROCESS and TEXT. -Debug text is written to `rcirc-debug-buffer' if `rcirc-debug-flag' -is non-nil." +Debug text is appended to `rcirc-debug-buffer' if `rcirc-debug-flag' +is non-nil. + +For convenience, the read-only state of the debug buffer is ignored. +When the point is at the end of the visible portion of the buffer, it +is moved to after the text inserted. Otherwise the point is not moved." (when rcirc-debug-flag (with-current-buffer (get-buffer-create rcirc-debug-buffer) - (goto-char (point-max)) - (insert (concat - "[" - (format-time-string "%Y-%m-%dT%T ") (process-name process) - "] " - text))))) + (let ((old (set-marker (make-marker) (point)))) + (set-marker-insertion-type old t) + (goto-char (point-max)) + (let ((inhibit-read-only t)) + (terpri (current-buffer) t) + (insert "[" + (format-time-string "%FT%T ") (process-name process) + "] " + text)) + (goto-char old))))) (define-obsolete-variable-alias 'rcirc-sentinel-hooks 'rcirc-sentinel-functions "24.3") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 08:22:35 2018 Received: (at 32470) by debbugs.gnu.org; 14 Sep 2018 12:22:35 +0000 Received: from localhost ([127.0.0.1]:40118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0n7L-00085D-G7 for submit@debbugs.gnu.org; Fri, 14 Sep 2018 08:22:35 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:38567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0n7H-00084y-Hu for 32470@debbugs.gnu.org; Fri, 14 Sep 2018 08:22:32 -0400 Received: by mail-it0-f43.google.com with SMTP id p129-v6so2252677ite.3 for <32470@debbugs.gnu.org>; Fri, 14 Sep 2018 05:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hpN+JL7w2UiqBrhIF9N5Hm+0ya3eE7TQVxubrgmGAcg=; b=inFoIitVwYL9u7bdvm1c5LT9tVSBS1qrB2NRa8Uwk36HHnv3jPWfCMRwSg6VgjLlG2 nEYF9C/QWSGvk4AKBeJSvuP7DtwHcU8OBfd6M+INCwOaEi4NVcWgQzUYu+2wurnuf+IA ozxoomWnIWagI74vLPj9cIsFS6n0F0U9imUgmPTeaRmkPObq7CCr3DMuxyHfkZcPxGFy fgdAGjIoOTf6sVCHzE0iciko96H77SD4XtXmfek08qfvGLI/JA7tmjJRwetyJhoaavy6 tqYtoMdSpqbaAvCArV4tSjD79EcEG7/D2IBmsBvETqm8Vzu1TzvrqUI4yAZGZmUwDf4Z UKmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hpN+JL7w2UiqBrhIF9N5Hm+0ya3eE7TQVxubrgmGAcg=; b=AsuElW7GJySPngfibWE1HF9jM2jIZEP/G1NbqrfjiiE5MEzh4hjYG2dvYi73dnFfWx E0GdCxCfwbGW0SCC9AOb6cq/Wo7G+Gs2/v79Cj2B+d5Zma3swYtoJQxS2DpPLmYta/tq 4RPlNb35gCLiNb65PLPgg5RokUz1tcyOByo1MiVvK5PAJJyor/G2ib4DAKGvDx4FDXk+ WfcjRh3s5MZb4nS82IOz9dw5PdpZoDHnLEJu0ZjqiFH1cCO5wjb6IImLrwr+tux34sWy 3QGGj1lE9m8SM9qrxku4A52xyAGoayOsBSXG7Wv4g1mM2eSYINRdqnvBp7eALiufpppr wUQQ== X-Gm-Message-State: APzg51DotBaXJpmxsZLXo6crG5qoSuML+ZcXdEW1L4OpFD/Nes9KJSK7 2JddkjMgqFmZmCqTPu0yIjErWV1H X-Google-Smtp-Source: ANB0Vdah67hHMKTdceWLqer3za6wMMTbx0uS8jbYZna7y+uuyxnj9nruyMnM85A5alk1ZijCBvXK9g== X-Received: by 2002:a02:9d45:: with SMTP id m5-v6mr10734841jal.72.1536927745758; Fri, 14 Sep 2018 05:22:25 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b10-v6sm2246122iok.40.2018.09.14.05.22.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Sep 2018 05:22:24 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F References: <87k1ooyrug.fsf@violet.siamics.net> Date: Fri, 14 Sep 2018 08:22:23 -0400 In-Reply-To: <87k1ooyrug.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 18 Aug 2018 08:57:43 +0000") Message-ID: <87d0tgs1z4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32470 Cc: 32470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ivan Shmakov writes: > I=E2=80=99m somewhat unsure if this change is NEWS-worthy; if so, > I suggest the following entry. The behaviour of debug tracing functions is somewhat in the gray area between user visible and internal details, but I'd say there's no need to update NEWS for this. > - (goto-char (point-max)) > - (insert (concat > - "[" > - (format-time-string "%Y-%m-%dT%T ") (process-name process) > - "] " > - text))))) > + (let ((old (set-marker (make-marker) (point)))) You could use (point-marker) instead. > + (set-marker-insertion-type old t) > + (goto-char (point-max)) > + (let ((inhibit-read-only t)) > + (terpri (current-buffer) t) This looks like you're adding an extra newline, or was there a lack of newlines before? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 14 15:05:31 2018 Received: (at 32470) by debbugs.gnu.org; 14 Sep 2018 19:05:31 +0000 Received: from localhost ([127.0.0.1]:40922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0tPG-0003u1-VD for submit@debbugs.gnu.org; Fri, 14 Sep 2018 15:05:31 -0400 Received: from fely.am-1.org ([78.47.74.50]:51180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g0tPF-0003tt-M1 for 32470@debbugs.gnu.org; Fri, 14 Sep 2018 15:05:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net ; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:X-License:Cc:To:Subject:From:Sender:Content-Transfer-Encoding: Reply-To:Content-ID:Content-Description; bh=V2f8CnjWQ8rV0oDUhvPEkCT/dGHVySiAMK1Ah0Svfxc=; b=JIWOzOk8xFl2iGdgaTlIzHytt3 /YAnnlqh6IN+CHy8f+DlOa2LBrny2t7dNqn1W+MB2NEeJvIELQwOWVGZxswL9l1f66T0yPZXZcy7l 8RsvArKs4KDW0Pab8x5j/SHrmIo/Jc6siKWw5lIPw34czMGVJkEE8pyEuPlv60nkJ16M=; Received: from tunnel35660-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:1eb::2] helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1g0tPE-0007zy-5f; Fri, 14 Sep 2018 19:05:28 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtp (Exim 4.84_2) (envelope-from ) id 1g0tPD-0001cg-56; Fri, 14 Sep 2018 19:05:27 +0000 From: Ivan Shmakov Subject: Re: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F To: 32470@debbugs.gnu.org X-License: CC-BY-SA-3.0+ (original contributions only) References: <87k1ooyrug.fsf@violet.siamics.net> <87d0tgs1z4.fsf@gmail.com> Date: Fri, 14 Sep 2018 19:05:26 +0000 In-Reply-To: <87d0tgs1z4.fsf@gmail.com> (Noam Postavsky's message of "Fri, 14 Sep 2018 08:22:23 -0400") Message-ID: <87pnxfgart.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32470 Cc: Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Noam Postavsky writes: >>>>> Ivan Shmakov writes: >> I=E2=80=99m somewhat unsure if this change is NEWS-worthy; if so, I sug= gest >> the following entry. > The behaviour of debug tracing functions is somewhat in the gray area > between user visible and internal details, but I=E2=80=99d say there=E2= =80=99s no > need to update NEWS for this. ACK. >> + (let ((old (set-marker (make-marker) (point)))) > You could use (point-marker) instead. ACK, thanks! >> + (set-marker-insertion-type old t) >> + (goto-char (point-max)) >> + (let ((inhibit-read-only t)) >> + (terpri (current-buffer) t) > This looks like you=E2=80=99re adding an extra newline, Only if there=E2=80=99s none already, as the second argument to terpri is non-nil. Which can happen, for example, should user edit the buffer manually (for whatever reason.) > or was there a lack of newlines before? Actually, yes, there seem to be an issue with a =E2=80=9Cmissing=E2=80=9D trailing newline when rcirc-debug is called from rcirc-filter. AIUI, when the remote produces a large amount of data (such as just after the handshake), rcirc-filter gets called for each bufferful of data, e. g.: (rcirc-filter # "line-1\nline-2\nli") (rcirc-filter # "ne-3\nline-4\nline") (rcirc-filter # "-5\nline-6\nline-7") ; and so on=E2=80=A6 There, rcirc-filter will accumulate data in rcirc-process-output and process only when the value ends with a newline. OTOH, rcirc-debug gets called once for each rcirc-debug call, currently resulting in the *rcirc debug* state being like: [2018-09-14T18:35:19 process] line-1 line-2 li[2018-09-14T18:35:19 process] ne-3 line-4 line[2018-09-14T18:35:19 process] -5=E2=80=A6 This patch ensures a newline before every [timestamp] marker. Please consider the revised patch MIMEd. FTR, a =E2=80=98side effect=E2=80=99 of this change is that rcirc-debug no longer returns the string appended to buffer. (Instead, it returns the marker coinciding with point.) AFAICT, the return value of this function is never used in the Rcirc code. --=20 FSF associate member #7257 http://softwarefreedomday.org/ 15 September 20= 18 --=-=-= Content-Type: text/patch Content-Disposition: inline From: Ivan Shmakov Subject: Improve user convenience of the rcirc debug buffer Date: Fri, 14 Sep 2018 19:05:12 +0000 * lisp/net/rcirc.el (rcirc-debug): Ignore rcirc-debug-buffer read-only status. Restore point after insertion unless it was at the end. Ensure a newline before each [lead]. Replace %Y-%m-%d with the equivalent %F in format-time-string; remove useless concat. (Bug#32470) --- --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -670,16 +670,24 @@ "If non-nil, write information to `rcirc-debug-buffer'.") (defun rcirc-debug (process text) "Add an entry to the debug log including PROCESS and TEXT. -Debug text is written to `rcirc-debug-buffer' if `rcirc-debug-flag' -is non-nil." +Debug text is appended to `rcirc-debug-buffer' if `rcirc-debug-flag' +is non-nil. + +For convenience, the read-only state of the debug buffer is ignored. +When the point is at the end of the visible portion of the buffer, it +is moved to after the text inserted. Otherwise the point is not moved." (when rcirc-debug-flag (with-current-buffer (get-buffer-create rcirc-debug-buffer) - (goto-char (point-max)) - (insert (concat - "[" - (format-time-string "%Y-%m-%dT%T ") (process-name process) - "] " - text))))) + (let ((old (point-marker))) + (set-marker-insertion-type old t) + (goto-char (point-max)) + (let ((inhibit-read-only t)) + (terpri (current-buffer) t) + (insert "[" + (format-time-string "%FT%T ") (process-name process) + "] " + text)) + (goto-char old))))) (define-obsolete-variable-alias 'rcirc-sentinel-hooks 'rcirc-sentinel-functions "24.3") --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 18:47:08 2018 Received: (at 32470) by debbugs.gnu.org; 18 Sep 2018 22:47:08 +0000 Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Olw-000799-9a for submit@debbugs.gnu.org; Tue, 18 Sep 2018 18:47:08 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:43767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Olu-00078d-Mx for 32470@debbugs.gnu.org; Tue, 18 Sep 2018 18:47:07 -0400 Received: by mail-io1-f50.google.com with SMTP id y10-v6so2916104ioa.10 for <32470@debbugs.gnu.org>; Tue, 18 Sep 2018 15:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=rG1oAaGY7MKDS0qbPG+1+IJF8JrGWxPS2OGSCMPiLgQ=; b=f4sM6yHbD81IxLR0FPUuOENUQNkPdLy60DERwGn6I0aGOUnIONQXYsN3yAcA7DOhAn khBqJwmnGs/AwP61/uebW4QoOTWeAl7h8FKP1dcOS2UOhmJOJ9VPq4I3dkXLlvA4epyA E45k6adjF26+UGmdSb4X9nv41HE13YAVvS0HlzyaO9Qx9bD5WCCZglitBbiHlHzsjllv yM3lamRu2i0ohyX9IiP2QxrYbxbuiecCpLeXP9soSy2DWR7SCa79EWt2F867bAWxVA55 7YsMwskmyZXzqZDguBEdZ/DXzMAtkadhEVsXBxyBmtCxGfdnO4vp+nd6WJSFpSBal2n8 SvKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=rG1oAaGY7MKDS0qbPG+1+IJF8JrGWxPS2OGSCMPiLgQ=; b=nDnUJNtCgX2b2pN88dW2M5pOXLx+fbl8SZiGBxDCi3X24OTI6Z6kv6Bu/kUnkH74Pg nEB3iFiVKse05Owmv5R7RdSHw5Jpyif+fNjFR+/3c0N5k2v3QfMvqdibseahqDtzszhk SPeasSLdXKZwdYqa07aQoThmZJLd+nYKiztZfc3fae1M4aV4z+psyDx9QzmPwHqKCp56 p4BzM0TQktqBHTyvJOxfNiDjhOTpvygE3i+IOAsndnL0oP7oHL0APbkWoEC+xQE0ot+/ BeopYatAykPbuq1hSukxuNypoPsZ+AiO85YJdQUaK8BGa3nHvZzDNpB4/9TqA/4Rf8U4 edRA== X-Gm-Message-State: APzg51AznOk0D0pn4AkIXL+1ZgbuqDK4K9ePTgUUijZDYFmlpToMpuT8 uT+gnJB5+jlIYNljklizm9yfKzoA X-Google-Smtp-Source: ANB0Vdb7FZccK5SJWbBXBr4VwJIoZQcBFsAa0PtbhPKXD9nu+6q/Qu5Z9xJgR2zQgz6gP5n+iINqxg== X-Received: by 2002:a6b:ee13:: with SMTP id i19-v6mr27019673ioh.132.1537310820940; Tue, 18 Sep 2018 15:47:00 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o8-v6sm6982121ioh.56.2018.09.18.15.47.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Sep 2018 15:47:00 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F References: <87k1ooyrug.fsf@violet.siamics.net> <87d0tgs1z4.fsf@gmail.com> <87pnxfgart.fsf@violet.siamics.net> Date: Tue, 18 Sep 2018 18:46:59 -0400 In-Reply-To: <87pnxfgart.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 14 Sep 2018 19:05:26 +0000") Message-ID: <877ejiqv8c.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32470 Cc: 32470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ivan Shmakov writes: > >> + (terpri (current-buffer) t) > > > This looks like you=E2=80=99re adding an extra newline, > > Only if there=E2=80=99s none already, as the second argument to terpri > is non-nil. Which can happen, for example, should user edit the > buffer manually (for whatever reason.) Oh, right. I don't use terpri so much, so I'd forgotten about that handy feature. > Please consider the revised patch MIMEd. > > FTR, a =E2=80=98side effect=E2=80=99 of this change is that rcirc-debug = no > longer returns the string appended to buffer. (Instead, it > returns the marker coinciding with point.) AFAICT, the return > value of this function is never used in the Rcirc code. I think that's fine, please push to master. From debbugs-submit-bounces@debbugs.gnu.org Thu May 16 07:26:31 2019 Received: (at 32470) by debbugs.gnu.org; 16 May 2019 11:26:31 +0000 Received: from localhost ([127.0.0.1]:54478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hREWt-0003hD-J7 for submit@debbugs.gnu.org; Thu, 16 May 2019 07:26:31 -0400 Received: from mail-it1-f180.google.com ([209.85.166.180]:52758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hREWr-0003gr-2e; Thu, 16 May 2019 07:26:30 -0400 Received: by mail-it1-f180.google.com with SMTP id q65so5489132itg.2; Thu, 16 May 2019 04:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=sBfAMPBYebcOIgNeKHihtHYQAdZjwyMV0/RsuC3QcbU=; b=Olukpu2aN/Xin+CZPmUkvV43Swp7OnGdQeKJSVlKtzH+A663ZS5x7hRVy7oJF6s55Q /1W++i4N+0vvqcojstUDuyEZB+TVW9vrwNYKX9i5894KvaoZaN+Al5uoPRaAEmSckIap XAJw59GLG2R4HuuEzQBudQKulDVgJFANmFwE0ufXTBPniAeUBQDva1qS7HjoDQjwYTni jL0LDCgGEeSTk0MOe51myUsUNb0iFxQ7MUQHEE9d8/MrK6xzvtni8WDQXZrneXeyAA/D hhmiy3DLpiBEkOXCWEHwlvJ+LQxhzZL23Lvmzx9YW9v/LePOK4L01EOkqOqKXxH6tauq 9y3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=sBfAMPBYebcOIgNeKHihtHYQAdZjwyMV0/RsuC3QcbU=; b=cZ/VWFRBz8F09XbH4Ta4I1fBb1lW/mMMALsUsHMt+QNOGVdw1pv5MhEqGiDVHyKoGj Kk6BLXSI/pqXaG9WmrVPfU2MK53mk4ZxAQC4ea4EjhUONE398l5gIJkyjPJac64JhMX5 JUfT7DsnebmHOfC2SNJotLo+FYQkBMoJWF4jinCX9zRmA/LzKvhS8AeLkCn/PvuQjjCd oGJgYH0KlDhG0n/r2gtatta12465QYHWRhLgKuOq39qvTI2O/50LBis1VlmTxMKVvuJJ UqU5fZY6CNv1obbPbPJkPY+/vgiytHf7ho+lNVKO5v+ByEVXgtyTT8MjTw2PmHWz3eBg WGcw== X-Gm-Message-State: APjAAAW0QCLCA/n1dwqrrYL5oGYUmqjIaqI3fSUJ08tVGpYHLHM0hOdE e6ImfFf8qV+x0VdUi46yRaJ3Kdkt X-Google-Smtp-Source: APXvYqyc3F2h1HAzVjI+hXmC/BcYdQdLuhcC4laILq+b4d0ZLrOa6uu7CzLe+2JozrK4rLuLMGm+ug== X-Received: by 2002:a05:660c:a8e:: with SMTP id m14mr12893859itk.169.1558005983406; Thu, 16 May 2019 04:26:23 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id 74sm1679449itk.3.2019.05.16.04.26.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 04:26:22 -0700 (PDT) From: Noam Postavsky To: Ivan Shmakov Subject: Re: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F References: <87k1ooyrug.fsf@violet.siamics.net> <87d0tgs1z4.fsf@gmail.com> <87pnxfgart.fsf@violet.siamics.net> <877ejiqv8c.fsf@gmail.com> Date: Thu, 16 May 2019 07:26:21 -0400 In-Reply-To: <877ejiqv8c.fsf@gmail.com> (Noam Postavsky's message of "Tue, 18 Sep 2018 18:46:59 -0400") Message-ID: <87v9yaej36.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32470 Cc: 32470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32470 fixed close 32470 27.1 quit >> Please consider the revised patch MIMEd. >> >> FTR, a =E2=80=98side effect=E2=80=99 of this change is that rcirc-debug= no >> longer returns the string appended to buffer. (Instead, it >> returns the marker coinciding with point.) AFAICT, the return >> value of this function is never used in the Rcirc code. > > I think that's fine, please push to master. I've done that now. 63a71535a8 2019-05-16T06:54:54-04:00 "Improve user convenience of the rcirc= debug buffer" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D63a71535a8998ac6e8= cadb9db44cf1dca650d4cb From unknown Wed Sep 10 19:49:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Jun 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator