GNU bug report logs - #32452
26.1; gnutls_try_handshake maxes out cpu retrying when server is a bit busy

Previous Next

Package: emacs;

Reported by: Noam Postavsky <npostavs <at> gmail.com>

Date: Thu, 16 Aug 2018 12:14:01 UTC

Severity: minor

Tags: moreinfo

Found in version 26.1

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #156 received at 32452 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, npostavs <at> gmail.com, 32452 <at> debbugs.gnu.org
Subject: Re: bug#32452: 26.1; gnutls_try_handshake maxes out cpu retrying
 when server is a bit busy
Date: Sat, 05 Mar 2022 18:11:33 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

> mod-test.c calls nanosleep, so it needs to be linked against libgnu.a,
> I think.  (We should have done that to begin with, since mod-test.c
> includes config.h and headers that have Gnulib replacements.)

The following seems to do the trick (and simplifies the rule slightly).
Does this look correct to you?

diff --git a/test/Makefile.in b/test/Makefile.in
index 708c4b2fb0..09f1e0f005 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -283,9 +283,9 @@ $(test_module): $(test_module:
 	$(AM_V_CCLD)${MKDIR_P} $(dir $@)
 	$(AM_V_at)$(CC) -shared $(CPPFLAGS) $(MODULE_CFLAGS) $(LDFLAGS) \
 	  -o $@ $< $(LIBGMP) \
+	  ../lib/libgnu.a \
 	  $(and $(GMP_H),$(srcdir)/../lib/mini-gmp-gnulib.c) \
-	  $(FREE_SOURCE_$(REPLACE_FREE)) \
-	  $(srcdir)/../lib/timespec.c $(srcdir)/../lib/gettime.c
+	  $(FREE_SOURCE_$(REPLACE_FREE))
 endif
 
 src/emacs-tests.log: ../lib-src/seccomp-filter.c


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 3 years and 117 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.