From unknown Mon Jun 23 18:28:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32446 <32446@debbugs.gnu.org> To: bug#32446 <32446@debbugs.gnu.org> Subject: Status: Configure-time requirement for gnutls is too old Reply-To: bug#32446 <32446@debbugs.gnu.org> Date: Tue, 24 Jun 2025 01:28:39 +0000 retitle 32446 Configure-time requirement for gnutls is too old reassign 32446 emacs submitter 32446 Gavin Smith severity 32446 important tag 32446 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 15 07:12:20 2018 Received: (at submit) by debbugs.gnu.org; 15 Aug 2018 11:12:20 +0000 Received: from localhost ([127.0.0.1]:51351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fptiu-0001Ys-0T for submit@debbugs.gnu.org; Wed, 15 Aug 2018 07:12:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41277) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fptir-0001Yh-VZ for submit@debbugs.gnu.org; Wed, 15 Aug 2018 07:12:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fptip-0005CC-IF for submit@debbugs.gnu.org; Wed, 15 Aug 2018 07:12:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_40, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fptip-0005BC-2X for submit@debbugs.gnu.org; Wed, 15 Aug 2018 07:12:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fptin-0003e0-I2 for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 07:12:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fptil-00054x-Sf for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 07:12:13 -0400 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]:37500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fptil-000534-LB for bug-gnu-emacs@gnu.org; Wed, 15 Aug 2018 07:12:11 -0400 Received: by mail-it0-x236.google.com with SMTP id h20-v6so1413003itf.2 for ; Wed, 15 Aug 2018 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=qef2huKyZ0sS1CL/+HFyyoORYiNoSvOOjYDIBAYXm88=; b=eu2+rI7L5m1NQC4U/xu4D4xB55uSOCXEJV3v3Y3eiBiyRp+7X1gQ5jSrvmaT6GqUFO 7dZVEDB8ajVpFa1aCJ5AWDdblbxzi86zIXaowjF5aFfdCepvdURzHEd3rQZDRVr/Q+za ovKynKSW2apiTfx6Tc3du7OOV7YKVwY92aDCNmS4ovMT+/dT/hWOF6tEzZsqxKwUIeeQ iHARI0b8/9OswVvr9cSdzCX6P3IVCBfBdW4cEZIAcSO6fazz5+cbp2dkZwRlMqObjMMo FqFeegMo/uYkjZGJMfpIrFyBHr1cpjHTSUTDhldIq6Gv+oaiXrI3upXgxqItZhF4CKil nWjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=qef2huKyZ0sS1CL/+HFyyoORYiNoSvOOjYDIBAYXm88=; b=LdwM2CfZm+taOB4Zy3+eopaw9ncvJlhpNU0s6ZBwfpM2aWPZvRTCrsjxWe7WVuK+F7 yKtuB3uQQsJzM8tLJh5tXg14PSqvlYANMIGP2xE9SKY8uXifbAG/dF/xzMKwso1mWpQa afKSzv7nkSDWDysLirc5iO++6v+SV9NYwUsOF3YESl0vM1NZ5vWw6lNBSyIvAIM5ikxX T3gavmQF81pzzrqPKsiz0ppexMN6Ydok34AXFPifUjNeW9kEItTGr2mMC+TfN+Qqv8KO yW0lytSzGOZm4ZlwC6CKWbedwJ4aDqov2zFNM28oyGEVRP3UZUA4yDzmlM7/LBfUxPaZ XuUQ== X-Gm-Message-State: AOUpUlGIunSiOyGi3o6gMFhUd4Um9YdzQ4WIKolQlyEzB8hhRHSVmqO5 lmJM/V5NpwiXRSQZqh86NADG0wRCwdL+Fd9SAUMzAQHN X-Google-Smtp-Source: AA+uWPzjHvxwLcIw4E4jau2HIAHRNFwn9qk09Sa5A48J2DQO5k6xZu1/ohbRs7pzMhVigB98eTsd2aVajnTuCjKtWMA= X-Received: by 2002:a02:1e41:: with SMTP id m62-v6mr22766645jad.110.1534331530358; Wed, 15 Aug 2018 04:12:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:91c9:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 04:12:10 -0700 (PDT) From: Gavin Smith Date: Wed, 15 Aug 2018 12:12:10 +0100 Message-ID: Subject: Configure-time requirement for gnutls is too old To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) I downloaded and tried to build Emacs 26.1. I ran "./configure" and "make", but after a while there is an error. With "make V=1": gcc -std=gnu11 -Demacs -I. -I. -I../lib -I../lib -pthread -I/usr/local/include -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/include/libdrm -I/usr/include/freetype2 -I/usr/include/alsa -pthread -I/usr/local/include -I/usr/include/librsvg-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo -I/usr/include/libpng14 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16 -I/usr/include/ImageMagick-6 -I/usr/include/libpng14 -I/usr/include/libxml2 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -MMD -MF deps/.d -MP -I/usr/include/p11-kit-1 -g3 -O2 -Wl,-znocombreloc \ -o temacs vm-limit.o dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o xsmfns.o xsettings.o gtkutil.o emacsgtkfixed.o dbusbind.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexelf.o bytecode.o process.o gnutls.o callproc.o region-cache.o sound.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o lcms.o inotify.o profiler.o decompress.o thread.o systhread.o xfont.o ftfont.o xftfont.o ftxfont.o fontset.o fringe.o image.o xgselect.o terminfo.o lastfile.o ../lib/libgnu.a -ltiff -ljpeg -L/usr/lib -lpng14 -lgif -lXpm -lgtk-3 -lgdk-3 -latk-1.0 -lgio-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo-gobject -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0 -lSM -lICE -lX11 -lX11-xcb -lxcb -lXrender -lXft -lasound -lrsvg-2 -lm -lgio-2.0 -lgdk_pixbuf-2.0 -lcairo -lgobject-2.0 -lglib-2.0 -lMagickWand-6.Q16 -lMagickCore-6.Q16 -lacl -lrt -ldbus-1 -lXrandr -lXinerama -lXfixes -lXext -lxml2 -lgpm -lncurses -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgobject-2.0 -lglib-2.0 -lfreetype -lfontconfig -lgnutls -lpthread -lanl -llcms2 -lm -lz gnutls.o: In function `Fgnutls_ciphers': /home/g/extsrc/emacs-26.1/src/gnutls.c:1889: undefined reference to `gnutls_cipher_get_tag_size' /home/g/extsrc/emacs-26.1/src/gnutls.c:1892: undefined reference to `gnutls_cipher_get_iv_size' gnutls.o: In function `Fgnutls_digests': /home/g/extsrc/emacs-26.1/src/gnutls.c:2242: undefined reference to `gnutls_digest_list' /home/g/extsrc/emacs-26.1/src/gnutls.c:2248: undefined reference to `gnutls_digest_get_name' gnutls.o: In function `gnutls_symmetric': /home/g/extsrc/emacs-26.1/src/gnutls.c:2062: undefined reference to `gnutls_cipher_get_iv_size' /home/g/extsrc/emacs-26.1/src/gnutls.c:2079: undefined reference to `gnutls_cipher_get_tag_size' collect2: error: ld returned 1 exit status make[1]: *** [temacs] Error 1 make[1]: Leaving directory `/home/g/extsrc/emacs-26.1/src' make: *** [src] Error 2 I looked to see which symbols were in the gnutls library: $ nm -D /usr/lib/libgnutls.so.28.21.5 | grep cipher 00043760 T gnutls_cipher_add_auth 00043880 T gnutls_cipher_decrypt 00043940 T gnutls_cipher_decrypt2 000439c0 T gnutls_cipher_deinit 00043830 T gnutls_cipher_encrypt 000438f0 T gnutls_cipher_encrypt2 0003d550 T gnutls_cipher_get 000b8dc0 T gnutls_cipher_get_block_size 000b8fd0 T gnutls_cipher_get_id 000b8ed0 T gnutls_cipher_get_key_size 000b8f90 T gnutls_cipher_get_name 000435e0 T gnutls_cipher_init 000b9020 T gnutls_cipher_list 000437f0 T gnutls_cipher_set_iv 00028f30 T gnutls_cipher_set_priority 000b9270 T gnutls_cipher_suite_get_name 000b9320 T gnutls_cipher_suite_info 000436d0 T gnutls_cipher_tag 000b95a0 T gnutls_priority_get_cipher_suite_index "gnutls_cipher_get_tag_size" is not there. According to https://www.gnutls.org/abi-tracker/changelog/gnutls/3.4.10/log.html, gnutls_cipher_get_tag_size was added in version 3.2.2. However, the configure script for Emacs did not detect that I had an out-of-date gnutls. From config.log: configure:13176: checking for LIBGNUTLS configure:13183: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2" configure:13186: $? = 0 configure:13200: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2" configure:13203: $? = 0 configure:13241: result: yes The check is for an older version of gnutls, which my system passes: $ pkg-config --modversion gnutls 3.1.25 I'd guess that the required version in 'configure' needs to be increased. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 15 16:49:45 2018 Received: (at 32446) by debbugs.gnu.org; 15 Aug 2018 20:49:45 +0000 Received: from localhost ([127.0.0.1]:52097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq2jh-0004cM-7L for submit@debbugs.gnu.org; Wed, 15 Aug 2018 16:49:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq2jf-0004c7-2k for 32446@debbugs.gnu.org; Wed, 15 Aug 2018 16:49:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpyMF-00017M-0C for 32446@debbugs.gnu.org; Wed, 15 Aug 2018 12:09:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpyMB-00011s-Fh; Wed, 15 Aug 2018 12:09:12 -0400 Received: from [176.228.60.248] (port=3323 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fpyM8-0000XY-8w; Wed, 15 Aug 2018 12:09:09 -0400 Date: Wed, 15 Aug 2018 19:09:03 +0300 Message-Id: <83y3d7ipcw.fsf@gnu.org> From: Eli Zaretskii To: Gavin Smith , Ted Zlatanov In-reply-to: (message from Gavin Smith on Wed, 15 Aug 2018 12:12:10 +0100) Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Gavin Smith > Date: Wed, 15 Aug 2018 12:12:10 +0100 > > According to https://www.gnutls.org/abi-tracker/changelog/gnutls/3.4.10/log.html, > gnutls_cipher_get_tag_size was added in version 3.2.2. However, the > configure script for Emacs did not detect that I had an out-of-date > gnutls. From config.log: > > configure:13176: checking for LIBGNUTLS > configure:13183: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2" > configure:13186: $? = 0 > configure:13200: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2" > configure:13203: $? = 0 > configure:13241: result: yes > > The check is for an older version of gnutls, which my system passes: > > $ pkg-config --modversion gnutls > 3.1.25 > > I'd guess that the required version in 'configure' needs to be increased. The problem is not with the minimum required version, because we have additional version-dependent cpp conditions in gnutls.c. The problem is that we assumed these functions were available since GnuTLS 3.0.0, which is false. Ted, what would you propose to do with this issue? Disable the relevant functionality for versions of GnuTLS that don't have these APIs? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 20 21:58:16 2018 Received: (at control) by debbugs.gnu.org; 21 Aug 2018 01:58:16 +0000 Received: from localhost ([127.0.0.1]:56064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frvw0-0002HC-1s for submit@debbugs.gnu.org; Mon, 20 Aug 2018 21:58:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frvvx-0002GY-VK for control@debbugs.gnu.org; Mon, 20 Aug 2018 21:58:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frvvq-0000Ed-IE for control@debbugs.gnu.org; Mon, 20 Aug 2018 21:58:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frvvq-0000EV-FE for control@debbugs.gnu.org; Mon, 20 Aug 2018 21:58:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1frvvq-0003OE-5w for control@debbugs.gnu.org; Mon, 20 Aug 2018 21:58:06 -0400 Subject: control message for bug 32446 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 20 Aug 2018 21:58:06 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) severity 32446 important From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 20 22:08:59 2018 Received: (at 32446) by debbugs.gnu.org; 21 Aug 2018 02:08:59 +0000 Received: from localhost ([127.0.0.1]:56068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frw6N-0004ZL-2k for submit@debbugs.gnu.org; Mon, 20 Aug 2018 22:08:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frw6L-0004Z9-L4 for 32446@debbugs.gnu.org; Mon, 20 Aug 2018 22:08:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frw6G-0001DV-01 for 32446@debbugs.gnu.org; Mon, 20 Aug 2018 22:08:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frw6D-0001C7-2a; Mon, 20 Aug 2018 22:08:49 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1frw6C-0005Vr-Rh; Mon, 20 Aug 2018 22:08:48 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> X-Spook: Domestic nuclear detection DRM Nuevo Leon Chemical spill X-Ran: (Eli Zaretskii's message of "Wed, 15 Aug 2018 19:09:03 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, Ted Zlatanov , Gavin Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Looks like relevant discussion in https://debbugs.gnu.org/27708 . From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 10:44:17 2018 Received: (at 32446) by debbugs.gnu.org; 15 Sep 2018 14:44:17 +0000 Received: from localhost ([127.0.0.1]:41708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Bo0-0004SQ-Ip for submit@debbugs.gnu.org; Sat, 15 Sep 2018 10:44:16 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:38110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Bnv-0004S5-Og; Sat, 15 Sep 2018 10:44:12 -0400 Received: by mail-io1-f66.google.com with SMTP id y3-v6so8242066ioc.5; Sat, 15 Sep 2018 07:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SShCHW1tHNjiRfnVLfRz0db4n214P54LKKHJ1i0KfEQ=; b=FDXc9Gz88/aU0AR2hWMsyqZNVtpPwLoIcUtoJvm5V4qi3BKbuMQN4NnY2qiveFNGRz C65TcRx5dT9RRWopM5+NYsDrvTaeE1rUVBCWf5HCR6TvZFBUPQ6Zs4ZJVaY+MPYzzy1n 4eCQpm9c6Cfx88ZG+JSHMEGbfA68u7IL9m4CDxVKsN92JV1GzWZJX1qecGs83JmX8mCM T9XioiGtDOadshzb6H6ETIGbDJF+mYgrUno25iYNL+ESnptlwBF1+C39/Bc6S30AsvDI Hwxfa9PAjW186uhtrOMM26NZkE7GkA44CD43ZIaxUoAGrRdzqMtvkIvZbvgmiRc9+bZX OR8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SShCHW1tHNjiRfnVLfRz0db4n214P54LKKHJ1i0KfEQ=; b=toX157YmbsENxxbAGCN+9tENge2JKX2DwTpgRJLHLEq4PhhwEsTiJ4qvgyNoiEatBs iF5iz5RAa1KK8/BQWVb8WF2P2MJmzua4nhZedSUmpkwQ+CfYCr2jNjov/DXPsNe1f82N wu7qdiyKkEaZqbsd7/SI740l5mov+58lgBtabmt9BPImi7Uff6e/mbxXRJCs/Amu6Zts qaUdy7fLDvu14bjUDlLiWeEoREU/bTfvilI+GCuSNrMsHkvvsXY3rqtXlAVnWvWt4q6C rc3A/tymzpbeADmAHUgD7fgu568JyxVi96RfY5YDKjF4x/EzMrIfgq2uYgW/6IuId+op LxOQ== X-Gm-Message-State: APzg51AKDJdEZsDmHNzuhD4ui4o3yfuNpt2h1gS/Ubue3KG0RLYGk+/x 9zXQLaVaO4BmUny7v6VbvTLNlp8M X-Google-Smtp-Source: ANB0VdYVCEa3kNmUpjcizu56TKYVxsXJiTJQmRKeBmnbn4rzCg28G/XFycpl6yWPubqa7g/I0VcUpA== X-Received: by 2002:a5e:da49:: with SMTP id o9-v6mr14258819iop.215.1537022646155; Sat, 15 Sep 2018 07:44:06 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id g198-v6sm970534itg.4.2018.09.15.07.44.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Sep 2018 07:44:05 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> Date: Sat, 15 Sep 2018 10:44:04 -0400 In-Reply-To: <83y3d7ipcw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Aug 2018 19:09:03 +0300") Message-ID: <87va76rfbf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, Ted Zlatanov , Gavin Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain tags 32446 + patch quit Eli Zaretskii writes: >> I'd guess that the required version in 'configure' needs to be increased. > > The problem is not with the minimum required version, because we have > additional version-dependent cpp conditions in gnutls.c. The problem > is that we assumed these functions were available since GnuTLS 3.0.0, > which is false. > > Ted, what would you propose to do with this issue? Disable the > relevant functionality for versions of GnuTLS that don't have these > APIs? I think we can keep most of the functionality: the missing APIs only make a difference for AEAD ciphers, which are already disabled for versions before 3.5. --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v1-0001-Fix-build-with-gnutls-versions-3.0-to-3.2-Bug-324.patch Content-Description: patch >From 14efb9e7826e06c25e495f9d17d3b3179f380c6a Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 15 Sep 2018 10:25:11 -0400 Subject: [PATCH v1] Fix build with gnutls versions 3.0 to 3.2 (Bug#32446) We previously used functions available only in 3.2+ for all 3.x versions. * src/gnutls.c [! GNUTLS_VERSION_NUMBER >= 0x030501]: Replace calls to gnutls_cipher_get_tag_size with 0. [! GNUTLS_VERSION_NUMBER >= 0x030200]: Alias gnutls_cipher_get_iv_size to gnutls_cipher_get_block_size, gnutls_digest_list to gnutls_mac_list, and gnutls_digest_get_name to gnutls_mac_get_name. [WINDOWSNT]: Adjust DLL function definitions and declarations accordingly. --- src/gnutls.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 51 insertions(+), 4 deletions(-) diff --git a/src/gnutls.c b/src/gnutls.c index 461260e27f..83c3e79cbf 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -38,6 +38,29 @@ your option) any later version. So, require 3.5.1. */ #if GNUTLS_VERSION_NUMBER >= 0x030501 # define HAVE_GNUTLS_AEAD +/* gnutls_cipher_get_tag_size was introduced in 3.2.0, but it's only + relevant for AEAD ciphers. */ +# define HAVE_GNUTLS_CIPHER_GET_TAG_SIZE +#else +# define gnutls_cipher_get_tag_size(cipher) 0 +#endif + +/* gnutls_cipher_get_iv_size was introduced in 3.2.0. */ +#if GNUTLS_VERSION_NUMBER >= 0x030200 +# define HAVE_GNUTLS_CIPHER_GET_IV_SIZE +#else +/* For the ciphers available in previous versions, block size is equivalent. */ +#define gnutls_cipher_get_iv_size(cipher) gnutls_cipher_get_block_size (cipher) +#endif + +/* gnutls_digest_list and gnutls_digest_get_name were added in 3.2.2. */ +#if GNUTLS_VERSION_NUMBER >= 0x030202 +# define HAVE_GNUTLS_DIGEST_LIST +# define HAVE_GNUTLS_DIGEST_GET_NAME +#else +/* For previous versions, the mac algorithms are equivalent. */ +# define gnutls_digest_list() ((const gnutls_digest_algorithm_t *) gnutls_mac_list ()) +# define gnutls_digest_get_name(id) gnutls_mac_get_name ((gnutls_mac_algorithm_t) id) #endif /* gnutls_mac_get_nonce_size was added in GnuTLS 3.2.0, but was @@ -205,13 +228,21 @@ DEF_DLL_FN (const gnutls_mac_algorithm_t *, gnutls_mac_list, (void)); DEF_DLL_FN (size_t, gnutls_mac_get_nonce_size, (gnutls_mac_algorithm_t)); # endif DEF_DLL_FN (size_t, gnutls_mac_get_key_size, (gnutls_mac_algorithm_t)); +# ifdef HAVE_GNUTLS_DIGEST_LIST DEF_DLL_FN (const gnutls_digest_algorithm_t *, gnutls_digest_list, (void)); +# endif +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME DEF_DLL_FN (const char *, gnutls_digest_get_name, (gnutls_digest_algorithm_t)); +# endif DEF_DLL_FN (gnutls_cipher_algorithm_t *, gnutls_cipher_list, (void)); +# ifdef HAVE_GNUTLS_CIPHER_GET_IV_SIZE DEF_DLL_FN (int, gnutls_cipher_get_iv_size, (gnutls_cipher_algorithm_t)); +# endif DEF_DLL_FN (size_t, gnutls_cipher_get_key_size, (gnutls_cipher_algorithm_t)); DEF_DLL_FN (int, gnutls_cipher_get_block_size, (gnutls_cipher_algorithm_t)); +# ifdef HAVE_GNUTLS_CIPHER_GET_TAG_SIZE DEF_DLL_FN (int, gnutls_cipher_get_tag_size, (gnutls_cipher_algorithm_t)); +# endif DEF_DLL_FN (int, gnutls_cipher_init, (gnutls_cipher_hd_t *, gnutls_cipher_algorithm_t, const gnutls_datum_t *, const gnutls_datum_t *)); @@ -339,13 +370,21 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_mac_get_nonce_size); # endif LOAD_DLL_FN (library, gnutls_mac_get_key_size); +# ifdef HAVE_GNUTLS_DIGEST_LIST LOAD_DLL_FN (library, gnutls_digest_list); +# endif +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME LOAD_DLL_FN (library, gnutls_digest_get_name); +# endif LOAD_DLL_FN (library, gnutls_cipher_list); +# ifdef HAVE_GNUTLS_CIPHER_GET_IV_SIZE LOAD_DLL_FN (library, gnutls_cipher_get_iv_size); +# endif LOAD_DLL_FN (library, gnutls_cipher_get_key_size); LOAD_DLL_FN (library, gnutls_cipher_get_block_size); +# ifdef HAVE_GNUTLS_CIPHER_GET_TAG_SIZE LOAD_DLL_FN (library, gnutls_cipher_get_tag_size); +# endif LOAD_DLL_FN (library, gnutls_cipher_init); LOAD_DLL_FN (library, gnutls_cipher_set_iv); LOAD_DLL_FN (library, gnutls_cipher_encrypt2); @@ -455,13 +494,21 @@ init_gnutls_functions (void) # define gnutls_mac_get_nonce_size fn_gnutls_mac_get_nonce_size # endif # define gnutls_mac_get_key_size fn_gnutls_mac_get_key_size -# define gnutls_digest_list fn_gnutls_digest_list -# define gnutls_digest_get_name fn_gnutls_digest_get_name +# ifdef HAVE_GNUTLS_DIGEST_LIST +# define gnutls_digest_list fn_gnutls_digest_list +# endif +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME +# define gnutls_digest_get_name fn_gnutls_digest_get_name +# endif # define gnutls_cipher_list fn_gnutls_cipher_list -# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size +# ifdef HAVE_GNUTLS_CIPHER_GET_IV_SIZE +# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size +# endif # define gnutls_cipher_get_key_size fn_gnutls_cipher_get_key_size # define gnutls_cipher_get_block_size fn_gnutls_cipher_get_block_size -# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size +# ifdef HAVE_GNUTLS_CIPHER_GET_TAG_SIZE +# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size +# endif # define gnutls_cipher_init fn_gnutls_cipher_init # define gnutls_cipher_set_iv fn_gnutls_cipher_set_iv # define gnutls_cipher_encrypt2 fn_gnutls_cipher_encrypt2 -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 11:27:10 2018 Received: (at 32446) by debbugs.gnu.org; 15 Sep 2018 15:27:10 +0000 Received: from localhost ([127.0.0.1]:41718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1CTW-0007UC-56 for submit@debbugs.gnu.org; Sat, 15 Sep 2018 11:27:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1CTV-0007U1-5w for 32446@debbugs.gnu.org; Sat, 15 Sep 2018 11:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1CTM-00041t-FH for 32446@debbugs.gnu.org; Sat, 15 Sep 2018 11:27:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1CTM-00041V-BM; Sat, 15 Sep 2018 11:27:00 -0400 Received: from [176.228.60.248] (port=4218 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g1CTL-00075E-UY; Sat, 15 Sep 2018 11:27:00 -0400 Date: Sat, 15 Sep 2018 18:26:51 +0300 Message-Id: <83musiixxg.fsf@gnu.org> From: Eli Zaretskii To: gavinsmith0123@gmail.com, Noam Postavsky In-reply-to: <87va76rfbf.fsf@gmail.com> (message from Noam Postavsky on Sat, 15 Sep 2018 10:44:04 -0400) Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: Gavin Smith , Ted Zlatanov , 32446@debbugs.gnu.org > Date: Sat, 15 Sep 2018 10:44:04 -0400 > > I think we can keep most of the functionality: the missing APIs only > make a difference for AEAD ciphers, which are already disabled for > versions before 3.5. Thanks. Gavin, can you test this with your version of GnuTLS? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 11:55:18 2018 Received: (at 32446) by debbugs.gnu.org; 15 Sep 2018 15:55:18 +0000 Received: from localhost ([127.0.0.1]:41725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Cuk-0008AU-H1 for submit@debbugs.gnu.org; Sat, 15 Sep 2018 11:55:18 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:35099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1Cuj-0008AH-Bk for 32446@debbugs.gnu.org; Sat, 15 Sep 2018 11:55:17 -0400 Received: by mail-wr1-f54.google.com with SMTP id j26-v6so13264789wre.2 for <32446@debbugs.gnu.org>; Sat, 15 Sep 2018 08:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=34XPXzuG0W6+mPKJnl/BrkO5Y8CfJQp3tA928+YR+kY=; b=AP9kSUw8r/7obp7LDFmd1r6HPh8HCXZ8yhUccLMFKObkXrPGhv6dMNayDAKD81gJEl 0FuNJ+wMeK7g+B9fjcOge77Fn3M0aAnQBw0xzPbqvG1GJR1EWACcOPlpHh4kod17Tdu4 1hOcSS8/dnfze2A9sLBn2loZrYP9p3AwJ36joDv10TnoQsfzupZwAp3F49qyDiUNTsEV WdzpEk6YkdNL6T74PDGmCTvtxwTwli7e+Ozdu2hvSD2QbdEys3ApWMtfRUqTSRRbmnSb ZeWjghL2Z2WqM0KKsGwvlPPyOV2lIYkqUWc6kEikE5E8Ie3pFL9aEwcwBjW50QJCPvc7 ++Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=34XPXzuG0W6+mPKJnl/BrkO5Y8CfJQp3tA928+YR+kY=; b=OOPgkAF5XsD0AqIbO+Moi73mvgHNA6KilIU8BZQrmHkbWBdobfA+LAz2hqVQOw0pAd MI9+H2ddADuCpV2aThIMdMasw+uVzaMQdWpDfAaDIKErBj7Eg1gULd+SdyacNj+DHb0j NIPtlA5C3KLrro2JE/rVfr8DhD/kvAEAZaL3taROn5dmJ4JBnZbnIt3wambPjYyjdqDb 0RbVYolRoJcpH6+iROD1KKCKA+fWOyyOb/78ZP0tLbIZ8CaHu7nQLWS+sM55FF8r3m1B kz2QHKs49vNPGFu1tdC17GqIZIr1YFt8oMODDUS0gRwzcLDRiVu1QP9YWNEXvbF+6Lsr NlpQ== X-Gm-Message-State: APzg51BLnAWMR7X/YKBmX8DkwFv9WAJMe4mTDrRJ+hBcDC1XG2HmD1sH o/Vq8XbXH4EgLsMQ94O0tvo= X-Google-Smtp-Source: ANB0VdbLz84DFVVYYXmaB2gN0TbHE3MiqOwf4eFzJRwe1UIl0dC/lEmN0UEkKVktnj7SE2K3/6/Ikw== X-Received: by 2002:adf:e648:: with SMTP id b8-v6mr13723519wrn.254.1537026911510; Sat, 15 Sep 2018 08:55:11 -0700 (PDT) Received: from darkstar.example.net (242.153.199.146.dyn.plus.net. [146.199.153.242]) by smtp.gmail.com with ESMTPSA id h7-v6sm8978454wrs.3.2018.09.15.08.55.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Sep 2018 08:55:10 -0700 (PDT) From: Gavin Smith X-Google-Original-From: Gavin Smith Received: from darkstar.example.net (localhost [127.0.0.1]) by darkstar.example.net (8.14.9/8.14.9) with ESMTP id w8FFtABS021214; Sat, 15 Sep 2018 16:55:11 +0100 Received: (from g@localhost) by darkstar.example.net (8.14.9/8.14.9/Submit) id w8FFt9vx020836; Sat, 15 Sep 2018 16:55:09 +0100 Date: Sat, 15 Sep 2018 16:55:09 +0100 To: Eli Zaretskii Subject: Re: bug#32446: Configure-time requirement for gnutls is too old Message-ID: <20180915155509.GA750@darkstar> References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83musiixxg.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Sep 15, 2018 at 06:26:51PM +0300, Eli Zaretskii wrote: > Gavin, can you test this with your version of GnuTLS? I applied Noam's patch, reconfigured to enable GnuTLS, and ran "make", and the build completed successfully. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 15 12:17:29 2018 Received: (at 32446) by debbugs.gnu.org; 15 Sep 2018 16:17:29 +0000 Received: from localhost ([127.0.0.1]:41731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1DGD-0000H8-DN for submit@debbugs.gnu.org; Sat, 15 Sep 2018 12:17:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1DGB-0000Gv-IP for 32446@debbugs.gnu.org; Sat, 15 Sep 2018 12:17:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g1DG3-0003HV-6N for 32446@debbugs.gnu.org; Sat, 15 Sep 2018 12:17:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g1DG3-0003H7-2W; Sat, 15 Sep 2018 12:17:19 -0400 Received: from [176.228.60.248] (port=3345 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g1DG2-0005Bb-LJ; Sat, 15 Sep 2018 12:17:18 -0400 Date: Sat, 15 Sep 2018 19:17:10 +0300 Message-Id: <83k1nmivll.fsf@gnu.org> From: Eli Zaretskii To: Gavin Smith In-reply-to: <20180915155509.GA750@darkstar> (message from Gavin Smith on Sat, 15 Sep 2018 16:55:09 +0100) Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Gavin Smith > Date: Sat, 15 Sep 2018 16:55:09 +0100 > Cc: Noam Postavsky , tzz@lifelogs.com, > 32446@debbugs.gnu.org > > On Sat, Sep 15, 2018 at 06:26:51PM +0300, Eli Zaretskii wrote: > > Gavin, can you test this with your version of GnuTLS? > > I applied Noam's patch, reconfigured to enable GnuTLS, and ran "make", > and the build completed successfully. Thanks. The patch LGTM as well, so, Noam, please push eto emacs-26, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 16:31:27 2018 Received: (at 32446) by debbugs.gnu.org; 16 Sep 2018 20:31:27 +0000 Received: from localhost ([127.0.0.1]:42337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1dhW-0003Hy-BB for submit@debbugs.gnu.org; Sun, 16 Sep 2018 16:31:26 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:37958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g1dhT-0003CR-R4 for 32446@debbugs.gnu.org; Sun, 16 Sep 2018 16:31:24 -0400 Received: by mail-io1-f66.google.com with SMTP id y3-v6so9869869ioc.5 for <32446@debbugs.gnu.org>; Sun, 16 Sep 2018 13:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=CTS9LmsLRc+cyAxiD2pJZlWlUk3eN9G19Qyzmxd3HcI=; b=G5oPnsOr1eF0VVJiZObJ5jjdK/Gc9PNrv2x87CxXh2U7uL5TzJOZ8hMb/B/YltuqSB EXjaqW4OVvL0wOgy3kyMRrW5mjv2vDzeAOaljQrqt2bBIpcfbm6ZsuQCxnS4LBUNTkHZ 3vyxeCGQiOQaeqeUymHnSDQRwW1IaBzLbBI76KJeCZuGRI/3n+4GgA4u5jGTPUwVcg5e mkdp/W1eKJVzpmcJmHIDLflWiRRbrnhmFRQ+eQ10kAS0GqfPrHw8To0NRKHnNFaxtzx9 UgbDGqQETG6yU/wv6GKd4UwSIMrvC8ZLkDKZGSzMLKOgmHOCOfKXsLLixml77yblfpcw jVfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=CTS9LmsLRc+cyAxiD2pJZlWlUk3eN9G19Qyzmxd3HcI=; b=lnOHuK7Y9MmJ0vwTQXI0abh02lpJoMM2knsbbtaZ1wBVP++XwpmsFpWhXYIcAH4fer fQJ/D31qqEACWeg05VUwasCn+ZrzgoAPbO1v1mJi17x1plj2Gf4xbf6YAk3+BRTPL4gB /+WiokAOjjBlJLa3tA+lUYiu0HNioJR3oddRx2LtJgNfLV6KhozEh3e9BeIN51qNahAl yCrcB3s0pik7n4WPefaA1wBcOi7ud++rRbxABLsyCpwsYj8iBgGrn4pEiy4YgeKM8Zvq QIaKWlERfiChnTdJGjeC094v2ZBPY5hEQ3H0vwmRI3oVyeRRQ0CI+gnigMXwJ4hCjUvm lATw== X-Gm-Message-State: APzg51Ad/TklHZ0C1aMVMAm/4Gcy/xyD5sYLSQh9S3G9Y1Pv8qVJI+Ss K4misYgsySFad8Y1bs0POb0= X-Google-Smtp-Source: ANB0VdZXOi0JFUZo3HEnrH7o/XrDitKcEBTbfrc4667VSqgswy7gzlTquv9uu6Lq86fPgz2Vq1bnQA== X-Received: by 2002:a5e:c705:: with SMTP id f5-v6mr18406887iop.197.1537129878168; Sun, 16 Sep 2018 13:31:18 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w8-v6sm4283385iom.15.2018.09.16.13.31.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Sep 2018 13:31:17 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> Date: Sun, 16 Sep 2018 16:31:16 -0400 In-Reply-To: <83k1nmivll.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Sep 2018 19:17:10 +0300") Message-ID: <87sh29qj57.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Gavin Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > The patch LGTM as well, so, Noam, please push eto emacs-26, and > thanks. Ah, minor problem, I had initially written this on Windows, but it turns out on GNU/Linux when the '#ifdef WINDOWSNT' part is skipped, gcc gives a few warnings. I've adjusted the patch to avoid this (see attached); I'll push it tomorrow after double checking the updated version on Windows. CC gnutls.o ../../src/gnutls.c:59:0: warning: macro "HAVE_GNUTLS_DIGEST_GET_NAME" is not used [-Wunused-macros] # define HAVE_GNUTLS_DIGEST_GET_NAME ../../src/gnutls.c:43:0: warning: macro "HAVE_GNUTLS_CIPHER_GET_TAG_SIZE" is not used [-Wunused-macros] # define HAVE_GNUTLS_CIPHER_GET_TAG_SIZE ../../src/gnutls.c:50:0: warning: macro "HAVE_GNUTLS_CIPHER_GET_IV_SIZE" is not used [-Wunused-macros] # define HAVE_GNUTLS_CIPHER_GET_IV_SIZE ../../src/gnutls.c:58:0: warning: macro "HAVE_GNUTLS_DIGEST_LIST" is not used [-Wunused-macros] # define HAVE_GNUTLS_DIGEST_LIST --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=v2-0001-Fix-build-with-gnutls-versions-3.0-to-3.2-Bug-324.patch Content-Description: patch >From f7d6e2b5b6c4cc24d935d1eee84df4dfc6ded7c8 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 15 Sep 2018 10:25:11 -0400 Subject: [PATCH v2] Fix build with gnutls versions 3.0 to 3.2 (Bug#32446) We previously used functions available only in 3.2+ for all 3.x versions. * src/gnutls.c [GNUTLS_VERSION_NUMBER < 0x030501]: Replace calls to gnutls_cipher_get_tag_size with 0. [GNUTLS_VERSION_NUMBER < 0x030200]: Alias gnutls_cipher_get_iv_size to gnutls_cipher_get_block_size, gnutls_digest_list to gnutls_mac_list, and gnutls_digest_get_name to gnutls_mac_get_name. [WINDOWSNT]: Adjust DLL function definitions and declarations accordingly. --- src/gnutls.c | 49 +++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/src/gnutls.c b/src/gnutls.c index 461260e27f..2a834d9391 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -38,6 +38,23 @@ your option) any later version. So, require 3.5.1. */ #if GNUTLS_VERSION_NUMBER >= 0x030501 # define HAVE_GNUTLS_AEAD +#else +/* gnutls_cipher_get_tag_size was introduced in 3.2.0, but it's only + relevant for AEAD ciphers. */ +# define gnutls_cipher_get_tag_size(cipher) 0 +#endif + +#if GNUTLS_VERSION_NUMBER < 0x030200 +/* gnutls_cipher_get_iv_size was introduced in 3.2.0. For the ciphers + available in previous versions, block size is equivalent. */ +#define gnutls_cipher_get_iv_size(cipher) gnutls_cipher_get_block_size (cipher) +#endif + +#if GNUTLS_VERSION_NUMBER < 0x030202 +/* gnutls_digest_list and gnutls_digest_get_name were added in 3.2.2. + For previous versions, the mac algorithms are equivalent. */ +# define gnutls_digest_list() ((const gnutls_digest_algorithm_t *) gnutls_mac_list ()) +# define gnutls_digest_get_name(id) gnutls_mac_get_name ((gnutls_mac_algorithm_t) id) #endif /* gnutls_mac_get_nonce_size was added in GnuTLS 3.2.0, but was @@ -205,13 +222,21 @@ DEF_DLL_FN (const gnutls_mac_algorithm_t *, gnutls_mac_list, (void)); DEF_DLL_FN (size_t, gnutls_mac_get_nonce_size, (gnutls_mac_algorithm_t)); # endif DEF_DLL_FN (size_t, gnutls_mac_get_key_size, (gnutls_mac_algorithm_t)); +# ifndef gnutls_digest_list DEF_DLL_FN (const gnutls_digest_algorithm_t *, gnutls_digest_list, (void)); +# endif +# ifndef gnutls_digest_get_name DEF_DLL_FN (const char *, gnutls_digest_get_name, (gnutls_digest_algorithm_t)); +# endif DEF_DLL_FN (gnutls_cipher_algorithm_t *, gnutls_cipher_list, (void)); +# ifndef gnutls_cipher_get_iv_size DEF_DLL_FN (int, gnutls_cipher_get_iv_size, (gnutls_cipher_algorithm_t)); +# endif DEF_DLL_FN (size_t, gnutls_cipher_get_key_size, (gnutls_cipher_algorithm_t)); DEF_DLL_FN (int, gnutls_cipher_get_block_size, (gnutls_cipher_algorithm_t)); +# ifndef gnutls_cipher_get_tag_size DEF_DLL_FN (int, gnutls_cipher_get_tag_size, (gnutls_cipher_algorithm_t)); +# endif DEF_DLL_FN (int, gnutls_cipher_init, (gnutls_cipher_hd_t *, gnutls_cipher_algorithm_t, const gnutls_datum_t *, const gnutls_datum_t *)); @@ -339,13 +364,21 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_mac_get_nonce_size); # endif LOAD_DLL_FN (library, gnutls_mac_get_key_size); +# ifndef gnutls_digest_list LOAD_DLL_FN (library, gnutls_digest_list); +# endif +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME LOAD_DLL_FN (library, gnutls_digest_get_name); +# endif LOAD_DLL_FN (library, gnutls_cipher_list); +# ifndef gnutls_cipher_get_iv_size LOAD_DLL_FN (library, gnutls_cipher_get_iv_size); +# endif LOAD_DLL_FN (library, gnutls_cipher_get_key_size); LOAD_DLL_FN (library, gnutls_cipher_get_block_size); +# ifndef gnutls_cipher_get_tag_size LOAD_DLL_FN (library, gnutls_cipher_get_tag_size); +# endif LOAD_DLL_FN (library, gnutls_cipher_init); LOAD_DLL_FN (library, gnutls_cipher_set_iv); LOAD_DLL_FN (library, gnutls_cipher_encrypt2); @@ -455,13 +488,21 @@ init_gnutls_functions (void) # define gnutls_mac_get_nonce_size fn_gnutls_mac_get_nonce_size # endif # define gnutls_mac_get_key_size fn_gnutls_mac_get_key_size -# define gnutls_digest_list fn_gnutls_digest_list -# define gnutls_digest_get_name fn_gnutls_digest_get_name +# ifndef gnutls_digest_list +# define gnutls_digest_list fn_gnutls_digest_list +# endif +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME +# define gnutls_digest_get_name fn_gnutls_digest_get_name +# endif # define gnutls_cipher_list fn_gnutls_cipher_list -# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size +# ifndef gnutls_cipher_get_iv_size +# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size +# endif # define gnutls_cipher_get_key_size fn_gnutls_cipher_get_key_size # define gnutls_cipher_get_block_size fn_gnutls_cipher_get_block_size -# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size +# ifndef gnutls_cipher_get_tag_size +# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size +# endif # define gnutls_cipher_init fn_gnutls_cipher_init # define gnutls_cipher_set_iv fn_gnutls_cipher_set_iv # define gnutls_cipher_encrypt2 fn_gnutls_cipher_encrypt2 -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 17 19:29:40 2018 Received: (at 32446) by debbugs.gnu.org; 17 Sep 2018 23:29:40 +0000 Received: from localhost ([127.0.0.1]:43464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g22xX-0007Bh-Q3 for submit@debbugs.gnu.org; Mon, 17 Sep 2018 19:29:39 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:33767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g22xV-0007BL-CM; Mon, 17 Sep 2018 19:29:38 -0400 Received: by mail-io1-f44.google.com with SMTP id r196-v6so67979iod.0; Mon, 17 Sep 2018 16:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=H/a4altpvCJjfjSQuAQ5FGZgdOBdPySd5EGKYexE/js=; b=VXqq/CsER+wY3eaEA7nm9su+SWnSCGMaqpmgPXaohFp/L6uYby/Vjk97UlBSSZoLqP elt7ZFD83Z6nrcpIpIfx0VCxMFrnUsyyVlmXA3JSdQr7gH1jEOXKzVLwKb2ajueuncKO 5YiBgGSL105AW3CpIYYSCdYD/ne5iUglVGe11lyJs2gSA5CkLKSbZGpxC0kxp5lgbxeE xiBYvY4OUO268IpC5eBFB8IQJTt4NZMqIbz8s+QW7B3ueamH+tiYEUIXEag/2dvK+4Lf U+8hnzrg1dFCKQgJuvMZy3VTH+hEcQEpr0zk+v3/2ICoTCHwC+q1+IswcntXihLicZiN 2KfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=H/a4altpvCJjfjSQuAQ5FGZgdOBdPySd5EGKYexE/js=; b=aQIJuV7l9EVNOkMahBwjXvoWBcQfZOSpIWuMTdeS9w9CV0numP21LkYDx0r5kH1Pa0 Lu/E2CgJkNPCnrapt0i5c6aajMo4KtcAVI3lxqRw6uUMRJWgMKMPYsQ9Xbqkkz78GBaN HKm4THQoHMO92s4NRLek3XxQkb2WZe1MgACFiDl95FR+xc2sly+VemO7RLlb3EF7i3X7 otrtrDHFwoAC2R56VxG3Uhu83cvOztibkGuAiENvL/HDAd5IKmrTFnHs6xZJdHaUI+Wd kTUko+/Foisy9Qj6mJgDcH2jsNGK2ZOO2HY5BYtbGO9mH7QP75lPfPBNni0eVgJGVHsg khow== X-Gm-Message-State: APzg51CZmKG6710A312m7WAYK4Oa2zP0cBcZawAgq4qnY8T4OO50RHeF hZYGwSAfZfqPWNy9+mwh/0w/kSMT X-Google-Smtp-Source: ANB0VdZyRgWMAlKbFl50XqJbU8D3V+tJx6KXuriZMnzSouk27cXpp1ZA6BKGTXs7gfD6NwvnARDz0A== X-Received: by 2002:a5e:c705:: with SMTP id f5-v6mr22887829iop.197.1537226971497; Mon, 17 Sep 2018 16:29:31 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id x68-v6sm5151443ita.31.2018.09.17.16.29.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Sep 2018 16:29:30 -0700 (PDT) From: Noam Postavsky To: Eli Zaretskii Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> <87sh29qj57.fsf@gmail.com> Date: Mon, 17 Sep 2018 19:29:29 -0400 In-Reply-To: <87sh29qj57.fsf@gmail.com> (Noam Postavsky's message of "Sun, 16 Sep 2018 16:31:16 -0400") Message-ID: <87a7ofr9d2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Gavin Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 32446 fixed close 32446 26.2 quit Noam Postavsky writes: > I'll push it tomorrow after double checking the updated version on > Windows. > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > LOAD_DLL_FN (library, gnutls_digest_get_name); > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > +# define gnutls_digest_get_name fn_gnutls_digest_get_name Fixed those two ifdef checks, and pushed to emacs-26. [1: b5bee6bf48]: 2018-09-17 17:54:32 -0400 Fix build with gnutls versions 3.0 to 3.2 (Bug#32446) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 06:28:39 2018 Received: (at 32446) by debbugs.gnu.org; 18 Sep 2018 10:28:39 +0000 Received: from localhost ([127.0.0.1]:43658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2DFG-0003DV-TS for submit@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2DFC-0003DF-OO for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2DF6-0001j2-CZ for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 06:28:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2DEm-00019X-Qo; Tue, 18 Sep 2018 06:28:08 -0400 Received: from [176.228.60.248] (port=4352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2DEl-0006YF-MD; Tue, 18 Sep 2018 06:28:08 -0400 Date: Tue, 18 Sep 2018 13:28:03 +0300 Message-Id: <8336u7gkwc.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: <87a7ofr9d2.fsf@gmail.com> (message from Noam Postavsky on Mon, 17 Sep 2018 19:29:29 -0400) Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> <87sh29qj57.fsf@gmail.com> <87a7ofr9d2.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, gavinsmith0123@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, Gavin Smith > Date: Mon, 17 Sep 2018 19:29:29 -0400 > > > I'll push it tomorrow after double checking the updated version on > > Windows. > > > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > > LOAD_DLL_FN (library, gnutls_digest_get_name); > > > +# ifdef HAVE_GNUTLS_DIGEST_GET_NAME > > +# define gnutls_digest_get_name fn_gnutls_digest_get_name > > Fixed those two ifdef checks, and pushed to emacs-26. > > [1: b5bee6bf48]: 2018-09-17 17:54:32 -0400 > Fix build with gnutls versions 3.0 to 3.2 (Bug#32446) > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf This caused Emacs with GnuTLS 3.4.15 to crash in the test suite. The problem is that the test suite avoids trying AEAD-capable ciphers when AEAD is unavailable, but one of the changes in the above made _all_ ciphers look like not AEAD-capable. I fixed it by allowing gnutls_cipher_get_tag_size for versions above 3.2.2, as it should at least allow use to continue skipping AEAD-capable ciphers based on this assumption, and it shouldn't affect GnuTLS 2.x. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 09:14:53 2018 Received: (at 32446) by debbugs.gnu.org; 18 Sep 2018 13:14:53 +0000 Received: from localhost ([127.0.0.1]:43797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Fq9-0001Ju-Fk for submit@debbugs.gnu.org; Tue, 18 Sep 2018 09:14:53 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Fq8-0001Jf-Cy for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 09:14:52 -0400 Received: by mail-oi0-f49.google.com with SMTP id 13-v6so1731094ois.1 for <32446@debbugs.gnu.org>; Tue, 18 Sep 2018 06:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=V7oGvtWn79aWtKo681p5jjPDsLFP6x0Px3XZkGYmI8Q=; b=XZw2oEFrH8+uFgKT1vXfa8M6kp9Wvg/k0w59qjnq0ETMRTFBilyKzWZJaI8+KqAdu9 pAU0BCkE7D+iWb8Z8HpY3p3HploKk5EZwfwChJ994eEHX+gdW4G7gZtgyGnNnFVlO9wk YfYDYip54KwrgRAY0VXYPXRhfOSnQuU3132tisq26VSYj0mS57iCb+TIL5hPMHLCa/az JjPv14FWYllMnRrr3JQJQYUFEENoF1cXw8+jYmLhEdzyOTf8fv+SBSiwM2YgSl08+Zs3 h8DQfhsVChHwQpWJ14X0Fjih1NCc9qBeJkQFNmgii/T3XQyEWh8EqseyVeiqfHMsXczD 3wbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=V7oGvtWn79aWtKo681p5jjPDsLFP6x0Px3XZkGYmI8Q=; b=lFjEeDSk0WE5Fj4abDJiH4znVpCTFCT3VWZ+ASJdNmKrP3EIHbd+8FidedyrheVILm fC/DSPZ3qQs5DKL65P4FWdJQ8icJAGZOj+ahBDb/RUxUwQgyJwZEV2fYWsih1dqPDJnh txbWC9qY+rW3bpSPhozK4+LoOPA8uk2Le0XGd8ivoWNIVROdDOj2zJ+VC1jaj9tN4f9+ Fk0mn2tmQMp1swp4IEN6raqPP1QEcYh4w1THGPiJs7BKzgWDReOHIfpdiYxv8Nljsaqj /rVxmCEnc1B5HFl173tur7oqhu8aD1S6ir3M330LmxsKPzdjagJAvrP55wuQfFXtlkpa oJAg== X-Gm-Message-State: APzg51DJdS+/rLx7Y1bOsj/p/i534U6p7ZHpoB+Lfz8FHuD32qd2jxmZ MvWpvh1AElXal5k1wP7WAFbh0S3R9Df4WH010XB3qi15 X-Google-Smtp-Source: ANB0VdZCKW0UhmbmjIjiHCfpQQYJSrvGobNTotngtq3uZoi2diJCLIFNTdc3yj2iAxSUMAtkH+sexZde4rNZhbxyDns= X-Received: by 2002:aca:4c14:: with SMTP id z20-v6mr1529348oia.164.1537276486752; Tue, 18 Sep 2018 06:14:46 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:540f:0:0:0:0:0 with HTTP; Tue, 18 Sep 2018 06:14:46 -0700 (PDT) In-Reply-To: <8336u7gkwc.fsf@gnu.org> References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> <87sh29qj57.fsf@gmail.com> <87a7ofr9d2.fsf@gmail.com> <8336u7gkwc.fsf@gnu.org> From: Noam Postavsky Date: Tue, 18 Sep 2018 09:14:46 -0400 Message-ID: Subject: Re: bug#32446: Configure-time requirement for gnutls is too old To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, Ted Zlatanov , Gavin Smith X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 18 September 2018 at 06:28, Eli Zaretskii wrote: > This caused Emacs with GnuTLS 3.4.15 to crash in the test suite. The > problem is that the test suite avoids trying AEAD-capable ciphers when > AEAD is unavailable, but one of the changes in the above made _all_ > ciphers look like not AEAD-capable. Oh, you mean using an AEAD cipher with the non-AEAD codepath crashes? > I fixed it by allowing gnutls_cipher_get_tag_size for versions above > 3.2.2, as it should at least allow use to continue skipping > AEAD-capable ciphers based on this assumption, and it shouldn't affect > GnuTLS 2.x. Right, makes sense. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 18 10:08:43 2018 Received: (at 32446) by debbugs.gnu.org; 18 Sep 2018 14:08:43 +0000 Received: from localhost ([127.0.0.1]:44535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2GgF-0004pn-66 for submit@debbugs.gnu.org; Tue, 18 Sep 2018 10:08:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2GgD-0004pR-8x for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 10:08:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Gg4-0003NP-34 for 32446@debbugs.gnu.org; Tue, 18 Sep 2018 10:08:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Gfw-00033k-Bq; Tue, 18 Sep 2018 10:08:26 -0400 Received: from [176.228.60.248] (port=2210 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2Gfu-0007GZ-0V; Tue, 18 Sep 2018 10:08:24 -0400 Date: Tue, 18 Sep 2018 17:08:12 +0300 Message-Id: <83o9cugapf.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Tue, 18 Sep 2018 09:14:46 -0400) Subject: Re: bug#32446: Configure-time requirement for gnutls is too old References: <83y3d7ipcw.fsf@gnu.org> <87va76rfbf.fsf@gmail.com> <83musiixxg.fsf@gnu.org> <20180915155509.GA750@darkstar> <83k1nmivll.fsf@gnu.org> <87sh29qj57.fsf@gmail.com> <87a7ofr9d2.fsf@gmail.com> <8336u7gkwc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32446 Cc: 32446@debbugs.gnu.org, tzz@lifelogs.com, gavinsmith0123@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > From: Noam Postavsky > Date: Tue, 18 Sep 2018 09:14:46 -0400 > Cc: 32446@debbugs.gnu.org, Ted Zlatanov , > Gavin Smith > > On 18 September 2018 at 06:28, Eli Zaretskii wrote: > > > This caused Emacs with GnuTLS 3.4.15 to crash in the test suite. The > > problem is that the test suite avoids trying AEAD-capable ciphers when > > AEAD is unavailable, but one of the changes in the above made _all_ > > ciphers look like not AEAD-capable. > > Oh, you mean using an AEAD cipher with the non-AEAD codepath crashes? More like "with non-AEAD capable gnutls.c". It's arguably a bug in the test suite, but given the available attributes of the ciphgers, I couldn't find any alternative way of filtering out the AEAD ciphers. From unknown Mon Jun 23 18:28:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Oct 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator