GNU bug report logs - #32446
Configure-time requirement for gnutls is too old

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32446 in the body.
You can then email your comments to 32446 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gavin Smith <gavinsmith0123 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Configure-time requirement for gnutls is too old
Date: Wed, 15 Aug 2018 12:12:10 +0100

I downloaded and tried to build Emacs 26.1. I ran "./configure" and
"make", but after a while there is an error. With "make V=1":

gcc -std=gnu11 -Demacs  -I. -I. -I../lib -I../lib   -pthread
-I/usr/local/include -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0
-I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/cairo
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/include/harfbuzz
-I/usr/include/freetype2 -I/usr/include/pixman-1
-I/usr/include/libpng14 -I/usr/include/libdrm
-I/usr/include/freetype2    -I/usr/include/alsa   -pthread
-I/usr/local/include -I/usr/include/librsvg-2.0
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/cairo
-I/usr/include/libpng14 -I/usr/include/pixman-1
-I/usr/include/freetype2 -I/usr/include/libdrm
-DMAGICKCORE_HDRI_ENABLE=0 -DMAGICKCORE_QUANTUM_DEPTH=16
-I/usr/include/ImageMagick-6   -I/usr/include/libpng14
-I/usr/include/libxml2   -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include        -pthread -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -I/usr/include/freetype2      -MMD -MF
deps/.d -MP  -I/usr/include/p11-kit-1       -g3 -O2  -Wl,-znocombreloc
  \
  -o temacs  vm-limit.o dispnew.o frame.o scroll.o xdisp.o menu.o
xmenu.o window.o charset.o coding.o category.o ccl.o character.o
chartab.o bidi.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o
xselect.o xrdb.o xsmfns.o xsettings.o gtkutil.o emacsgtkfixed.o
dbusbind.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o
filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o
casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o
doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o
lread.o  syntax.o unexelf.o bytecode.o process.o gnutls.o callproc.o
region-cache.o sound.o atimer.o doprnt.o intervals.o textprop.o
composite.o xml.o lcms.o inotify.o  profiler.o decompress.o thread.o
systhread.o      xfont.o ftfont.o xftfont.o ftxfont.o  fontset.o
fringe.o image.o xgselect.o  terminfo.o lastfile.o
../lib/libgnu.a       -ltiff -ljpeg -L/usr/lib -lpng14 -lgif -lXpm
-lgtk-3 -lgdk-3 -latk-1.0 -lgio-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0
-lcairo-gobject -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0   -lSM
-lICE -lX11 -lX11-xcb -lxcb -lXrender -lXft   -lasound   -lrsvg-2 -lm
-lgio-2.0 -lgdk_pixbuf-2.0 -lcairo -lgobject-2.0 -lglib-2.0
-lMagickWand-6.Q16 -lMagickCore-6.Q16   -lacl     -lrt -ldbus-1
-lXrandr   -lXinerama   -lXfixes   -lXext -lxml2   -lgpm   -lncurses
-lgio-2.0 -lgobject-2.0 -lglib-2.0   -lgobject-2.0 -lglib-2.0
-lfreetype   -lfontconfig     -lgnutls   -lpthread -lanl -llcms2  -lm
-lz
gnutls.o: In function `Fgnutls_ciphers':
/home/g/extsrc/emacs-26.1/src/gnutls.c:1889: undefined reference to
`gnutls_cipher_get_tag_size'
/home/g/extsrc/emacs-26.1/src/gnutls.c:1892: undefined reference to
`gnutls_cipher_get_iv_size'
gnutls.o: In function `Fgnutls_digests':
/home/g/extsrc/emacs-26.1/src/gnutls.c:2242: undefined reference to
`gnutls_digest_list'
/home/g/extsrc/emacs-26.1/src/gnutls.c:2248: undefined reference to
`gnutls_digest_get_name'
gnutls.o: In function `gnutls_symmetric':
/home/g/extsrc/emacs-26.1/src/gnutls.c:2062: undefined reference to
`gnutls_cipher_get_iv_size'
/home/g/extsrc/emacs-26.1/src/gnutls.c:2079: undefined reference to
`gnutls_cipher_get_tag_size'
collect2: error: ld returned 1 exit status
make[1]: *** [temacs] Error 1
make[1]: Leaving directory `/home/g/extsrc/emacs-26.1/src'
make: *** [src] Error 2

I looked to see which symbols were in the gnutls library:

$ nm -D /usr/lib/libgnutls.so.28.21.5 | grep cipher
00043760 T gnutls_cipher_add_auth
00043880 T gnutls_cipher_decrypt
00043940 T gnutls_cipher_decrypt2
000439c0 T gnutls_cipher_deinit
00043830 T gnutls_cipher_encrypt
000438f0 T gnutls_cipher_encrypt2
0003d550 T gnutls_cipher_get
000b8dc0 T gnutls_cipher_get_block_size
000b8fd0 T gnutls_cipher_get_id
000b8ed0 T gnutls_cipher_get_key_size
000b8f90 T gnutls_cipher_get_name
000435e0 T gnutls_cipher_init
000b9020 T gnutls_cipher_list
000437f0 T gnutls_cipher_set_iv
00028f30 T gnutls_cipher_set_priority
000b9270 T gnutls_cipher_suite_get_name
000b9320 T gnutls_cipher_suite_info
000436d0 T gnutls_cipher_tag
000b95a0 T gnutls_priority_get_cipher_suite_index

"gnutls_cipher_get_tag_size" is not there.

According to https://www.gnutls.org/abi-tracker/changelog/gnutls/3.4.10/log.html,
gnutls_cipher_get_tag_size was added in version 3.2.2. However, the
configure script for Emacs did not detect that I had an out-of-date
gnutls. From config.log:

configure:13176: checking for LIBGNUTLS
configure:13183: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2"
configure:13186: $? = 0
configure:13200: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2"
configure:13203: $? = 0
configure:13241: result: yes

The check is for an older version of gnutls, which my system passes:

$ pkg-config --modversion gnutls
3.1.25

I'd guess that the required version in 'configure' needs to be increased.

Message #8 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gavin Smith <gavinsmith0123 <at> gmail.com>, Ted Zlatanov <tzz <at> lifelogs.com>
Cc: 32446 <at> debbugs.gnu.org
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Wed, 15 Aug 2018 19:09:03 +0300

> From: Gavin Smith <gavinsmith0123 <at> gmail.com>
> Date: Wed, 15 Aug 2018 12:12:10 +0100
> 
> According to https://www.gnutls.org/abi-tracker/changelog/gnutls/3.4.10/log.html,
> gnutls_cipher_get_tag_size was added in version 3.2.2. However, the
> configure script for Emacs did not detect that I had an out-of-date
> gnutls. From config.log:
> 
> configure:13176: checking for LIBGNUTLS
> configure:13183: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2"
> configure:13186: $? = 0
> configure:13200: $PKG_CONFIG --exists --print-errors "gnutls >= 2.12.2"
> configure:13203: $? = 0
> configure:13241: result: yes
> 
> The check is for an older version of gnutls, which my system passes:
> 
> $ pkg-config --modversion gnutls
> 3.1.25
> 
> I'd guess that the required version in 'configure' needs to be increased.

The problem is not with the minimum required version, because we have
additional version-dependent cpp conditions in gnutls.c.  The problem
is that we assumed these functions were available since GnuTLS 3.0.0,
which is false.

Ted, what would you propose to do with this issue?  Disable the
relevant functionality for versions of GnuTLS that don't have these
APIs?

Thanks.

Message #13 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>,
 Gavin Smith <gavinsmith0123 <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Mon, 20 Aug 2018 22:08:48 -0400

Looks like relevant discussion in https://debbugs.gnu.org/27708 .

Message #16 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>,
 Gavin Smith <gavinsmith0123 <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Sat, 15 Sep 2018 10:44:04 -0400

[Message part 1 (text/plain, inline)]

tags 32446 + patch
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> I'd guess that the required version in 'configure' needs to be increased.
>
> The problem is not with the minimum required version, because we have
> additional version-dependent cpp conditions in gnutls.c.  The problem
> is that we assumed these functions were available since GnuTLS 3.0.0,
> which is false.
>
> Ted, what would you propose to do with this issue?  Disable the
> relevant functionality for versions of GnuTLS that don't have these
> APIs?

I think we can keep most of the functionality: the missing APIs only
make a difference for AEAD ciphers, which are already disabled for
versions before 3.5.

[v1-0001-Fix-build-with-gnutls-versions-3.0-to-3.2-Bug-324.patch (text/plain, attachment)]

Message #21 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: gavinsmith0123 <at> gmail.com, Noam Postavsky <npostavs <at> gmail.com>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Sat, 15 Sep 2018 18:26:51 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Cc: Gavin Smith <gavinsmith0123 <at> gmail.com>,  Ted Zlatanov <tzz <at> lifelogs.com>,  32446 <at> debbugs.gnu.org
> Date: Sat, 15 Sep 2018 10:44:04 -0400
> 
> I think we can keep most of the functionality: the missing APIs only
> make a difference for AEAD ciphers, which are already disabled for
> versions before 3.5.

Thanks.

Gavin, can you test this with your version of GnuTLS?

Message #24 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Gavin Smith <gavinsmith0123 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com,
 Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Sat, 15 Sep 2018 16:55:09 +0100

On Sat, Sep 15, 2018 at 06:26:51PM +0300, Eli Zaretskii wrote:
> Gavin, can you test this with your version of GnuTLS?

I applied Noam's patch, reconfigured to enable GnuTLS, and ran "make", 
and the build completed successfully.

Message #27 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gavin Smith <gavinsmith0123 <at> gmail.com>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com, npostavs <at> gmail.com
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Sat, 15 Sep 2018 19:17:10 +0300

> From: Gavin Smith <gavinsmith0123 <at> gmail.com>
> Date: Sat, 15 Sep 2018 16:55:09 +0100
> Cc: Noam Postavsky <npostavs <at> gmail.com>, tzz <at> lifelogs.com,
>         32446 <at> debbugs.gnu.org
> 
> On Sat, Sep 15, 2018 at 06:26:51PM +0300, Eli Zaretskii wrote:
> > Gavin, can you test this with your version of GnuTLS?
> 
> I applied Noam's patch, reconfigured to enable GnuTLS, and ran "make", 
> and the build completed successfully.

Thanks.

The patch LGTM as well, so, Noam, please push eto emacs-26, and
thanks.

Message #30 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com,
 Gavin Smith <gavinsmith0123 <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Sun, 16 Sep 2018 16:31:16 -0400

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> The patch LGTM as well, so, Noam, please push eto emacs-26, and
> thanks.

Ah, minor problem, I had initially written this on Windows, but it turns
out on GNU/Linux when the '#ifdef WINDOWSNT' part is skipped, gcc gives
a few warnings.  I've adjusted the patch to avoid this (see attached);
I'll push it tomorrow after double checking the updated version on
Windows.

  CC       gnutls.o
../../src/gnutls.c:59:0: warning: macro "HAVE_GNUTLS_DIGEST_GET_NAME" is not used [-Wunused-macros]
 # define HAVE_GNUTLS_DIGEST_GET_NAME
 
../../src/gnutls.c:43:0: warning: macro "HAVE_GNUTLS_CIPHER_GET_TAG_SIZE" is not used [-Wunused-macros]
 # define HAVE_GNUTLS_CIPHER_GET_TAG_SIZE
 
../../src/gnutls.c:50:0: warning: macro "HAVE_GNUTLS_CIPHER_GET_IV_SIZE" is not used [-Wunused-macros]
 # define HAVE_GNUTLS_CIPHER_GET_IV_SIZE
 
../../src/gnutls.c:58:0: warning: macro "HAVE_GNUTLS_DIGEST_LIST" is not used [-Wunused-macros]
 # define HAVE_GNUTLS_DIGEST_LIST

[v2-0001-Fix-build-with-gnutls-versions-3.0-to-3.2-Bug-324.patch (text/plain, attachment)]

Message #33 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com,
 Gavin Smith <gavinsmith0123 <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Mon, 17 Sep 2018 19:29:29 -0400

tags 32446 fixed
close 32446 26.2
quit

Noam Postavsky <npostavs <at> gmail.com> writes:

> I'll push it tomorrow after double checking the updated version on
> Windows.

> +#   ifdef HAVE_GNUTLS_DIGEST_GET_NAME
>    LOAD_DLL_FN (library, gnutls_digest_get_name);

> +#  ifdef HAVE_GNUTLS_DIGEST_GET_NAME
> +#   define gnutls_digest_get_name fn_gnutls_digest_get_name

Fixed those two ifdef checks, and pushed to emacs-26.

[1: b5bee6bf48]: 2018-09-17 17:54:32 -0400
  Fix build with gnutls versions 3.0 to 3.2 (Bug#32446)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf

Message #40 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com, gavinsmith0123 <at> gmail.com
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Tue, 18 Sep 2018 13:28:03 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Cc: 32446 <at> debbugs.gnu.org,  tzz <at> lifelogs.com,  Gavin Smith <gavinsmith0123 <at> gmail.com>
> Date: Mon, 17 Sep 2018 19:29:29 -0400
> 
> > I'll push it tomorrow after double checking the updated version on
> > Windows.
> 
> > +#   ifdef HAVE_GNUTLS_DIGEST_GET_NAME
> >    LOAD_DLL_FN (library, gnutls_digest_get_name);
> 
> > +#  ifdef HAVE_GNUTLS_DIGEST_GET_NAME
> > +#   define gnutls_digest_get_name fn_gnutls_digest_get_name
> 
> Fixed those two ifdef checks, and pushed to emacs-26.
> 
> [1: b5bee6bf48]: 2018-09-17 17:54:32 -0400
>   Fix build with gnutls versions 3.0 to 3.2 (Bug#32446)
>   https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b5bee6bf489d8c54a5e39baed4d578ada54c99bf

This caused Emacs with GnuTLS 3.4.15 to crash in the test suite.  The
problem is that the test suite avoids trying AEAD-capable ciphers when
AEAD is unavailable, but one of the changes in the above made _all_
ciphers look like not AEAD-capable.

I fixed it by allowing gnutls_cipher_get_tag_size for versions above
3.2.2, as it should at least allow use to continue skipping
AEAD-capable ciphers based on this assumption, and it shouldn't affect
GnuTLS 2.x.

Message #43 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32446 <at> debbugs.gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>,
 Gavin Smith <gavinsmith0123 <at> gmail.com>
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Tue, 18 Sep 2018 09:14:46 -0400

On 18 September 2018 at 06:28, Eli Zaretskii <eliz <at> gnu.org> wrote:

> This caused Emacs with GnuTLS 3.4.15 to crash in the test suite.  The
> problem is that the test suite avoids trying AEAD-capable ciphers when
> AEAD is unavailable, but one of the changes in the above made _all_
> ciphers look like not AEAD-capable.

Oh, you mean using an AEAD cipher with the non-AEAD codepath crashes?

> I fixed it by allowing gnutls_cipher_get_tag_size for versions above
> 3.2.2, as it should at least allow use to continue skipping
> AEAD-capable ciphers based on this assumption, and it shouldn't affect
> GnuTLS 2.x.

Right, makes sense.

Message #46 received at 32446 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 32446 <at> debbugs.gnu.org, tzz <at> lifelogs.com, gavinsmith0123 <at> gmail.com
Subject: Re: bug#32446: Configure-time requirement for gnutls is too old
Date: Tue, 18 Sep 2018 17:08:12 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Tue, 18 Sep 2018 09:14:46 -0400
> Cc: 32446 <at> debbugs.gnu.org, Ted Zlatanov <tzz <at> lifelogs.com>, 
> 	Gavin Smith <gavinsmith0123 <at> gmail.com>
> 
> On 18 September 2018 at 06:28, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> > This caused Emacs with GnuTLS 3.4.15 to crash in the test suite.  The
> > problem is that the test suite avoids trying AEAD-capable ciphers when
> > AEAD is unavailable, but one of the changes in the above made _all_
> > ciphers look like not AEAD-capable.
> 
> Oh, you mean using an AEAD cipher with the non-AEAD codepath crashes?

More like "with non-AEAD capable gnutls.c".  It's arguably a bug in
the test suite, but given the available attributes of the ciphgers, I
couldn't find any alternative way of filtering out the AEAD ciphers.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.