GNU bug report logs - #32436
26.1.50; Duplicate bibtex/BibTeX custom groups

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32436 in the body.
You can then email your comments to 32436 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Tue, 14 Aug 2018 16:35:19 +0300

X-Debbugs-Cc: Roland Winkler <winkler <at> gnu.org>
Severity: minor

The file lisp/textmodes/bibtex.el seems to use both custom group names
'bibtex' and 'BibTeX':

0. emacs -Q
1. M-x customize-group RET
2. bibtex TAB TAB
   => BibTeX, bibtex, bibtex-autokey

The name 'BibTeX' is only used once and is never defined via defgroup,
however, so I presume it's just a typo introduced in Emacs 24.1:

[2de69e00f3]: 2011-07-05 12:44:15 -0500
  lisp/textmodes/bibtex.el: add support for biblatex
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2de69e00f3991d554d37327a2afd71b981d4e488

Thanks,

-- 
Basil

In GNU Emacs 26.1.50 (build 4, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-08-14 built on thunk
Repository revision: f882de8b8095c3a42d1f6d22ed3f7aed57e9f5e0
Windowing system distributor 'The X.Org Foundation', version 11.0.12000000
System Description:	Debian GNU/Linux testing (buster)

Message #8 received at 32436 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: 32436 <at> debbugs.gnu.org
Cc: roland winkler <winkler <at> gnu.org>
Subject: Re: bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Tue, 14 Aug 2018 16:43:18 +0300

[Message part 1 (text/plain, inline)]

tags 32436 patch
quit

[0001-Fix-duplicate-custom-group-names-in-bibtex.el.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

I attach a patch which the presumed typo and then bumps the user
option's :version.  Is a change of custom group significant enough to
justify this, or should the :version be left alone?

Thanks,

-- 
Basil

Message #15 received at 32436 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 32436 <at> debbugs.gnu.org, roland winkler <winkler <at> gnu.org>
Subject: Re: bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Tue, 14 Aug 2018 22:42:56 -0400

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

> I attach a patch which the presumed typo and then bumps the user
> option's :version.  Is a change of custom group significant enough to
> justify this, or should the :version be left alone?

I'd say no, since there is no need for users to review their settings of
this option because of this.  And if we look at the associated *Help*
text:

    This variable was introduced, or its default value was changed, in
    version 26.2 of Emacs.

That wouldn't be correct, since you haven't introduced, nor changed the
default value of the variable in your patch.

Message #18 received at 32436 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 32436 <at> debbugs.gnu.org, roland winkler <winkler <at> gnu.org>
Subject: Re: bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Wed, 15 Aug 2018 10:09:06 +0300

[0001-Fix-duplicate-custom-group-names-in-bibtex.el.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> writes:

> "Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
>> I attach a patch which the presumed typo and then bumps the user
>> option's :version.  Is a change of custom group significant enough to
>> justify this, or should the :version be left alone?
>
> I'd say no, since there is no need for users to review their settings of
> this option because of this.  And if we look at the associated *Help*
> text:
>
>     This variable was introduced, or its default value was changed, in
>     version 26.2 of Emacs.
>
> That wouldn't be correct, since you haven't introduced, nor changed the
> default value of the variable in your patch.

Fair enough; I've removed the :version change from the attached patch.

Thanks,

-- 
Basil

Message #21 received at 32436 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 32436 <at> debbugs.gnu.org, roland winkler <winkler <at> gnu.org>
Subject: Re: bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Fri, 17 Aug 2018 15:38:11 -0400

tags 32436 fixed
close 32436 26.2
quit

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:
>
> Fair enough; I've removed the :version change from the attached patch.

Pushed to emacs-26.

[1: 7bc9ce7431]: 2018-08-17 15:22:06 -0400
  Fix duplicate custom group names in bibtex.el
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7bc9ce7431ae6ab4e6828015f75caf1f2196a97c

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.