GNU bug report logs - #32431
[PATCH] gnu: clementine: Drop dependency on qtwebkit.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: bug#32431: closed (Re: [bug#32431] [PATCH] gnu: clementine: Drop
 dependency on qtwebkit.)
Date: Wed, 15 Aug 2018 18:36:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#32431: [PATCH] gnu: clementine: Drop dependency on qtwebkit.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 32431 <at> debbugs.gnu.org.

-- 
32431: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32431
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 32431-done <at> debbugs.gnu.org
Subject: Re: [bug#32431] [PATCH] gnu: clementine: Drop dependency on qtwebkit.
Date: Wed, 15 Aug 2018 14:35:26 -0400

[Message part 3 (text/plain, inline)]

On Wed, Aug 15, 2018 at 07:57:07AM +0100, Pierre Langlois wrote:
> Ah yes, that's expected. when packaging this we agreed not to add any of
> the gst-plugins-{good,bad,ugly} to the inputs and let the user install
> what they want instead [0]. Although, while we defenetely shouldn't add
> 'bad' and 'ugly', I don't see any reason not to add 'good' to make sure
> it all works out of the box. But then, the dialog hints the user should
> install them so that's not so bad as it is.
> 
> Basically, I don't mind either way :-).

Previously, MP3 decoding in GStreamer was in gst-plugins-ugly because
MP3 was patented, but the patents expired and now gst-plugins-good
includes MP3.

I think the package should work as-is for its primary use case (music
playback), so I pushed your patches and also added gst-plugins-good and
gst-libav, ending with commit 8473f8024ceb8e7249702289b206782de7d4c71c.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Cc: Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: [PATCH] gnu: clementine: Drop dependency on qtwebkit.
Date: Mon, 13 Aug 2018 20:26:21 +0100

[Message part 6 (text/plain, inline)]

Hello guix!

I realised clementine wasn't building because qtwebkit isn't building
either. But, it turns out that while it's an optional dependency
according to CMakeList.txt, it isn't actually used anywhere in the
code. Here's a patch that removes qtwebkit from its inputs.

[0001-gnu-clementine-Drop-dependency-on-qtwebkit.patch (text/x-patch, attachment)]

[Message part 8 (text/plain, inline)]

Thanks!
Pierre

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.