GNU bug report logs - #32410
[PATCH] libgcrypt: Make it reproducible

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32410 in the body.
You can then email your comments to 32410 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: <guix-patches <at> gnu.org>
Subject: [PATCH] libgcrypt: Make it reproducible
Date: Thu, 9 Aug 2018 17:04:29 +0200

[Message part 1 (text/plain, inline)]

This is a fix for core-updates.

The libgcrypt package contains a yat2m command that adds a timestamp
into the generated man-page. The (more or less) same C-file exits
also in the packages gnupg and libgpg-error. There it already considers
SOURCE_DATE_EPOCH. I diffed from gnupg and removed unrelated things.

I will also report upstream.

Björn

[0001-gnu-libgcrypt-Make-build-reproducible.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 32410 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: 32410 <at> debbugs.gnu.org, Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: [bug#32410] [PATCH] libgcrypt: Make it reproducible
Date: Tue, 14 Aug 2018 07:06:15 +0200

[Message part 1 (text/plain, inline)]

On Thu, 9 Aug 2018 17:04:29 +0200
Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> wrote:

> This is a fix for core-updates.
> 
> The libgcrypt package contains a yat2m command that adds a timestamp
> into the generated man-page. The (more or less) same C-file exits
> also in the packages gnupg and libgpg-error. There it already
> considers SOURCE_DATE_EPOCH. I diffed from gnupg and removed
> unrelated things.

Concerning tests:

1. It compiles.
2. New manpage does contain an EPOCH timestamp.
3. gpg -c still works (And strace says it's loading the new libgcrypt).
4. diffoscope of old and new store entry only shows the manpage change
and of cause reference updates into new store entry.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #13 received at 32410-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: 32410-done <at> debbugs.gnu.org
Subject: Re: [bug#32410] [PATCH] libgcrypt: Make it reproducible
Date: Thu, 16 Aug 2018 17:11:06 -0400

[Message part 1 (text/plain, inline)]

On Thu, Aug 09, 2018 at 05:04:29PM +0200, Björn Höfling wrote:
> This is a fix for core-updates.
> 
> The libgcrypt package contains a yat2m command that adds a timestamp
> into the generated man-page. The (more or less) same C-file exits
> also in the packages gnupg and libgpg-error. There it already considers
> SOURCE_DATE_EPOCH. I diffed from gnupg and removed unrelated things.
> 
> I will also report upstream.

Thanks, please reply with a link to the upstream discussion.

> From 908c760f89ae5b47edbb0124339eab5801196f62 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
>  <bjoern.hoefling <at> bjoernhoefling.de>
> Date: Thu, 9 Aug 2018 16:45:45 +0200
> Subject: [PATCH] gnu: libgcrypt: Make build reproducible.
> 
> * gnu/packages/patches/libgcrypt-make-yat2m-reproducible.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/gnupg.scm (libgcrypt)[source]: Use it.

Pushed as 4866cba66ae40d722bb6c50b7dca27725ffa4532

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 32410-done <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32410-done <at> debbugs.gnu.org
Subject: Re: [bug#32410] [PATCH] libgcrypt: Make it reproducible
Date: Fri, 17 Aug 2018 09:40:27 +0200

[Message part 1 (text/plain, inline)]

On Thu, 16 Aug 2018 17:11:06 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> On Thu, Aug 09, 2018 at 05:04:29PM +0200, Björn Höfling wrote:
> > This is a fix for core-updates.
> > 
> > The libgcrypt package contains a yat2m command that adds a timestamp
> > into the generated man-page. The (more or less) same C-file exits
> > also in the packages gnupg and libgpg-error. There it already
> > considers SOURCE_DATE_EPOCH. I diffed from gnupg and removed
> > unrelated things.
> > 
> > I will also report upstream.  
> 
> Thanks, please reply with a link to the upstream discussion.

It's not (yet) a discussion :-) The task is tracked here:

https://dev.gnupg.org/T4102


> > From 908c760f89ae5b47edbb0124339eab5801196f62 Mon Sep 17 00:00:00
> > 2001 From: =?UTF-8?q?Bj=C3=B6rn=20H=C3=B6fling?=
> >  <bjoern.hoefling <at> bjoernhoefling.de>
> > Date: Thu, 9 Aug 2018 16:45:45 +0200
> > Subject: [PATCH] gnu: libgcrypt: Make build reproducible.
> > 
> > * gnu/packages/patches/libgcrypt-make-yat2m-reproducible.patch: New
> > file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
> > * gnu/packages/gnupg.scm (libgcrypt)[source]: Use it.  
> 
> Pushed as 4866cba66ae40d722bb6c50b7dca27725ffa4532

Thanks.

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.