GNU bug report logs - #32394
[PATCH] gnu: restic: Fix tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32394 in the body.
You can then email your comments to 32394 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: restic: Fix tests.
Date: Wed,  8 Aug 2018 08:29:06 +0300

* gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.
---
 gnu/packages/backup.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index 0733d9c34..bca070d3f 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -850,6 +850,9 @@ is like a time machine for your data. ")
     (build-system go-build-system)
     (arguments
      `(#:import-path "github.com/restic/restic"
+       #:modules ((srfi srfi-26)
+                  (guix build go-build-system)
+                  (guix build utils))
        #:unpack-path "github.com/restic"
       ;; We don't need to install the source code for end-user applications.
        #:install-source? #f
@@ -862,6 +865,18 @@ is like a time machine for your data. ")
                                         ,version)
                (invoke "go" "run" "build.go"))))
 
+         (replace 'check
+           (lambda _
+             (with-directory-excursion (string-append
+                                        "src/github.com/restic/restic-"
+                                        ,version)
+               (for-each (cut delete-file <>)
+                         '(;; Requires a network.
+                           "internal/backend/rest/rest_int_test.go"
+                           ;; unexpected error: fusermount: exit status 1
+                           "cmd/restic/integration_fuse_test.go"))
+               (invoke "go" "run" "build.go" "--test"))))
+
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let ((out (assoc-ref outputs "out"))
-- 
2.18.0

Message #8 received at 32394 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32394 <at> debbugs.gnu.org
Subject: Re: [bug#32394] [PATCH] gnu: restic: Fix tests.
Date: Wed, 8 Aug 2018 09:22:15 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 08, 2018 at 08:29:06AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.

Thanks, LGTM! Should we report the issues upstream?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 32394 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32394 <at> debbugs.gnu.org
Subject: Re: [bug#32394] [PATCH] gnu: restic: Fix tests.
Date: Wed, 08 Aug 2018 20:58:32 +0300

[Message part 1 (text/plain, inline)]

Hello Leo,

Thank you for review.

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Aug 08, 2018 at 08:29:06AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/backup.scm (restic)[arguments]: Replace 'check' phase.
>
> Thanks, LGTM! Should we report the issues upstream?

I've played little bit more and found that
‘internal/backend/rest/rest_int_test.go’ is actually passes.

Pushed 4976ebddf1a4735ee12808083876f573121993bf as with changes:

[restic.diff (text/x-patch, inline)]

diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
index bca070d3f..251dadf84 100644
--- a/gnu/packages/backup.scm
+++ b/gnu/packages/backup.scm
@@ -850,9 +850,6 @@ is like a time machine for your data. ")
     (build-system go-build-system)
     (arguments
      `(#:import-path "github.com/restic/restic"
-       #:modules ((srfi srfi-26)
-                  (guix build go-build-system)
-                  (guix build utils))
        #:unpack-path "github.com/restic"
       ;; We don't need to install the source code for end-user applications.
        #:install-source? #f
@@ -870,11 +867,8 @@ is like a time machine for your data. ")
              (with-directory-excursion (string-append
                                         "src/github.com/restic/restic-"
                                         ,version)
-               (for-each (cut delete-file <>)
-                         '(;; Requires a network.
-                           "internal/backend/rest/rest_int_test.go"
-                           ;; unexpected error: fusermount: exit status 1
-                           "cmd/restic/integration_fuse_test.go"))
+               ;; unexpected error: fusermount: exit status 1
+               (delete-file "cmd/restic/integration_fuse_test.go")
                (invoke "go" "run" "build.go" "--test"))))
 
          (replace 'install

[Message part 3 (text/plain, inline)]

I'm not sure about reporting to upstream, because I think fusermount
fail in a build process is Guix specific.  WDYT?

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 32394 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32394 <at> debbugs.gnu.org
Subject: Re: [bug#32394] [PATCH] gnu: restic: Fix tests.
Date: Wed, 8 Aug 2018 14:50:27 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 08, 2018 at 08:58:32PM +0300, Oleg Pykhalov wrote:
> I'm not sure about reporting to upstream, because I think fusermount
> fail in a build process is Guix specific.  WDYT?

Agreed, if it's really specific to Guix then I think we should not report
it.

[signature.asc (application/pgp-signature, inline)]

Message #21 received at 32394-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32394-done <at> debbugs.gnu.org
Subject: Re: [bug#32394] [PATCH] gnu: restic: Fix tests.
Date: Wed, 08 Aug 2018 23:44:09 +0300

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Aug 08, 2018 at 08:58:32PM +0300, Oleg Pykhalov wrote:
>> I'm not sure about reporting to upstream, because I think fusermount
>> fail in a build process is Guix specific.  WDYT?
>
> Agreed, if it's really specific to Guix then I think we should not report
> it.

OK, then I close the bug report.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.