Subject: Re: [bug#32386] [PATCH] gnu: Add ubridge.

From: Oleg Pykhalov <[email-masked]>
Date: Wed, 08 Aug 2018 02:50:42 +0300

Hello Leo,

Thank you for review.

Leo Famulari <[email-masked]> writes:

> On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/networking.scm (ubridge): New variable.
>> +         (add-before 'build 'set-env-cc
>> +           (lambda _
>> +             (setenv "CC" "gcc")
>> +           #t))
>
> Would it work to set this in #:make-flags? I think that's a little
> clearer.

Indeed, I forgot about ‘#:make-flags’, thank you.

>> +    (description "uBridge is a simple program to create user-land bridges
>> +between various technologies.  Currently bridging between UDP tunnels,
>> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
>
> Please add a comma in the second sentence: "Currently, bridging between
> UDP tunnels, Ethernet, and TAP interfaces is supported."

OK.

Pushed as 277f25ce5af060e2a057f5f43eeea2ae6f4fc5b9

Thanks,
Oleg.