Subject: bug#32386: closed (Re: [bug#32386] [PATCH] gnu: Add ubridge.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 08 Aug 2018 02:57:02 +0000

Your bug report

#32386: [PATCH] gnu: Add ubridge.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
32386: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32386
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#32386] [PATCH] gnu: Add ubridge.
From: Oleg Pykhalov <[email-masked]>
To: Leo Famulari <[email-masked]>
Cc: [email-masked]
Date: Wed, 08 Aug 2018 02:50:42 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Leo,

Thank you for review.

Leo Famulari <[email-masked]> writes:

> On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/networking.scm (ubridge): New variable.
>> +         (add-before 'build 'set-env-cc
>> +           (lambda _
>> +             (setenv "CC" "gcc")
>> +           #t))
>
> Would it work to set this in #:make-flags? I think that's a little
> clearer.

Indeed, I forgot about ‘#:make-flags’, thank you.

>> +    (description "uBridge is a simple program to create user-land bridges
>> +between various technologies.  Currently bridging between UDP tunnels,
>> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
>
> Please add a comma in the second sentence: "Currently, bridging between
> UDP tunnels, Ethernet, and TAP interfaces is supported."

OK.

Pushed as 277f25ce5af060e2a057f5f43eeea2ae6f4fc5b9

Thanks,
Oleg.

Subject: [PATCH] gnu: Add ubridge.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked]
Cc: Oleg Pykhalov <[email-masked]>
Date: Tue, 7 Aug 2018 11:38:10 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/networking.scm (ubridge): New variable.
---
 gnu/packages/networking.scm | 40 +++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 5055f030a..a8c5a7aee 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2042,3 +2042,43 @@ SNMP v3 using both IPv4 and IPv6.")
                    (license:non-copyleft
                     "http://www.net-snmp.org/about/license.html"
                     "CMU/UCD copyright notice")))))
+
+(define-public ubridge
+  (package
+    (name "ubridge")
+    (version "0.9.14")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/GNS3/ubridge/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1hivb8wqkk5047bdl2vbsbcvkmam1107hx1ahy4virq2bkqki1fj"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (add-before 'build 'set-env-cc
+           (lambda _
+             (setenv "CC" "gcc")
+           #t))
+         (add-before 'install 'set-bindir
+           (lambda* (#:key  inputs outputs #:allow-other-keys)
+             (let ((bin (string-append (assoc-ref outputs "out")
+                                       "/bin")))
+               (mkdir-p bin)
+               (substitute* "Makefile"
+                 (("\\$\\(BINDIR\\)") bin)
+                 (("\tsetcap cap_net.*$") "")))
+             #t)))))
+    (inputs
+     `(("libpcap" ,libpcap)))
+    (home-page "https://github.com/GNS3/ubridge/")
+    (synopsis "Bridge for UDP tunnels, Ethernet, TAP and VMnet interfaces")
+    (description "uBridge is a simple program to create user-land bridges
+between various technologies.  Currently bridging between UDP tunnels,
+Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
+    (license license:gpl3+)))
-- 
2.18.0