GNU bug report logs - #32386
[PATCH] gnu: Add ubridge.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32386 in the body.
You can then email your comments to 32386 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add ubridge.
Date: Tue,  7 Aug 2018 11:38:10 +0300

* gnu/packages/networking.scm (ubridge): New variable.
---
 gnu/packages/networking.scm | 40 +++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 5055f030a..a8c5a7aee 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2042,3 +2042,43 @@ SNMP v3 using both IPv4 and IPv6.")
                    (license:non-copyleft
                     "http://www.net-snmp.org/about/license.html"
                     "CMU/UCD copyright notice")))))
+
+(define-public ubridge
+  (package
+    (name "ubridge")
+    (version "0.9.14")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/GNS3/ubridge/archive/v"
+                                  version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1hivb8wqkk5047bdl2vbsbcvkmam1107hx1ahy4virq2bkqki1fj"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ;no tests
+       #:phases
+       (modify-phases %standard-phases
+         (delete 'configure)
+         (add-before 'build 'set-env-cc
+           (lambda _
+             (setenv "CC" "gcc")
+           #t))
+         (add-before 'install 'set-bindir
+           (lambda* (#:key  inputs outputs #:allow-other-keys)
+             (let ((bin (string-append (assoc-ref outputs "out")
+                                       "/bin")))
+               (mkdir-p bin)
+               (substitute* "Makefile"
+                 (("\\$\\(BINDIR\\)") bin)
+                 (("\tsetcap cap_net.*$") "")))
+             #t)))))
+    (inputs
+     `(("libpcap" ,libpcap)))
+    (home-page "https://github.com/GNS3/ubridge/")
+    (synopsis "Bridge for UDP tunnels, Ethernet, TAP and VMnet interfaces")
+    (description "uBridge is a simple program to create user-land bridges
+between various technologies.  Currently bridging between UDP tunnels,
+Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
+    (license license:gpl3+)))
-- 
2.18.0

Message #8 received at 32386 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32386 <at> debbugs.gnu.org
Subject: Re: [bug#32386] [PATCH] gnu: Add ubridge.
Date: Tue, 7 Aug 2018 16:58:57 -0400

[Message part 1 (text/plain, inline)]

On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/networking.scm (ubridge): New variable.
> +         (add-before 'build 'set-env-cc
> +           (lambda _
> +             (setenv "CC" "gcc")
> +           #t))

Would it work to set this in #:make-flags? I think that's a little
clearer.

> +    (description "uBridge is a simple program to create user-land bridges
> +between various technologies.  Currently bridging between UDP tunnels,
> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")

Please add a comma in the second sentence: "Currently, bridging between
UDP tunnels, Ethernet, and TAP interfaces is supported."

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 32386-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 32386-done <at> debbugs.gnu.org
Subject: Re: [bug#32386] [PATCH] gnu: Add ubridge.
Date: Wed, 08 Aug 2018 02:50:42 +0300

[Message part 1 (text/plain, inline)]

Hello Leo,

Thank you for review.

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Aug 07, 2018 at 11:38:10AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/networking.scm (ubridge): New variable.
>> +         (add-before 'build 'set-env-cc
>> +           (lambda _
>> +             (setenv "CC" "gcc")
>> +           #t))
>
> Would it work to set this in #:make-flags? I think that's a little
> clearer.

Indeed, I forgot about ‘#:make-flags’, thank you.

>> +    (description "uBridge is a simple program to create user-land bridges
>> +between various technologies.  Currently bridging between UDP tunnels,
>> +Ethernet and TAP interfaces is supported.  Packet capture is also supported.")
>
> Please add a comma in the second sentence: "Currently, bridging between
> UDP tunnels, Ethernet, and TAP interfaces is supported."

OK.

Pushed as 277f25ce5af060e2a057f5f43eeea2ae6f4fc5b9

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.