Subject: Re: bug#32378: [PATCH] bibtex-next/previous-entry

From: Eli Zaretskii <[email-masked]>
Date: Tue, 21 Aug 2018 05:28:27 +0300

> From: Alex Branham <[email-masked]>
> Date: Mon, 20 Aug 2018 14:23:58 -0500
> Cc: [email-masked]
> 
> > Would it make sense to use [remap forward-paragraph] and [remap
> > backward-paragraph] instead of "\M-\}" and "\M-\{"?  (I guess the
> > question is how "paragraph-like" are these movement commands)
> 
> Yes, that probably makes sense. Revised patch attached.

Thanks.

> ++++
> +** bibtex
> +*** New commands bibtex-next-entry and bibtex-previous-entry

Missing period at end of sentence.  Also, please quote command 'like
this'.

> +They are bound to M-{ and M-} in bibtex-mode-map.
> +
>  +++
>  ** Dired
>  
> diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
> index 50a30cf6c3..fccaed7cac 100644
> --- a/lisp/textmodes/bibtex.el
> +++ b/lisp/textmodes/bibtex.el
> @@ -1356,6 +1356,8 @@ bibtex-mode-map
>      ;; The Key `C-c&' is reserved for reftex.el
>      (define-key km "\t" 'bibtex-find-text)
>      (define-key km "\n" 'bibtex-next-field)
> +    (define-key km [remap forward-paragraph] 'bibtex-next-entry)
> +    (define-key km [remap backward-paragraph] 'bibtex-previous-entry)
>      (define-key km "\M-\t" 'completion-at-point)
>      (define-key km "\C-c\"" 'bibtex-remove-delimiters)
>      (define-key km "\C-c{" 'bibtex-remove-delimiters)
> @@ -1415,6 +1417,8 @@ bibtex-mode-map
>      ("Moving inside an Entry"
>       ["End of Field" bibtex-find-text t]
>       ["Next Field" bibtex-next-field t]
> +     ["Next entry" bibtex-next-entry t]
> +     ["Previous entry" bibtex-previous-entry t]
>       ["Beginning of Entry" bibtex-beginning-of-entry t]
>       ["End of Entry" bibtex-end-of-entry t]
>      "--"
> @@ -4452,6 +4456,20 @@ bibtex-next-field
>        (goto-char (match-beginning 0)))
>      (bibtex-find-text begin nil bibtex-help-message)))
>  
> +(defun bibtex-next-entry (&optional arg)
> +  "Move point ARG entries forward."

We usually say in the doc string that interactively ARG is the prefix
argument.  Also that the default is 1 if ARG is omitted or nil.