GNU bug report logs - #32375
Bug Gzip v1.9

Previous Next

Full log

View this message in rfc822 format

From: Johannes Przybilla <johannes.przybilla <at> rwth-aachen.de>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 32375 <at> debbugs.gnu.org, Antonio Diaz Diaz <antonio <at> gnu.org>, Bdale Garbee <bdale <at> gag.com>
Subject: bug#32375: Bug Gzip v1.9
Date: Sun, 19 Aug 2018 12:34:22 +0200

Hello Paul.

I only recently got around to check the fix you committed.
It seems to me that after 'volatile_strcpy (remove_ofname, ofname);‘ the 'remove_ofname‘ variable is not used anymore.
The 'xunlink' function in 'remove_output_file' is still called on 'ofname' instead of 'remove_ofname‘.
Therefore the non-volatile access still occurs in the signal handler.
Could you look into that?

Best regards,
Johannes

> Am 08.08.2018 um 11:34 schrieb Paul Eggert <eggert <at> cs.ucla.edu>:
> 
> Johannes Przybilla wrote:
>> This can lead to undefined behaviour for example in the case of nested signal handler calls
> 
> These can't happen in gzip, so we should be OK here.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.