GNU bug report logs - #32358
Add pcscd service

Previous Next

Full log

View this message in rfc822 format

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 32358 <at> debbugs.gnu.org
Subject: [bug#32358] Add pcscd service
Date: Tue, 14 Aug 2018 22:55:30 -0700

[Message part 1 (text/plain, inline)]

Hi Clément and Arun,

Clément, your explanation makes sense.  With that information, I now
understand why it isn't necessary to use make-forkexec-constructor in
this case.  Thank you for taking the time to explain it in detail!

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> I have finished work on the tests too. Please find attached the updated
> patch.

Awesome!

> +(define* (run-pcscd-test)
> +  "Run tests of 'pcscd-service-type'."
> +  (define os
> +    (marionette-operating-system
> +     %pcscd-os
> +     #:imported-modules '((gnu services herd))))

If you use the #:requirements keyword argument to
marionette-operating-system, you can guarantee that the marionette
service will start up after the pcscd service.  This would be good in
order to avoid the possibility that you might marionette-eval something
before the pcscd service is started.

With that small change, if the system test passes, I think this is good
to go to master.  Thank you for taking the time to work on this and
iterate through the feedback!

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.