GNU bug report logs - #32344
Add option to keep colorization in comint, use it in python.el

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: behrmann <at> physik.fu-berlin.de, eggert <at> cs.ucla.edu, 32344 <at> debbugs.gnu.org
Subject: bug#32344: [PATCH] 26.3/27 Option to avoid comint override colorization provided by major modes
Date: Mon, 10 Aug 2020 14:51:16 +0200

Carlos Pita <carlosjosepita <at> gmail.com> writes:

> I've merged both patches since the python.el one was trivial and
> dependent on the other and the main target of the new option.
>
> I've also rewritten the commit message following the conventions
> described in CONTRIBUTE.
>
> Here is the commit so that you can easily comment online if you so
> prefer:
> https://github.com/memeplex/emacs/commit/27acd97dfec7ecd9667a032e3a94650cb01244c1

Could you post the patch here instead?  It's nice to have the proposed
patches in the bug tracker.

Anyway, while Juri's suggestion makes sense (merging faces) in general,
I think the mechanism here (making comint not do any face mangling for
the modes that do it themselves) is cleaner.  So I think Carlos' patch
should be applied to Emacs.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.