GNU bug report logs - #32344
Add option to keep colorization in comint, use it in python.el

Previous Next

Package: emacs;

Reported by: Carlos Pita <carlosjosepita <at> gmail.com>

Date: Thu, 2 Aug 2018 00:15:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Carlos Pita <carlosjosepita <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>, 32344 <at> debbugs.gnu.org
Subject: bug#32344: Add option to keep colorization in comint, use it in python.el
Date: Mon, 21 Oct 2019 17:53:06 -0300

> But I wonder if you could just replace add-text-properties with
> add-face-text-property?  It will keep your previous text properties
> and will just merge them with the comint-highlight-input face.

I'm not sure about this:

> If any text in the region already has a non-nil ‘face’ property, those
> face(s) are retained.

Is the default face represented as a nil face property? Will it be
overridden? In that case the mix could be ugly.

In general I'd prefer to keep both paths of execution as separate as
possible so as to avoid regressions.
This bug report was last modified 4 years and 275 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.