GNU bug report logs - #32344
Add option to keep colorization in comint, use it in python.el

Previous Next

Package: emacs;

Reported by: Carlos Pita <carlosjosepita <at> gmail.com>

Date: Thu, 2 Aug 2018 00:15:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 26.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 32344 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Carlos Pita <carlosjosepita <at> gmail.com>
Cc: behrmann <at> physik.fu-berlin.de, eggert <at> cs.ucla.edu, 32344 <at> debbugs.gnu.org
Subject: Re: bug#32344:
Date: Sun, 20 Oct 2019 18:57:39 +0300
> Forgot the screenshots.

So nice looking screenshot, thanks.

But I wonder if you could just replace add-text-properties with
add-face-text-property?  It will keep your previous text properties
and will just merge them with the comint-highlight-input face.

So when the face comint-highlight-input is customized to have
no face attributes, add-face-text-property will do nothing.

But it would be more nice to change the default value of the face
comint-highlight-input to some light-grey background (it seems
a new face attribute ':extend' is not needed here).
Then add-face-text-property will add this background
to your fontified comint input.

PS: would other modes benefit from fontifying the input
with their syntax.  In particular, I don't understand
why the input is not fontified using emacs-lisp-mode
in the minibuffer of ‘M-:’ (‘eval-expression’)




This bug report was last modified 4 years and 276 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.