From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Do not store mtime when compressing stdin Resent-From: "Bernhard M. Wiedemann" Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Wed, 01 Aug 2018 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: 32342@debbugs.gnu.org Cc: "Bernhard M. Wiedemann" X-Debbugs-Original-To: bug-gzip@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.153312433310125 (code B ref -1); Wed, 01 Aug 2018 11:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Aug 2018 11:52:13 +0000 Received: from localhost ([127.0.0.1]:37009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkpfo-0002dE-NB for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkpfn-0002d3-Or for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkpfh-0001C3-Sa for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkpfh-0001Bx-Ph for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkpfg-00042v-Kf for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkpfb-00016B-PF for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:52:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:49718 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkpfb-00014C-ID for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:51:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 57D61AE4E for ; Wed, 1 Aug 2018 11:51:57 +0000 (UTC) From: "Bernhard M. Wiedemann" Date: Wed, 1 Aug 2018 13:51:40 +0200 Message-Id: <20180801115140.18679-1-bwiedemann@suse.de> X-Mailer: git-send-email 2.16.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This allows for reproducible output of echo foo | gzip | md5sum tar -cz -H ustar SOMEFILE | md5sum See https://reproducible-builds.org/ for why this is good. --- gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gzip.c b/gzip.c index a023d81..4b00e42 100644 --- a/gzip.c +++ b/gzip.c @@ -767,7 +767,7 @@ local void treat_stdin() { if (S_ISREG (istat.st_mode)) time_stamp = get_stat_mtime (&istat); - else + else if (decompress) gettime (&time_stamp); } -- 2.16.4 From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Do not store mtime when compressing stdin Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 06:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: "Bernhard M. Wiedemann" , 32342@debbugs.gnu.org Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.153319247919277 (code B ref 32342); Thu, 02 Aug 2018 06:48:02 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 06:47:59 +0000 Received: from localhost ([127.0.0.1]:38160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl7Ow-00050q-6d for submit@debbugs.gnu.org; Thu, 02 Aug 2018 02:47:58 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl7Ot-00050Z-R3 for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 02:47:56 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EB3EE160E02; Wed, 1 Aug 2018 23:47:49 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0gJDe9bDQ8aW; Wed, 1 Aug 2018 23:47:49 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 40891160E71; Wed, 1 Aug 2018 23:47:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OCTOZnzlRkEB; Wed, 1 Aug 2018 23:47:49 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id F1DBC160E02; Wed, 1 Aug 2018 23:47:48 -0700 (PDT) References: <20180801115140.18679-1-bwiedemann@suse.de> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Wed, 1 Aug 2018 23:47:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180801115140.18679-1-bwiedemann@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bernhard M. Wiedemann wrote: > This allows for reproducible output of > echo foo | gzip | md5sum gzip -n already does that, so we don't need to change the gzip source code to get reproducible output. From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Do not store mtime when compressing stdin Resent-From: "Bernhard M. Wiedemann" Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: Paul Eggert , 32342@debbugs.gnu.org Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.153319870729581 (code B ref 32342); Thu, 02 Aug 2018 08:32:02 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 08:31:47 +0000 Received: from localhost ([127.0.0.1]:38232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl91P-0007h3-Fc for submit@debbugs.gnu.org; Thu, 02 Aug 2018 04:31:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:55700 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl91N-0007gp-Ca for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 04:31:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A88AFAF40; Thu, 2 Aug 2018 08:31:38 +0000 (UTC) References: <20180801115140.18679-1-bwiedemann@suse.de> From: "Bernhard M. Wiedemann" Openpgp: preference=signencrypt Autocrypt: addr=bwiedemann@suse.de; prefer-encrypt=mutual; keydata= xsDiBDa4Do4RBADrHxWZStG7ZjH+EKgROa9ISXQi21wGNSPOA0XiAExp4gotZ7yZJwLL2vkt 71vNDdLoAexG7cU1jq3aK273qGBF4QOzO/OqUmtq3eugIpGR89Fd3gHFTl7ob62iUyu2Rr9p 4PV/BHwjAVJQac9Oa9gUjk2J6/FD0aERZLY3MTbj0QCg/3vFC6whS1SLF9dOM9EeqWXyJY8E ANnSpHRCUBaehuE/p41sozVhvlDcUuI4JQ4QovTQ1YTHSz6yVARoJ2r2cndoVMVgrBCXcCpk gZxirB0Qa7ndYVuqliKSPDmxZCnbPT1P7Guq//VF9+pW6Iaubm9VSL1nnW//ICIOUEfYtbHq kpdVdG8sPzBrry7qfqwhOgch6R2FBADevQvDx3CEEEXONlTMNhgW0EjlWfLuHZAyOfDTWCub iODbcOHw+e/tTljqSeqSHJmp4H/3UADZd6GIy2BMYJX10mlqJYi07f8U17y/GBozPyLzuZd5 eFSpmbaJT6iZ84BAG6PIEXugO31A9hvAANUUzEK/K4rsfVH14af9KaAJLs0pQmVybmhhcmQg V2llZGVtYW5uIDxiZXJuaGFyZHBncEBsc21vZC5kZT7CZAQTEQIAJAIbAwIeAQIXgAULCQgH AwUVCgkICwUWAgMBAAUCTRCjzAIZAQAKCRBJNgs7HfuhZALYAJ44WwvIefMXoJPmRyKL0KBc dFzwqgCeKjS50F9gUTUrAuUZdIEu0U4Vvo7Ow00ENrgWshAP/j9XkQQNZPUiUmEa7TnChO+Q UJyAPwvXVtf7E/4haGl7PXae4YtwPAfVYmPnXRhp1F7V4u7p6gWBBrSuSjBZ7KOsDbi9t95U GcKqi24p933bhyVWKml/KwjpKpceNT9fj/FrIA9+khj+1/7E39QR1xNOG/+9ZSchYvo7G1uc 2UEFFkzkeNtFuFqnsgyQB7v5n5+NLbT+Kp3upxbHSgEWMJYJKgQF3KDZYWnUnawTYAJZKuZT c3b4Fn/7EeVaWb1Y5SynvRGdde8K7ZTwKZ0jEynf3sDGMyk+3A0tHrMHTxbR7BEZNoeV6hU8 XBgbI0+oWtdd3E9JxOg2pgKL2uEZdWqP38Fsx10GPq5/Uy5tblprISdF9fC1RliKd3Xy8WHS qCPFNUxaJD+mHtqioIBanC5AzHWVa2+6IrDWToLfgkWs2l5cbKJk3/twJbDCR+Ygd7d3RCAL GxGPWcyDl5UQrtFYiC7cD8V/hphniBGuHwdKTfUQYQQa5FpOP2d5sUjrDFk4L9IaamYKKPFx +cqwYGO6nnhZ2/kJvm+InLHACRIJQVF+HcnlrUOkojikP8TDSrB9iwH0F04U5sF+jYA9cP/3 a1KpF2wTKz5w9ab4nzSj1v4l6U854nKAZRJF8BNiPPr+r+B0aPPxcD0PCnhEDKuN3XALi3Gq ciLKrmREjEwXAAICD/4ilsXL5r9vm0vwLsveVYYehZwGRBTcXQaA/wbtX3Bcp3sAbLiCQy8R 5dQsmNkknB8xWjEIJIroOIwmKDqwu7H6oMunveimyQsf1CPeVMIdyoJv0+dYN4uGwiKZL0Zw 3A/tqvCH/3ZejoAC+dUq31AmrhpbpV/o9XK5YpnNLWVBfSDDuEfTOSDULpB5tr4D6w1sqdcM WPpxINKJUIrs/AiRqFqm4/03ohpWYcQqB4ZVPJlmbt726uzrZetytyhwfv4RX0rL2QXcOs4r QtvCbm28htKCrmGDl928EI4UYNS3nqcmZO40FoTseIJDrfPVh1Q9X07/K7Kzzk7/nHFwuTea XFYZuCzQIGi2X4+cnvA0xVk3Or71s4appvGhVozVE74F0+iDiHzX64zRQlbqW4ktDUI3KZ2g 8pK84UrdQCyCPZYt64rK+dhEnESZSu2OZJTUmh98yVK5uV7TXI/Tvo3Q+8Ox/HCsS5b+LXB9 hnko00fDlGlbzcVjpRgaBIdxx+zwMOzU0KEjZKG4JV06m79Nf/oFRS08RVCxbU77tLoRf9u2 jbbQ83uPtADwaYsxvTZEueWJ61/ve3QDn36Yrq8APgJxvbJySlUQQ20QerHAfUks9bmeCDGY 6CXcrIqMcIY+bpRqe6AogQh/iuDGtjO788S+TcIjmr+TlrEUI89n+8JOBBgRAgAGBQI2uBay ABIJEEk2Czsd+6FkB2VHUEcAAQGf8QCgr7hNwY4kPfDTaVKSNpnx3CzjXjQAn0tHVYa+e7pe z7TXZtbYV+mLAAY5 Message-ID: Date: Thu, 2 Aug 2018 10:31:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PioAShrCJ7YjelAoslFUJy0sd0RDt6onF" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PioAShrCJ7YjelAoslFUJy0sd0RDt6onF Content-Type: multipart/mixed; boundary="gETK1QCk4IXZrmDuBvqA8WhYJRFNRZ9jr"; protected-headers="v1" From: "Bernhard M. Wiedemann" To: Paul Eggert , 32342@debbugs.gnu.org Message-ID: Subject: Re: bug#32342: [PATCH] Do not store mtime when compressing stdin References: <20180801115140.18679-1-bwiedemann@suse.de> In-Reply-To: --gETK1QCk4IXZrmDuBvqA8WhYJRFNRZ9jr Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-08-02 08:47, Paul Eggert wrote: > Bernhard M. Wiedemann wrote: >> This allows for reproducible output of >> echo foo | gzip | md5sum >=20 > gzip -n already does that, so we don't need to change the gzip source > code to get reproducible output. I know that it does, but patching hundreds of packages [1] (including ones still to be created) doing tar -czf $file to do instead tar -c | gzip -n > $file is a lot more effort than this one-line patch. It is also worth noting that the first variant works without a shell involved, so is easier+safer to call from other programs via system(3). Is there a good reason to want the current time in .gz in this situation?= I found that .bz2 and .xz dont carry it either. If there is a good reason, we could probably make it so that echo foo | gzip -N triggers the old default behaviour again. Another possible approach would be to use the $SOURCE_DATE_EPOCH environment variable's value instead of the current time, as defined in https://reproducible-builds.org/specs/source-date-epoch/ This would leave the default behaviour as is, but fix reproducible builds for us, because the variable is set in our package build environme= nt. I'd just really like to have it reproducible by default. [1] https://github.com/performancecopilot/pcp/pull/540 https://github.com/L1L1/cardpeek/pull/97 https://github.com/singularityware/singularity/pull/1083 https://sourceforge.net/p/x3270/code/merge-requests/1/ https://stat.ethz.ch/pipermail/r-devel/2017-April/074165.html --gETK1QCk4IXZrmDuBvqA8WhYJRFNRZ9jr-- --PioAShrCJ7YjelAoslFUJy0sd0RDt6onF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF0EARECAB0WIQRk4KvQEtfG32NHprVJNgs7HfuhZAUCW2LBZAAKCRBJNgs7Hfuh ZCAvAKCDZBgflNv93vlLM758IgDDlXS97wCg0iYYEtIZ7PfzQXaJwosQfJMc2mg= =h4HE -----END PGP SIGNATURE----- --PioAShrCJ7YjelAoslFUJy0sd0RDt6onF-- From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH References: <20180801115140.18679-1-bwiedemann@suse.de> In-Reply-To: <20180801115140.18679-1-bwiedemann@suse.de> Resent-From: "Bernhard M. Wiedemann" Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 09:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: 32342@debbugs.gnu.org Cc: "Bernhard M. Wiedemann" Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.1533200717323 (code B ref 32342); Thu, 02 Aug 2018 09:06:02 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 09:05:17 +0000 Received: from localhost ([127.0.0.1]:38240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl9Xp-000059-I8 for submit@debbugs.gnu.org; Thu, 02 Aug 2018 05:05:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:38936 helo=mx1.suse.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fl9Xo-0008WU-55 for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 05:05:16 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 86D1CACB0 for <32342@debbugs.gnu.org>; Thu, 2 Aug 2018 09:05:10 +0000 (UTC) From: "Bernhard M. Wiedemann" Date: Thu, 2 Aug 2018 11:03:59 +0200 Message-Id: <20180802090359.1214-1-bwiedemann@suse.de> X-Mailer: git-send-email 2.16.4 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. --- 1st draft: probably has some year-2038 problems left --- zip.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/zip.c b/zip.c index 337932c..b5c8867 100644 --- a/zip.c +++ b/zip.c @@ -19,6 +19,7 @@ #include #include +#include #include "tailor.h" #include "gzip.h" @@ -34,6 +35,7 @@ off_t header_bytes; /* number of bytes in gzip header */ int zip(in, out) int in, out; /* input and output file descriptors */ { + char *source_date_epoch; uch flags = 0; /* general purpose bit flags */ ush attr = 0; /* ascii/binary flag */ ush deflate_flags = 0; /* pkzip -es, -en or -ex equivalent */ @@ -57,7 +59,10 @@ int zip(in, out) if (time_stamp.tv_nsec < 0) stamp = 0; else if (0 < time_stamp.tv_sec && time_stamp.tv_sec <= 0xffffffff) - stamp = time_stamp.tv_sec; + { + if ((source_date_epoch = getenv("SOURCE_DATE_EPOCH")) == NULL || (stamp = strtol(source_date_epoch, NULL, 10)) <= 0) + stamp = time_stamp.tv_sec; + } else { /* It's intended that timestamp 0 generates this warning, -- 2.16.4 From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Do not store mtime when compressing stdin Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: "Bernhard M. Wiedemann" , 32342@debbugs.gnu.org Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.153322557522351 (code B ref 32342); Thu, 02 Aug 2018 16:00:02 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 15:59:35 +0000 Received: from localhost ([127.0.0.1]:39170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flG0l-0005oR-BZ for submit@debbugs.gnu.org; Thu, 02 Aug 2018 11:59:35 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flG0j-0005oE-IL for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 11:59:33 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E4C05161105; Thu, 2 Aug 2018 08:59:27 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id N1iGHGCOYTl7; Thu, 2 Aug 2018 08:59:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 38109161129; Thu, 2 Aug 2018 08:59:27 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8i_ovQI1JUIb; Thu, 2 Aug 2018 08:59:27 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1E251161105; Thu, 2 Aug 2018 08:59:27 -0700 (PDT) References: <20180801115140.18679-1-bwiedemann@suse.de> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Thu, 2 Aug 2018 08:59:26 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 08/02/2018 01:31 AM, Bernhard M. Wiedemann wrote: > I know that it does, but patching hundreds of packages [1] (including > ones still to be created) doing > tar -czf $file > to do instead > tar -c | gzip -n > $file This would be something that tar could and should address, I'd think. > Is there a good reason to want the current time in .gz in this situation? It seemed like a good idea at the time :-). At this point, it'd be an incompatible change to omit the timestamp. From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: "Bernhard M. Wiedemann" , 32342@debbugs.gnu.org Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.153322567622625 (code B ref 32342); Thu, 02 Aug 2018 16:02:01 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 16:01:16 +0000 Received: from localhost ([127.0.0.1]:39174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flG2N-0005sr-NP for submit@debbugs.gnu.org; Thu, 02 Aug 2018 12:01:15 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flG2K-0005sa-3n for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 12:01:12 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B89F91610F1; Thu, 2 Aug 2018 09:01:06 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5LzZenQwcAb1; Thu, 2 Aug 2018 09:01:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F1877161130; Thu, 2 Aug 2018 09:01:05 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5EWhBA2dUHbh; Thu, 2 Aug 2018 09:01:05 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D92D91610F1; Thu, 2 Aug 2018 09:01:05 -0700 (PDT) References: <20180801115140.18679-1-bwiedemann@suse.de> <20180802090359.1214-1-bwiedemann@suse.de> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <8e367b25-e0bf-fcb0-f158-824bce734e90@cs.ucla.edu> Date: Thu, 2 Aug 2018 09:01:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180802090359.1214-1-bwiedemann@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 08/02/2018 02:03 AM, Bernhard M. Wiedemann wrote: > + if ((source_date_epoch = getenv("SOURCE_DATE_EPOCH")) == NULL || (stamp = strtol(source_date_epoch, NULL, 10)) That won't work after 2038 on x32. Also, I'm leery of having environment variables affect standard utilities' behavior, though perhaps we could shoehorn this in. From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Thu, 02 Aug 2018 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: Paul Eggert Cc: "Bernhard M. Wiedemann" , 32342@debbugs.gnu.org Received: via spool by 32342-submit@debbugs.gnu.org id=B32342.153322635423730 (code B ref 32342); Thu, 02 Aug 2018 16:13:01 +0000 Received: (at 32342) by debbugs.gnu.org; 2 Aug 2018 16:12:34 +0000 Received: from localhost ([127.0.0.1]:39190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flGDJ-0006Ag-T6 for submit@debbugs.gnu.org; Thu, 02 Aug 2018 12:12:34 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flGDE-0006AP-VZ for 32342@debbugs.gnu.org; Thu, 02 Aug 2018 12:12:29 -0400 Received: by mail-wr1-f67.google.com with SMTP id h9-v6so2707734wro.3 for <32342@debbugs.gnu.org>; Thu, 02 Aug 2018 09:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8gpPOD7Ct8a16EBjcajuMMFfiblLYLOZPVP/M9bKH0o=; b=VWyguZk+BHMVcuUFYbkcM7nEgnGiWUGRiEhuMe2XeBXH+wILiW5Xeg3y8gKFqrOyd1 sYx4UGgkHYoL4h9TVXeiMAdLkvMwsL02HOFtBgWUW1VaSUNFwFVa+qSj44yxhl37oqJL X84sEcn16b46noWE+1ZaOCruS41ppzJC82nxSU8h6NrWafSGVDdg6GLZ4BS/31OW5oe/ V7wBrfFO3Jdf4tTvyd88OZgmkq0nwGlQZg85ai6zoN/7qmkQ+XIuZgLjyRF6XevhGW/X vPf+szV4vcCQ04BYuErdcTPlYx1AizEYHCauxANg76Ssc9I9i18qUsaYED5oYOLSJQCC 2wwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8gpPOD7Ct8a16EBjcajuMMFfiblLYLOZPVP/M9bKH0o=; b=hdkQY5HkDnSNeVRQD85IhHK7/5ZwhVssYcL0veeVkbL0gGIbUhiA2WR2OmvXD0VKUX FtE2zW+frQml3AZkJMqPqLaoXdKmu20VRQZLUiO7PHh7wNzkzH+17ujWtLcKX7Ud48SC c+axBqVcqgsOBGcVGNISETDfvk1wX5+7cvrw2nb3UM9bZ2WyEN9sIwGLztCBWeESwHgm 6i2GEXqMVsb8Bb+sjYjGxpDxMITrDyF+9gGniYA2CibZGmSYJfqjPJUmh3A8rg6vZjyh E3uMI9Sq1R2IErXAjgMe4hEoGvuOnav/E+cg5qowDcD/KShvUx+g/Dx0jDqlHJXeZToN 4l8A== X-Gm-Message-State: AOUpUlGz9QQtSxdXdRyvkQoSm2im/GyFSQCNa/bx430eMP20MDs4uyyO qHlfkKtPFqPYtg87pHg3bzQYPTNalKEsSlUzehU= X-Google-Smtp-Source: AAOMgpdT79BL+9Zv9AL9Gl18Fn311wa5SPawM8WiA/w/QzJkTB0s0XNQkSG+hLuUDIv7agimTW5YySeFETCdR2AzVkA= X-Received: by 2002:a5d:46d1:: with SMTP id g17-v6mr93858wrs.76.1533226343304; Thu, 02 Aug 2018 09:12:23 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:ec4e:0:0:0:0:0 with HTTP; Thu, 2 Aug 2018 09:12:02 -0700 (PDT) In-Reply-To: <8e367b25-e0bf-fcb0-f158-824bce734e90@cs.ucla.edu> References: <20180801115140.18679-1-bwiedemann@suse.de> <20180802090359.1214-1-bwiedemann@suse.de> <8e367b25-e0bf-fcb0-f158-824bce734e90@cs.ucla.edu> From: Jim Meyering Date: Thu, 2 Aug 2018 18:12:02 +0200 X-Google-Sender-Auth: PJ8Jt4Lg8HpfPz2hSdWRi-RT36s Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 2, 2018 at 6:01 PM, Paul Eggert wrote: > On 08/02/2018 02:03 AM, Bernhard M. Wiedemann wrote: >> >> + if ((source_date_epoch = getenv("SOURCE_DATE_EPOCH")) == NULL || >> (stamp = strtol(source_date_epoch, NULL, 10)) > > > That won't work after 2038 on x32. Also, I'm leery of having environment > variables affect standard utilities' behavior, though perhaps we could > shoehorn this in. I had the same initial negative reaction to adding support for an envvar, but given the minor effect and worthy goal, I think the balance has tipped in favor of allowing this one. From unknown Sat Aug 09 13:21:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Bernhard M. Wiedemann" Subject: bug#32342: closed (Re: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH) Message-ID: References: <5e745d6e-2d60-d84d-b0fb-f6c6671ba028@cs.ucla.edu> <20180801115140.18679-1-bwiedemann@suse.de> X-Gnu-PR-Message: they-closed 32342 X-Gnu-PR-Package: gzip X-Gnu-PR-Keywords: patch Reply-To: 32342@debbugs.gnu.org Date: Thu, 02 Aug 2018 17:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1533232202-8372-1" This is a multi-part message in MIME format... ------------=_1533232202-8372-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32342: [PATCH] Do not store mtime when compressing stdin which was filed against the gzip package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32342@debbugs.gnu.org. --=20 32342: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32342 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1533232202-8372-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32342-done) by debbugs.gnu.org; 2 Aug 2018 17:49:42 +0000 Received: from localhost ([127.0.0.1]:39232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flHjJ-0002AQ-OV for submit@debbugs.gnu.org; Thu, 02 Aug 2018 13:49:42 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flHjH-0002AC-R3 for 32342-done@debbugs.gnu.org; Thu, 02 Aug 2018 13:49:40 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 013E9161389; Thu, 2 Aug 2018 10:49:34 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wGUDpMDSNODm; Thu, 2 Aug 2018 10:49:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 000591613BF; Thu, 2 Aug 2018 10:49:31 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id agiIz1dQro3Z; Thu, 2 Aug 2018 10:49:31 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D5458161389; Thu, 2 Aug 2018 10:49:31 -0700 (PDT) Subject: Re: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH To: Jim Meyering References: <20180801115140.18679-1-bwiedemann@suse.de> <20180802090359.1214-1-bwiedemann@suse.de> <8e367b25-e0bf-fcb0-f158-824bce734e90@cs.ucla.edu> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <5e745d6e-2d60-d84d-b0fb-f6c6671ba028@cs.ucla.edu> Date: Thu, 2 Aug 2018 10:49:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------CBA2F243CF5AE6420801B65B" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32342-done Cc: "Bernhard M. Wiedemann" , 32342-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------CBA2F243CF5AE6420801B65B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 08/02/2018 09:12 AM, Jim Meyering wrote: > I had the same initial negative reaction to adding support for an > envvar, but given the minor effect and worthy goal, I think the > balance has tipped in favor of allowing this one. Yes, on further thought I'm inclined to go whole hog and just fix the durn thing without any fancy environment variables. In hindsight, that timestamp never should have been put in there when stdin is a pipe. I installed the attached patch, which should fix the problem. What do you think? Although this is not strictly backward-compatible and arguably violates the GNU coding guidelines, I can't imagine anybody really wants that timestamp in there (except perhaps for spy agencies trying to track what people are doing :-). --------------CBA2F243CF5AE6420801B65B Content-Type: text/x-patch; name="0001-gzip-make-the-output-more-reproducible.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-gzip-make-the-output-more-reproducible.patch" >From e5e601102cd7e57a9e60afd03f52154fd83123fa Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Aug 2018 10:35:15 -0700 Subject: [PATCH] gzip: make the output more reproducible Problem reported by Bernhard M. Wiedemann (Bug#32342). * NEWS: Mention this. * doc/gzip.texi (Overview, Invoking gzip): Document this. * gzip.c (get_input_size_and_time): New function, which implements the change. (treat_stdin, treat_file): Use it. * tests/reproducible: New test. * tests/Makefile.am (TESTS): Add it. --- NEWS | 9 +++++++++ doc/gzip.texi | 18 ++++++++++++------ gzip.c | 35 ++++++++++++++++++++++------------- tests/Makefile.am | 1 + tests/reproducible | 28 ++++++++++++++++++++++++++++ 5 files changed, 72 insertions(+), 19 deletions(-) create mode 100755 tests/reproducible diff --git a/NEWS b/NEWS index 0e3a126..49c2e9b 100644 --- a/NEWS +++ b/NEWS @@ -2,6 +2,15 @@ GNU gzip NEWS -*- outline -*- * Noteworthy changes in release ?.? (????-??-??) [?] +** Changes in behavior + + Compressed gzip output no longer contains the current time as a + timestamp when the input is not a regular file. Instead, the output + contains a null (zero) timestamp. This makes gzip's behavior more + reproducible when used as part of a pipeline. (As a reminder, even + regular files will use null timestamps after the year 2106, due to a + limitation in the gzip format.) + * Noteworthy changes in release 1.9 (2018-01-07) [stable] diff --git a/doc/gzip.texi b/doc/gzip.texi index 195bab8..a7037ac 100644 --- a/doc/gzip.texi +++ b/doc/gzip.texi @@ -98,11 +98,16 @@ For example, if file names are limited to 14 characters, gzip.msdos.exe is compressed to gzi.msd.exe.gz. Names are not truncated on systems which do not have a limit on file name length. -By default, @command{gzip} keeps the original file name and timestamp in -the compressed file. These are used when decompressing the file with the -@option{-N} option. This is useful when the compressed file name was -truncated or when the timestamp was not preserved after a file -transfer. However, due to limitations in the current @command{gzip} file +By default, @command{gzip} keeps the original file name in the +compressed file. This can be useful when decompressing the file with +@option{-N} if the compressed file name was truncated after a file +transfer. + +If the original is a regular file, @command{gzip} by default keeps its +timestamp in the compressed file. This can be useful when +decompressing the file with @option{-N} if the timestamp was not +preserved after a file transfer. +However, due to limitations in the current @command{gzip} file format, fractional seconds are discarded. Also, timestamps must fall within the range 1970-01-01 00:00:01 through 2106-02-07 06:28:15 @abbr{UTC}, and hosts whose operating systems use 32-bit timestamps @@ -344,7 +349,8 @@ is the default when decompressing. @item --name @itemx -N -When compressing, always save the original file name and timestamp; this +When compressing, always save the original file name, and save +the original timestamp if the original is a regular file; this is the default. When decompressing, restore the original file name and timestamp if present. This option is useful on systems which have a limit on file name length or when the timestamp has been lost after diff --git a/gzip.c b/gzip.c index a023d81..02d5364 100644 --- a/gzip.c +++ b/gzip.c @@ -714,6 +714,25 @@ input_eof () return 0; } +static void +get_input_size_and_time (void) +{ + ifile_size = -1; + time_stamp.tv_nsec = -1; + + /* Record the input file's size and timestamp only if it is a + regular file. Doing this for the timestamp helps to keep gzip's + output more reproducible when it is used as part of a + pipeline. */ + + if (S_ISREG (istat.st_mode)) + { + ifile_size = istat.st_size; + if (!no_time || list) + time_stamp = get_stat_mtime (&istat); + } +} + /* ======================================================================== * Compress or decompress stdin */ @@ -761,15 +780,8 @@ local void treat_stdin() progerror ("standard input"); do_exit (ERROR); } - ifile_size = S_ISREG (istat.st_mode) ? istat.st_size : -1; - time_stamp.tv_nsec = -1; - if (!no_time || list) - { - if (S_ISREG (istat.st_mode)) - time_stamp = get_stat_mtime (&istat); - else - gettime (&time_stamp); - } + + get_input_size_and_time (); clear_bufs(); /* clear input and output buffers */ to_stdout = 1; @@ -941,10 +953,7 @@ local void treat_file(iname) } } - ifile_size = S_ISREG (istat.st_mode) ? istat.st_size : -1; - time_stamp.tv_nsec = -1; - if (!no_time || list) - time_stamp = get_stat_mtime (&istat); + get_input_size_and_time (); /* Generate output file name. For -r and (-t or -l), skip files * without a valid gzip suffix (check done in make_ofname). diff --git a/tests/Makefile.am b/tests/Makefile.am index ebdce5b..691bbf8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -24,6 +24,7 @@ TESTS = \ memcpy-abuse \ mixed \ null-suffix-clobber \ + reproducible \ stdin \ timestamp \ trailing-nul \ diff --git a/tests/reproducible b/tests/reproducible new file mode 100755 index 0000000..3bb4974 --- /dev/null +++ b/tests/reproducible @@ -0,0 +1,28 @@ +#!/bin/sh +# Ensure that gzip has repoducible output. + +# Copyright 2018 Free Software Foundation, Inc. + +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. + +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. + +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# limit so don't run it by default. + +. "${srcdir=.}/init.sh"; path_prepend_ .. + +echo a | gzip > exp || fail=1 +sleep 1 +echo a | gzip > out || fail=1 + +compare exp out || fail=1 + +Exit $fail -- 2.17.1 --------------CBA2F243CF5AE6420801B65B-- ------------=_1533232202-8372-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Aug 2018 11:52:13 +0000 Received: from localhost ([127.0.0.1]:37009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkpfo-0002dE-NB for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fkpfn-0002d3-Or for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkpfh-0001C3-Sa for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkpfh-0001Bx-Ph for submit@debbugs.gnu.org; Wed, 01 Aug 2018 07:52:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkpfg-00042v-Kf for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:52:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkpfb-00016B-PF for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:52:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:49718 helo=mx1.suse.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fkpfb-00014C-ID for bug-gzip@gnu.org; Wed, 01 Aug 2018 07:51:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 57D61AE4E for ; Wed, 1 Aug 2018 11:51:57 +0000 (UTC) From: "Bernhard M. Wiedemann" To: bug-gzip@gnu.org Subject: [PATCH] Do not store mtime when compressing stdin Date: Wed, 1 Aug 2018 13:51:40 +0200 Message-Id: <20180801115140.18679-1-bwiedemann@suse.de> X-Mailer: git-send-email 2.16.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: "Bernhard M. Wiedemann" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This allows for reproducible output of echo foo | gzip | md5sum tar -cz -H ustar SOMEFILE | md5sum See https://reproducible-builds.org/ for why this is good. --- gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gzip.c b/gzip.c index a023d81..4b00e42 100644 --- a/gzip.c +++ b/gzip.c @@ -767,7 +767,7 @@ local void treat_stdin() { if (S_ISREG (istat.st_mode)) time_stamp = get_stat_mtime (&istat); - else + else if (decompress) gettime (&time_stamp); } -- 2.16.4 ------------=_1533232202-8372-1-- From unknown Sat Aug 09 13:21:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32342: [PATCH] Allow to override time_stamp with SOURCE_DATE_EPOCH Resent-From: Jim Meyering Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Fri, 03 Aug 2018 12:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32342 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: patch To: Paul Eggert Cc: "Bernhard M. Wiedemann" , 32342-done@debbugs.gnu.org Received: via spool by 32342-done@debbugs.gnu.org id=D32342.153330059512367 (code D ref 32342); Fri, 03 Aug 2018 12:50:03 +0000 Received: (at 32342-done) by debbugs.gnu.org; 3 Aug 2018 12:49:55 +0000 Received: from localhost ([127.0.0.1]:39608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flZWk-0003DN-HN for submit@debbugs.gnu.org; Fri, 03 Aug 2018 08:49:54 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flZWi-0003CR-M8 for 32342-done@debbugs.gnu.org; Fri, 03 Aug 2018 08:49:53 -0400 Received: by mail-wr1-f66.google.com with SMTP id r16-v6so5290430wrt.11 for <32342-done@debbugs.gnu.org>; Fri, 03 Aug 2018 05:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xXQYu51AhtqWKpBDM33kzQ0Ep7tS26yB27dGK/O5ptE=; b=mnxZnm30WbJK+1KqUC9X/+vWyIOLFc6eA8rZx8EcIdoVXv+BVm8+lbT36Tchd5GjcK QOYpySBR8wjZZTbAqawh/JNtPGIs5w+2f4bsNZhs4GSdLubG69X6RhkECrm6gyr0Ry19 Ita8S7Fo79VFyDlKjcbrUH0D0QReqrb9JGnxyK8gHxRfuM5RzHptP5RE8kjLs5YL2F9j uWbj8JHSOoOttEozPSY3pUYeD4gvprdkwtOSDIgUeGRXxvwOo/EUiFgyuN+I0dKVB/Tq LL06Z4/rKWJmFhlaZ+vYo1vyYR9Kf5AJbyQ8JvaGjqt7G4EJlqp8fxOm1l2hTXk65f83 M6tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xXQYu51AhtqWKpBDM33kzQ0Ep7tS26yB27dGK/O5ptE=; b=MaajxMmSbMf0Mzt8tbBKXz9Xbie10K4vKHKiPrVtov0gXF8j1cbkKEbovQIuVgGTo/ tvBaMpDCEShBZIsX2rrkMcLuAzCQfZ0LCnCr6Aa5s64Ak/V6GNHXxKjuSMBYBWLolUeZ mHRng8w6s11g8VqTn3V1wlsTeUl/rF+pReYgvqfCx0lQwHlziHvd/ehLeNg5Ug7kRcTB OMbcrJqEij/6oJQD4AQtFtg1vI058UV78gnFY3NN8HLCNx0IGV79e37h79GMAhfIcgrR I1Nl7RpLS/K7UFXovjf1WGNKtGvNMu1z225DGgU3bzRoU2MwiGPzn8Ke371JEIayCtXr Oxog== X-Gm-Message-State: AOUpUlFNaWklg7lhOyaOZ3tbi9kf6Pb6x/evdgAqxlEbbynk5MvT3kv+ 8ZOj1vG+AoPznKI9hGC5rk4e791/VZd0AS7TNnc= X-Google-Smtp-Source: AAOMgpdEDWo0Nnn/XIdZDlqGjpibxnBzVkV65BprIjQUCn5bSLad6XwUgEjVwI+1zQu0NdCG3XnCbHKWDS2Pos4WKWE= X-Received: by 2002:adf:fdcd:: with SMTP id i13-v6mr2412162wrs.276.1533300585619; Fri, 03 Aug 2018 05:49:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:ec4e:0:0:0:0:0 with HTTP; Fri, 3 Aug 2018 05:49:24 -0700 (PDT) In-Reply-To: <5e745d6e-2d60-d84d-b0fb-f6c6671ba028@cs.ucla.edu> References: <20180801115140.18679-1-bwiedemann@suse.de> <20180802090359.1214-1-bwiedemann@suse.de> <8e367b25-e0bf-fcb0-f158-824bce734e90@cs.ucla.edu> <5e745d6e-2d60-d84d-b0fb-f6c6671ba028@cs.ucla.edu> From: Jim Meyering Date: Fri, 3 Aug 2018 14:49:24 +0200 X-Google-Sender-Auth: lNEpo8JMhiGg_IbNuK1oOXVlh00 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Aug 2, 2018 at 7:49 PM, Paul Eggert wrote: > On 08/02/2018 09:12 AM, Jim Meyering wrote: >> I had the same initial negative reaction to adding support for an >> envvar, but given the minor effect and worthy goal, I think the >> balance has tipped in favor of allowing this one. > > Yes, on further thought I'm inclined to go whole hog and just fix the durn > thing without any fancy environment variables. In hindsight, that timestamp > never should have been put in there when stdin is a pipe. I installed the > attached patch, which should fix the problem. What do you think? Although > this is not strictly backward-compatible and arguably violates the GNU > coding guidelines, I can't imagine anybody really wants that timestamp in > there (except perhaps for spy agencies trying to track what people are doing > :-). Thanks. With that, we'll have some NEWS for the next release. I'm not planning a release at the moment, but do prefer to make a new one at least once per year -- it's been almost 8 months.