GNU bug report logs - #3234
fill-column+1 problem

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#3234: closed (fill-column+1 problem)
Date: Fri, 30 Nov 2012 07:14:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 30 Nov 2012 15:11:36 +0800
with message-id <87624nimzb.fsf <at> gnu.org>
and subject line Re: bug#3234: fill-column+1 problem
has caused the debbugs.gnu.org bug report #3234,
regarding fill-column+1 problem
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
3234: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3234
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Toru TSUNEYOSHI <t_tuneyosi <at> hotmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: fill-column+1 problem
Date: Thu, 07 May 2009 20:00:08 +0900 (JST)

Hi. I met a problem about `fill-region-as-paragraph' on Emacs
22.3.1. (This problem happens on Emacs 23.0.93.1, because there is no
change of the function's code.) Please read the following.

condition:

	fill-column => 10

>>> example 1 (no problems) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

12345678901234567890

あいうえおかきくけこ	<- fill-region (this function is a caller of
			   	        `fill-region-as-paragraph')

=>

あいうえお
かきくけこ

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

>>> example 2 (no good) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

123456789012345678901

あいxうえおかきくけこ	<- fill-region

=>

あいxうえお		<- fill-column+1 problem
かきくけこ

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

>>> patch for the problem >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
--- fill.el.original	2008-08-27 00:45:42.000000000 +0900
+++ fill.el	2009-05-07 18:29:16.931120600 +0900
@@ -713,7 +713,8 @@
 	    (move-to-column (current-fill-column))
 	    (if (when (< (point) to)
 		  ;; Find the position where we'll break the line.
-		  (forward-char 1) ;Use an immediately following space, if any.
+		  (unless (> (current-column) (current-fill-column))
+		    (forward-char 1)) ;Use an immediately following space, if any.
 		  (fill-move-to-break-point linebeg)
 		  ;; Check again to see if we got to the end of
 		  ;; the paragraph.
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

>>> example 3 (after patching, good) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

123456789012345678901

あいxうえおかきくけこ	<- fill-region

=>

あいxうえ		<- no problem
おかきくけ
こ

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

Anyone can check the validity of the patch?
If invalid, I wish that someone solves the problem.

[Message part 3 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> gnu.org>
To: Toru TSUNEYOSHI <t_tuneyosi <at> hotmail.com>
Cc: 3234-done <at> debbugs.gnu.org
Subject: Re: bug#3234: fill-column+1 problem
Date: Fri, 30 Nov 2012 15:11:36 +0800

Toru TSUNEYOSHI <t_tuneyosi <at> hotmail.com> writes:

> Hi. I met a problem about `fill-region-as-paragraph' on Emacs 22.3.1.
> (This problem happens on Emacs 23.0.93.1, because there is no change
> of the function's code.)
>
> Anyone can check the validity of the patch?
> If invalid, I wish that someone solves the problem.

Sorry for the very late response.  Your patch looks good, and I've just
committed it to trunk.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.