GNU bug report logs - #3233
23.0.93; [NS] Regression in x-display-pixel-width

Previous Next

Full log

Message #30 received at 3233 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ian Eure <ian <at> digg.com>
Cc: 3233 <at> debbugs.gnu.org
Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width
Date: Wed, 06 May 2009 21:34:13 -0400

>   (let ((disp (frame-parameter frame 'display)))

Why not use `frame' directly?  The `display' frame parameter is
fundamentally specific to X11 (although we kinds of try to make Emacs
pretend that it also exists under other GUIs).

> I don't know how (display-pixel-height) handles multihead displays, but it
> seems saner to explicitly pass the display the frame occupies.

The "display" you pass is just some string.  So "right" way would be to
pass the corresponding terminal (i.e. (frame-terminal frame)), but
most/all the functions that operate on terminals accept frames as well
(since terminal object were only introduced in Emacs-23 as pat of the
multi-tty code, so frames were previously the canonical way to refer to
a display).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.