From unknown Wed Jun 18 23:15:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#3233 <3233@debbugs.gnu.org> To: bug#3233 <3233@debbugs.gnu.org> Subject: Status: 23.0.93; [NS] Regression in x-display-pixel-width Reply-To: bug#3233 <3233@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:15:14 +0000 retitle 3233 23.0.93; [NS] Regression in x-display-pixel-width reassign 3233 emacs,ns submitter 3233 Ian Eure severity 3233 normal thanks From ian@digg.com Wed May 6 11:50:16 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 6 May 2009 18:50:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n46Io9O1021252 for ; Wed, 6 May 2009 11:50:11 -0700 Received: from mx10.gnu.org ([199.232.76.166]:54210) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M1mBq-0002vT-DC for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 14:50:09 -0400 Received: from mail.digg.com ([64.191.203.36]:56347) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1mBm-0001x9-Lt for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 14:49:56 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 6D3A2A8575D for ; Wed, 6 May 2009 11:49:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tyyc6NZuMZjP for ; Wed, 6 May 2009 11:49:40 -0700 (PDT) Received: from [10.2.16.122] (diggstage01.digg.com [64.191.203.34]) by mail.digg.com (Postfix) with ESMTP id 011B5A85758 for ; Wed, 6 May 2009 11:49:39 -0700 (PDT) Message-Id: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> From: Ian Eure To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=WINDOWS-1252; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: 23.0.93; [NS] Regression in x-display-pixel-width Date: Wed, 6 May 2009 11:49:39 -0700 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) It looks like the rewrite of (ns_get_screen) has some problems. In =20 recent nightlies, the following code breaks: (x-display-pixel-width (frame-parameter (selected-frame) 'display)) With: Wrong type argument: terminal-live-p, "electron.local" It worked as of 05/05, and is broken in the 05/06 build. It works if =20 you don=92t provide an argument, but if you give it the display =20 paramater from a frame, it breaks. In GNU Emacs 23.0.93.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-05-06 on neutron.local Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Git-Log-View Minor modes in effect: diff-auto-refine-mode: t icomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-spelling-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-netsplit-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-autojoin-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t which-function-mode: t yas/minor-mode: t shell-dirtrack-mode: t ime-bindings: t show-paren-mode: t recentf-mode: t iswitchb-mode: t cua-mode: t auto-insert-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: g r e p x - d i s p l a u y - p u x e i x e l - w i d t h * . c m ~ / P O r P i P r e m C-x ` C-x v l C-x o C-c ! g i t SPC p u l l C-x b C-g C-h f d i s p l p i w C-x o C-e C-b C-b C-b C-b C-n C-n C-n C-n C-n C-n M-x t o g g l e - d e b u f e C-x o C-x b s c r a t e m a c s - C-e C-x C-e C-a C-f x - C-e C-x C-e C-x o C-x b . m M-< C-s t e r m i n a l - l i _ C-n C-p C-x o C-x b s h e l C-x o C-x C-v C-s C-g C-x C-v C-g C-x C-f n s f n M-< C-s l i v e - C-n C-p C-s d i s p l a y _ w C-s h C-s C-s C-n C-p M-< C-x 1 C-x b i n f e r e m a c s - C-x b C-x v l n d C-v C-x 4 b C-g C-n C-p C-n C-x o M-x r e p o r t - e Recent messages: Mark set Mark saved where search started Quit [2 times] Mark set Mark saved where search started [2 times] Mark set Buffer is read-only: # Finding changes in /Users/ieure/Projects/emacs/src/nsfns.m... Quit Making completion list... [2 times]= From monnier@IRO.UMontreal.CA Wed May 6 12:58:13 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 6 May 2009 19:58:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n46JwANT010342 for ; Wed, 6 May 2009 12:58:11 -0700 Received: from mx10.gnu.org ([199.232.76.166]:59981) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M1nFq-0005E8-3V for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 15:58:10 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M1nFp-0006Y3-3L for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 15:58:10 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40849) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1nFo-0006Xs-MU for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 15:58:08 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n46Jw0WA009838; Wed, 6 May 2009 15:58:01 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 4CB5B3A03E; Wed, 6 May 2009 15:57:59 -0400 (EDT) From: Stefan Monnier To: Ian Eure Cc: 3233@debbugs.gnu.org, emacs-pretest-bug@gnu.org Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Message-ID: References: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> Date: Wed, 06 May 2009 15:57:59 -0400 In-Reply-To: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> (Ian Eure's message of "Wed, 6 May 2009 11:49:39 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3269=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > It looks like the rewrite of (ns_get_screen) has some problems. In recent > nightlies, the following code breaks: > (x-display-pixel-width (frame-parameter (selected-frame) 'display)) > With: > Wrong type argument: terminal-live-p, "electron.local" > It worked as of 05/05, As of 05/05 it treated any string as equivalent to nil, indeed. Not sure if that qualifies as "worked". Can you point us to code that is affected? Stefan From ian@digg.com Wed May 6 14:22:41 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 6 May 2009 21:22:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n46LMWJV004136 for ; Wed, 6 May 2009 14:22:34 -0700 Received: from mx10.gnu.org ([199.232.76.166]:44614) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M1oZU-0000o3-AE for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 17:22:32 -0400 Received: from mail.digg.com ([64.191.203.36]:39252) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1oZT-000199-KQ for emacs-pretest-bug@gnu.org; Wed, 06 May 2009 17:22:31 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 92B2FA84FC9; Wed, 6 May 2009 14:22:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DuXXByHmMhst; Wed, 6 May 2009 14:22:29 -0700 (PDT) Received: from [10.2.16.122] (diggstage01.digg.com [64.191.203.34]) by mail.digg.com (Postfix) with ESMTP id 5C456A84F57; Wed, 6 May 2009 14:22:28 -0700 (PDT) Cc: 3233@debbugs.gnu.org, emacs-pretest-bug@gnu.org Message-Id: <87AAEBEC-E8DD-4BE0-A35A-9C0AEFB2F997@digg.com> From: Ian Eure To: Stefan Monnier In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Date: Wed, 6 May 2009 14:22:27 -0700 References: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) On May 6, 2009, at 12:57 PM, Stefan Monnier wrote: >> It looks like the rewrite of (ns_get_screen) has some problems. In >> recent >> nightlies, the following code breaks: > >> (x-display-pixel-width (frame-parameter (selected-frame) 'display)) > >> With: >> Wrong type argument: terminal-live-p, "electron.local" >> It worked as of 05/05, > > As of 05/05 it treated any string as equivalent to nil, indeed. > Not sure if that qualifies as "worked". Can you point us to code that > is affected? > I don't think there's anything in Emacs itself, but it broke my code which centers an Emacs frame: (defun screen-usable-height (&optional display) "Return the usable height of the display. Some window-systems have portions of the screen which Emacs cannot address. This function should return the height of the screen, minus anything which is not usable." (- (display-pixel-height display) (cond ((eq window-system 'ns) 22) (t 0)))) (defun screen-usable-width (&optional display) "Return the usable width of the display. This works like `screen-usable-height', but for the width of the display." (display-pixel-width display)) (defun frame-box-get-center (w h cw ch) "Center a box inside another box. Returns a list of `(TOP LEFT)' representing the centered position of the box `(w h)' inside the box `(cw ch)'." (list (/ (- cw w) 2) (/ (- ch h) 2))) (defun frame-get-center (frame) "Return the center position of FRAME on it's display." (let ((disp (frame-parameter frame 'display))) (frame-box-get-center (frame-pixel-width frame) (frame-pixel- height frame) (screen-usable-width disp) (screen-usable-height disp)))) (defun frame-center (&optional frame) "Center a frame on the screen." (interactive) (let ((frame (or frame (selected-frame)))) (apply 'set-frame-position `(,frame ,@(frame-get-center frame))))) I don't know how (display-pixel-height) handles multihead displays, but it seems saner to explicitly pass the display the frame occupies. - Ian From monnier@iro.umontreal.ca Wed May 6 18:34:24 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 7 May 2009 01:34:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n471YJ6P011853 for <3233@emacsbugs.donarmstrong.com>; Wed, 6 May 2009 18:34:21 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUFAGjXAUrO+IYe/2dsb2JhbACBUM51hAEFhU4 X-IronPort-AV: E=Sophos;i="4.40,305,1238990400"; d="scan'208";a="38110421" Received: from 206-248-134-30.dsl.teksavvy.com (HELO ceviche.home) ([206.248.134.30]) by ironport2-out.teksavvy.com with ESMTP; 06 May 2009 21:34:14 -0400 Received: by ceviche.home (Postfix, from userid 20848) id E47CBB523F; Wed, 6 May 2009 21:34:13 -0400 (EDT) From: Stefan Monnier To: Ian Eure Cc: 3233@debbugs.gnu.org Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Message-ID: References: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> <87AAEBEC-E8DD-4BE0-A35A-9C0AEFB2F997@digg.com> Date: Wed, 06 May 2009 21:34:13 -0400 In-Reply-To: <87AAEBEC-E8DD-4BE0-A35A-9C0AEFB2F997@digg.com> (Ian Eure's message of "Wed, 6 May 2009 14:22:27 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > (let ((disp (frame-parameter frame 'display))) Why not use `frame' directly? The `display' frame parameter is fundamentally specific to X11 (although we kinds of try to make Emacs pretend that it also exists under other GUIs). > I don't know how (display-pixel-height) handles multihead displays, but it > seems saner to explicitly pass the display the frame occupies. The "display" you pass is just some string. So "right" way would be to pass the corresponding terminal (i.e. (frame-terminal frame)), but most/all the functions that operate on terminals accept frames as well (since terminal object were only introduced in Emacs-23 as pat of the multi-tty code, so frames were previously the canonical way to refer to a display). Stefan From ian@digg.com Wed May 6 21:50:23 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 7 May 2009 04:50:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.digg.com (mail.digg.com [64.191.203.36]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n474oKS3002728 for <3233@emacsbugs.donarmstrong.com>; Wed, 6 May 2009 21:50:21 -0700 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id 43862A85775; Wed, 6 May 2009 21:50:17 -0700 (PDT) X-Virus-Scanned: amavisd-new at Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id savtYvP9EzJM; Wed, 6 May 2009 21:50:12 -0700 (PDT) Received: from [192.168.1.100] (adsl-68-124-177-161.dsl.pltn13.pacbell.net [68.124.177.161]) by mail.digg.com (Postfix) with ESMTP id D8D1BA85779; Wed, 6 May 2009 21:50:10 -0700 (PDT) Cc: 3233@debbugs.gnu.org Message-Id: From: Ian Eure To: Stefan Monnier In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Mailer: Apple Mail (2.930.3) Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Date: Wed, 6 May 2009 21:50:09 -0700 References: <7F4B990D-CC02-4571-8637-A633215441C4@digg.com> <87AAEBEC-E8DD-4BE0-A35A-9C0AEFB2F997@digg.com> On May 6, 2009, at 6:34 PM, Stefan Monnier wrote: >> (let ((disp (frame-parameter frame 'display))) > > Why not use `frame' directly? The `display' frame parameter is > fundamentally specific to X11 (although we kinds of try to make Emacs > pretend that it also exists under other GUIs). > Because I didn't know it was possible, because the docstrings refer to a `display' argument without elaborating on what that means. >> I don't know how (display-pixel-height) handles multihead displays, >> but it >> seems saner to explicitly pass the display the frame occupies. > > The "display" you pass is just some string. So "right" way would be > to > pass the corresponding terminal (i.e. (frame-terminal frame)), but > most/all the functions that operate on terminals accept frames as well > (since terminal object were only introduced in Emacs-23 as pat of the > multi-tty code, so frames were previously the canonical way to refer > to > a display). Looks like it may be moot, since the info docs say: "For graphical terminals, note that on "multi-monitor" setups this refers to the pixel width for all physical monitors associated with DISPLAY." So it may not be possible to handle in a sane manner, i.e. centering on the display the frame occupies. - Ian From david.reitter@gmail.com Fri May 15 19:26:47 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 May 2009 02:26:47 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.5 required=4.0 tests=AWL,MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f178.google.com (mail-ew0-f178.google.com [209.85.219.178]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4G2QhEW022870 for ; Fri, 15 May 2009 19:26:44 -0700 Received: by ewy26 with SMTP id 26so3082699ewy.1 for ; Fri, 15 May 2009 19:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=plg2Eootcg1IMs04Y/3QPOxu7dk6vl7WwLghb+OQ7wU=; b=a270UFEuvHs51iAHCPLA8vz9xpKvMhyiKKCYB33BLNafHwNcG+wyPYIf74iO3Behav uaMcRJzqX6PnUCwLEeGUvEbEfS+BCcLdB6XacaoRYB9m2O8XRZWG3v90QSfp3PheT8EB t+I3emAxwhe40MqjYcdIPUrd/zFvOHoHWz2V8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=gPHamF+qgFSrERfhg/lm05ePA+RizqrreW4dRDsBV/P7UfnmLv/LLo0CxLnHZ6mxHE ye2f/I+XJduFpJaDiktuI2kRYVVGeQcfGGMgUdOxjdtsbxC3e3pbUYUaHgSOmy7pHchM 3XxN5UfA+gNBnTe41ti6YCEZCH43Ee2I7VBbk= Received: by 10.210.63.2 with SMTP id l2mr1665149eba.10.1242440797306; Fri, 15 May 2009 19:26:37 -0700 (PDT) Received: from ?192.168.251.50? ([69.26.225.190]) by mx.google.com with ESMTPS id 28sm2507823eye.26.2009.05.15.19.26.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 15 May 2009 19:26:36 -0700 (PDT) Message-Id: From: David Reitter To: control@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Date: Fri, 15 May 2009 19:26:32 -0700 X-Mailer: Apple Mail (2.935.3) reassign 3286 ns reassign 3233 ns reassign 3204 ns From reitter@cmu.edu Thu May 21 21:22:01 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 22 May 2009 04:22:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.9 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from smtp.andrew.cmu.edu (SMTP.ANDREW.CMU.EDU [128.2.11.95]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4M4LwLg002212 for <3233@emacsbugs.donarmstrong.com>; Thu, 21 May 2009 21:21:59 -0700 Received: from [192.168.1.42] (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) (user=reitter mech=PLAIN (0 bits)) by smtp.andrew.cmu.edu (8.14.3/8.13.8) with ESMTP id n4M4LqYG022618 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for <3233@emacsbugs.donarmstrong.com>; Fri, 22 May 2009 00:21:52 -0400 Message-Id: <2B8C12A2-5535-45AB-B5A2-4B8E165D2043@cmu.edu> From: David Reitter To: 3233@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Date: Fri, 22 May 2009 00:21:51 -0400 X-Mailer: Apple Mail (2.935.3) X-PMX-Version: 5.5.5.374460, Antispam-Engine: 2.7.1.369594, Antispam-Data: 2009.5.22.41048 X-SMTP-Spam-Clean: 8% ( BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_500_599 0, BODY_SIZE_7000_LESS 0, FROM_EDU_TLD 0, RDNS_GENERIC_POOLED 0, RDNS_POOLED 0, RDNS_SUSP 0, RDNS_SUSP_GENERIC 0, RDNS_SUSP_SPECIFIC 0, TO_NO_NAME 0, __BOUNCE_CHALLENGE_SUBJ 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MSGID_APPLEMAIL 0, __RDNS_POOLED_9 0, __SANE_MSGID 0, __TO_MALFORMED_2 0) X-SMTP-Spam-Score: 8% X-Scanned-By: MIMEDefang 2.60 on 128.2.11.95 This gives me the width of the current display, not the total multi- monitor width: (x-display-pixel-width (get-device-terminal (frame-parameter (selected-frame) 'display))) same with the more elegant version that Stefan pointed out: (x-display-pixel-width (selected-frame)) I think that this is buggy (on NS), because the terminal is the same. ns_get_screen() indeed uses dpyinfo->x_focus_frame and ignores the screen argument for purposes of calculating the width. I don't really see how the pre-2009-05-06 code would have achieved anything more useful. From david.reitter@gmail.com Fri May 22 15:57:21 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 22 May 2009 22:57:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER, IMPRONONCABLE_2,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.154]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4MMvFQJ032279 for <3233@emacsbugs.donarmstrong.com>; Fri, 22 May 2009 15:57:17 -0700 Received: by fg-out-1718.google.com with SMTP id e12so635219fga.20 for <3233@emacsbugs.donarmstrong.com>; Fri, 22 May 2009 15:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :in-reply-to:content-type:mime-version:subject:date:references :x-mailer; bh=4nUKCxMgocMtZMLtV1og0Nk2QDtYDN7BcwQRyRi9yYg=; b=fFv/WbfRxOISFpbO8KE9d79ZJPRKHCRB64qND/qYwWPCvVevpqPMXnmQ5YX9vdlwqy jsIskTbRtTvePBYlPvdfVepaLqf7muk2b8hb1aaPmvLT5w7Kpx4RlRDOKvXQ1XcNasvf mOpjjY26OQxKsNEWoKL7Sj7WPbgmdKsWdiqcw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:in-reply-to:content-type:mime-version:subject :date:references:x-mailer; b=EkewWiO2vdyeTSzcIjGqKADBKeHH56WTnCJ9dcIDK64atkJ8cfcrWcxKa/PRk9Tev+ qE+yXfxUJDlMkVjlK/J8h6cZbIpOjwzltvNji+vj6Ge7ywmnWxo4/F8B2bgA1vX9yR3q E6EqBuTaSqn4/yQsW3VfHFbCzvuSBwS6srnDc= Received: by 10.86.90.2 with SMTP id n2mr3535539fgb.39.1243033034952; Fri, 22 May 2009 15:57:14 -0700 (PDT) Received: from ?192.168.1.42? (pool-71-162-19-47.pitbpa.east.verizon.net [71.162.19.47]) by mx.google.com with ESMTPS id 4sm1693618fge.23.2009.05.22.15.57.13 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 22 May 2009 15:57:14 -0700 (PDT) Message-Id: <5B7E13B4-559F-470B-925F-7359BF24EADC@gmail.com> From: David Reitter To: 3233@debbugs.gnu.org In-Reply-To: <2B8C12A2-5535-45AB-B5A2-4B8E165D2043@cmu.edu> Content-Type: multipart/signed; boundary=Apple-Mail-5-585342687; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: bug#3233: 23.0.93; [NS] Regression in x-display-pixel-width Date: Fri, 22 May 2009 18:57:11 -0400 References: <2B8C12A2-5535-45AB-B5A2-4B8E165D2043@cmu.edu> X-Mailer: Apple Mail (2.935.3) --Apple-Mail-5-585342687 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On May 22, 2009, at 12:21 AM, David Reitter wrote: > This gives me the width of the current display, not the total multi- > monitor width: > > (x-display-pixel-width > (get-device-terminal (frame-parameter (selected-frame) 'display))) > > same with the more elegant version that Stefan pointed out: > > (x-display-pixel-width (selected-frame)) > > I think that this is buggy (on NS), because the terminal is the same. > ns_get_screen() indeed uses dpyinfo->x_focus_frame and ignores the > screen argument for purposes of calculating the width. I don't > really see how the pre-2009-05-06 code would have achieved anything > more useful. OP, can you try the patch below? I think my ns_get_screen rewrite DTRT, preserving the stated intention of Stefan's change to handle non-NS frames somehow (we return NULL). Regarding this comment: // Not sure if this special case for nil is needed. It does seem to be // important in xfns.c for the make-frame call in frame-initialize, // so let's keep it here for now. Not sure what that is about. I can't find frame-initialize in xfns.c. Also, all uses of ns_get_screen appear to be in nsfns.m, and they all assume that giving it Qnil results in the selected frame's display being used rather than mainScreen. Also, display-usable-bounds was simply broken. If it was tested at some point, they probably assumed a hidden Dock. diff --git a/src/nsfns.m b/src/nsfns.m index 01ffcf1..e2e187f 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -205,29 +205,31 @@ ns_get_window (Lisp_Object maybeFrame) static NSScreen * ns_get_screen (Lisp_Object screen) { + struct frame *f; + + if (EQ (Qt, screen)) /* not documented */ + return [NSScreen mainScreen]; + struct terminal *terminal = get_terminal (screen, 1); if (terminal->type != output_ns) - // Not sure if this special case for nil is needed. It does seem to be - // important in xfns.c for the make-frame call in frame-initialize, - // so let's keep it here for now. - return (NILP (screen) ? [NSScreen mainScreen] : NULL); + return NULL; else { - struct ns_display_info *dpyinfo = terminal->display_info.ns; - struct frame *f = dpyinfo->x_focus_frame; - if (!f) - f = dpyinfo->x_highlight_frame; - if (!f) - return NULL; + if (NILP (screen)) + f = SELECTED_FRAME (); + else if (FRAMEP (screen)) + f = XFRAME (screen); else { - id window = nil; - Lisp_Object frame; - eassert (FRAME_NS_P (f)); - XSETFRAME (frame, f); - window = ns_get_window (frame); - return window ? [window screen] : NULL; + struct ns_display_info *dpyinfo = terminal->display_info.ns; + f = dpyinfo->x_focus_frame; + if (!f) + f = dpyinfo->x_highlight_frame; } + if (!f || !FRAME_NS_P (f)) + return NULL; + else + return [[FRAME_NS_VIEW (f) window] screen]; } } @@ -2358,15 +2367,23 @@ that stands for the selected frame's display. */) Lisp_Object display; { int top; + NSScreen *screen; + NSRect vScreen; check_ns (); - vScreen = [ns_get_screen (display) visibleFrame]; - top = vScreen.origin.y == 0.0 ? - (int) [ns_get_screen (display) frame].size.height - vScreen.size.height : 0; + screen = ns_get_screen (display); + if (!screen) + return Qnil; + + vScreen = [screen visibleFrame]; + + /* NS coordinate system is upside-down. + Transform to screen-specific coordinates. */ return list4 (make_number ((int) vScreen.origin.x), - make_number (top), + make_number ((int) [screen frame].size.height + - vScreen.size.height - vScreen.origin.y), make_number ((int) vScreen.size.width), make_number ((int) vScreen.size.height)); } --Apple-Mail-5-585342687 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICED6shx13jEDrq0eL8FRq5ykwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA4MTIwOTAyMDgwMVoXDTA5MTIwOTAyMDgw MVowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDOdo6kAwlkBxUb8dj4saMbYg4SVng8CUePFn3cjjWrakBTbUVa4Z0n wlUxr7AitEeKhBy5nGhu96+jKUPrCwYNRCZ0l2ovvuGq4z1m1nZ5/c8WvFlVhieuxXMUfmb/O7D3 IojoX6iS8n5MNNU2IWNNT/AD3vOl6DKgOtOw4J9y+QIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAIjI8yEW wkiEfA9PMgpjnD6KyCXT0iZjHhW2PkR53yZZLUoTboHnKgsFwYp/gzzIL8J5cvZaRUyMUzXDufPP dRmxxCs2jXXLDD/8bvdvOuMzqgYoFA73fAfsC8S6qUL1PayZ90J8CZHNhDwqWqOA56T+DdKUegJT sqoHKh6OnypTMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhA+rIcdd4xA66tH i/BUaucpMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA5MDUyMjIyNTcxMVowIwYJKoZIhvcNAQkEMRYEFA9QKAvWkb7DrE0ulScUiUyeFqWT MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQPqyHHXeMQOurR4vwVGrnKTCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQPqyHHXeMQOurR4vwVGrnKTANBgkqhkiG9w0B AQEFAASBgAVwPTj1v2FQNKEx0S4jO+6NU/O9x34zHAHaufGIPM1tqqPzomDBqq2wsHlSbxDXCYRK DFJ361ASbgDmBSq0enb2NKqiAe/l00gJBnxsdPgnkaQowJEghLfIXS8XzNGKcUFoRGjR9bXALq2+ 8R9yoCOCRgDUVi6X1c/kVZbAuMCwAAAAAAAA --Apple-Mail-5-585342687-- From rgm@gnu.org Wed Jun 17 13:22:35 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Jun 2009 20:22:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,ONEWORD,PHONENUMBER, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5HKMVgb030690 for ; Wed, 17 Jun 2009 13:22:33 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MH1eR-0007i7-2N; Wed, 17 Jun 2009 16:22:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19001.20615.29387.897755@fencepost.gnu.org> Date: Wed, 17 Jun 2009 16:22:31 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes reassign 3204 emacs,ns close 3204 reassign 3233 emacs,ns tags 1131 moreinfo unreproducible tags 1804 moreinfo close 2658 From adrian.b.robert@gmail.com Thu Jul 23 09:42:45 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 23 Jul 2009 16:42:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.5 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-gx0-f224.google.com (mail-gx0-f224.google.com [209.85.217.224]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6NGgfGG012535 for <3233@emacsbugs.donarmstrong.com>; Thu, 23 Jul 2009 09:42:42 -0700 Received: by gxk24 with SMTP id 24so1837632gxk.1 for <3233@emacsbugs.donarmstrong.com>; Thu, 23 Jul 2009 09:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date:cc :x-mailer; bh=Rffor9BKhnst9phGdClCoZyoz0mVSBnjX84IthErAQ4=; b=CGBcKMaqn42KDB55JemInK9tK/J0wa1HqC8nWLxnoccLgm5kufReMizQStS5GnH4z0 YfKBaCwF9bNTmwNoaXPt6UpuqYSIXYPq1nppYPsCWphbTdzx2m9dK1OXEcEtK7aFRDBh Leto8yDVmV9aY3u1IqXXaFo4Nypnu38YtPspg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:cc:x-mailer; b=UM4G1jF+fPAAX0rYFHJhsj+xB4VYIDUEgt/3f43dPa7Z08KrY22lFJZGG13v4U3GUW eTbShNQBBMtP65Hmm57flHP+DkHX64zgLh0ypN2MMdyBd1Dgd2r155dDS99ou7O2YU1m XVEAyuxC8GclIWflkGSwNVuNluIDnXQk4mJ1o= Received: by 10.90.31.13 with SMTP id e13mr2002924age.1.1248367356071; Thu, 23 Jul 2009 09:42:36 -0700 (PDT) Received: from ?10.0.1.3? (dpc6745214221.direcpc.com [67.45.214.221]) by mx.google.com with ESMTPS id 10sm5931279agd.73.2009.07.23.09.42.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 23 Jul 2009 09:42:35 -0700 (PDT) Message-Id: <95B352E0-B2AD-4E3A-8D83-AA4F45768C88@gmail.com> From: Adrian Robert To: 3233@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: 23.0.93; [NS] Regression in x-display-pixel-width Date: Thu, 23 Jul 2009 12:42:22 -0400 Cc: Ian Eure , David Reitter X-Mailer: Apple Mail (2.935.3) http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3233 Hi, Ian, David posted a patch at the end of the bug report referenced above -- did you see it or get a chance to try it? If not could you check it now? David, did this patch receive any other testing? Do you think it's safe to commit, either to branch or trunk? thanks, Adrian From wyuenho@gmail.com Mon Nov 23 08:49:38 2009 Received: (at 3233) by emacsbugs.donarmstrong.com; 23 Nov 2009 16:49:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.1 required=4.0 tests=AWL,FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANGnaWa029817 for <3233@emacsbugs.donarmstrong.com>; Mon, 23 Nov 2009 08:49:38 -0800 Received: by qyk11 with SMTP id 11so2706544qyk.13 for <3233@emacsbugs.donarmstrong.com>; Mon, 23 Nov 2009 08:49:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=UCb/KWBvHOBEYyS0tz26jtRHC5xpKiHkO7wKlta0fHg=; b=T5w7SJPoG63be0+0jkAXWJImOCoXPAPN9UlPhOSh8caBmhFRxejejr5eqsZnAt17XS fvksspZROX1b5zVi/p10olkd3RDHuPGqW/xAMxkNJmMwj4qYgSryAgbasM84F0+GkOt6 41LhZ+3kF9Z+hcDpJ2smoi61HLEQSE5InOm8o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=NThGqhLpXXdWk6GlWmxrWJo9OUm/MPWNGdz9nJf3wecFRVgtltewpBtpU7rQpWVDpa B74TjZQ2YscY3K/0sxQW2BhPRXB0dX9SuIaW2RtPpUrAuIEiUEfLpD3nOvY/O8nqv9I3 uWq79M5a78Lm6bh3dPKRvRIXev86ZfQfuKdg8= Received: by 10.224.80.28 with SMTP id r28mr2563581qak.155.1258994971579; Mon, 23 Nov 2009 08:49:31 -0800 (PST) Received: from MobileCat.local (146-115-23-49.c3-0.abr-ubr3.sbo-abr.ma.cable.rcn.com [146.115.23.49]) by mx.google.com with ESMTPS id 23sm144273qyk.3.2009.11.23.08.49.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 23 Nov 2009 08:49:30 -0800 (PST) Message-ID: <4B0ABD19.1030904@gmail.com> Date: Mon, 23 Nov 2009 11:49:29 -0500 From: Jimmy Yuen Ho Wong User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: 3233@debbugs.gnu.org Subject: Re: 23.0.93; [NS] Regression in x-display-pixel-width Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit This bug is giving me a similar problem in which `get_ns_screen` returns NULL when Emacs is loading and its window and menu bar are out of focus. This subsequently broke maxframe.el, which I use to maximize my Emacs frame on load. I've applied David's patch and it works fine now, `display-usable-bounds` works too. Jimmy Wong From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 09 13:50:58 2010 Received: (at 3233) by debbugs.gnu.org; 9 Jan 2010 18:50:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTgOn-0002Iq-I8 for submit@debbugs.gnu.org; Sat, 09 Jan 2010 13:50:58 -0500 Received: from pantheon-po19.its.yale.edu ([130.132.50.75]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTgOl-0002Ie-4H for 3233@debbugs.gnu.org; Sat, 09 Jan 2010 13:50:55 -0500 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po19.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o09IooA6009196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 9 Jan 2010 13:50:50 -0500 Received: by furry (Postfix, from userid 1000) id 07C91C07A; Wed, 6 Jan 2010 11:45:39 -0500 (EST) From: Chong Yidong To: Jimmy Yuen Ho Wong Subject: Re: 23.0.93; [NS] Regression in x-display-pixel-width Date: Wed, 06 Jan 2010 09:45:39 -0700 Message-ID: <87iqbfi3m4.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 3233 Cc: 3233@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.7 (-----) > This bug is giving me a similar problem in which `get_ns_screen` > returns NULL when Emacs is loading and its window and menu bar are out > of focus. This subsequently broke maxframe.el, which I use to > maximize my Emacs frame on load. > I've applied David's patch and it works fine now, > `display-usable-bounds` works too. Thanks, I've applied the patch to the repository. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 09 13:50:59 2010 Received: (at control) by debbugs.gnu.org; 9 Jan 2010 18:50:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTgOo-0002Iu-MU for submit@debbugs.gnu.org; Sat, 09 Jan 2010 13:50:59 -0500 Received: from pantheon-po42.its.yale.edu ([130.132.50.101]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NTgOk-0002Id-Uz for control@debbugs.gnu.org; Sat, 09 Jan 2010 13:50:55 -0500 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po42.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o09IooRJ024646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 9 Jan 2010 13:50:50 -0500 Received: by furry (Postfix, from userid 1000) id C8FEDC07C; Wed, 6 Jan 2010 11:45:48 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 3233 Date: Wed, 06 Jan 2010 09:45:48 -0700 Message-ID: <87fx6ji3lv.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) close 3233 thanks From unknown Wed Jun 18 23:15:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Feb 2010 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator