GNU bug report logs - #32305
mingw vs do_chown in gzip

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bdale Garbee <bdale <at> gag.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: gzip bugs <bug-gzip <at> gnu.org>
Subject: Re: mingw vs do_chown in gzip
Date: Mon, 30 Jul 2018 11:31:50 +0800

[Message part 1 (text/plain, inline)]

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> Yes, that must be it. I installed the attached into gzip master on Savannah; 
> does it fix things for you?

That fixes the compilation of gzip.c, but of course causes a link
failure since it leaves two calls to function do_chown() that is no
longer defined.

The hack I used to build the Debian gzip 1.9-1 upload I did last night
is to conditionally add two bogus typedefs and elide the function
content if __MINGW32__ is defined.  So far, that seems to work ok.  My
patch is attached to this email.

It does feel like an "ugly" approach, but I just got confused trying to
unwind how the configure code which learns there are no *chown()
functions in the mingw environment didn't actually cause the right
things to happen in the build.  Since apparently I'm the first person to
stumble over this since you added do_chown shortly after the gzip 1.6
release, I doubt it's worth much more time from either of us to come up
with a "cleaner" patch...

Feel free to use some or all of my patch, but I am also happy to update
may packaging for Debian if you choose to put more time in this and
develop a better solution. 

Regards,

Bdale

[fix-mingw-compile.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.