From unknown Sun Jun 22 22:47:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32305: mingw vs do_chown in gzip Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Sun, 29 Jul 2018 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32305 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: To: Bdale Garbee Cc: 32305@debbugs.gnu.org X-Debbugs-Original-Cc: gzip bugs Received: via spool by submit@debbugs.gnu.org id=B.153288908515273 (code B ref -1); Sun, 29 Jul 2018 18:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jul 2018 18:31:25 +0000 Received: from localhost ([127.0.0.1]:34081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjqTS-0003yE-Nt for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjqTR-0003y1-7t for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjqTK-0002Yp-VY for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjqTK-0002Yj-RI for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjqTJ-0006es-Ea for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjqTF-0002WZ-GG for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:13 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjqTF-0002W5-3y for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 20B4F160661; Sun, 29 Jul 2018 11:31:08 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QdeDNc_T0g5a; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4CAEF1606C2; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dMvdnWxo84Wh; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0A88B160661; Sun, 29 Jul 2018 11:31:06 -0700 (PDT) References: <87tvoi3gv8.fsf@gag.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> Date: Sun, 29 Jul 2018 11:31:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87tvoi3gv8.fsf@gag.com> Content-Type: multipart/mixed; boundary="------------76E3F04BAFDB753A68B755C7" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------76E3F04BAFDB753A68B755C7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Bdale Garbee wrote: > I'm (finally) working on updating the gzip in Debian to something newer > than 1.6, which caused me to stumble over the addition of the do_chown > function in gzip.c. That's because I need to build both native Debian > and Windows binary packages, the latter in support of a portion of the > Debian installer system that has something to do with Windows. >=20 > The problem is that mingw doesn't provide uid_t or gid_t definitions, > perhaps just because there isn't really an equivalent ownership > construct in Windows? Yes, that must be it. I installed the attached into gzip master on Savann= ah;=20 does it fix things for you? --------------76E3F04BAFDB753A68B755C7 Content-Type: text/x-patch; name="0001-gzip-port-better-to-mingw.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gzip-port-better-to-mingw.patch" =46rom 5405b4046acf80744caf2ba666128f25047b6411 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 29 Jul 2018 11:27:32 -0700 Subject: [PATCH] gzip: port better to mingw Problem reported by Bdale Garbee for Debian * gzip.c (do_chown): Don't assume uid_t and gid_t. --- gzip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gzip.c b/gzip.c index 429e554..a023d81 100644 --- a/gzip.c +++ b/gzip.c @@ -1914,17 +1914,20 @@ local int check_ofname() the file and NAME its name. Change it to user UID and to group GID. If UID or GID is -1, though, do not change the corresponding user or group. */ +#ifdef NO_CHOWN +/* The types uid_t and gid_t do not exist on mingw, so don't assume them= =2E */ +# define do_chown(fd, name, uid, gid) ((void) 0) +#else static void do_chown (int fd, char const *name, uid_t uid, gid_t gid) { -#ifndef NO_CHOWN # if HAVE_FCHOWN ignore_value (fchown (fd, uid, gid)); # else ignore_value (chown (name, uid, gid)); # endif -#endif } +#endif =20 /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D * Copy modes, times, ownership from input file to output file. --=20 2.7.4 --------------76E3F04BAFDB753A68B755C7-- From unknown Sun Jun 22 22:47:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32305: mingw vs do_chown in gzip Resent-From: Bdale Garbee Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Mon, 30 Jul 2018 03:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32305 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: To: Paul Eggert Cc: 32305@debbugs.gnu.org X-Debbugs-Original-Cc: gzip bugs Received: via spool by submit@debbugs.gnu.org id=B.15329215387863 (code B ref -1); Mon, 30 Jul 2018 03:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jul 2018 03:32:18 +0000 Received: from localhost ([127.0.0.1]:34264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjyuw-00022l-1c for submit@debbugs.gnu.org; Sun, 29 Jul 2018 23:32:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjyuv-00022Y-5l for submit@debbugs.gnu.org; Sun, 29 Jul 2018 23:32:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjyuo-0003cD-So for submit@debbugs.gnu.org; Sun, 29 Jul 2018 23:32:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36880) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjyuo-0003c6-OH for submit@debbugs.gnu.org; Sun, 29 Jul 2018 23:32:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjyun-0004rz-H1 for bug-gzip@gnu.org; Sun, 29 Jul 2018 23:32:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjyuj-0003ZU-Ig for bug-gzip@gnu.org; Sun, 29 Jul 2018 23:32:09 -0400 Received: from winfree.gag.com ([71.39.148.17]:47064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjyuj-0003ZK-7Y for bug-gzip@gnu.org; Sun, 29 Jul 2018 23:32:05 -0400 Received: from localhost (localhost [127.0.0.1]) by winfree.gag.com (Postfix) with ESMTP id 6261E1207B0; Sun, 29 Jul 2018 21:32:03 -0600 (MDT) X-Virus-Scanned: Debian amavisd-new at gag.com Received: from winfree.gag.com ([127.0.0.1]) by localhost (winfree.gag.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I980PphNAlg9; Sun, 29 Jul 2018 21:32:02 -0600 (MDT) Received: from rover.gag.com (unknown [140.113.61.252]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bdale) by winfree.gag.com (Postfix) with ESMTPSA id 6D49D1206E1; Sun, 29 Jul 2018 21:32:01 -0600 (MDT) Received: by rover.gag.com (Postfix, from userid 1000) id A9E4B1B60085; Sun, 29 Jul 2018 21:31:56 -0600 (MDT) From: Bdale Garbee In-Reply-To: <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> References: <87tvoi3gv8.fsf@gag.com> <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> Date: Mon, 30 Jul 2018 11:31:50 +0800 Message-ID: <87va8x1jrt.fsf@gag.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Paul Eggert writes: > Yes, that must be it. I installed the attached into gzip master on Savann= ah;=20 > does it fix things for you? That fixes the compilation of gzip.c, but of course causes a link failure since it leaves two calls to function do_chown() that is no longer defined. The hack I used to build the Debian gzip 1.9-1 upload I did last night is to conditionally add two bogus typedefs and elide the function content if __MINGW32__ is defined. So far, that seems to work ok. My patch is attached to this email. It does feel like an "ugly" approach, but I just got confused trying to unwind how the configure code which learns there are no *chown() functions in the mingw environment didn't actually cause the right things to happen in the build. Since apparently I'm the first person to stumble over this since you added do_chown shortly after the gzip 1.6 release, I doubt it's worth much more time from either of us to come up with a "cleaner" patch... Feel free to use some or all of my patch, but I am also happy to update may packaging for Debian if you choose to put more time in this and develop a better solution.=20 Regards, Bdale --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=fix-mingw-compile.diff Content-Transfer-Encoding: quoted-printable Content-Description: patch to allow gzip 1.9 to build with mingw =2D-- gzip-1.9/gzip.c 2018-01-07 13:05:21.000000000 +0800 +++ /tmp/gzip.c 2018-07-29 14:37:00.228844928 +0800 @@ -1910,6 +1910,11 @@ return OK; } =20 +#ifdef __MINGW32__ +typedef int uid_t; +typedef int gid_t; +#endif + /* Change the owner and group of a file. FD is a file descriptor for the file and NAME its name. Change it to user UID and to group GID. If UID or GID is -1, though, do not change the corresponding user @@ -1917,13 +1922,15 @@ static void do_chown (int fd, char const *name, uid_t uid, gid_t gid) { =2D#ifndef NO_CHOWN +#ifndef __MINGW32__ +#ifndef NO_CHOWN=20 # if HAVE_FCHOWN ignore_value (fchown (fd, uid, gid)); # else ignore_value (chown (name, uid, gid)); # endif #endif +#endif } =20 /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEhHDyCwYlkhh8unuzOpNhlsCV2UEFAltehqYACgkQOpNhlsCV 2UH3SBAAvF0KByMYgnBWOKza6BDHRuZkz6ZUrk2RV2kwkhYr9zZSebcDdPsPgw7o DNjpUPPPb5DXTcHzdHfEczmIatGKO/T0foPpqCdiG9fyc8OtjoBIp9fUBDS0FyPH zfkehOlDCe4tHSuBxAsX+93OBfMEfd68HeLNsdU5ARgSyw+YZQty4vfGelxc6nTf SxQEmkZMJQaqxW4g0J7uexAZzmfbvm4E8IpLdd3E/6aqmdxLC85jH4zwsQL4rb6o rscqphE84MW/20FggNpmi7cOsre4KWDSocZnrdjQNp7iSmpZYE8d4FBYobYbI8jP cQ0B8Y72fdX4Y/RneYtZdRZdKLFJ9FgaZSqqh0/mG6AiJAnIFqoa9ZN2oofwroJY GEL4jIp0KjGrIZPK95lVtx6dFYBHOvy8te/DATxP1sX45OJOAii7MWoVsDg+plHi f2LR6LT3f2d8bVb0Bqxef0/DPBUkgA47dVs9N7YBHpoio+nt+1zDv0ozxEZHfyOs K2eHH/wIOgrP3NwrknMOZG10vuVEcfeZtw7cbF8+lyp+adkkyOoiVwunhYwEjUuG xAHtdBLb5E1TLcUlG62zj9QxZ0+97j+8I7M5Yuxn6jy/0hBVod6dDLXKe3jGGcKw spJPqJ7IbnR/ngzHp87gHo5j0O6s0nWEIUjK9OIzOJwKwCXwS6Y= =BDi4 -----END PGP SIGNATURE----- --==-=-=-- From unknown Sun Jun 22 22:47:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32305: mingw vs do_chown in gzip Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Sat, 04 Aug 2018 07:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32305 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: To: Bdale Garbee Cc: 32305@debbugs.gnu.org Received: via spool by 32305-submit@debbugs.gnu.org id=B32305.153336838424780 (code B ref 32305); Sat, 04 Aug 2018 07:40:01 +0000 Received: (at 32305) by debbugs.gnu.org; 4 Aug 2018 07:39:44 +0000 Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flrA7-0006Rc-Qj for submit@debbugs.gnu.org; Sat, 04 Aug 2018 03:39:44 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flrA6-0006RN-Cx for 32305@debbugs.gnu.org; Sat, 04 Aug 2018 03:39:43 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 68D7E16081D; Sat, 4 Aug 2018 00:39:36 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 4BVH66zvJxZX; Sat, 4 Aug 2018 00:39:35 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C25E160CE0; Sat, 4 Aug 2018 00:39:35 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id S3DiebhXrdG9; Sat, 4 Aug 2018 00:39:35 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 552B116081D; Sat, 4 Aug 2018 00:39:35 -0700 (PDT) References: <87tvoi3gv8.fsf@gag.com> <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> <87va8x1jrt.fsf@gag.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Sat, 4 Aug 2018 00:39:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87va8x1jrt.fsf@gag.com> Content-Type: multipart/mixed; boundary="------------D14E01774FAE7F14C3F9D437" Content-Language: en-US X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------D14E01774FAE7F14C3F9D437 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Bdale Garbee wrote: > That fixes the compilation of gzip.c, but of course causes a link > failure since it leaves two calls to function do_chown() that is no > longer defined. I installed into Savannah master the attached patch, which should be a bi= t=20 cleaner. Does it fix things for you? --------------D14E01774FAE7F14C3F9D437 Content-Type: text/x-patch; name="0001-gzip-port-better-to-mingw-again.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gzip-port-better-to-mingw-again.patch" =46rom 385faa488bd98691cfb82ec4a317c7720a6008ae Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 4 Aug 2018 00:37:43 -0700 Subject: [PATCH] gzip: port better to mingw again Problem reported by Bdale Garbee (Bug#32305#8). * gzip.c (do_chown): Use HAVE_FCHOWN || HAVE_CHOWN, which is configured, instead of DO_CHOWN, which is not. --- gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gzip.c b/gzip.c index 02d5364..b26dd14 100644 --- a/gzip.c +++ b/gzip.c @@ -1923,7 +1923,7 @@ local int check_ofname() the file and NAME its name. Change it to user UID and to group GID. If UID or GID is -1, though, do not change the corresponding user or group. */ -#ifdef NO_CHOWN +#if ! (HAVE_FCHOWN || HAVE_CHOWN) /* The types uid_t and gid_t do not exist on mingw, so don't assume them= =2E */ # define do_chown(fd, name, uid, gid) ((void) 0) #else --=20 2.17.1 --------------D14E01774FAE7F14C3F9D437-- From unknown Sun Jun 22 22:47:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32305: mingw vs do_chown in gzip Resent-From: Bdale Garbee Original-Sender: "Debbugs-submit" Resent-CC: bug-gzip@gnu.org Resent-Date: Sun, 05 Aug 2018 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32305 X-GNU-PR-Package: gzip X-GNU-PR-Keywords: To: Paul Eggert Cc: 32305@debbugs.gnu.org Received: via spool by 32305-submit@debbugs.gnu.org id=B32305.15334273019527 (code B ref 32305); Sun, 05 Aug 2018 00:02:02 +0000 Received: (at 32305) by debbugs.gnu.org; 5 Aug 2018 00:01:41 +0000 Received: from localhost ([127.0.0.1]:41194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fm6UO-0002Tb-RW for submit@debbugs.gnu.org; Sat, 04 Aug 2018 20:01:41 -0400 Received: from winfree.gag.com ([71.39.148.17]:48996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fm6UN-0002TQ-2q for 32305@debbugs.gnu.org; Sat, 04 Aug 2018 20:01:39 -0400 Received: from localhost (localhost [127.0.0.1]) by winfree.gag.com (Postfix) with ESMTP id 023091206BD; Sat, 4 Aug 2018 18:01:38 -0600 (MDT) X-Virus-Scanned: Debian amavisd-new at gag.com Received: from winfree.gag.com ([127.0.0.1]) by localhost (winfree.gag.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AvuUTjUciz_c; Sat, 4 Aug 2018 18:01:37 -0600 (MDT) Received: from rover.gag.com (220-137-54-34.dynamic-ip.hinet.net [220.137.54.34]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bdale) by winfree.gag.com (Postfix) with ESMTPSA id 695D712069F; Sat, 4 Aug 2018 18:01:36 -0600 (MDT) Received: by rover.gag.com (Postfix, from userid 1000) id 040051B6007B; Sun, 5 Aug 2018 08:01:33 +0800 (CST) From: Bdale Garbee In-Reply-To: References: <87tvoi3gv8.fsf@gag.com> <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> <87va8x1jrt.fsf@gag.com> Date: Sun, 05 Aug 2018 08:01:28 +0800 Message-ID: <87a7q1isvb.fsf@gag.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Paul Eggert writes: > I installed into Savannah master the attached patch, which should be a bi= t=20 > cleaner. Does it fix things for you? Yep, thanks! I've updated my packaging repo to use your approach for the 1.9-2 upload. Bdale --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEhHDyCwYlkhh8unuzOpNhlsCV2UEFAltmPlgACgkQOpNhlsCV 2UFsuhAAmBlzDZ8BIFtTj7YcsyNwy5su8bcmmdjOLm4YxndDyOK0hmFdCg546PHv 3CQhbdhYCkgN0lEVIspPo5vUMQ1sXJk+jnDO035I59UDnWf+Ja7JnLyUsWJVIlUc qKyUJGboZBbMDaLJpIEhM6AaYRs6HyUCzA5qK7Yy+fEO3SLfYmS0rF7Bl898O+RX IOQYpZb9SrYkNlSFCNP0LhNghHqzDI8HJF1+tM8jmRxMhsX+pXd/B4pfUO/cxBjY Ykzs4IEoaaWMPNYDmFSW+tGOOy1qXDgtN3Da4gvJA47lQvUqW9fdWtZy2o8t4yNO ZOFM8YWE0/TRiHfOjbISHcpTJ7OsiNFvICygyIPOV+JUHCFA6DuDF7BLw+cga45+ qhN4XpQ1+yqgxJwNLsM+RtgIwhW735xX9xkSnULTSDJHCyyaqcaT2CUZHsW77rnt hkO0sGnf9TOMFLrd4cNaSdHcR+tWhk5A1pQPseslkP3CAetmVCgwQjASvZFVSO5k +OtyDsxA7b5AL3VvpGmjCRreTokGc5wFS0Z6rdKYPIE+zDy8BW+vBU5pzWS0gbBK kiQA2UQTcI3B/tTMJFWJWOysO9PdlC9abs6k00kqv0D4UWhpHHuhF6oKIrcOz2u2 yUzjJFKKrEWFkJbCU/+h//hCnm5UnSv/JFi7iMFEpT11bmwBIiA= =EnHm -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 22:47:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#32305: closed (Re: bug#32305: mingw vs do_chown in gzip) Message-ID: References: <8234356e-f11d-91bd-0c3f-0eb4f685f23b@cs.ucla.edu> <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> X-Gnu-PR-Message: they-closed 32305 X-Gnu-PR-Package: gzip Reply-To: 32305@debbugs.gnu.org Date: Sun, 05 Aug 2018 03:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1533440222-31047-1" This is a multi-part message in MIME format... ------------=_1533440222-31047-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32305: mingw vs do_chown in gzip which was filed against the gzip package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32305@debbugs.gnu.org. --=20 32305: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32305 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1533440222-31047-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32305-done) by debbugs.gnu.org; 5 Aug 2018 03:36:54 +0000 Received: from localhost ([127.0.0.1]:41224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fm9qf-00084R-N3 for submit@debbugs.gnu.org; Sat, 04 Aug 2018 23:36:53 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fm9qd-00084C-3t for 32305-done@debbugs.gnu.org; Sat, 04 Aug 2018 23:36:51 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BD584160CF7; Sat, 4 Aug 2018 20:36:44 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sOylZBgpyYw7; Sat, 4 Aug 2018 20:36:44 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CF0F8160D70; Sat, 4 Aug 2018 20:36:42 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SSu5vpKaw5nB; Sat, 4 Aug 2018 20:36:42 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8818C160CF7; Sat, 4 Aug 2018 20:36:42 -0700 (PDT) Subject: Re: bug#32305: mingw vs do_chown in gzip To: Bdale Garbee References: <87tvoi3gv8.fsf@gag.com> <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> <87va8x1jrt.fsf@gag.com> <87a7q1isvb.fsf@gag.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <8234356e-f11d-91bd-0c3f-0eb4f685f23b@cs.ucla.edu> Date: Sat, 4 Aug 2018 20:36:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87a7q1isvb.fsf@gag.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32305-done Cc: 32305-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks for checking the fix; closing the bug report. ------------=_1533440222-31047-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jul 2018 18:31:25 +0000 Received: from localhost ([127.0.0.1]:34081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjqTS-0003yE-Nt for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjqTR-0003y1-7t for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjqTK-0002Yp-VY for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjqTK-0002Yj-RI for submit@debbugs.gnu.org; Sun, 29 Jul 2018 14:31:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjqTJ-0006es-Ea for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjqTF-0002WZ-GG for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:13 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjqTF-0002W5-3y for bug-gzip@gnu.org; Sun, 29 Jul 2018 14:31:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 20B4F160661; Sun, 29 Jul 2018 11:31:08 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id QdeDNc_T0g5a; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4CAEF1606C2; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dMvdnWxo84Wh; Sun, 29 Jul 2018 11:31:07 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0A88B160661; Sun, 29 Jul 2018 11:31:06 -0700 (PDT) Subject: Re: mingw vs do_chown in gzip To: Bdale Garbee References: <87tvoi3gv8.fsf@gag.com> From: Paul Eggert Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: <740e063c-859f-6694-dfe1-7750804d007d@cs.ucla.edu> Date: Sun, 29 Jul 2018 11:31:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87tvoi3gv8.fsf@gag.com> Content-Type: multipart/mixed; boundary="------------76E3F04BAFDB753A68B755C7" Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: gzip bugs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------76E3F04BAFDB753A68B755C7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Bdale Garbee wrote: > I'm (finally) working on updating the gzip in Debian to something newer > than 1.6, which caused me to stumble over the addition of the do_chown > function in gzip.c. That's because I need to build both native Debian > and Windows binary packages, the latter in support of a portion of the > Debian installer system that has something to do with Windows. >=20 > The problem is that mingw doesn't provide uid_t or gid_t definitions, > perhaps just because there isn't really an equivalent ownership > construct in Windows? Yes, that must be it. I installed the attached into gzip master on Savann= ah;=20 does it fix things for you? --------------76E3F04BAFDB753A68B755C7 Content-Type: text/x-patch; name="0001-gzip-port-better-to-mingw.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gzip-port-better-to-mingw.patch" =46rom 5405b4046acf80744caf2ba666128f25047b6411 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 29 Jul 2018 11:27:32 -0700 Subject: [PATCH] gzip: port better to mingw Problem reported by Bdale Garbee for Debian * gzip.c (do_chown): Don't assume uid_t and gid_t. --- gzip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gzip.c b/gzip.c index 429e554..a023d81 100644 --- a/gzip.c +++ b/gzip.c @@ -1914,17 +1914,20 @@ local int check_ofname() the file and NAME its name. Change it to user UID and to group GID. If UID or GID is -1, though, do not change the corresponding user or group. */ +#ifdef NO_CHOWN +/* The types uid_t and gid_t do not exist on mingw, so don't assume them= =2E */ +# define do_chown(fd, name, uid, gid) ((void) 0) +#else static void do_chown (int fd, char const *name, uid_t uid, gid_t gid) { -#ifndef NO_CHOWN # if HAVE_FCHOWN ignore_value (fchown (fd, uid, gid)); # else ignore_value (chown (name, uid, gid)); # endif -#endif } +#endif =20 /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D * Copy modes, times, ownership from input file to output file. --=20 2.7.4 --------------76E3F04BAFDB753A68B755C7-- ------------=_1533440222-31047-1--