GNU bug report logs - #32304
27.0.50; tramp-tests issue with double slash

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#32304: closed (27.0.50; tramp-tests issue with double slash)
Date: Fri, 10 Aug 2018 07:28:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 10 Aug 2018 09:27:48 +0200
with message-id <87bmaa8yvf.fsf <at> gmx.de>
and subject line Re: bug#32304: 27.0.50; tramp-tests issue with double slash
has caused the debbugs.gnu.org bug report #32304,
regarding 27.0.50; tramp-tests issue with double slash
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
32304: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=32304
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; tramp-tests issue with double slash
Date: Sun, 29 Jul 2018 11:54:10 -0400

[Message part 3 (text/plain, inline)]

The following parts of tramp-test04-substitute-in-file-name are failing
on Cygwin (and probably also on MS-Windows, but I can't easily test
that):

(should
   (string-equal
    (substitute-in-file-name "/method:host://foo") "/method:host:/foo"))
(should
   (string-equal (substitute-in-file-name "/method:host:/path///foo") 
"/foo"))
(should
   (string-equal (substitute-in-file-name "/method:host://~foo") "/~foo"))

Here are the corresponding evaluations:

(substitute-in-file-name "/method:host://foo")
"/method:host://foo"

(substitute-in-file-name "/method:host:/path///foo")
"//foo"

(substitute-in-file-name "/method:host://~foo")
"//~foo"

This is a consequence of the fact that Tramp calls
substitute-in-file-name on the local part of the file name:

(substitute-in-file-name "//foo")
"//foo"

(substitute-in-file-name "/path///foo")
"//foo"

(substitute-in-file-name "//~foo")
"//~foo"

"//" has a special meaning at the beginning of a file name on Cygwin and
MS-Windows; see the comment near the beginning of
search_embedded_absfilename.  So I don't think there's a real bug here.
Maybe the expected result of the test should simply be adjusted, as in
the attached patch.  Someone who builds on MS-Windows would have to
check this.

Ken

[0001-Adjust-expected-results-on-a-tramp-test.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 32304-done <at> debbugs.gnu.org
Subject: Re: bug#32304: 27.0.50; tramp-tests issue with double slash
Date: Fri, 10 Aug 2018 09:27:48 +0200

Version: 27.1

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Should be fixed now in master. Could you, pls recheck? (I haven't tested
>> on MS Windows today)
>
> Thanks, it works now as expected.

Thanks for checking, I'm closing the bug.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.