From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: Cuirass: the 'nr' filter doesn't when builds have multiple outputs Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: dannym@scratchpost.org, tanja201396@gmail.com, bug-guix@gnu.org Resent-Date: Sat, 28 Jul 2018 23:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 32300@debbugs.gnu.org Cc: Danny Milosavljevic , Tatiana Sholokhova X-Debbugs-Original-To: bug-guix@gnu.org X-Debbugs-Original-Xcc: Danny Milosavljevic , Tatiana Sholokhova Received: via spool by submit@debbugs.gnu.org id=B.153282008614805 (code B ref -1); Sat, 28 Jul 2018 23:22:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jul 2018 23:21:26 +0000 Received: from localhost ([127.0.0.1]:33147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWc-0003qj-2z for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWb-0003qV-36 for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjYWV-0007AQ-06 for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39039) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjYWU-0007AJ-Sf for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjYWT-0004AI-Ox for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjYWQ-00078j-M1 for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:17 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjYWQ-000784-BQ for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:14 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 16f128c5 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Sat, 28 Jul 2018 23:21:11 +0000 (UTC) User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Date: Sun, 29 Jul 2018 01:21:10 +0200 Message-ID: <874lgjc5g9.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi, With, say, 'nr' =3D 4, the GROUP-OUTPUTS procedure in cuirass/database.scm will transform 0 | out | /gnu/store/... 1 | out | /gnu/store/... 1 | debug | /gnu/store/... 2 | out | /gnu/store/... into ((#:id . 0) (#:outputs ("out" (#:path . "/gnu/store/...")))) ((#:id . 1) (#:outputs ("out" (#:path . "/gnu/store/...")) ("debug" (#:path . "/gnu/store/...")))) ((#:id . 2) (#:outputs ("out" (#:path . "/gnu/store/...")))) Thus there are only 3 elements returned by the low-level DB-GET-BUILDS procedure, while we expect 4. This bug is visible through the API (latestbuilds, queue) and the web interface (eval) because they use that DB-GET-BUILDS procedure. Cl=C3=A9ment From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 28 19:23:25 2018 Received: (at control) by debbugs.gnu.org; 28 Jul 2018 23:23:25 +0000 Received: from localhost ([127.0.0.1]:33158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYYW-0003uq-RI for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:23:25 -0400 Received: from mail.lassieur.org ([83.152.10.219]:50546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYYV-0003ug-21 for control@debbugs.gnu.org; Sat, 28 Jul 2018 19:23:23 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id eab236d5 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Sat, 28 Jul 2018 23:23:21 +0000 (UTC) Date: Sun, 29 Jul 2018 01:23:21 +0200 Message-Id: <8736w3c5cm.fsf@lassieur.org> To: control@debbugs.gnu.org From: clement@lassieur.org (=?utf-8?Q?Cl=C3=A9ment?= Lassieur) Subject: control message for bug #32300 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) retitle 32300 Cuirass: the 'nr' filter doesn't work when builds have multiple outputs From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: Cuirass: the 'nr' filter doesn't work when builds have multiple outputs Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 28 Jul 2018 23:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153282039615390 (code B ref 32300); Sat, 28 Jul 2018 23:27:01 +0000 Received: (at 32300) by debbugs.gnu.org; 28 Jul 2018 23:26:36 +0000 Received: from localhost ([127.0.0.1]:33163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYbc-000408-A9 for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:26:36 -0400 Received: from mail.lassieur.org ([83.152.10.219]:50548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYba-000400-7O for 32300@debbugs.gnu.org; Sat, 28 Jul 2018 19:26:34 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 26f07cd5 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <32300@debbugs.gnu.org>; Sat, 28 Jul 2018 23:26:33 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <874lgjc5g9.fsf@lassieur.org> Date: Sun, 29 Jul 2018 01:26:32 +0200 Message-ID: <871sbnc57b.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Typo in subject: it doesn't *work. From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. References: <874lgjc5g9.fsf@lassieur.org> In-Reply-To: <874lgjc5g9.fsf@lassieur.org> Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Aug 2018 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153339852319853 (code B ref 32300); Sat, 04 Aug 2018 16:03:02 +0000 Received: (at 32300) by debbugs.gnu.org; 4 Aug 2018 16:02:03 +0000 Received: from localhost ([127.0.0.1]:41116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flz0F-0005A9-9t for submit@debbugs.gnu.org; Sat, 04 Aug 2018 12:02:03 -0400 Received: from mail.lassieur.org ([83.152.10.219]:32850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flz0C-00059g-OR for 32300@debbugs.gnu.org; Sat, 04 Aug 2018 12:02:02 -0400 Received: from localhost.localdomain (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 758be5b0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <32300@debbugs.gnu.org>; Sat, 4 Aug 2018 16:01:59 +0000 (UTC) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Date: Sat, 4 Aug 2018 18:00:57 +0200 Message-Id: <20180804160057.20254-1-clement@lassieur.org> X-Mailer: git-send-email 2.18.0 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . * src/cuirass/database.scm (filters->order): New procedure. (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT JOIN Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. --- src/cuirass/database.scm | 126 ++++++++++++--------------------------- 1 file changed, 37 insertions(+), 89 deletions(-) diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm index 4927f2a..b4b1652 100644 --- a/src/cuirass/database.scm +++ b/src/cuirass/database.scm @@ -443,104 +443,33 @@ log file for DRV." (cons `(,name . ((#:path . ,path))) outputs)))))) +(define (filters->order filters) + (match (assq 'order filters) + (('order . 'build-id) "id ASC") + (('order . 'decreasing-build-id) "id DESC") + (('order . 'finish-time) "stoptime DESC") + (('order . 'finish-time+build-id) "stoptime DESC, id DESC") + (('order . 'start-time) "starttime DESC") + (('order . 'submission-time) "timestamp DESC") + ;; With this order, builds in 'running' state (-1) appear + ;; before those in 'scheduled' state (-2). + (('order . 'status+submission-time) "status DESC, timestamp DESC") + (_ "id DESC"))) + (define (db-get-builds db filters) "Retrieve all builds in database DB which are matched by given FILTERS. FILTERS is an assoc list whose possible keys are 'id | 'jobset | 'job | 'system | 'nr | 'order | 'status | 'evaluation." - - (define (format-output name path) - `(,name . ((#:path . ,path)))) - - (define (cons-output name path rest) - "If NAME and PATH are both not #f, cons them to REST. -Otherwise return REST unchanged." - (if (and (not name) (not path)) - rest - (cons (format-output name path) rest))) - - (define (collect-outputs repeated-builds-id repeated-row outputs rows) - "Given rows somewhat like -1 'a 'b 2 'x -^ 'c 'd 2 'x -| ^^^^^ ^^^^ -| group ++++- group headers -| detail -+------------ group id - -return rows somewhat like - -1 2 'x '((a b) (c d)) - -. - -As a special case, if the group detail is #f #f, ignore it. -This is made specifically to support LEFT JOINs. - -Assumes that if group id stays the same the group headers stay the same." - (define (finish-group) - (match repeated-row - (#(timestamp starttime stoptime log status derivation job-name system - nix-name specification) - `((#:id . ,repeated-builds-id) - (#:timestamp . ,timestamp) - (#:starttime . ,starttime) - (#:stoptime . ,stoptime) - (#:log . ,log) - (#:status . ,status) - (#:derivation . ,derivation) - (#:job-name . ,job-name) - (#:system . ,system) - (#:nix-name . ,nix-name) - (#:specification . ,specification) - (#:outputs . ,outputs))))) - - (define (same-group? builds-id) - (= builds-id repeated-builds-id)) - - (match rows - (() (list (finish-group))) - ((#((? same-group? x-builds-id) x-output-name x-output-path other-cells ...) . rest) - ;; Accumulate group members of current group. - (let ((outputs (cons-output x-output-name x-output-path outputs))) - (collect-outputs repeated-builds-id repeated-row outputs rest))) - ((#(x-builds-id x-output-name x-output-path other-cells ...) . rest) - (cons (finish-group) ;finish current group - - ;; Start new group. - (let* ((outputs (cons-output x-output-name x-output-path '())) - (x-repeated-row (list->vector other-cells))) - (collect-outputs x-builds-id x-repeated-row outputs rest)))))) - - (define (group-outputs rows) - (match rows - (() '()) - ((#(x-builds-id x-output-name x-output-path other-cells ...) . rest) - (let ((x-repeated-row (list->vector other-cells))) - (collect-outputs x-builds-id x-repeated-row '() rows))))) - - (let* ((order (match (assq 'order filters) - (('order . 'build-id) "id ASC") - (('order . 'decreasing-build-id) "id DESC") - (('order . 'finish-time) "stoptime DESC") - (('order . 'finish-time+build-id) "stoptime DESC, id DESC") - (('order . 'start-time) "starttime DESC") - (('order . 'submission-time) "timestamp DESC") - (('order . 'status+submission-time) - ;; With this order, builds in 'running' state (-1) appear - ;; before those in 'scheduled' state (-2). - "status DESC, timestamp DESC") - (_ "id DESC"))) + (let* ((order (filters->order filters)) (stmt-text (format #f "SELECT * FROM ( -SELECT Builds.id, Outputs.name, Outputs.path, Builds.timestamp, -Builds.starttime, Builds.stoptime, Builds.log, Builds.status, -Builds.derivation, Derivations.job_name, Derivations.system, -Derivations.nix_name,Specifications.name +SELECT Builds.id, Builds.timestamp, Builds.starttime, Builds.stoptime, +Builds.log, Builds.status, Builds.derivation, Derivations.job_name, +Derivations.system, Derivations.nix_name, Specifications.name FROM Builds INNER JOIN Derivations ON Builds.derivation = Derivations.derivation AND Builds.evaluation = Derivations.evaluation INNER JOIN Evaluations ON Derivations.evaluation = Evaluations.id INNER JOIN Specifications ON Evaluations.specification = Specifications.name -LEFT JOIN Outputs ON Outputs.build = Builds.id WHERE (:id IS NULL OR (:id = Builds.id)) AND (:jobset IS NULL OR (:jobset = Specifications.name)) AND (:job IS NULL OR (:job = Derivations.job_name)) @@ -580,7 +509,26 @@ ORDER BY ~a, id ASC;" order)) (#f -1) (x x))) (sqlite-reset stmt) - (group-outputs (sqlite-fold-right cons '() stmt)))) + (let loop ((rows (sqlite-fold-right cons '() stmt)) + (builds '())) + (match rows + (() (reverse builds)) + ((#(id timestamp starttime stoptime log status derivation job-name + system nix-name specification) . rest) + (loop rest + (cons `((#:id . ,id) + (#:timestamp . ,timestamp) + (#:starttime . ,starttime) + (#:stoptime . ,stoptime) + (#:log . ,log) + (#:status . ,status) + (#:derivation . ,derivation) + (#:job-name . ,job-name) + (#:system . ,system) + (#:nix-name . ,nix-name) + (#:specification . ,specification) + (#:outputs . ,(db-get-outputs db id))) + builds))))))) (define (db-get-build db id) "Retrieve a build in database DB which corresponds to ID." -- 2.18.0 From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Aug 2018 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153339905520695 (code B ref 32300); Sat, 04 Aug 2018 16:11:02 +0000 Received: (at 32300) by debbugs.gnu.org; 4 Aug 2018 16:10:55 +0000 Received: from localhost ([127.0.0.1]:41139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flz8p-0005Nj-CL for submit@debbugs.gnu.org; Sat, 04 Aug 2018 12:10:55 -0400 Received: from mail.lassieur.org ([83.152.10.219]:32856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flz8m-0005Na-Pg for 32300@debbugs.gnu.org; Sat, 04 Aug 2018 12:10:53 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id c27cd28d (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <32300@debbugs.gnu.org>; Sat, 4 Aug 2018 16:10:51 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <20180804160057.20254-1-clement@lassieur.org> Date: Sat, 04 Aug 2018 18:10:51 +0200 Message-ID: <87sh3ui038.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Cl=C3=A9ment Lassieur writes: > Fixes . > > * src/cuirass/database.scm (filters->order): New procedure. > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT JO= IN > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. This may be less efficient because there are more SQL queries (one per output), but it's way less complicated and less buggy, so I think it's worth it. From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 07 Aug 2018 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153363879928243 (code B ref 32300); Tue, 07 Aug 2018 10:47:02 +0000 Received: (at 32300) by debbugs.gnu.org; 7 Aug 2018 10:46:39 +0000 Received: from localhost ([127.0.0.1]:43191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmzVe-0007LS-N6 for submit@debbugs.gnu.org; Tue, 07 Aug 2018 06:46:39 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:53894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmzVZ-0007LF-7z for 32300@debbugs.gnu.org; Tue, 07 Aug 2018 06:46:35 -0400 Received: from localhost (213162073133.public.t-mobile.at [213.162.73.133]) by dd26836.kasserver.com (Postfix) with ESMTPSA id A46A93360A5A; Tue, 7 Aug 2018 12:46:31 +0200 (CEST) Date: Tue, 7 Aug 2018 12:46:26 +0200 From: Danny Milosavljevic Message-ID: <20180807124626.29e6a12a@scratchpost.org> In-Reply-To: <87sh3ui038.fsf@lassieur.org> References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/ixemy96i5NFfRSBps0z_6wc"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/ixemy96i5NFfRSBps0z_6wc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment, On Sat, 04 Aug 2018 18:10:51 +0200 Cl=C3=A9ment Lassieur wrote: > Cl=C3=A9ment Lassieur writes: >=20 > > Fixes . > > > > * src/cuirass/database.scm (filters->order): New procedure. > > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, > > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT = JOIN > > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. = =20 >=20 > This may be less efficient because there are more SQL queries (one per > output), but it's way less complicated and less buggy, so I think it's > worth it. The more complicated version is a LOT faster - and was added because the version in this patch was just way too slow (unusably slow). I think it's better to also remove the call to db-get-outputs (and the entry #:outputs) entirely. I don't think our overview page even shows the outputs in the first place, so why fetch them? --Sig_/ixemy96i5NFfRSBps0z_6wc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAltpeIMACgkQ5xo1VCww uqUjkwf+Lh7+SmRc8RZ0LvbpPoX2Grun4UCj/RAqv0DruNFSuDh+ukz+uU+gBfsA DTX0nSKyrNDm5ECAOUrmePx1GkP+joGYsvzzor5Txz+keP1KATnv0MKqZl+NbTyy pC6OpWc4i/F42L03O8yuOQsOel9iRO4jZF/+reO1vIVcMOZW8jnTUxpApouzkTAf BleQ/U/YMibzpFONSX7/OxVuRoJcjj+qSSduIS1J1BEddPJ+GlgML8pPDqUBEALi aFtt3xSe6vDnN1KiHJQxeS7qiGgZTNDbSTTCLeGa/0qm9AkrJS+3a9qFBbdFjEo5 6ksXjeQyShBrxysdAURU1rD0EhvYpA== =ibYz -----END PGP SIGNATURE----- --Sig_/ixemy96i5NFfRSBps0z_6wc-- From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 08 Aug 2018 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153372869025622 (code B ref 32300); Wed, 08 Aug 2018 11:45:02 +0000 Received: (at 32300) by debbugs.gnu.org; 8 Aug 2018 11:44:50 +0000 Received: from localhost ([127.0.0.1]:44251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnMtW-0006fB-5x for submit@debbugs.gnu.org; Wed, 08 Aug 2018 07:44:50 -0400 Received: from mail.lassieur.org ([83.152.10.219]:33076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnMtU-0006f2-3u for 32300@debbugs.gnu.org; Wed, 08 Aug 2018 07:44:49 -0400 Received: from rodion (88.203.199.161 [88.203.199.161]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 1bffba76 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Wed, 8 Aug 2018 11:44:46 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> <20180807124626.29e6a12a@scratchpost.org> User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <20180807124626.29e6a12a@scratchpost.org> Date: Wed, 08 Aug 2018 13:44:44 +0200 Message-ID: <878t5h13rn.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Danny, Danny Milosavljevic writes: > The more complicated version is a LOT faster - and was added because > the version in this patch was just way too slow (unusably slow). > > I think it's better to also remove the call to db-get-outputs (and > the entry #:outputs) entirely. I don't think our overview page even > shows the outputs in the first place, so why fetch them? As you can see on my test machine with a Berlin database, it's almost instantaneous. Also, with my commit that merges the Derivations and the Builds tables, the queries are way lighter: they return about 100 builds per evaluation, instead of 20000. Plus, the outputs are used to get the build log. https://cuirass.lassieur.org:8081/jobset/guix-master WDYT? Cl=C3=A9ment From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 08 Aug 2018 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Danny Milosavljevic , Tatiana Sholokhova Cc: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153374233223429 (code B ref 32300); Wed, 08 Aug 2018 15:33:02 +0000 Received: (at 32300) by debbugs.gnu.org; 8 Aug 2018 15:32:12 +0000 Received: from localhost ([127.0.0.1]:45239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnQRY-00065p-8f for submit@debbugs.gnu.org; Wed, 08 Aug 2018 11:32:12 -0400 Received: from mail.lassieur.org ([83.152.10.219]:33092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnQRV-00065d-JL for 32300@debbugs.gnu.org; Wed, 08 Aug 2018 11:32:10 -0400 Received: from rodion (88.203.199.161 [88.203.199.161]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 7e7566fd (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Wed, 8 Aug 2018 15:32:08 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> <20180807124626.29e6a12a@scratchpost.org> <878t5h13rn.fsf@lassieur.org> User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <878t5h13rn.fsf@lassieur.org> Date: Wed, 08 Aug 2018 17:32:06 +0200 Message-ID: <874lg427t5.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Cl=C3=A9ment Lassieur writes: > Hi Danny, > > Danny Milosavljevic writes: > >> The more complicated version is a LOT faster - and was added because >> the version in this patch was just way too slow (unusably slow). >> >> I think it's better to also remove the call to db-get-outputs (and >> the entry #:outputs) entirely. I don't think our overview page even >> shows the outputs in the first place, so why fetch them? > > As you can see on my test machine with a Berlin database, it's almost > instantaneous. Also, with my commit that merges the Derivations and the > Builds tables, the queries are way lighter: they return about 100 builds > per evaluation, instead of 20000. > > Plus, the outputs are used to get the build log. > > https://cuirass.lassieur.org:8081/jobset/guix-master I just reverted to my own Cuirass config because my hard drive is too small (256G...) to build everything. And I added Tatiana's recent changes. Cl=C3=A9ment From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: Danny Milosavljevic Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 09 Aug 2018 05:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.153379423726787 (code B ref 32300); Thu, 09 Aug 2018 05:58:02 +0000 Received: (at 32300) by debbugs.gnu.org; 9 Aug 2018 05:57:17 +0000 Received: from localhost ([127.0.0.1]:45461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fndwi-0006xz-PE for submit@debbugs.gnu.org; Thu, 09 Aug 2018 01:57:16 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:51902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fndwg-0006xo-B5 for 32300@debbugs.gnu.org; Thu, 09 Aug 2018 01:57:14 -0400 Received: from localhost (178.112.152.129.wireless.dyn.drei.com [178.112.152.129]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 10A623360E18; Thu, 9 Aug 2018 07:57:12 +0200 (CEST) Date: Thu, 9 Aug 2018 07:57:09 +0200 From: Danny Milosavljevic Message-ID: <20180809075709.44883c92@scratchpost.org> In-Reply-To: <87sh3ui038.fsf@lassieur.org> References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/6qdIxbCQ3gUSHaT6vHSNaZS"; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/6qdIxbCQ3gUSHaT6vHSNaZS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, On Sat, 04 Aug 2018 18:10:51 +0200 Cl=C3=A9ment Lassieur wrote: > Cl=C3=A9ment Lassieur writes: >=20 > > Fixes . > > > > * src/cuirass/database.scm (filters->order): New procedure. > > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, > > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT = JOIN > > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched. = =20 >=20 > This may be less efficient because there are more SQL queries (one per > output), but it's way less complicated and less buggy, so I think it's > worth it. Yeah, if it's still usable, I agree. But I think we shouldn't overlook the possibility of not fetching the outpu= ts in the first place (at all). --Sig_/6qdIxbCQ3gUSHaT6vHSNaZS Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAltr17UACgkQ5xo1VCww uqXtHwf+MtPLJDj+rcjxQd/C0Bk1cB7r4hvAprotwj41XELmCm1wiTQL5vwRimrf Andv3Xfp8YldJeBhj4ohq4DhYK6APID1iW05lrP41zhe9HrG5cSlAxv6acR7/I12 OAEUoicv5p9jjqnpm/0H5NaWm8afAKAAXx5+n4RnlKQJqfCRFct+o4qVn3JxXkZU I+vVzdN6kIAAbr8z3etWrczncVbZZP47yd6Pkj+AL+BIuhk7zxsG+d4xkhcR0EJz j2qU7DhL399Z9eW7Mqd5KZX71UlubrBBikrgwCArj1Kkhr8EN/jCadm7NSddZT0w FRGLoaafdMMWbs7SWeGwFjVz698uag== =7GBG -----END PGP SIGNATURE----- --Sig_/6qdIxbCQ3gUSHaT6vHSNaZS-- From unknown Sat Jun 21 10:46:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#32300: [PATCH] database: Fix the builds limit issue. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 09 Aug 2018 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32300 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 32300@debbugs.gnu.org Received: via spool by 32300-submit@debbugs.gnu.org id=B32300.15338017736711 (code B ref 32300); Thu, 09 Aug 2018 08:03:02 +0000 Received: (at 32300) by debbugs.gnu.org; 9 Aug 2018 08:02:53 +0000 Received: from localhost ([127.0.0.1]:45511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnfuG-0001kB-My for submit@debbugs.gnu.org; Thu, 09 Aug 2018 04:02:52 -0400 Received: from mail.lassieur.org ([83.152.10.219]:33126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fnfuF-0001k2-Cw for 32300@debbugs.gnu.org; Thu, 09 Aug 2018 04:02:51 -0400 Received: from rodion (88.203.199.161 [88.203.199.161]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 52b14635 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Thu, 9 Aug 2018 08:02:49 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> <20180809075709.44883c92@scratchpost.org> User-agent: mu4e 1.0; emacs 26.1 From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <20180809075709.44883c92@scratchpost.org> Date: Thu, 09 Aug 2018 10:02:47 +0200 Message-ID: <87k1p0otlk.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Danny Milosavljevic writes: > Hi, > > On Sat, 04 Aug 2018 18:10:51 +0200 > Cl=C3=A9ment Lassieur wrote: > >> Cl=C3=A9ment Lassieur writes: >>=20 >> > Fixes . >> > >> > * src/cuirass/database.scm (filters->order): New procedure. >> > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, >> > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT= JOIN >> > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched.= =20=20 >>=20 >> This may be less efficient because there are more SQL queries (one per >> output), but it's way less complicated and less buggy, so I think it's >> worth it. > > Yeah, if it's still usable, I agree. > > But I think we shouldn't overlook the possibility of not fetching the out= puts > in the first place (at all). I totally agree! Although it should be another commit, I think. From unknown Sat Jun 21 10:46:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Subject: bug#32300: closed (Re: bug#32300: [PATCH] database: Fix the builds limit issue.) Message-ID: References: <87zhxm3u4k.fsf@lassieur.org> <874lgjc5g9.fsf@lassieur.org> X-Gnu-PR-Message: they-closed 32300 X-Gnu-PR-Package: guix Reply-To: 32300@debbugs.gnu.org Date: Thu, 16 Aug 2018 21:00:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1534453203-5632-1" This is a multi-part message in MIME format... ------------=_1534453203-5632-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #32300: Cuirass: the 'nr' filter doesn't work when builds have multiple out= puts which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 32300@debbugs.gnu.org. --=20 32300: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D32300 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1534453203-5632-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 32300-done) by debbugs.gnu.org; 16 Aug 2018 20:59:46 +0000 Received: from localhost ([127.0.0.1]:52858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqPMw-0001S2-0N for submit@debbugs.gnu.org; Thu, 16 Aug 2018 16:59:46 -0400 Received: from mail.lassieur.org ([83.152.10.219]:57070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqPMt-0001Rs-VT for 32300-done@debbugs.gnu.org; Thu, 16 Aug 2018 16:59:44 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 8e29469a (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); Thu, 16 Aug 2018 20:59:41 +0000 (UTC) References: <874lgjc5g9.fsf@lassieur.org> <20180804160057.20254-1-clement@lassieur.org> <87sh3ui038.fsf@lassieur.org> <20180809075709.44883c92@scratchpost.org> User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Danny Milosavljevic Subject: Re: bug#32300: [PATCH] database: Fix the builds limit issue. In-reply-to: <20180809075709.44883c92@scratchpost.org> Danny Milosavljevic writes: Date: Thu, 16 Aug 2018 22:59:39 +0200 Message-ID: <87zhxm3u4k.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 32300-done Cc: 32300-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Hi, > > On Sat, 04 Aug 2018 18:10:51 +0200 > Cl=C3=A9ment Lassieur wrote: > >> Cl=C3=A9ment Lassieur writes: >>=20 >> > Fixes . >> > >> > * src/cuirass/database.scm (filters->order): New procedure. >> > (db-get-builds): Remove FORMAT-OUTPUT, CONS-OUTPUT, COLLECT-OUTPUTS, >> > FINISH-GROUP, SAME-GROUP?, GROUP-OUTPUTS procedures. Remove the 'LEFT= JOIN >> > Outputs' clause. Use DB-GET-OUTPUTS for each build that was fetched.= =20=20 >>=20 >> This may be less efficient because there are more SQL queries (one per >> output), but it's way less complicated and less buggy, so I think it's >> worth it. > > Yeah, if it's still usable, I agree. > > But I think we shouldn't overlook the possibility of not fetching the out= puts > in the first place (at all). Pushed. Thank you for the review! Cl=C3=A9ment ------------=_1534453203-5632-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jul 2018 23:21:26 +0000 Received: from localhost ([127.0.0.1]:33147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWc-0003qj-2z for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjYWb-0003qV-36 for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjYWV-0007AQ-06 for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39039) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjYWU-0007AJ-Sf for submit@debbugs.gnu.org; Sat, 28 Jul 2018 19:21:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjYWT-0004AI-Ox for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjYWQ-00078j-M1 for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:17 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fjYWQ-000784-BQ for bug-guix@gnu.org; Sat, 28 Jul 2018 19:21:14 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 16f128c5 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Sat, 28 Jul 2018 23:21:11 +0000 (UTC) User-agent: mu4e 1.0; emacs 26.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: bug-guix@gnu.org Subject: Cuirass: the 'nr' filter doesn't when builds have multiple outputs X-Debbugs-CC: Danny Milosavljevic , Tatiana Sholokhova Date: Sun, 29 Jul 2018 01:21:10 +0200 Message-ID: <874lgjc5g9.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Hi, With, say, 'nr' =3D 4, the GROUP-OUTPUTS procedure in cuirass/database.scm will transform 0 | out | /gnu/store/... 1 | out | /gnu/store/... 1 | debug | /gnu/store/... 2 | out | /gnu/store/... into ((#:id . 0) (#:outputs ("out" (#:path . "/gnu/store/...")))) ((#:id . 1) (#:outputs ("out" (#:path . "/gnu/store/...")) ("debug" (#:path . "/gnu/store/...")))) ((#:id . 2) (#:outputs ("out" (#:path . "/gnu/store/...")))) Thus there are only 3 elements returned by the low-level DB-GET-BUILDS procedure, while we expect 4. This bug is visible through the API (latestbuilds, queue) and the web interface (eval) because they use that DB-GET-BUILDS procedure. Cl=C3=A9ment ------------=_1534453203-5632-1--