From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 27 06:36:56 2018 Received: (at submit) by debbugs.gnu.org; 27 Jul 2018 10:36:56 +0000 Received: from localhost ([127.0.0.1]:59620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj07E-0007do-4q for submit@debbugs.gnu.org; Fri, 27 Jul 2018 06:36:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fj07B-0007dZ-NR for submit@debbugs.gnu.org; Fri, 27 Jul 2018 06:36:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj075-0007Pg-RE for submit@debbugs.gnu.org; Fri, 27 Jul 2018 06:36:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fj075-0007PY-N8 for submit@debbugs.gnu.org; Fri, 27 Jul 2018 06:36:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj074-0005G5-EY for guix-patches@gnu.org; Fri, 27 Jul 2018 06:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj070-0007Nt-Fl for guix-patches@gnu.org; Fri, 27 Jul 2018 06:36:46 -0400 Received: from lepiller.eu ([2a00:5884:8208::1]:48948) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fj070-0007MS-4n for guix-patches@gnu.org; Fri, 27 Jul 2018 06:36:42 -0400 Received: from localhost (i19-les01-t2-31-35-229-149.sfr.lns.abo.bbox.fr [31.35.229.149]) by lepiller.eu (OpenSMTPD) with ESMTPSA id b2e021ef (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for ; Fri, 27 Jul 2018 10:38:03 +0000 (UTC) Date: Fri, 27 Jul 2018 12:36:33 +0200 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] Reproducible svn checkouts Message-ID: <20180727123633.03683e9e@lepiller.eu> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/IOKU0n.gQhKwk6ruhpZLIJ=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) --MP_/IOKU0n.gQhKwk6ruhpZLIJ= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Some svn checkouts have sub-repositories that have their own .svn folder. These folders contain timestamps, so this patch removes every .svn folder in the result of the checkout, instead of only the top-level one. --MP_/IOKU0n.gQhKwk6ruhpZLIJ= Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-guix-svn-Remove-all-.svn-folders.patch >From 93aa06821d62ba902d6b3fbf5ece0cbb9d9ec797 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Fri, 6 Jul 2018 18:32:50 +0200 Subject: [PATCH] guix: svn: Remove all .svn folders. * guix/build/svn.scm (svn-fetch): Remove all .svn folders as they contain timestamps. --- guix/build/svn.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/build/svn.scm b/guix/build/svn.scm index 252d1d4ee..41bbfdc87 100644 --- a/guix/build/svn.scm +++ b/guix/build/svn.scm @@ -51,7 +51,7 @@ valid Subversion revision. Return #t on success, #f otherwise." ;; of the repo. Since we want a fixed output, this directory needs ;; to be taken out. (with-directory-excursion directory - (delete-file-recursively ".svn")) + (for-each delete-file-recursively (find-files "." "\\.svn"))) #t) -- 2.18.0 --MP_/IOKU0n.gQhKwk6ruhpZLIJ=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 29 09:59:14 2018 Received: (at 32287) by debbugs.gnu.org; 29 Jul 2018 13:59:14 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmE6-0005lY-FY for submit@debbugs.gnu.org; Sun, 29 Jul 2018 09:59:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmE4-0005lH-H6 for 32287@debbugs.gnu.org; Sun, 29 Jul 2018 09:59:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjmDy-0008G9-ML for 32287@debbugs.gnu.org; Sun, 29 Jul 2018 09:59:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjmDy-0008G3-IQ; Sun, 29 Jul 2018 09:59:06 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48188 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fjmDw-0007D4-Qp; Sun, 29 Jul 2018 09:59:05 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Julien Lepiller Subject: Re: [bug#32287] [PATCH] Reproducible svn checkouts References: <20180727123633.03683e9e@lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Thermidor an 226 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 29 Jul 2018 15:59:03 +0200 In-Reply-To: <20180727123633.03683e9e@lepiller.eu> (Julien Lepiller's message of "Fri, 27 Jul 2018 12:36:33 +0200") Message-ID: <87lg9uf8ig.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32287 Cc: 32287@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Hi Julien, Julien Lepiller skribis: > Some svn checkouts have sub-repositories that have their own .svn > folder. These folders contain timestamps, so this patch removes > every .svn folder in the result of the checkout, instead of only the > top-level one. Ouch, good catch. Did you find packages that would trigger this issue? We should somehow check all the packages that use =E2=80=98svn-fetch=E2=80=99 when we merge t= his patch, and update hashes as needed. > From 93aa06821d62ba902d6b3fbf5ece0cbb9d9ec797 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Fri, 6 Jul 2018 18:32:50 +0200 > Subject: [PATCH] guix: svn: Remove all .svn folders. > > * guix/build/svn.scm (svn-fetch): Remove all .svn folders as they contain > timestamps. > --- > guix/build/svn.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/guix/build/svn.scm b/guix/build/svn.scm > index 252d1d4ee..41bbfdc87 100644 > --- a/guix/build/svn.scm > +++ b/guix/build/svn.scm > @@ -51,7 +51,7 @@ valid Subversion revision. Return #t on success, #f ot= herwise." > ;; of the repo. Since we want a fixed output, this directory needs > ;; to be taken out. > (with-directory-excursion directory > - (delete-file-recursively ".svn")) > + (for-each delete-file-recursively (find-files "." "\\.svn"))) =E2=80=98find-files=E2=80=99 doesn=E2=80=99t include directories by default= ; we also need a stricter regexp, leading to: (for-each delete-file-recursively (find-files "." "^\\.svn$" #:directories? #t)) WDYT? (I=E2=80=99ll be AFK so feel free to apply if it looks good to you.) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 19 11:52:16 2018 Received: (at 32287-done) by debbugs.gnu.org; 19 Aug 2018 15:52:16 +0000 Received: from localhost ([127.0.0.1]:54762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frPzy-0003Hq-4b for submit@debbugs.gnu.org; Sun, 19 Aug 2018 11:52:15 -0400 Received: from lepiller.eu ([89.234.186.109]:54712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frPzv-0003Ha-SO for 32287-done@debbugs.gnu.org; Sun, 19 Aug 2018 11:52:12 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id 8532f312 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO) for <32287-done@debbugs.gnu.org>; Sun, 19 Aug 2018 15:52:32 +0000 (UTC) Date: Sun, 19 Aug 2018 17:52:06 +0200 From: Julien Lepiller To: 32287-done@debbugs.gnu.org Subject: Re: [bug#32287] [PATCH] Reproducible svn checkouts Message-ID: <20180819175206.31068276@lepiller.eu> In-Reply-To: <87lg9uf8ig.fsf@gnu.org> References: <20180727123633.03683e9e@lepiller.eu> <87lg9uf8ig.fsf@gnu.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 32287-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Sun, 29 Jul 2018 15:59:03 +0200, ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit : > Hi Julien, >=20 > Julien Lepiller skribis: >=20 > > Some svn checkouts have sub-repositories that have their own .svn > > folder. These folders contain timestamps, so this patch removes > > every .svn folder in the result of the checkout, instead of only the > > top-level one. =20 >=20 > Ouch, good catch. >=20 > Did you find packages that would trigger this issue? We should > somehow check all the packages that use =E2=80=98svn-fetch=E2=80=99 when = we merge > this patch, and update hashes as needed. >=20 No package in Guix trigger this issue, but I have a package definition for JOSM that does. The patch doesn't change the content of sources using svn-fetch we have, so there's nothing to worry about. Pushed as dd1e45335e135fe724acece440782344ef8ca9fd in staging with your suggestions. And now I wonder why I pushed to staging since it doesn't change any existing package... too late I guess :) Thank you! From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 19 17:47:50 2018 Received: (at 32287) by debbugs.gnu.org; 19 Aug 2018 21:47:50 +0000 Received: from localhost ([127.0.0.1]:54871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVY6-0003vy-57 for submit@debbugs.gnu.org; Sun, 19 Aug 2018 17:47:50 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frVY4-0003vq-0J for 32287@debbugs.gnu.org; Sun, 19 Aug 2018 17:47:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 866B9211E5; Sun, 19 Aug 2018 17:47:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 19 Aug 2018 17:47:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=3SlMpedR6T9miCAfrHGMCfCnX/2BqvF/H6gGQifvtmI=; b=BTSHn O7+IzDnNUwZ4GoYR/u2FNR8otDYV0R1CL609mBRxzm4XvwEuObCrTRdwzKFy2kyF EqPdonZhSiZZefliQ5CwGUem6rh8RZAdplNDnY/A3AZtRSKr+ytUEl6EwylLGb3h f+Uc6KdKGiPMJnLurS5W4UUwUIors2ndAzCHIs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=3SlMpedR6T9miCAfrHGMCfCnX/2Bq vF/H6gGQifvtmI=; b=Xbf3Yxp6xJn1ICkpgscPDd4CLjH4pa2e+amTHgJguP7YC CrdUp6zeyZhR1bStkoy2gb5Ai5dJ3zra1Ytfs8XXlmwrnsidm4mI5wo5bPpG5LNi RlEhiyen6xAbW30HlphRNxEZcybNsYeXHnpM/UXWwbszTbI5hXAmZLOc1i1bwBPM yQNksXgZ38a6A9n+DhfvN4XyslpwIny468vjnvyZPFJMyaFkyrAdbqm4wL0Pvfqd FdR/+GfhQJSG96HRcu5CQ6Dl6hR1U3M4fQDsBRkwZHLG/6c7YzgGoXigTWKws9i8 VrTIeClQ84SU3Ty9UzcBPXGFuI2Fc6MfgPqADOS7A== X-ME-Proxy: X-ME-Sender: Received: from localhost (pool-71-183-39-69.nycmny.fios.verizon.net [71.183.39.69]) by mail.messagingengine.com (Postfix) with ESMTPA id 82C61E425A; Sun, 19 Aug 2018 17:47:46 -0400 (EDT) Date: Sun, 19 Aug 2018 17:47:38 -0400 From: Leo Famulari To: 32287@debbugs.gnu.org, julien@lepiller.eu Subject: Re: bug#32287: [PATCH] Reproducible svn checkouts Message-ID: <20180819214738.GA10916@jasmine.lan> References: <20180727123633.03683e9e@lepiller.eu> <87lg9uf8ig.fsf@gnu.org> <20180819175206.31068276@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <20180819175206.31068276@lepiller.eu> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 32287 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Aug 19, 2018 at 05:52:06PM +0200, Julien Lepiller wrote: > Pushed as dd1e45335e135fe724acece440782344ef8ca9fd in staging with > your suggestions. And now I wonder why I pushed to staging since it > doesn't change any existing package... too late I guess :) If you use `git cherry-pick` to apply the commit to the master branch, Git should do the right thing when staging is eventually merged to master. --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlt55XoACgkQJkb6MLrK fwh+SQ/9HtMYguR4fwX0QNxMYFI43YZzz0jP3oRVgCYmYM5H54NeQLa3siZ8ncEU N+9coF+kSGuQGKyOJr4AuPorMkkPY5nbhv++oGPbq22oPY6jl1Mq8ypAxLtoNOSH uNi/buCUEfvZMZcJYx8yM46UNmYAPyeA8aFjl1WHptZwkk1h/clgz0iuhkCFumeY LMEtVlmV1Taeql9h3o2VNdZsB+x/yn5rpEYjKRqK71JF3B/DmPTpsKYOcM5ixST4 iA3uJFmcO2vU0VVFQ4rdT58ua/aivbP9gUyyTd6XLn5njlWED0HOTNFBI9kjfw6V GpRaJtEWiCAcg7nFOKUCi1+O39Lk9gvJ3ujEyommL8U2hz4GSD508Q7Fa+MXxmBJ /D6N+kRYMWqDKTxDx2ckpWrLqSw76SG5QAv5/9QwRUHlzuzGpnYG/zsrz02aPROq kx0kvJAsNRH7i8XrRvWEmHTxiylb/U6xVpgZB04D8Jvt/K1N0XUveF8a8FHkd7tI c+qj0Vy715Lu6K5Mob13gDkHvtFqwkOtuyzeUdWELWxf2v52g5doz4/MW7CyKtei K1mgMCbIfWqPrgsReX/Pp9F5KWevo+DQo9RjfjDGNAJlITZOjn2JQg9GENxJP+YS SK6yZLgLwaxS9GLx6D9orbRo8Rp8W0dHz72ylw1NsHSRLVXKkrw= =8heF -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu-- From unknown Mon Jun 23 16:48:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Sep 2018 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator