GNU bug report logs - #32281
shr.el align support patch

Previous Next

Full log

Message #18 received at 32281 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: 32281 <at> debbugs.gnu.org
Cc: Bad Blue Bull <ibmbull <at> yandex.ru>
Subject: Re: bug#32281: shr.el align support patch
Date: Mon, 06 Aug 2018 13:36:18 -0400

[Message part 1 (text/plain, inline)]

[forwarding to list, please use "Reply All" to keep 32281 <at> debbugs.gnu.org on Cc]

[Message part 2 (message/rfc822, inline)]

From: Bad Blue Bull <ibmbull <at> yandex.ru>
To: Noam Postavsky <npostavs <at> gmail.com>
Subject: Re: bug#32281: shr.el align support patch
Date: Mon, 06 Aug 2018 16:01:49 +0300

> The indentation in your patch looks kind of off, are you not using
> Emacs' builtin auto-indentation? (also, don't leave hanging parens.)

I have (setq-default lisp-body-indent 2) in my ~/.emacs, things seemed
for me indented like the rest of the source, as for hanging parens -
there's a comment (that though should be put before paren as it relates
to the last argument), it's unnecessary.

As for monospace/proportional fonts: I don't insist on change of
shr-use-fonts default value, paragraph justification won't work with
proportional fonts though.

Current version of shr.el don't fill the text at all and I don't know
maybe smb likes it and won't welcome the change (see pics), although ERC
fills text for example.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.