From unknown Sun Jun 22 09:57:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#32276 <32276@debbugs.gnu.org> To: bug#32276 <32276@debbugs.gnu.org> Subject: Status: char-width of a space is 0 when display-table entry has a face. Reply-To: bug#32276 <32276@debbugs.gnu.org> Date: Sun, 22 Jun 2025 16:57:08 +0000 retitle 32276 char-width of a space is 0 when display-table entry has a fac= e. reassign 32276 emacs submitter 32276 Keith David Bershatsky severity 32276 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 25 23:34:16 2018 Received: (at submit) by debbugs.gnu.org; 26 Jul 2018 03:34:16 +0000 Received: from localhost ([127.0.0.1]:57967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiX2d-0004zX-PT for submit@debbugs.gnu.org; Wed, 25 Jul 2018 23:34:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiX2b-0004zB-0A for submit@debbugs.gnu.org; Wed, 25 Jul 2018 23:34:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiX2S-0001be-SZ for submit@debbugs.gnu.org; Wed, 25 Jul 2018 23:34:07 -0400 Received: from lists.gnu.org ([2001:4830:134:3::11]:42516) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fiX2S-0001bS-OW for submit@debbugs.gnu.org; Wed, 25 Jul 2018 23:34:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiX2P-00043g-GA for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 23:34:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiX2M-0001Wn-G9 for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 23:34:01 -0400 Received: from gateway23.websitewelcome.com ([192.185.50.250]:12633) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fiX2M-0001O4-80 for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 23:33:58 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway23.websitewelcome.com (Postfix) with ESMTP id A2CF33AB4 for ; Wed, 25 Jul 2018 22:33:45 -0500 (CDT) Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id iX1zflEIDbXuJiX24friTa; Wed, 25 Jul 2018 22:33:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:To :From:Message-ID:Date:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=crDDctt5B5MI9PxFKMxNj+OtlXv5T1miq/qSGXHr01A=; b=NcBJmSHxCkJIO/mYKjL+SC09AX pNipneQjH8FvkURWNvXH8lSWTMPfRS9zTYrHsJ9sg9xE6WHhXHQlG/mNHVX81g2/E3BsVFQh0C/uA IX7i8aUoJbW26mekKeTHY8b+FNpMqhl6vftSO58LpWZZ6dADaTNz6Sb0jxQBIVOP44V0KBrcoDfFt 1pQKncQAmYsygj4J6qmhAhwXZeZIsep2VHk6Dob8p/GAtnVHT3Btg22GYBKnt1vg+/TOOyy2K4cKN A0TlPgDZAvEUFEbJG6KJNj9UDwO9cNJCySeoI9IYIp2WHbyCoKgP7iTbUTYJ0KGvfjFeR62CudeT8 wWeSbj1w==; Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:54114 helo=server.local) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.91) (envelope-from ) id 1fiX1y-001oe0-NJ for bug-gnu-emacs@gnu.org; Wed, 25 Jul 2018 22:33:34 -0500 Date: Wed, 25 Jul 2018 20:33:33 -0700 Message-ID: From: Keith David Bershatsky To: Emacs Bug Reports Subject: char-width of a space is 0 when display-table entry has a face. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Source-L: No X-Exim-ID: 1fiX1y-001oe0-NJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.local) [45.48.239.195]:54114 X-Source-Auth: lawlist X-Email-Count: 1 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Local-Domain: yes Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Step 1: Open a newly built GUI version of Emacs master branch. Step 2: Open a scratch buffer and evaluate the following code: ;;; char-width =3D=3D 0 (progn (fundamental-mode) (setq buffer-display-table (make-display-table)) (aset buffer-display-table ?\s (vector (make-glyph-code ?=C2=B7 'font-lock-warning-face))) (char-width ?\s)) Step 3: The char-width in Step 2 is 0. Step 4: In the same or a different scratch buffer, evaluate the followin= g code: ;;; char-width =3D=3D 1 (progn (fundamental-mode) (setq buffer-display-table (make-display-table)) (aset buffer-display-table ?\s (vector (make-glyph-code ?=C2=B7))) (char-width ?\s)) Step 5: The char-width in Step 4 is 1. EXPECTED RESULT: The char-width should be 1 in Step 2, just like in Step= 4. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 27 05:34:42 2018 Received: (at 32276-done) by debbugs.gnu.org; 27 Jul 2018 09:34:42 +0000 Received: from localhost ([127.0.0.1]:59563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiz8z-00047h-Pu for submit@debbugs.gnu.org; Fri, 27 Jul 2018 05:34:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiz8x-00047U-GP for 32276-done@debbugs.gnu.org; Fri, 27 Jul 2018 05:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiz8p-0000dl-3g for 32276-done@debbugs.gnu.org; Fri, 27 Jul 2018 05:34:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiz8o-0000db-Vr; Fri, 27 Jul 2018 05:34:31 -0400 Received: from [176.228.60.248] (port=4088 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fiz8o-0005bH-EK; Fri, 27 Jul 2018 05:34:30 -0400 Date: Fri, 27 Jul 2018 12:34:30 +0300 Message-Id: <83k1phrpi1.fsf@gnu.org> From: Eli Zaretskii To: Keith David Bershatsky In-reply-to: (message from Keith David Bershatsky on Wed, 25 Jul 2018 20:33:33 -0700) Subject: Re: bug#32276: char-width of a space is 0 when display-table entry has a face. References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32276-done Cc: 32276-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Wed, 25 Jul 2018 20:33:33 -0700 > From: Keith David Bershatsky > > EXPECTED RESULT: The char-width should be 1 in Step 2, just like in Step 4. Thanks, fixed on the emacs-26 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 28 18:38:01 2018 Received: (at 32276) by debbugs.gnu.org; 28 Jul 2018 22:38:02 +0000 Received: from localhost ([127.0.0.1]:33140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjXqb-0002ms-JP for submit@debbugs.gnu.org; Sat, 28 Jul 2018 18:38:01 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjXqZ-0002ma-Eu for 32276@debbugs.gnu.org; Sat, 28 Jul 2018 18:38:00 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0A3BC160661; Sat, 28 Jul 2018 15:37:53 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wTYCESUyZTWV; Sat, 28 Jul 2018 15:37:52 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17CBE1606C2; Sat, 28 Jul 2018 15:37:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lOK-Ux0gbX_9; Sat, 28 Jul 2018 15:37:51 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B3BE3160661; Sat, 28 Jul 2018 15:37:51 -0700 (PDT) To: Eli Zaretskii From: Paul Eggert Subject: Re: bug#32276: char-width of a space is 0 when display-table entry has a face. Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECHgECF4AACgkQ7ZfpDmKqfjRRGw/+Ij03dhYfYl/gXVRiuzV1gGrbHk+t nfrI/C7fAeoFzQ5tVgVinShaPkZo0HTPf18x6IDEdAiO8Mqo1yp0CtHmzGMCJ50o4Grgfjlr 6g/+vtEOKbhleszN2XpJvpwM2QgGvn/laTLUu8PH9aRWTs7qJJZKKKAb4sxYc92FehPu6FOD 0dDiyhlDAq4lOV2mdBpzQbiojoZzQLMQwjpgCTK2572eK9EOEQySUThXrSIz6ASenp4NYTFH s9tuJQvXk9gZDdPSl3bp+47dGxlxEWLpBIM7zIONw4ks4azgT8nvDZxA5IZHtvqBlJLBObYY 0Le61Wp0y3TlBDh2qdK8eYL426W4scEMSuig5gb8OAtQiBW6k2sGUxxeiv8ovWu8YAZgKJfu oWI+uRnMEddruY8JsoM54KaKvZikkKs2bg1ndtLVzHpJ6qFZC7QVjeHUh6/BmgvdjWPZYFTt N+KA9CWX3GQKKgN3uu988yznD7LnB98T4EUH1HA/GnfBqMV1gpzTvPc4qVQinCmIkEFp83zl +G5fCjJJ3W7ivzCnYo4KhKLpFUm97okTKR2LW3xZzEW4cLSWO387MTK3CzDOx5qe6s4a91Zu ZM/j/TQdTLDaqNn83kA4Hq48UHXYxcIh+Nd8k/3w6lFuoK0wrOFiywjLx+0ur5jmmbecBGHc 1xdhAFHOwU0ETIByZAEQAKaF678T9wyH4wjTrV1Pz3cDEoSnV/0ZUrOT37p1dcGyj/IXq1x6 70HRVahAmk0sZpYc25PF9D5GPYHFWlNjuPU96rDndXB3hedmBRhLdC4bAXjI4DV+bmdVe+q/ IMnlZRaVlm9EiMCVAR6w13sReu7qXkW9r3RwY2AzXskp/tAe4BRKr1Zmbvi2nbnQ6epEC42r Rbx0B1EhjbIQZ5JHGk24iPT7LdBgnNmos5wYjzwNlkMQD5T0Ydzhk7J+UxwA5m46mOhRDC2r FV/A0gm5TLy8DXjv/Esc4gYnYai6SQqnUEVh5LuV8YCJBnijs+Tiw71x1icmn6xGI45EugJO gec+rLypYgpVp4x0HI5T88qBRYCkxH3Kg8Qo+EWNA9A4LRQ9DX8njona0gf0s03tocK8kBN6 6UoqqPtHBnc4eMgBymCflK12eKfd2YYxnyg9cZazWA5VslvTxpm76hbg5oiAEH/Vg/8MxHyA nPhfrgwyPrmJEcVBafdspJnYQxBYNco2LFPIhlOvWh8r4at+s+M3Lb26oUTczlgdW1Sf3SDA 77BMRnF0FQyE+7AzV79MBN4ykiqaezQxtaF1Fy/tvkhffSo8u+dwG0EgJh+te38gTcISVr0G IPplLz6YhjrbHrPRF1CN5UuL9DBGjxuN35RLNVEfta6RUFlR6NctTjvrABEBAAHCwWUEGAEC AA8FAkyAcmQCGwwFCRLMAwAACgkQ7ZfpDmKqfjSrHA/+KzAKvTxRhA9MWNLxIyJ7S5uJ16gs T3oCjZrBKGEhKMOGX4O0GA6VOEryO7QRCCYah3oxSG38IAnNeiwJXgU9Bzkk85UGbPEd7HGF /VSeHCQwWou6jqUDTSDvn9YhNTdG0KXPM74aC+xr2Zow1O2mhXihgWKD0Dw+0LYPnUOsQ0KO FxHXXYHmRrS1OZPU59BLvc+TRhIhafSHKLwbXK+6ckkxBx6h8z5ccpG0Qs4bFhdFYnFrEieD LoGmnE2YLhdV6swJ9VNCS6pLiEohT3fm7aXm15tZOIyzMZhHRSAPblXxQ0ZSWjq8oRrcYNFx c4W1URpAkBCOYJoXvQfD5L3lqAl8TCqDUzYxhH/tJhbDdHrqHH767jaDaTB1+Talp/2AMKwc XNOdiklGxbmHVG6YGl6g8Lrbsu9NZEI4yLlHzuikthJWgz+3vZhVGyNlt+HNIoF6CjDL2omu 5cEq4RDHM44QqPk6l7O0pUvN1mT4B+S1b08RKpqm/ff015E37HNV/piIvJlxGAYz8PSfuGCB 1thMYqlmgdhd9/BabGFbGGYHA6U4/T5zqU+f6xHy1SsAQZ1MSKlLwekBIT+4/cLRGqCHjnV0 q5H/T6a7t5mPkbzSrOLSo4puj+IToNjYyYIDBWzhlA19avOa+rvUjmHtD3sFN7cXWtkGoi8b uNcby4U= Organization: UCLA Computer Science Department Message-ID: Date: Sat, 28 Jul 2018 15:37:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8FA0DE66A7E984DA330C17CE" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 32276 Cc: Keith David Bershatsky , 32276@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------8FA0DE66A7E984DA330C17CE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Unfortunately that change causes the emacs-26 build to fail for me: make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src' CC character.o In file included from character.c:34:0: character.c: In function =E2=80=98char_width=E2=80=99: lisp.h:1682:11: error: =E2=80=98c=E2=80=99 may be used uninitialized in t= his function=20 [-Werror=3Dmaybe-uninitialized] ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \ ^ character.c:292:10: note: =E2=80=98c=E2=80=99 was declared here int c; ^ cc1: all warnings being treated as errors Makefile:376: recipe for target 'character.o' failed Although the attached patch fixes this and presumably speeds up the code = a bit=20 when optimized, is this the right thing to do? I have not looked into the= code=20 carefully. --------------8FA0DE66A7E984DA330C17CE Content-Type: text/x-patch; name="0001-Adjust-recent-Bug-32276-fix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Adjust-recent-Bug-32276-fix.patch" =46rom 4c321dc8d6b059ddaf5aab137aadbae18a3cb5af Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 28 Jul 2018 15:36:04 -0700 Subject: [PATCH] Adjust recent Bug#32276 fix * src/character.c (char_width): Make explicit the assumption that a display character vector element is a character if is not a glyph code. --- src/character.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/character.c b/src/character.c index 48268e0..6af9825 100644 --- a/src/character.c +++ b/src/character.c @@ -293,8 +293,11 @@ char_width (int c, struct Lisp_Char_Table *dp) ch =3D AREF (disp, i); if (GLYPH_CODE_P (ch)) c =3D GLYPH_CODE_CHAR (ch); - else if (CHARACTERP (ch)) - c =3D XFASTINT (ch); + else + { + eassert (CHARACTERP (ch)); + c =3D XFASTINT (ch); + } int w =3D CHARACTER_WIDTH (c); if (INT_ADD_WRAPV (width, w, &width)) string_overflow (); --=20 2.7.4 --------------8FA0DE66A7E984DA330C17CE-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 29 10:45:37 2018 Received: (at 32276) by debbugs.gnu.org; 29 Jul 2018 14:45:37 +0000 Received: from localhost ([127.0.0.1]:33983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmwz-0006xz-FE for submit@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmwx-0006xj-MR for 32276@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjmwp-000103-8B for 32276@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjmwY-0000sg-EN; Sun, 29 Jul 2018 10:45:10 -0400 Received: from [176.228.60.248] (port=1834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fjmwX-0003xc-Ka; Sun, 29 Jul 2018 10:45:10 -0400 Date: Sun, 29 Jul 2018 17:45:14 +0300 Message-Id: <834lgit81x.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Sat, 28 Jul 2018 15:37:50 -0700) Subject: Re: bug#32276: char-width of a space is 0 when display-table entry has a face. References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 32276 Cc: esq@lawlist.com, 32276@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Cc: 32276@debbugs.gnu.org, Keith David Bershatsky > From: Paul Eggert > Date: Sat, 28 Jul 2018 15:37:50 -0700 > > Unfortunately that change causes the emacs-26 build to fail for me: Sorry about that. > make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src' > CC character.o > In file included from character.c:34:0: > character.c: In function ‘char_width’: > lisp.h:1682:11: error: ‘c’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \ > ^ > character.c:292:10: note: ‘c’ was declared here > int c; > ^ > cc1: all warnings being treated as errors > Makefile:376: recipe for target 'character.o' failed > > Although the attached patch fixes this and presumably speeds up the code a bit > when optimized, is this the right thing to do? I have not looked into the code > carefully. I preferred to keep the modified code work the same as before that change, i.e. count any non-characters (which now shouldn't happen, I think) as having a width of zero. So I pushed a slightly different fix. From unknown Sun Jun 22 09:57:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Aug 2018 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator