GNU bug report logs - #32268
[PATCH] gnu: Add net-snmp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32268 in the body.
You can then email your comments to 32268 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add net-snmp.
Date: Wed, 25 Jul 2018 14:44:34 +0300

* gnu/packages/networking.scm (net-snmp): New variable.
---
 gnu/packages/networking.scm | 76 +++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 90967b9b1..a77452d6a 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -66,6 +66,7 @@
   #:use-module (gnu packages databases)
   #:use-module (gnu packages dejagnu)
   #:use-module (gnu packages documentation)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
@@ -1965,3 +1966,78 @@ Features:
 @item Destination IP blacklist
 @end itemize")
       (license license:asl2.0))))
+
+(define-public net-snmp
+  (package
+    (name "net-snmp")
+    (version "5.7.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/net-snmp/net-snmp/" version
+                           "/net-snmp-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1w5l9w0sgi1zkzq8ww6kc6fzq7ljq59z2d9ks6bdq1vp7ihqkvqj"))
+       (patches
+        (map (lambda (file hash)
+               (origin
+                 (method url-fetch)
+                 (uri (string-append
+                       "https://git.alpinelinux.org\
+/cgit/aports/plain/main/net-snmp/"
+                       file "?id=f25d3fb08341b60b6ccef424399f060dfcf3f1a5"))
+                 (sha256
+                  (base32
+                   hash))))
+             '("CVE-2015-5621.patch"
+               "fix-Makefile-PL.patch"
+               "fix-includes.patch"
+               "netsnmp-swinst-crash.patch"
+               "remove-U64-typedef.patch")
+             '("0mg2mlfb45fnv7m1k9wckrqjfizipyvrl1q4dn1r0zc774mm7zjc"
+               "1pd85sy04n76q1ri3l33f0zpnnw76nd5mcny2j39ilzp76bjfik5"
+               "0zpkbb6k366qpq4dax5wknwprhwnhighcp402mlm7950d39zfa3m"
+               "0gh164wy6zfiwiszh58fsvr25k0ns14r3099664qykgpmickkqid"
+               "0jcpcpgx4z9k1w0x6km0132n67qc29mz6cialwfjm02l76q2yk5n")))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (inputs
+     `(("file" ,file)
+       ("perl" ,perl)
+       ("openssl" ,openssl)))
+    (arguments
+     `(#:tests? #f
+       #:configure-flags
+       (list "--with-default-snmp-version=3"
+             "--with-sys-location=Unknown"
+             "--with-sys-contact=root <at> unknown"
+             "--with-logfile=/var/log/net-snmpd.log"
+             "--with-persistent-directory=/var/lib/net-snmp"
+             (string-append "--with-openssl="
+                            (assoc-ref %build-inputs "openssl"))
+             "--with-mnttab=/proc/mounts")
+       #:make-flags
+       (let ((out (assoc-ref %outputs "out")))
+         (list (string-append "INSTALLSITEARCH=" out
+                              "/lib/perl5/site_perl/" ,(package-version perl)
+                              "/x86_64-linux-thread-multi")
+               (string-append"INSTALLSITEMAN3DIR=" out "/share/man/man3")))
+
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'autoreconf
+           (lambda _
+             (invoke "autoreconf" "-vfi"))))))
+    (home-page "http://net-snmp.sourceforge.net/")
+    (synopsis "Clients and server for the SNMP network monitoring protocol")
+    (description "The Simple Network Management Protocol (SNMP) provides a
+framework for the exchange of management information between agents (servers)
+and clients.
+
+The Net-SNMP applications are a collection of command line clients for issuing
+SNMP requests to agents.")
+    (license license:bsd-3)))
-- 
2.18.0

Message #8 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 32268 <at> debbugs.gnu.org
Subject: Re: [bug#32268] [PATCH] gnu: Add net-snmp.
Date: Wed, 25 Jul 2018 14:50:48 +0300

[Message part 1 (text/plain, inline)]

I should mention that I converted the recipe from Nix [1] which has
different hashes for patches.
--8<---------------cut here---------------start------------->8---
  patches =
    let fetchAlpinePatch = name: sha256: fetchpatch {
      url = "https://git.alpinelinux.org/cgit/aports/plain/main/net-snmp/${name}?id=f25d3fb08341b60b6ccef424399f060dfcf3f1a5";
      inherit name sha256;
    };
  in [
    (fetchAlpinePatch "CVE-2015-5621.patch" "05098jyvd9ddr5q26z7scbbvk1bk6x4agpjm6pyprvpc1zpi0y09")
    (fetchAlpinePatch "fix-Makefile-PL.patch" "14ilnkj3cr6mpi242hrmmmv8nv4dj0fdgn42qfk9aa7scwsc0lc7")
    (fetchAlpinePatch "fix-includes.patch" "0zpkbb6k366qpq4dax5wknwprhwnhighcp402mlm7950d39zfa3m")
    (fetchAlpinePatch "netsnmp-swinst-crash.patch" "0gh164wy6zfiwiszh58fsvr25k0ns14r3099664qykgpmickkqid")
    (fetchAlpinePatch "remove-U64-typedef.patch" "1msxyhcqkvhqa03dwb50288g7f6nbrcd9cs036m9xc8jdgjb8k8j")
  ];
--8<---------------cut here---------------end--------------->8---

[1]  https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/monitoring/net-snmp/default.nix#L11

Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: Nils Gillmann <ng0 <at> n0.is>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32268 <at> debbugs.gnu.org
Subject: Re: [bug#32268] [PATCH] gnu: Add net-snmp.
Date: Wed, 25 Jul 2018 11:56:13 +0000

Oleg Pykhalov transcribed 3.7K bytes:
> * gnu/packages/networking.scm (net-snmp): New variable.
> ---
>  gnu/packages/networking.scm | 76 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)
> 
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 90967b9b1..a77452d6a 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -66,6 +66,7 @@
>    #:use-module (gnu packages databases)
>    #:use-module (gnu packages dejagnu)
>    #:use-module (gnu packages documentation)
> +  #:use-module (gnu packages file)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages gettext)
>    #:use-module (gnu packages glib)
> @@ -1965,3 +1966,78 @@ Features:
>  @item Destination IP blacklist
>  @end itemize")
>        (license license:asl2.0))))
> +
> +(define-public net-snmp
> +  (package
> +    (name "net-snmp")
> +    (version "5.7.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/net-snmp/net-snmp/" version
> +                           "/net-snmp-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1w5l9w0sgi1zkzq8ww6kc6fzq7ljq59z2d9ks6bdq1vp7ihqkvqj"))
> +       (patches
> +        (map (lambda (file hash)
> +               (origin
> +                 (method url-fetch)
> +                 (uri (string-append
> +                       "https://git.alpinelinux.org\
> +/cgit/aports/plain/main/net-snmp/"
> +                       file "?id=f25d3fb08341b60b6ccef424399f060dfcf3f1a5"))

Can you please make the 3 lines above look more aligned? like:

> +                 (uri (string-append "https://git.alpinelinux.org"
                                        "/cgit/aports/plain/main/net-snmp/"
                                        file
                                        "?id=f25d3fb08341b60b6ccef424399f060dfcf3f1a5"))

> +                 (sha256
> +                  (base32
> +                   hash))))
> +             '("CVE-2015-5621.patch"
> +               "fix-Makefile-PL.patch"
> +               "fix-includes.patch"
> +               "netsnmp-swinst-crash.patch"
> +               "remove-U64-typedef.patch")
> +             '("0mg2mlfb45fnv7m1k9wckrqjfizipyvrl1q4dn1r0zc774mm7zjc"
> +               "1pd85sy04n76q1ri3l33f0zpnnw76nd5mcny2j39ilzp76bjfik5"
> +               "0zpkbb6k366qpq4dax5wknwprhwnhighcp402mlm7950d39zfa3m"
> +               "0gh164wy6zfiwiszh58fsvr25k0ns14r3099664qykgpmickkqid"
> +               "0jcpcpgx4z9k1w0x6km0132n67qc29mz6cialwfjm02l76q2yk5n")))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))
> +    (inputs
> +     `(("file" ,file)
> +       ("perl" ,perl)
> +       ("openssl" ,openssl)))
> +    (arguments
> +     `(#:tests? #f
> +       #:configure-flags
> +       (list "--with-default-snmp-version=3"
> +             "--with-sys-location=Unknown"
> +             "--with-sys-contact=root <at> unknown"

Would root <at> localhost make more sense? Why @unknown?

> +             "--with-logfile=/var/log/net-snmpd.log"
> +             "--with-persistent-directory=/var/lib/net-snmp"
> +             (string-append "--with-openssl="
> +                            (assoc-ref %build-inputs "openssl"))
> +             "--with-mnttab=/proc/mounts")
> +       #:make-flags
> +       (let ((out (assoc-ref %outputs "out")))
> +         (list (string-append "INSTALLSITEARCH=" out
> +                              "/lib/perl5/site_perl/" ,(package-version perl)
> +                              "/x86_64-linux-thread-multi")
> +               (string-append"INSTALLSITEMAN3DIR=" out "/share/man/man3")))
> +
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'autoreconf
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))

What I recently discovered, or it might be false memory, is that we
have a phase for this which runs autoreconf -vfi automatically. Or am
I wrong about this?

> +    (home-page "http://net-snmp.sourceforge.net/")
> +    (synopsis "Clients and server for the SNMP network monitoring protocol")
> +    (description "The Simple Network Management Protocol (SNMP) provides a
> +framework for the exchange of management information between agents (servers)
> +and clients.
> +
> +The Net-SNMP applications are a collection of command line clients for issuing
> +SNMP requests to agents.")
> +    (license license:bsd-3)))
> -- 
> 2.18.0

No further comments. As I didn't compile it I can't conclude with 'LGTM'.

Message #14 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Nils Gillmann <ng0 <at> n0.is>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 32268 <at> debbugs.gnu.org
Subject: Re: [bug#32268] [PATCH] gnu: Add net-snmp.
Date: Sun, 29 Jul 2018 15:54:13 +0200

Hello,

Nils Gillmann <ng0 <at> n0.is> skribis:

> Oleg Pykhalov transcribed 3.7K bytes:
>> * gnu/packages/networking.scm (net-snmp): New variable.

[...]

>> +       (modify-phases %standard-phases
>> +         (add-before 'configure 'autoreconf
>> +           (lambda _
>> +             (invoke "autoreconf" "-vfi"))))))
>
> What I recently discovered, or it might be false memory, is that we
> have a phase for this which runs autoreconf -vfi automatically. Or am
> I wrong about this?

You’re right, it appeared with the last ‘core-updates’ merge.  Oleg, can
you make sure this phase can be removed?

No further comments!

Thanks Nils & Oleg,
Ludo’.

Message #17 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 32268 <at> debbugs.gnu.org
Subject: Re: [bug#32268] [PATCH] gnu: Add net-snmp.
Date: Mon, 30 Jul 2018 00:03:50 +0200

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> * gnu/packages/networking.scm (net-snmp): New variable.

Hello!  This patch reminded me I had an ancient patch for Net-SNMP too,
but got stuck on a single test failure and forgot all about it.

I see you've disabled tests altogether which is a neat workaround.
However I'm hoping we can consolidate our efforts and just disable the
one (or was it two) tests that are failing.

Comments inline, my patch attached at the end.

> ---
>  gnu/packages/networking.scm | 76 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)

I chose to add a (gnu packages snmp) module, but that may be overkill
indeed.

[...]

> +(define-public net-snmp
> +  (package
> +    (name "net-snmp")
> +    (version "5.7.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "mirror://sourceforge/net-snmp/net-snmp/" version
> +                           "/net-snmp-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1w5l9w0sgi1zkzq8ww6kc6fzq7ljq59z2d9ks6bdq1vp7ihqkvqj"))
> +       (patches
> +        (map (lambda (file hash)
> +               (origin
> +                 (method url-fetch)
> +                 (uri (string-append
> +                       "https://git.alpinelinux.org\
> +/cgit/aports/plain/main/net-snmp/"
> +                       file "?id=f25d3fb08341b60b6ccef424399f060dfcf3f1a5"))
> +                 (sha256
> +                  (base32
> +                   hash))))
> +             '("CVE-2015-5621.patch"
> +               "fix-Makefile-PL.patch"
> +               "fix-includes.patch"
> +               "netsnmp-swinst-crash.patch"
> +               "remove-U64-typedef.patch")
> +             '("0mg2mlfb45fnv7m1k9wckrqjfizipyvrl1q4dn1r0zc774mm7zjc"
> +               "1pd85sy04n76q1ri3l33f0zpnnw76nd5mcny2j39ilzp76bjfik5"
> +               "0zpkbb6k366qpq4dax5wknwprhwnhighcp402mlm7950d39zfa3m"
> +               "0gh164wy6zfiwiszh58fsvr25k0ns14r3099664qykgpmickkqid"
> +               "0jcpcpgx4z9k1w0x6km0132n67qc29mz6cialwfjm02l76q2yk5n")))))

Instead of adding all these patches, I opted to use the 5.8
pre-release instead.  No strong opinion, but since it's a new package
and 5.8 is "just around the corner" I think that's fine.  WDYT?

Also note that this packages bundles a copy of OpenSSL, which should be
purged.

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))

Why are these needed?  Because of the patches?

> +    (inputs
> +     `(("file" ,file)
> +       ("perl" ,perl)
> +       ("openssl" ,openssl)))

"file" is an implicit input.  Can you add a comment about why it's
needed here (I guess it's referenced somewhere?)?

> +    (arguments
> +     `(#:tests? #f
> +       #:configure-flags
> +       (list "--with-default-snmp-version=3"
> +             "--with-sys-location=Unknown"
> +             "--with-sys-contact=root <at> unknown"
> +             "--with-logfile=/var/log/net-snmpd.log"
> +             "--with-persistent-directory=/var/lib/net-snmp"
> +             (string-append "--with-openssl="
> +                            (assoc-ref %build-inputs "openssl"))
> +             "--with-mnttab=/proc/mounts")
> +       #:make-flags
> +       (let ((out (assoc-ref %outputs "out")))
> +         (list (string-append "INSTALLSITEARCH=" out
> +                              "/lib/perl5/site_perl/" ,(package-version perl)
> +                              "/x86_64-linux-thread-multi")
> +               (string-append"INSTALLSITEMAN3DIR=" out "/share/man/man3")))
> +
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'autoreconf
> +           (lambda _
> +             (invoke "autoreconf" "-vfi"))))))
> +    (home-page "http://net-snmp.sourceforge.net/")
> +    (synopsis "Clients and server for the SNMP network monitoring protocol")
> +    (description "The Simple Network Management Protocol (SNMP) provides a
> +framework for the exchange of management information between agents (servers)
> +and clients.
> +
> +The Net-SNMP applications are a collection of command line clients for issuing
> +SNMP requests to agents.")
> +    (license license:bsd-3)))

The main license is actually CMU/UCDs "Historic Permission Notice and
Disclaimer", which is not in Guix.  Do you think it's worth adding, or
should we simply use a non-copyleft style URI here?

My patch attached:

[0001-gnu-Add-net-snmp.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 32268 <at> debbugs.gnu.org
Subject: Re: [bug#32268] [PATCH] gnu: Add net-snmp.
Date: Mon, 30 Jul 2018 20:08:31 +0300

[Message part 1 (text/plain, inline)]

Hello Marius,

First of all thank you for your work on ‘net-snmp’.

Marius Bakke <mbakke <at> fastmail.com> writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> writes:
>
>> * gnu/packages/networking.scm (net-snmp): New variable.
>
> Hello!  This patch reminded me I had an ancient patch for Net-SNMP too,
> but got stuck on a single test failure and forgot all about it.

Oh, unfortunate I didn't find it before #32268.

> I see you've disabled tests altogether which is a neat workaround.
> However I'm hoping we can consolidate our efforts and just disable the
> one (or was it two) tests that are failing.

I did't find tests suite while packaging.  Thank you for pointing that.

> Comments inline, my patch attached at the end.
>
>> ---
>>  gnu/packages/networking.scm | 76 +++++++++++++++++++++++++++++++++++++
>>  1 file changed, 76 insertions(+)
>
> I chose to add a (gnu packages snmp) module, but that may be overkill
> indeed.

If you think about adding other SNMP specific tools then it's a great
idea.  :-) Maybe a ‘(gnu packages monitoring)’ module could be also in a
consideration?  I vote for ‘(gnu packages networking)’ still.

[…]

> I opted to use the 5.8 pre-release instead.  No strong opinion, but
> since it's a new package and 5.8 is "just around the corner" I think
> that's fine.  WDYT?

Wow, indeed.  Seems I found a 5.8 release.  Maybe we should peek it?
WDYT?  https://sourceforge.net/projects/net-snmp/files/net-snmp/5.8/

> Also note that this packages bundles a copy of OpenSSL, which should be
> purged.
>
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)
>> +       ("libtool" ,libtool)))
>
> Why are these needed?  Because of the patches?

The ‘(invoke "autoreconf" "-vfi")’ requires all those three packages.

>> +    (inputs
>> +     `(("file" ,file)
>> +       ("perl" ,perl)
>> +       ("openssl" ,openssl)))
>
> "file" is an implicit input.  Can you add a comment about why it's
> needed here (I guess it's referenced somewhere?)?

Configuration or complation phases failed without it.  I don't see
‘file’ in your patch.  So, I think I could skip commenting above.  :-)

[…]

>> +    (license license:bsd-3)))
>
> The main license is actually CMU/UCDs "Historic Permission Notice and
> Disclaimer", which is not in Guix.  Do you think it's worth adding, or
> should we simply use a non-copyleft style URI here?

Either way is OK for me, but I vote for non-copyleft style.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 32268 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 32268 <at> debbugs.gnu.org, 32333 <at> debbugs.gnu.org,
 Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#32333] [PATCH 1/4] gnu: Add net-snmp.
Date: Wed, 1 Aug 2018 11:31:31 +0200

Hi Oleg and Marius,

> Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de> writes:
>
>> * gnu/packages/networking.scm (net-snmp): New variable.
>> ---
>>  gnu/packages/networking.scm | 71 ++++++++++++++++++++++++++++++++++++-
>>  1 file changed, 70 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
>> index 90967b9b1..57055a92e 100644
>> --- a/gnu/packages/networking.scm
>> +++ b/gnu/packages/networking.scm
>> @@ -1,6 +1,6 @@
>>  ;;; GNU Guix --- Functional package management for GNU
>>  ;;; Copyright © 2014, 2017, 2018 Ludovic Courtès <ludo <at> gnu.org>
>> -;;; Copyright © 2015, 2016, 2017 Ricardo Wurmus <rekado <at> elephly.net>
>> +;;; Copyright © 2015, 2016, 2017, 2018 Ricardo Wurmus <rekado <at> elephly.net>
>>  ;;; Copyright © 2015 Mark H Weaver <mhw <at> netris.org>
>>  ;;; Copyright © 2015, 2016, 2017 Stefan Reichör <stefan <at> xsteve.at>
>>  ;;; Copyright © 2016 Raimon Grau <raimonster <at> gmail.com>
>> @@ -1965,3 +1965,72 @@ Features:
>>  @item Destination IP blacklist
>>  @end itemize")
>>        (license license:asl2.0))))
>> +
>> +(define-public net-snmp
>
> […]
>
> This patch seems like what we want in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32268 \o/

Thanks for pointing this out!

I’ll combine this with both your patches and put it in networking.scm.

--
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.